espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-31 03:07:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

(wpa_supplicant) : Fixed a memory leak issue created when parsing scan results

Browse Source
This commit is contained in:
jgujarathi
2022-11-11 17:17:28 +05:30
parent dbcf640261
commit 561cce9446
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
components/wpa_supplicant/esp_supplicant/src/esp_wps.c
View File

@ -397,6 +397,7 @@ wps_parse_scan_result(struct wps_scan_ie *scan)
for (count = 0; count < WPS_MAX_DIS_AP_NUM; count++) { for (count = 0; count < WPS_MAX_DIS_AP_NUM; count++) {
if (os_memcmp(sm->dis_ap_list[count].bssid, scan->bssid, ETH_ALEN) == 0) { if (os_memcmp(sm->dis_ap_list[count].bssid, scan->bssid, ETH_ALEN) == 0) {
wpa_printf(MSG_INFO, "discard ap bssid "MACSTR, MAC2STR(scan->bssid)); wpa_printf(MSG_INFO, "discard ap bssid "MACSTR, MAC2STR(scan->bssid));
wpabuf_free(buf);
return false; return false;
} }
} }
@ -404,6 +405,9 @@ wps_parse_scan_result(struct wps_scan_ie *scan)
if (ap_found || sm->ignore_sel_reg) { if (ap_found || sm->ignore_sel_reg) {
wpabuf_free(buf); wpabuf_free(buf);
if (scan->ssid[1] > SSID_MAX_LEN) {
return false;
}
esp_wifi_enable_sta_privacy_internal(); esp_wifi_enable_sta_privacy_internal();
os_memset(sm->ssid[0], 0, SSID_MAX_LEN); os_memset(sm->ssid[0], 0, SSID_MAX_LEN);
os_memcpy(sm->ssid[0], (char *)&scan->ssid[2], (int)scan->ssid[1]); os_memcpy(sm->ssid[0], (char *)&scan->ssid[2], (int)scan->ssid[1]);
@ -1470,6 +1474,9 @@ _err:
sm->dev = NULL; sm->dev = NULL;
} }
if (sm->wps_ctx) { if (sm->wps_ctx) {
if (sm->wps_ctx->dh_privkey) {
wpabuf_free(sm->wps_ctx->dh_privkey);
}
os_free(sm->wps_ctx); os_free(sm->wps_ctx);
sm->wps_ctx = NULL; sm->wps_ctx = NULL;
} }
@ -1519,6 +1526,9 @@ wifi_station_wps_deinit(void)
sm->dev = NULL; sm->dev = NULL;
} }
if (sm->wps_ctx) { if (sm->wps_ctx) {
if (sm->wps_ctx->dh_privkey) {
wpabuf_free(sm->wps_ctx->dh_privkey);
}
os_free(sm->wps_ctx); os_free(sm->wps_ctx);
sm->wps_ctx = NULL; sm->wps_ctx = NULL;
} }