From 825bbb08e3df77ba770ff36c7ce10112718369af Mon Sep 17 00:00:00 2001 From: David Cermak Date: Wed, 2 Jun 2021 16:29:56 +0200 Subject: [PATCH] esp_netif: Added argument checks for PPP public API --- components/esp_netif/lwip/esp_netif_lwip_ppp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/components/esp_netif/lwip/esp_netif_lwip_ppp.c b/components/esp_netif/lwip/esp_netif_lwip_ppp.c index 425adfaaae..21385f479f 100644 --- a/components/esp_netif/lwip/esp_netif_lwip_ppp.c +++ b/components/esp_netif/lwip/esp_netif_lwip_ppp.c @@ -347,6 +347,10 @@ void esp_netif_destroy_ppp(netif_related_data_t *netif_related) esp_err_t esp_netif_ppp_set_params(esp_netif_t *netif, const esp_netif_ppp_config_t *config) { + if (netif == NULL || netif->related_data == NULL || config == NULL || + ((struct lwip_peer2peer_ctx *)netif->related_data)->base.netif_type != PPP_LWIP_NETIF) { + return ESP_ERR_INVALID_ARG; + } struct lwip_peer2peer_ctx *obj = (struct lwip_peer2peer_ctx *)netif->related_data; obj->ppp_phase_event_enabled = config->ppp_phase_event_enabled; obj->ppp_error_event_enabled = config->ppp_error_event_enabled; @@ -355,6 +359,10 @@ esp_err_t esp_netif_ppp_set_params(esp_netif_t *netif, const esp_netif_ppp_confi esp_err_t esp_netif_ppp_get_params(esp_netif_t *netif, esp_netif_ppp_config_t *config) { + if (netif == NULL || netif->related_data == NULL || config == NULL || + ((struct lwip_peer2peer_ctx *)netif->related_data)->base.netif_type != PPP_LWIP_NETIF) { + return ESP_ERR_INVALID_ARG; + } struct lwip_peer2peer_ctx *obj = (struct lwip_peer2peer_ctx *)netif->related_data; config->ppp_phase_event_enabled = obj->ppp_phase_event_enabled; config->ppp_error_event_enabled = obj->ppp_error_event_enabled;