espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-08-04 05:04:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'fix/ci_win_build_system_read_only_test' into 'master'

Browse Source 
fix(tools): fix failing create readonly project build system test

Closes IDFCI-2138

See merge request espressif/esp-idf!30596
This commit is contained in:
Roland Dobai
2024-05-02 17:45:05 +08:00
parent 1ca0793e4d e351a4407a
commit 8aa5188852
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tools/test_build_system/test_common.py
View File

@@ -233,27 +233,26 @@ def test_create_project(idf_py: IdfPyFunc, idf_copy: Path) -> None:
@pytest.mark.skipif(sys.platform == 'darwin', reason='macos runner is a shell executor, it would break the file system') @pytest.mark.skipif(sys.platform == 'darwin', reason='macos runner is a shell executor, it would break the file system')
def test_create_project_with_idf_readonly(idf_copy: Path) -> None: def test_create_project_with_idf_readonly(idf_copy: Path) -> None:
def change_to_readonly(src: Path) -> None: def change_file_permissions(src: Path, write_permission: bool) -> None:
dir_permission = 0o777 if write_permission else 0o555 # all or read & execute
file_permission = 0o777 if write_permission else 0o444 # all or readonly or all
for root, dirs, files in os.walk(src): for root, dirs, files in os.walk(src):
for name in dirs: for name in dirs:
os.chmod(os.path.join(root, name), 0o555) # read & execute os.chmod(os.path.join(root, name), dir_permission)
for name in files: for name in files:
path = os.path.join(root, name) path = os.path.join(root, name)
if '/bin/' in path: if '/bin/' in path:
continue # skip executables continue # skip executables
os.chmod(os.path.join(root, name), 0o444) # readonly os.chmod(os.path.join(root, name), file_permission)
logging.info('Check that command for creating new project will success if the IDF itself is readonly.') logging.info('Check that command for creating new project will success if the IDF itself is readonly.')
change_to_readonly(idf_copy) change_file_permissions(idf_copy, write_permission=False)
try: try:
run_idf_py('create-project', '--path', str(idf_copy / 'example_proj'), 'temp_test_project') run_idf_py('create-project', '--path', str(idf_copy / 'example_proj'), 'temp_test_project')
except Exception: except Exception:
raise raise
else: else:
def del_rw(function, path, excinfo): # type: ignore change_file_permissions(idf_copy, write_permission=True)
os.chmod(path, stat.S_IWRITE) shutil.rmtree(idf_copy)
os.remove(path)
shutil.rmtree(idf_copy, onerror=del_rw)
@pytest.mark.usefixtures('test_app_copy') @pytest.mark.usefixtures('test_app_copy')