Logging improvements in OTA example and component

This commit is contained in:
Mahavir Jain
2019-10-18 17:35:13 +05:30
parent de9549936d
commit 917a406c0a
2 changed files with 6 additions and 5 deletions

View File

@@ -263,7 +263,7 @@ esp_err_t esp_https_ota_perform(esp_https_ota_handle_t https_ota_handle)
handle->ota_upgrade_buf, handle->ota_upgrade_buf,
handle->ota_upgrade_buf_size); handle->ota_upgrade_buf_size);
if (data_read == 0) { if (data_read == 0) {
ESP_LOGI(TAG, "Connection closed, all data received"); ESP_LOGI(TAG, "Connection closed");
} else if (data_read < 0) { } else if (data_read < 0) {
ESP_LOGE(TAG, "Error: SSL data read error"); ESP_LOGE(TAG, "Error: SSL data read error");
return ESP_FAIL; return ESP_FAIL;

View File

@@ -176,19 +176,20 @@ static void ota_example_task(void *pvParameter)
binary_file_length += data_read; binary_file_length += data_read;
ESP_LOGD(TAG, "Written image length %d", binary_file_length); ESP_LOGD(TAG, "Written image length %d", binary_file_length);
} else if (data_read == 0) { } else if (data_read == 0) {
ESP_LOGI(TAG, "Connection closed,all data received"); ESP_LOGI(TAG, "Connection closed");
break; break;
} }
} }
ESP_LOGI(TAG, "Total Write binary data length : %d", binary_file_length); ESP_LOGI(TAG, "Total Write binary data length: %d", binary_file_length);
if (esp_http_client_is_complete_data_received(client) != true) { if (esp_http_client_is_complete_data_received(client) != true) {
ESP_LOGE(TAG, "Error in receiving complete file"); ESP_LOGE(TAG, "Error in receiving complete file");
http_cleanup(client); http_cleanup(client);
task_fatal_error(); task_fatal_error();
} }
if (esp_ota_end(update_handle) != ESP_OK) { err = esp_ota_end(update_handle);
ESP_LOGE(TAG, "esp_ota_end failed!"); if (err != ESP_OK) {
ESP_LOGE(TAG, "esp_ota_end failed (%s)!", esp_err_to_name(err));
http_cleanup(client); http_cleanup(client);
task_fatal_error(); task_fatal_error();
} }