espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-30 18:57:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

replace strncpy with strlcpy in wifi examples for safety's sake

Browse Source
This commit is contained in:
suda-morris
2019-06-11 15:46:02 +08:00
committed by morris
parent 6648127362
commit a476228c8c
4 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
examples/provisioning/custom_config/main/app_prov.c
View File

@ -326,8 +326,7 @@ static esp_err_t start_wifi_ap(const char *ssid, const char *pass)
}, },
}; };
strncpy((char *) wifi_config.ap.ssid, ssid, sizeof(wifi_config.ap.ssid)); strlcpy((char *) wifi_config.ap.ssid, ssid, sizeof(wifi_config.ap.ssid));
wifi_config.ap.ssid_len = strnlen(ssid, sizeof(wifi_config.ap.ssid));
if (strlen(pass) == 0) { if (strlen(pass) == 0) {
memset(wifi_config.ap.password, 0, sizeof(wifi_config.ap.password)); memset(wifi_config.ap.password, 0, sizeof(wifi_config.ap.password));

3
examples/provisioning/softap_prov/main/app_prov.c
View File

@ -313,8 +313,7 @@ static esp_err_t start_wifi_ap(const char *ssid, const char *pass)
}, },
}; };
strncpy((char *) wifi_config.ap.ssid, ssid, sizeof(wifi_config.ap.ssid)); strlcpy((char *) wifi_config.ap.ssid, ssid, sizeof(wifi_config.ap.ssid));
wifi_config.ap.ssid_len = strnlen(ssid, sizeof(wifi_config.ap.ssid));
if (strlen(pass) == 0) { if (strlen(pass) == 0) {
memset(wifi_config.ap.password, 0, sizeof(wifi_config.ap.password)); memset(wifi_config.ap.password, 0, sizeof(wifi_config.ap.password));

4
examples/system/console/main/cmd_wifi.c
View File

@ -63,9 +63,9 @@ static bool wifi_join(const char *ssid, const char *pass, int timeout_ms)
{ {
initialise_wifi(); initialise_wifi();
wifi_config_t wifi_config = { 0 }; wifi_config_t wifi_config = { 0 };
strncpy((char *) wifi_config.sta.ssid, ssid, sizeof(wifi_config.sta.ssid)); strlcpy((char *) wifi_config.sta.ssid, ssid, sizeof(wifi_config.sta.ssid));
if (pass) { if (pass) {
strncpy((char *) wifi_config.sta.password, pass, sizeof(wifi_config.sta.password)); strlcpy((char *) wifi_config.sta.password, pass, sizeof(wifi_config.sta.password));
} }
ESP_ERROR_CHECK( esp_wifi_set_mode(WIFI_MODE_STA) ); ESP_ERROR_CHECK( esp_wifi_set_mode(WIFI_MODE_STA) );

6
examples/wifi/iperf/main/cmd_wifi.c
View File

@ -129,7 +129,7 @@ static bool wifi_cmd_sta_join(const char* ssid, const char* pass)
strlcpy((char*) wifi_config.sta.ssid, ssid, sizeof(wifi_config.sta.ssid)); strlcpy((char*) wifi_config.sta.ssid, ssid, sizeof(wifi_config.sta.ssid));
if (pass) { if (pass) {
strncpy((char*) wifi_config.sta.password, pass, sizeof(wifi_config.sta.password)); strlcpy((char*) wifi_config.sta.password, pass, sizeof(wifi_config.sta.password));
} }
if (bits & CONNECTED_BIT) { if (bits & CONNECTED_BIT) {
@ -206,14 +206,14 @@ static bool wifi_cmd_ap_set(const char* ssid, const char* pass)
}; };
reconnect = false; reconnect = false;
strncpy((char*) wifi_config.ap.ssid, ssid, sizeof(wifi_config.ap.ssid)); strlcpy((char*) wifi_config.ap.ssid, ssid, sizeof(wifi_config.ap.ssid));
if (pass) { if (pass) {
if (strlen(pass) != 0 && strlen(pass) < 8) { if (strlen(pass) != 0 && strlen(pass) < 8) {
reconnect = true; reconnect = true;
ESP_LOGE(TAG, "password less than 8"); ESP_LOGE(TAG, "password less than 8");
return false; return false;
} }
strncpy((char*) wifi_config.ap.password, pass, sizeof(wifi_config.ap.password)); strlcpy((char*) wifi_config.ap.password, pass, sizeof(wifi_config.ap.password));
} }
if (strlen(pass) == 0) { if (strlen(pass) == 0) {