espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-30 18:57:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(gpio): improve set level performance

Browse Source 
by avoid "read-modify-write" operation. The registers designed to be
write only.

Related to https://github.com/espressif/esp-idf/issues/14674
This commit is contained in:
morris
2024-11-07 16:27:55 +08:00
parent ec8de8a1f9
commit a5fee4b8cc
10 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
components/hal/esp32/include/hal/gpio_ll.h
View File

@ -498,15 +498,15 @@ static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t
{ {
if (level) { if (level) {
if (gpio_num < 32) { if (gpio_num < 32) {
hw->out_w1ts = (1 << gpio_num); hw->out_w1ts = 1 << gpio_num;
} else { } else {
HAL_FORCE_MODIFY_U32_REG_FIELD(hw->out1_w1ts, data, (1 << (gpio_num - 32))); hw->out1_w1ts.val = 1 << (gpio_num - 32);
} }
} else { } else {
if (gpio_num < 32) { if (gpio_num < 32) {
hw->out_w1tc = (1 << gpio_num); hw->out_w1tc = 1 << gpio_num;
} else { } else {
HAL_FORCE_MODIFY_U32_REG_FIELD(hw->out1_w1tc, data, (1 << (gpio_num - 32))); hw->out1_w1tc.val = 1 << (gpio_num - 32);
} }
} }
} }

4
components/hal/esp32c2/include/hal/gpio_ll.h
View File

@ -330,9 +330,9 @@ __attribute__((always_inline))
static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level) static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level)
{ {
if (level) { if (level) {
hw->out_w1ts.out_w1ts = (1 << gpio_num); hw->out_w1ts.val = 1 << gpio_num;
} else { } else {
hw->out_w1tc.out_w1tc = (1 << gpio_num); hw->out_w1tc.val = 1 << gpio_num;
} }
} }

4
components/hal/esp32c3/include/hal/gpio_ll.h
View File

@ -339,9 +339,9 @@ __attribute__((always_inline))
static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level) static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level)
{ {
if (level) { if (level) {
hw->out_w1ts.out_w1ts = (1 << gpio_num); hw->out_w1ts.val = 1 << gpio_num;
} else { } else {
hw->out_w1tc.out_w1tc = (1 << gpio_num); hw->out_w1tc.val = 1 << gpio_num;
} }
} }

4
components/hal/esp32c5/include/hal/gpio_ll.h
View File

@ -360,9 +360,9 @@ __attribute__((always_inline))
static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level) static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level)
{ {
if (level) { if (level) {
hw->out_w1ts.out_w1ts = (1 << gpio_num); hw->out_w1ts.val = 1 << gpio_num;
} else { } else {
hw->out_w1tc.out_w1tc = (1 << gpio_num); hw->out_w1tc.val = 1 << gpio_num;
} }
} }

4
components/hal/esp32c6/include/hal/gpio_ll.h
View File

@ -332,9 +332,9 @@ __attribute__((always_inline))
static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level) static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level)
{ {
if (level) { if (level) {
hw->out_w1ts.out_w1ts = (1 << gpio_num); hw->out_w1ts.val = 1 << gpio_num;
} else { } else {
hw->out_w1tc.out_w1tc = (1 << gpio_num); hw->out_w1tc.val = 1 << gpio_num;
} }
} }

4
components/hal/esp32c61/include/hal/gpio_ll.h
View File

@ -356,9 +356,9 @@ __attribute__((always_inline))
static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level) static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t level)
{ {
if (level) { if (level) {
hw->out_w1ts.out_w1ts = (1 << gpio_num); hw->out_w1ts.val = 1 << gpio_num;
} else { } else {
hw->out_w1tc.out_w1tc = (1 << gpio_num); hw->out_w1tc.val = 1 << gpio_num;
} }
} }

4
components/hal/esp32h2/include/hal/gpio_ll.h
View File

@ -377,9 +377,9 @@ __attribute__((always_inline))
static inline void gpio_ll_set_level(gpio_dev_t *hw, gpio_num_t gpio_num, uint32_t level) static inline void gpio_ll_set_level(gpio_dev_t *hw, gpio_num_t gpio_num, uint32_t level)
{ {
if (level) { if (level) {
hw->out_w1ts.out_w1ts = (1 << gpio_num); hw->out_w1ts.val = 1 << gpio_num;
} else { } else {
hw->out_w1tc.out_w1tc = (1 << gpio_num); hw->out_w1tc.val = 1 << gpio_num;
} }
} }

8
components/hal/esp32p4/include/hal/gpio_ll.h
View File

@ -400,15 +400,15 @@ static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t
{ {
if (level) { if (level) {
if (gpio_num < 32) { if (gpio_num < 32) {
hw->out_w1ts.out_w1ts = (1 << gpio_num); hw->out_w1ts.val = 1 << gpio_num;
} else { } else {
hw->out1_w1ts.out1_w1ts = (1 << (gpio_num - 32)); hw->out1_w1ts.val = 1 << (gpio_num - 32);
} }
} else { } else {
if (gpio_num < 32) { if (gpio_num < 32) {
hw->out_w1tc.out_w1tc = (1 << gpio_num); hw->out_w1tc.val = 1 << gpio_num;
} else { } else {
hw->out1_w1tc.out1_w1tc = (1 << (gpio_num - 32)); hw->out1_w1tc.val = 1 << (gpio_num - 32);
} }
} }
} }

8
components/hal/esp32s2/include/hal/gpio_ll.h
View File

@ -338,15 +338,15 @@ static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t
{ {
if (level) { if (level) {
if (gpio_num < 32) { if (gpio_num < 32) {
hw->out_w1ts = (1 << gpio_num); hw->out_w1ts = 1 << gpio_num;
} else { } else {
hw->out1_w1ts.data = (1 << (gpio_num - 32)); hw->out1_w1ts.val = 1 << (gpio_num - 32);
} }
} else { } else {
if (gpio_num < 32) { if (gpio_num < 32) {
hw->out_w1tc = (1 << gpio_num); hw->out_w1tc = 1 << gpio_num;
} else { } else {
hw->out1_w1tc.data = (1 << (gpio_num - 32)); hw->out1_w1tc.val = 1 << (gpio_num - 32);
} }
} }
} }

8
components/hal/esp32s3/include/hal/gpio_ll.h
View File

@ -354,15 +354,15 @@ static inline void gpio_ll_set_level(gpio_dev_t *hw, uint32_t gpio_num, uint32_t
{ {
if (level) { if (level) {
if (gpio_num < 32) { if (gpio_num < 32) {
hw->out_w1ts = (1 << gpio_num); hw->out_w1ts = 1 << gpio_num;
} else { } else {
hw->out1_w1ts.data = (1 << (gpio_num - 32)); hw->out1_w1ts.val = 1 << (gpio_num - 32);
} }
} else { } else {
if (gpio_num < 32) { if (gpio_num < 32) {
hw->out_w1tc = (1 << gpio_num); hw->out_w1tc = 1 << gpio_num;
} else { } else {
hw->out1_w1tc.data = (1 << (gpio_num - 32)); hw->out1_w1tc.val = 1 << (gpio_num - 32);
} }
} }
} }