From a7b249b18261a0bdcfdb819d73e0dc5488583a34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ga=C5=88o?= Date: Fri, 4 Mar 2022 12:18:41 +0100 Subject: [PATCH] Remove line finalization when coredump is active to avoid coredump failure Closes https://github.com/espressif/esp-idf/issues/8099 --- tools/idf_monitor.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/idf_monitor.py b/tools/idf_monitor.py index 490178e53a..38fa6dd32d 100755 --- a/tools/idf_monitor.py +++ b/tools/idf_monitor.py @@ -594,8 +594,11 @@ class Monitor(object): # generates an event which will result in the finishing of # the last line. This is fix for handling lines sent # without EOL. + # finalizing the line when coredump is in progress causes decoding issues + # the espcoredump loader uses empty line as a sign for end-of-coredump + # line is finalized only for non coredump data elif event_tag == TAG_SERIAL_FLUSH: - self.handle_serial_input(data, finalize_line=True) + self.handle_serial_input(data, finalize_line=not self._coredump_buffer) else: raise RuntimeError('Bad event data %r' % ((event_tag,data),)) except SerialStopException: