espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-31 19:24:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(lp_i2c): Fixed a bug where LP I2C write got stuck

Browse Source 
This commit fixes a bug where an I2C write got stuck when using the
lp_core_i2c_master_write_read_device() API. This was because the LP I2C
HW was not programmed with an END condition and therefore did not know
the end of a transaction.

Closes: https://github.com/espressif/esp-idf/issues/11958
This commit is contained in:
Sudeep Mohanty
2023-08-07 09:59:28 +02:00
committed by BOT
parent ee8adce5ea
commit a9ef76b031
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/ulp/lp_core/lp_core/lp_core_i2c.c
View File

@@ -382,11 +382,9 @@ esp_err_t lp_core_i2c_master_write_read_device(i2c_port_t lp_i2c_num, uint16_t d
i2c_ll_write_txfifo(dev, &data_wr[data_idx], fifo_size); i2c_ll_write_txfifo(dev, &data_wr[data_idx], fifo_size);
lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_WRITE, 0, LP_I2C_ACK, s_ack_check_en, fifo_size); lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_WRITE, 0, LP_I2C_ACK, s_ack_check_en, fifo_size);
if (remaining_bytes) { /* Insert an End command to signal the end of the write transaction to the HW */
/* This means we have to send more than what can fit in the Tx FIFO. Insert an End command. */
lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_END, 0, 0, 0, 0); lp_core_i2c_format_cmd(cmd_idx++, I2C_LL_CMD_END, 0, 0, 0, 0);
cmd_idx = 0; cmd_idx = 0;
}
/* Initiate I2C transfer */ /* Initiate I2C transfer */
i2c_ll_update(dev); i2c_ll_update(dev);