From b13ade8e0c122033cbe75ac3ec3583f4a041f837 Mon Sep 17 00:00:00 2001 From: Guillaume Souchere Date: Thu, 29 May 2025 13:30:19 +0200 Subject: [PATCH] fix(driver): remove unecessary if conditions in the read function This changes affect usb_serial_jtag_vfs and cdcacm_vfs read functions. This commit removes the exit condition on reception of \n character. --- .../esp_driver_usb_serial_jtag/src/usb_serial_jtag_vfs.c | 3 --- components/esp_vfs_console/vfs_cdcacm.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/components/esp_driver_usb_serial_jtag/src/usb_serial_jtag_vfs.c b/components/esp_driver_usb_serial_jtag/src/usb_serial_jtag_vfs.c index d24ef0c351..e0a169f9fa 100644 --- a/components/esp_driver_usb_serial_jtag/src/usb_serial_jtag_vfs.c +++ b/components/esp_driver_usb_serial_jtag/src/usb_serial_jtag_vfs.c @@ -257,9 +257,6 @@ static ssize_t usb_serial_jtag_read(int fd, void* data, size_t size) } data_c[received] = (char) c; ++received; - if (c == '\n') { - break; - } } _lock_release_recursive(&s_ctx.read_lock); if (received > 0) { diff --git a/components/esp_vfs_console/vfs_cdcacm.c b/components/esp_vfs_console/vfs_cdcacm.c index 3402e34220..65dca2aa6e 100644 --- a/components/esp_vfs_console/vfs_cdcacm.c +++ b/components/esp_vfs_console/vfs_cdcacm.c @@ -196,9 +196,6 @@ static ssize_t cdcacm_read(int fd, void *data, size_t size) break; } data_c[received++] = (char) c; - if (c == '\n') { - break; - } } } _lock_release_recursive(&s_read_lock);