From b597dbff7c03b4a5b345b85bd21701e9ab7fa8fd Mon Sep 17 00:00:00 2001 From: David Cermak Date: Mon, 20 Sep 2021 16:17:59 +0200 Subject: [PATCH] vfs: Warn aobut using deprecated select option Add LWIP_USE_ONLY_LWIP_SELECT for compatibility, as the dependency may break backward compatibility if LWIP_USE_ONLY_LWIP_SELECT=y. --- components/lwip/Kconfig | 6 ++++++ components/vfs/vfs.c | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/components/lwip/Kconfig b/components/lwip/Kconfig index b644b2f2be..9d1d7561d3 100644 --- a/components/lwip/Kconfig +++ b/components/lwip/Kconfig @@ -81,6 +81,12 @@ menu "LWIP" the maximum amount of sockets here. The valid value is from 1 to 16. + config LWIP_USE_ONLY_LWIP_SELECT + bool "Support LWIP socket select() only (DEPRECATED)" + default n + help + This option is deprecated. Do not use this option, use VFS_SUPPORT_SELECT instead. + config LWIP_SO_LINGER bool "Enable SO_LINGER processing" default n diff --git a/components/vfs/vfs.c b/components/vfs/vfs.c index 9ca3689d26..ad38c0edd4 100644 --- a/components/vfs/vfs.c +++ b/components/vfs/vfs.c @@ -21,6 +21,11 @@ #include "esp_vfs_private.h" #include "sdkconfig.h" +// Warn about using deprecated option +#ifdef CONFIG_LWIP_USE_ONLY_LWIP_SELECT +#warning LWIP_USE_ONLY_LWIP_SELECT is deprecated: Please use VFS_SUPPORT_SELECT instead +#endif + #ifdef CONFIG_VFS_SUPPRESS_SELECT_DEBUG_OUTPUT #define LOG_LOCAL_LEVEL ESP_LOG_NONE #endif //CONFIG_VFS_SUPPRESS_SELECT_DEBUG_OUTPUT