espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-08-02 12:14:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

httpd: Fixed wrong header in ws_send_async() for lengthy packets

Browse Source 
Closes https://github.com/espressif/esp-idf/issues/6196
This commit is contained in:
David Cermak
2020-12-18 09:53:23 +01:00
committed by bot
parent cf9ff5eccf
commit c415c6f9a6
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
components/esp_http_server/src/httpd_ws.c
View File

@@ -377,9 +377,11 @@ esp_err_t httpd_ws_send_frame_async(httpd_handle_t hd, int fd, httpd_ws_frame_t
} else { } else {
header_buf[1] = 127; /* Length for 64 bits */ header_buf[1] = 127; /* Length for 64 bits */
uint8_t shift_idx = sizeof(uint64_t) - 1; /* Shift index starts at 7 */ uint8_t shift_idx = sizeof(uint64_t) - 1; /* Shift index starts at 7 */
for (int8_t idx = 2; idx > 9; idx--) { uint64_t len64 = frame->len; /* Raise variable size to make sure we won't shift by more bits
/* Now do shifting (be careful of endianess, i.e. when buffer index is 2, frame length shift index is 7) */ * than the length has (to avoid undefined behaviour) */
header_buf[idx] = (frame->len >> (uint8_t)(shift_idx * 8)) & 0xffU; for (int8_t idx = 2; idx <= 9; idx++) {
/* Now do shifting (be careful of endianness, i.e. when buffer index is 2, frame length shift index is 7) */
header_buf[idx] = (len64 >> (shift_idx * 8)) & 0xffU;
shift_idx--; shift_idx--;
} }
tx_len = 10; tx_len = 10;