espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-08-02 12:14:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(esp_http_client): fix memory leak in current_header_value buffer

Browse Source 
Fixed memory leak in esp_http_client_cleanup() where current_header_value
buffer was not being freed when ESP_ERR_HTTP_FETCH_HEADER is returned
during header parsing failures.
This commit is contained in:
Ashish Sharma
2025-07-11 13:12:58 +08:00
parent b257023dba
commit cfcf66f0b4
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
components/esp_http_client/esp_http_client.c
View File

@@ -993,6 +993,7 @@ esp_err_t esp_http_client_cleanup(esp_http_client_handle_t client)
_clear_auth_data(client); _clear_auth_data(client);
free(client->auth_data); free(client->auth_data);
free(client->current_header_key); free(client->current_header_key);
free(client->current_header_value);
free(client->location); free(client->location);
free(client->auth_header); free(client->auth_header);
free(client); free(client);

15
components/esp_http_client/lib/http_utils.c
View File

@@ -1,5 +1,5 @@
/* /*
* SPDX-FileCopyrightText: 2015-2021 Espressif Systems (Shanghai) CO LTD * SPDX-FileCopyrightText: 2015-2025 Espressif Systems (Shanghai) CO LTD
* *
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
@@ -11,6 +11,7 @@
#include <assert.h> #include <assert.h>
#include "http_utils.h" #include "http_utils.h"
#include "esp_check.h"
#ifndef mem_check #ifndef mem_check
#define mem_check(x) assert(x) #define mem_check(x) assert(x)
@@ -64,8 +65,16 @@ char *http_utils_append_string(char **str, const char *new_str, int len)
} }
if (old_str) { if (old_str) {
old_len = strlen(old_str); old_len = strlen(old_str);
old_str = realloc(old_str, old_len + l + 1); // old_str should not be reallocated directly, as in case of memory exhaustion,
mem_check(old_str); // it will be lost and we will not be able to free it.
char *tmp = realloc(old_str, old_len + l + 1);
if (tmp == NULL) {
free(old_str);
old_str = NULL;
ESP_RETURN_ON_FALSE(old_str, NULL, "http_utils", "Memory exhausted");
}
old_str = tmp;
// Ensure the new string is null-terminated
old_str[old_len + l] = 0; old_str[old_len + l] = 0;
} else { } else {
old_str = calloc(1, l + 1); old_str = calloc(1, l + 1);