diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index c591cae4cb..061ffe5cb6 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -47,6 +47,7 @@ * @esp-idf-codeowners/other /.* @esp-idf-codeowners/tools +/.gitlab/ci/ @esp-idf-codeowners/ci /.gitlab-ci.yml @esp-idf-codeowners/ci /.pre-commit-config.yaml @esp-idf-codeowners/ci /.readthedocs.yml @esp-idf-codeowners/docs diff --git a/.gitlab/ci/rules.yml b/.gitlab/ci/rules.yml index 1af988eef2..aacc79e126 100644 --- a/.gitlab/ci/rules.yml +++ b/.gitlab/ci/rules.yml @@ -13,6 +13,7 @@ .patterns-c-files: &patterns-c-files - ".gitlab/ci/static-code-analysis.yml" + - "tools/ci/static-analysis-rules.yml" - "**/*.{c,C}" - "**/*.{h,H}" - "components/**/Kconfig" @@ -121,6 +122,9 @@ - "tools/kconfig_new/**/*" + - "tools/detect_python.sh" + - "tools/detect_python.fish" + .patterns-windows: &patterns-windows - "tools/windows/**/*" diff --git a/.gitlab/ci/static-code-analysis.yml b/.gitlab/ci/static-code-analysis.yml index 5abf19eb8a..2165696015 100644 --- a/.gitlab/ci/static-code-analysis.yml +++ b/.gitlab/ci/static-code-analysis.yml @@ -58,7 +58,8 @@ code_quality_check: extends: - .sonar_scan_template - .rules:patterns:static-code-analysis-preview - allow_failure: true + allow_failure: true # since now it's using exit code to indicate the code analysis result, + # we don't want to block ci when critical issues founded script: - export CI_MERGE_REQUEST_COMMITS=$(python ${CI_PROJECT_DIR}/tools/ci/ci_get_mr_info.py commits ${CI_COMMIT_REF_NAME} | tr '\n' ',') # test if this branch have merge request, if not, exit 0 @@ -88,6 +89,8 @@ code_quality_report: extends: - .sonar_scan_template - .rules:protected + allow_failure: true # since now it's using exit code to indicate the code analysis result, + # we don't want to block ci when critical issues founded script: - sonar-scanner -Dsonar.branch.name=$CI_COMMIT_REF_NAME