From c06519a7592b9377b4f7c2166925bc7e07b300c6 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Mon, 23 Sep 2019 12:00:00 +0200 Subject: [PATCH 1/2] docs: update windows msys2 installer notes to unzip all-in-one toolchain to path without spaces --- docs/en/get-started-legacy/windows-setup.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/en/get-started-legacy/windows-setup.rst b/docs/en/get-started-legacy/windows-setup.rst index 79597ad399..07167e4b14 100644 --- a/docs/en/get-started-legacy/windows-setup.rst +++ b/docs/en/get-started-legacy/windows-setup.rst @@ -20,6 +20,10 @@ https://dl.espressif.com/dl/esp32_win32_msys2_environment_and_toolchain-20190611 Unzip the zip file to ``C:\`` (or some other location, but this guide assumes ``C:\``) and it will create an ``msys32`` directory with a pre-prepared environment. +.. important:: + + If another toolchain location is used (different than the default ``C:\msys32``), please ensure that the path where the all-in-one toolchain gets unzipped is a plain ASCII, contains no spaces, symlinks or accents. + Check it Out ============ From 4ddc6916c3910049b692ad735f58a5680699d5d6 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Thu, 26 Sep 2019 10:51:04 +0200 Subject: [PATCH 2/2] docs: fix minor parameter description inconsistency for idf_component_set_property --- docs/en/api-guides/build-system.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en/api-guides/build-system.rst b/docs/en/api-guides/build-system.rst index 9aa430d042..106d4f3aed 100644 --- a/docs/en/api-guides/build-system.rst +++ b/docs/en/api-guides/build-system.rst @@ -1179,7 +1179,7 @@ can be used with CMake commands that support generator expressions. .. code-block:: none - idf_component_set_property(property val [APPEND]) + idf_component_set_property(component property val [APPEND]) Set a specified *component*'s :ref:`component property`, *property* with value *val*. Specifying *APPEND* will append the specified value to the current value of the property. If the property does not previously exist or it is currently empty, the specified value becomes