From bc011410981f2803d1d4045c0137d0657c623460 Mon Sep 17 00:00:00 2001 From: Roland Dobai Date: Thu, 25 Sep 2025 09:19:38 +0200 Subject: [PATCH 1/2] fix(cmake): correct component targets property name in validation The component validation script was using an incorrect property name '__COMPONENT_TARGETS' when retrieving component targets. This should be '__BUILD_COMPONENT_TARGETS' to match the actual property name used throughout the build system. This fix ensures the component validation can properly access the list of component targets and perform validation checks correctly. --- tools/cmake/component_validation.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/cmake/component_validation.cmake b/tools/cmake/component_validation.cmake index f7d66103df..585198b45f 100644 --- a/tools/cmake/component_validation.cmake +++ b/tools/cmake/component_validation.cmake @@ -122,7 +122,7 @@ endfunction() # function(__component_validation_run_checks) # Get all component targets - idf_build_get_property(component_targets __COMPONENT_TARGETS) + idf_build_get_property(component_targets __BUILD_COMPONENT_TARGETS) # Run validation checks for each component foreach(component_target ${component_targets}) From 52f7cebcd337f17986564d84e77b45577941b4c3 Mon Sep 17 00:00:00 2001 From: Roland Dobai Date: Mon, 29 Sep 2025 06:59:38 +0200 Subject: [PATCH 2/2] ci: Support known failure cases in pytests on Windows runners --- .gitlab/ci/test-win.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.gitlab/ci/test-win.yml b/.gitlab/ci/test-win.yml index 158413f8ee..25ea54ed9b 100644 --- a/.gitlab/ci/test-win.yml +++ b/.gitlab/ci/test-win.yml @@ -65,7 +65,8 @@ test_tools_win: - .\export.ps1 - python "${SUBMODULE_FETCH_TOOL}" -s "all" - cd ${IDF_PATH}/tools/test_idf_py - - pytest --parallel-count ${CI_NODE_TOTAL} --parallel-index ${CI_NODE_INDEX} --junitxml=${IDF_PATH}/XUNIT_RESULT.xml + - idf-ci gitlab download-known-failure-cases-file ${KNOWN_FAILURE_CASES_FILE_NAME} + - pytest --parallel-count ${CI_NODE_TOTAL} --parallel-index ${CI_NODE_INDEX} --junitxml=${IDF_PATH}/XUNIT_RESULT.xml --ignore-result-files ${KNOWN_FAILURE_CASES_FILE_NAME} # Build tests .test_build_system_template_win: @@ -82,7 +83,8 @@ test_tools_win: - . .\export.ps1 - python "${SUBMODULE_FETCH_TOOL}" -s "all" - cd ${IDF_PATH}\tools\test_build_system - - pytest --parallel-count ${CI_NODE_TOTAL} --parallel-index ${CI_NODE_INDEX} --junitxml=${CI_PROJECT_DIR}\XUNIT_RESULT.xml + - idf-ci gitlab download-known-failure-cases-file ${KNOWN_FAILURE_CASES_FILE_NAME} + - pytest --parallel-count ${CI_NODE_TOTAL} --parallel-index ${CI_NODE_INDEX} --junitxml=${CI_PROJECT_DIR}\XUNIT_RESULT.xml --ignore-result-files ${KNOWN_FAILURE_CASES_FILE_NAME} pytest_build_system_win: extends: @@ -129,4 +131,5 @@ pytest_build_system_win_minimal_cmake: } - python "${SUBMODULE_FETCH_TOOL}" -s "all" - cd ${IDF_PATH}\tools\test_build_system - - pytest -k cmake --junitxml=${CI_PROJECT_DIR}\XUNIT_RESULT.xml + - idf-ci gitlab download-known-failure-cases-file ${KNOWN_FAILURE_CASES_FILE_NAME} + - pytest -k cmake --junitxml=${CI_PROJECT_DIR}\XUNIT_RESULT.xml --ignore-result-files ${KNOWN_FAILURE_CASES_FILE_NAME}