espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-30 18:57:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

ledc: Fix -Werror=maybe-uninitialized warning on glb_clk variable on specific kconfig options selected

Browse Source 
Closes https://github.com/espressif/esp-idf/pull/9025
Closes https://github.com/espressif/esp-idf/issues/10322
This commit is contained in:
Song Ruo Jing
2023-01-04 12:06:41 +08:00
parent 490216a2ac
commit e8386ed732
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
components/driver/ledc.c
View File

@ -27,6 +27,7 @@ static __attribute__((unused)) const char *LEDC_TAG = "ledc";
#define LEDC_ARG_CHECK(a, param) ESP_RETURN_ON_FALSE(a, ESP_ERR_INVALID_ARG, LEDC_TAG, param " argument is invalid") #define LEDC_ARG_CHECK(a, param) ESP_RETURN_ON_FALSE(a, ESP_ERR_INVALID_ARG, LEDC_TAG, param " argument is invalid")
#define LEDC_CLK_NOT_FOUND 0 #define LEDC_CLK_NOT_FOUND 0
#define LEDC_SLOW_CLK_UNINIT -1
typedef enum { typedef enum {
LEDC_FSM_IDLE, LEDC_FSM_IDLE,
@ -493,7 +494,7 @@ static esp_err_t ledc_set_timer_div(ledc_mode_t speed_mode, ledc_timer_t timer_n
/* Timer-specific mux. Set to timer-specific clock or LEDC_SCLK if a global clock is used. */ /* Timer-specific mux. Set to timer-specific clock or LEDC_SCLK if a global clock is used. */
ledc_clk_src_t timer_clk_src; ledc_clk_src_t timer_clk_src;
/* Global clock mux. Should be set when LEDC_SCLK is used in LOW_SPEED_MODE. Otherwise left uninitialized. */ /* Global clock mux. Should be set when LEDC_SCLK is used in LOW_SPEED_MODE. Otherwise left uninitialized. */
ledc_slow_clk_sel_t glb_clk; ledc_slow_clk_sel_t glb_clk = LEDC_SLOW_CLK_UNINIT;
if (clk_cfg == LEDC_AUTO_CLK) { if (clk_cfg == LEDC_AUTO_CLK) {
/* User hasn't specified the speed, we should try to guess it. */ /* User hasn't specified the speed, we should try to guess it. */
@ -566,6 +567,8 @@ static esp_err_t ledc_set_timer_div(ledc_mode_t speed_mode, ledc_timer_t timer_n
*/ */
assert(timer_clk_src == LEDC_SCLK); assert(timer_clk_src == LEDC_SCLK);
#endif #endif
// Arriving here, variable glb_clk must have been assigned to one of the ledc_slow_clk_sel_t enum values
assert(glb_clk != LEDC_SLOW_CLK_UNINIT);
ESP_LOGD(LEDC_TAG, "In slow speed mode, global clk set: %d", glb_clk); ESP_LOGD(LEDC_TAG, "In slow speed mode, global clk set: %d", glb_clk);
/* keep ESP_PD_DOMAIN_RTC8M on during light sleep */ /* keep ESP_PD_DOMAIN_RTC8M on during light sleep */