espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-08-03 12:44:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

esp_https_ota: Warn users when CONFIG_OTA_ALLOW_HTTP is set

Browse Source
This commit is contained in:
Aditya Patwardhan
2021-04-19 19:26:10 +05:30
parent 460df92e85
commit ead1587caf
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
components/esp_https_ota/src/esp_https_ota.c
View File

@@ -160,13 +160,11 @@ static esp_err_t _ota_write(esp_https_ota_t *https_ota_handle, const void *buffe
return err; return err;
} }
#if !CONFIG_OTA_ALLOW_HTTP
static bool is_server_verification_enabled(esp_https_ota_config_t *ota_config) { static bool is_server_verification_enabled(esp_https_ota_config_t *ota_config) {
return (ota_config->http_config->cert_pem return (ota_config->http_config->cert_pem
|| ota_config->http_config->use_global_ca_store || ota_config->http_config->use_global_ca_store
|| ota_config->http_config->crt_bundle_attach != NULL); || ota_config->http_config->crt_bundle_attach != NULL);
} }
#endif
esp_err_t esp_https_ota_begin(esp_https_ota_config_t *ota_config, esp_https_ota_handle_t *handle) esp_err_t esp_https_ota_begin(esp_https_ota_config_t *ota_config, esp_https_ota_handle_t *handle)
{ {
@@ -180,13 +178,15 @@ esp_err_t esp_https_ota_begin(esp_https_ota_config_t *ota_config, esp_https_ota_
return ESP_ERR_INVALID_ARG; return ESP_ERR_INVALID_ARG;
} }
#if !CONFIG_OTA_ALLOW_HTTP
if (!is_server_verification_enabled(ota_config)) { if (!is_server_verification_enabled(ota_config)) {
#if CONFIG_OTA_ALLOW_HTTP
ESP_LOGW(TAG, "Continuing with insecure option because CONFIG_OTA_ALLOW_HTTP is set.");
#else
ESP_LOGE(TAG, "No option for server verification is enabled in esp_http_client config."); ESP_LOGE(TAG, "No option for server verification is enabled in esp_http_client config.");
*handle = NULL; *handle = NULL;
return ESP_ERR_INVALID_ARG; return ESP_ERR_INVALID_ARG;
}
#endif #endif
}
esp_https_ota_t *https_ota_handle = calloc(1, sizeof(esp_https_ota_t)); esp_https_ota_t *https_ota_handle = calloc(1, sizeof(esp_https_ota_t));
if (!https_ota_handle) { if (!https_ota_handle) {