espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-08-06 06:04:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

esp-timer: fix (ignore) false positive memory alloc/free issue found by static analyser

Browse Source
This commit is contained in:
David Cermak
2020-05-11 21:38:01 +02:00
parent 6a47dc9275
commit f13f8927b1
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
components/esp_timer/src/esp_timer.c
View File

@@ -281,7 +281,11 @@ static void timer_process_alarm(esp_timer_dispatch_t dispatch_method)
int64_t now = esp_timer_impl_get_time(); int64_t now = esp_timer_impl_get_time();
esp_timer_handle_t it = LIST_FIRST(&s_timers); esp_timer_handle_t it = LIST_FIRST(&s_timers);
while (it != NULL && while (it != NULL &&
it->alarm < now) { it->alarm < now) { // NOLINT(clang-analyzer-unix.Malloc)
// Static analyser reports "Use of memory after it is freed" since the "it" variable
// is freed below (if EVENT_ID_DELETE_TIMER) and assigned to the (new) LIST_FIRST()
// so possibly (if the "it" hasn't been removed from the list) it might keep the same ptr.
// Ignoring this warning, as this couldn't happen if queue.h used to populate the list
LIST_REMOVE(it, list_entry); LIST_REMOVE(it, list_entry);
if (it->event_id == EVENT_ID_DELETE_TIMER) { if (it->event_id == EVENT_ID_DELETE_TIMER) {
free(it); free(it);