espressif/esp-idf
1
0
Fork 1
mirror of https://github.com/espressif/esp-idf.git synced 2025-07-31 11:17:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

idf.py: Fixed gdb target to exit cleanly when no openocd watch task

Browse Source 
When idf.py gdb starts, it expects openocd was started in the background
and creates a thread to watch for openocd errors. when gdb target exits,
the debug_ext.py aims to cleanup all threads and processes, but fails
with traceback if openocd-watch thread not available, which could happen
if openocd started separately.
This commit is contained in:
David Cermak
2020-09-17 15:08:54 +02:00
parent e849a77675
commit f871186da3
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/idf_py_actions/debug_ext.py
View File

@ -287,7 +287,11 @@ def action_extensions(base_actions, project_path):
continue continue
finally: finally:
watch_openocd.join() watch_openocd.join()
processes["threads_to_join"].remove(watch_openocd) try:
processes["threads_to_join"].remove(watch_openocd)
except ValueError:
# Valid scenario: watch_openocd task won't be in the list if openocd not started from idf.py
pass
fail_if_openocd_failed = { fail_if_openocd_failed = {
"names": ["--require-openocd", "--require_openocd"], "names": ["--require-openocd", "--require_openocd"],