From fd521fed30ad9f3c38b485c7545eecc91715af4f Mon Sep 17 00:00:00 2001 From: Shreyas Sheth Date: Tue, 10 Sep 2024 13:50:20 +0530 Subject: [PATCH] fix(wifi): Resolve comments on feature/softap_fixes_for_ceritification --- components/wpa_supplicant/src/ap/ieee802_11.c | 4 ++-- components/wpa_supplicant/src/common/wpa_common.c | 3 --- components/wpa_supplicant/src/rsn_supp/wpa_ie.c | 4 ---- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/components/wpa_supplicant/src/ap/ieee802_11.c b/components/wpa_supplicant/src/ap/ieee802_11.c index 48928b16c4..a844b5319f 100644 --- a/components/wpa_supplicant/src/ap/ieee802_11.c +++ b/components/wpa_supplicant/src/ap/ieee802_11.c @@ -180,7 +180,7 @@ static int auth_sae_send_confirm(struct hostapd_data *hapd, reply_res = -1; } else { if (sta->sae_data) - wpabuf_free(data); + wpabuf_free(sta->sae_data); sta->sae_data = data; reply_res = 0; /* confirm is sent in later stage when all the required processing for a sta is done*/ @@ -678,7 +678,7 @@ int auth_sae_queue(struct hostapd_data *hapd, unsigned int queue_len; queue_len = dl_list_len(&hapd->sae_commit_queue); - if (queue_len >= 5) { + if (queue_len >= hapd->conf->max_num_sta) { wpa_printf(MSG_DEBUG, "SAE: No more room in message queue - drop the new frame from " MACSTR, MAC2STR(bssid)); diff --git a/components/wpa_supplicant/src/common/wpa_common.c b/components/wpa_supplicant/src/common/wpa_common.c index 137187b83c..3574a21666 100644 --- a/components/wpa_supplicant/src/common/wpa_common.c +++ b/components/wpa_supplicant/src/common/wpa_common.c @@ -5,7 +5,6 @@ * This software may be distributed under the terms of the BSD license. * See README for more details. */ - #ifdef ESP_SUPPLICANT #include "utils/includes.h" #include "utils/common.h" @@ -1542,5 +1541,3 @@ int wpa_cipher_put_suites(u8 *pos, int ciphers) return num_suites; } - -#endif // ESP_SUPPLICANT diff --git a/components/wpa_supplicant/src/rsn_supp/wpa_ie.c b/components/wpa_supplicant/src/rsn_supp/wpa_ie.c index 34969aee6c..22d052dd6d 100644 --- a/components/wpa_supplicant/src/rsn_supp/wpa_ie.c +++ b/components/wpa_supplicant/src/rsn_supp/wpa_ie.c @@ -11,7 +11,6 @@ * * See README and COPYING for more details. */ - #ifdef ESP_SUPPLICANT #include "utils/includes.h" @@ -452,6 +451,3 @@ int wpa_supplicant_parse_ies(const u8 *buf, size_t len, return ret; } - - -#endif // ESP_SUPPLICANT