From 320b058e280527c32911a4b0ceddd069387e457f Mon Sep 17 00:00:00 2001
From: David Cermak <cermak@espressif.com>
Date: Thu, 21 Oct 2021 08:39:59 +0200
Subject: [PATCH] CI: Adjust jobs for testing IDFs, cleanup

Removes CI jobs for static analysis and reports as they are not primarily used
---
 .gitlab-ci.yml | 62 ++++----------------------------------------------
 1 file changed, 5 insertions(+), 57 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index b08c449..51a6f9d 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,7 +1,5 @@
 stages:
   - build
-  - static_analysis
-  - deploy_report
   - deploy
 
 
@@ -36,10 +34,6 @@ build_with_idf_v3:
     - $MQTT_PATH/ci/set_idf.sh release/v3.2
     - $MQTT_PATH/ci/set_mqtt.sh $CI_COMMIT_SHA
     - $MQTT_PATH/ci/build_examples.sh make
-    # build with IDFv3.3
-    - $MQTT_PATH/ci/set_idf.sh release/v3.3
-    - $MQTT_PATH/ci/set_mqtt.sh $CI_COMMIT_SHA
-    - $MQTT_PATH/ci/build_examples.sh make
     # simple build with IDFv3.1 (buiding directly in mqtt repo)
     - $MQTT_PATH/ci/set_idf.sh release/v3.1
     - cd $MQTT_PATH && ./ci/modify_for_legacy_idf.sh ${RECENT_IDF} || true
@@ -95,6 +89,11 @@ build_with_idf_v4:
     - cd $IDF_PATH && tools/idf_tools.py --non-interactive install && eval "$(tools/idf_tools.py --non-interactive export)"
     - $MQTT_PATH/ci/set_mqtt.sh $CI_COMMIT_SHA
     - $MQTT_PATH/ci/build_examples.sh
+    # build with IDFv3.3
+    - $MQTT_PATH/ci/set_idf.sh release/v3.3
+    - cd $IDF_PATH && tools/idf_tools.py --non-interactive install && eval "$(tools/idf_tools.py --non-interactive export)"
+    - $MQTT_PATH/ci/set_mqtt.sh $CI_COMMIT_SHA
+    - $MQTT_PATH/ci/build_examples.sh make    
 
 build_and_test_qemu:
   stage: build
@@ -121,57 +120,6 @@ build_and_test_qemu:
     - cd $IDF_PATH/tools/ci/python_packages/tiny_test_fw/bin
     - python Runner.py $TEST_PATH -c $TEST_PATH/publish_connect_mqtt_qemu.yml -e $TEST_PATH/env.yml
 
-clang_tidy_check:
-  stage: static_analysis
-  image: ${CI_DOCKER_REGISTRY}/clang-static-analysis
-  tags:
-    - host_test
-  dependencies:
-    - build_with_idf_v4
-  artifacts:
-    reports:
-      junit: esp-idf/examples/protocols/mqtt/tcp/tidybuild/output.xml
-    when: always
-    paths:
-      - esp-idf/examples/protocols/mqtt/tcp/tidybuild/report/*
-    expire_in: 1 day
-  script:
-    - cit_add_ssh_key "${GITLAB_KEY}"
-    - git clone "${IDF_REPO}"
-    - cd esp-idf
-    - ./tools/ci/mirror-submodule-update.sh
-    - export IDF_PATH=$(pwd)
-    - cd $IDF_PATH/components/mqtt/esp-mqtt
-    - rm -rf .git
-    - cp -r $CI_PROJECT_DIR/.git .
-    - git reset --hard $CI_COMMIT_SHA
-    - mv $CI_PROJECT_DIR/tidybuild $IDF_PATH/examples/protocols/mqtt/tcp/tidybuild
-    - cd $IDF_PATH/examples/protocols/mqtt/tcp/tidybuild
-    - git clone $IDF_ANALYSIS_UTILS static_analysis_utils && cd static_analysis_utils
-    - ./generate_report.sh $CI_PROJECT_DIR/static-analysis-rules.yml $IDF_PATH/examples/protocols/mqtt/tcp/tidybuild/report $IDF_PATH/examples/protocols/mqtt/tcp/tidybuild/output.xml
-
-deploy_report:
-  stage: deploy_report
-  image: $CI_DOCKER_REGISTRY/esp32-ci-env
-  tags:
-    - deploy
-    - shiny
-  dependencies:
-    - clang_tidy_check
-  script:
-    - cit_add_ssh_key "${DOCS_DEPLOY_KEY}"
-    - echo -e "Host $DOCS_SERVER\n\tStrictHostKeyChecking no\n\tUser $DOCS_SERVER_USER\n" >> ~/.ssh/config
-    - export GIT_VER=$(git describe --always)
-    - cd esp-idf/examples/protocols/mqtt/tcp/tidybuild
-    - mv report $GIT_VER
-    - tar czvf $GIT_VER.tar.gz $GIT_VER
-    - ssh $DOCS_SERVER -x "mkdir -p $DOCS_PATH/clang-tidy"
-    - scp $GIT_VER.tar.gz $DOCS_SERVER:$DOCS_PATH/clang-tidy
-    - ssh $DOCS_SERVER -x "cd $DOCS_PATH/clang-tidy && tar xzvf $GIT_VER.tar.gz && rm -f latest && ln -s $GIT_VER latest"
-    # add link to view the report
-    - echo "[static analysis][clang tidy] $CI_DOCKER_REGISTRY/static_analysis/esp-idf/clang-tidy/${GIT_VER}/index.html"
-    - test ! -e ${GIT_VER}/FAILED_RULES || { echo 'Failed static analysis rules!'; cat ${GIT_VER}/FAILED_RULES; exit 1; }
-
 push_master_to_github:
   stage: deploy
   image: ${CI_DOCKER_REGISTRY}/esp32-ci-env