espressif/esp-protocols
1
0
Fork 1
mirror of https://github.com/espressif/esp-protocols.git synced 2025-07-23 15:27:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

mdns: Fix crashes reported by the fuzzer

Browse Source 
* Original commit: espressif/esp-idf@79ba738626
This commit is contained in:
David Cermak
2021-06-09 09:59:25 +02:00
committed by suren-gabrielyan-espressif
parent 93e6efedc7
commit 27fc285000
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/mdns/mdns.c
View File

@ -2751,7 +2751,7 @@ static bool _mdns_question_matches(mdns_parsed_question_t * question, uint16_t t
&& !strcasecmp(MDNS_DEFAULT_DOMAIN, question->domain)) { && !strcasecmp(MDNS_DEFAULT_DOMAIN, question->domain)) {
return true; return true;
} }
} else if (type == MDNS_TYPE_SRV || type == MDNS_TYPE_TXT) { } else if (service && (type == MDNS_TYPE_SRV || type == MDNS_TYPE_TXT)) {
const char * name = _mdns_get_service_instance_name(service->service); const char * name = _mdns_get_service_instance_name(service->service);
if (name && question->host && !strcasecmp(name, question->host) if (name && question->host && !strcasecmp(name, question->host)
&& !strcasecmp(service->service->service, question->service) && !strcasecmp(service->service->service, question->service)
@ -3292,7 +3292,7 @@ void mdns_parse_packet(mdns_rx_packet_t * packet)
} else if (service) { // only detect txt collision if service existed } else if (service) { // only detect txt collision if service existed
col = _mdns_check_txt_collision(service->service, data_ptr, data_len); col = _mdns_check_txt_collision(service->service, data_ptr, data_len);
} }
if (col && !_mdns_server->interfaces[packet->tcpip_if].pcbs[packet->ip_protocol].probe_running) { if (col && !_mdns_server->interfaces[packet->tcpip_if].pcbs[packet->ip_protocol].probe_running && service) {
do_not_reply = true; do_not_reply = true;
_mdns_init_pcb_probe(packet->tcpip_if, packet->ip_protocol, &service, 1, true); _mdns_init_pcb_probe(packet->tcpip_if, packet->ip_protocol, &service, 1, true);
} else if (ttl > 2250 && !col && !parsed_packet->authoritative && !parsed_packet->probe && !parsed_packet->questions && !_mdns_server->interfaces[packet->tcpip_if].pcbs[packet->ip_protocol].probe_running) { } else if (ttl > 2250 && !col && !parsed_packet->authoritative && !parsed_packet->probe && !parsed_packet->questions && !_mdns_server->interfaces[packet->tcpip_if].pcbs[packet->ip_protocol].probe_running) {