From face03e4e570562a9db4181edaadbcd97e9d3f72 Mon Sep 17 00:00:00 2001 From: Vladimir Chistyakov Date: Fri, 28 Jan 2022 13:46:28 +0700 Subject: [PATCH 1/2] fix: add virtual destructors to ModuleIf and CommandableIf --- .../include/cxx_include/esp_modem_types.hpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/components/esp_modem/include/cxx_include/esp_modem_types.hpp b/components/esp_modem/include/cxx_include/esp_modem_types.hpp index 17c5d68e5..d6a3c0efd 100644 --- a/components/esp_modem/include/cxx_include/esp_modem_types.hpp +++ b/components/esp_modem/include/cxx_include/esp_modem_types.hpp @@ -67,6 +67,12 @@ struct PdpContext { */ class CommandableIf { public: + CommandableIf() = default; + CommandableIf(const CommandableIf&) = delete; + CommandableIf& operator=(const CommandableIf&) = delete; + CommandableIf(CommandableIf&&) = delete; + CommandableIf& operator=(CommandableIf&&) = delete; + virtual ~CommandableIf() = default; /** * @brief Sends custom AT command * @param command Command to be sent @@ -83,6 +89,12 @@ public: */ class ModuleIf { public: + ModuleIf() = default; + ModuleIf(const ModuleIf&) = delete; + ModuleIf& operator=(const ModuleIf&) = delete; + ModuleIf(ModuleIf&&) = delete; + ModuleIf& operator=(ModuleIf&&) = delete; + virtual ~ModuleIf() = default; /** * @brief Sets the data mode up (provides the necessary configuration to connect to the cellular network) * @return true on success From 325a1933c4703bb92109fdc834b2807bb2d7e101 Mon Sep 17 00:00:00 2001 From: Vladimir Chistyakov Date: Fri, 28 Jan 2022 19:48:08 +0700 Subject: [PATCH 2/2] fix: missing default statement in a switch in the modem_console example --- .../esp_modem/examples/modem_console/main/httpget_handle.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/components/esp_modem/examples/modem_console/main/httpget_handle.c b/components/esp_modem/examples/modem_console/main/httpget_handle.c index 71eb219c9..471562581 100644 --- a/components/esp_modem/examples/modem_console/main/httpget_handle.c +++ b/components/esp_modem/examples/modem_console/main/httpget_handle.c @@ -46,6 +46,7 @@ static esp_err_t http_event_handler(esp_http_client_event_t *evt) case HTTP_EVENT_DISCONNECTED: ESP_LOGI(TAG, "HTTP_EVENT_DISCONNECTED"); break; + default: break; } return ESP_OK; } @@ -105,4 +106,4 @@ void modem_console_register_http(void) .argtable = &http_args }; ESP_ERROR_CHECK(esp_console_cmd_register(&http_cmd)); -} \ No newline at end of file +}