From 8f8516cc3f81c0bc1e258794b1c07868f3aece6c Mon Sep 17 00:00:00 2001 From: David Cermak Date: Fri, 10 Jan 2025 11:31:45 +0100 Subject: [PATCH] fix(mdns): Fixed incorrect error conversion Mixing esp_err_t (int) with err_t (uint8_t) from lwip. Closes coverity isssue: 470139 Overflowed return value --- components/mdns/mdns_networking_lwip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/mdns/mdns_networking_lwip.c b/components/mdns/mdns_networking_lwip.c index 635f7e352..16604cdf1 100644 --- a/components/mdns/mdns_networking_lwip.c +++ b/components/mdns/mdns_networking_lwip.c @@ -288,7 +288,7 @@ typedef struct { static err_t _mdns_pcb_init_api(struct tcpip_api_call_data *api_call_msg) { mdns_api_call_t *msg = (mdns_api_call_t *)api_call_msg; - msg->err = _udp_pcb_init(msg->tcpip_if, msg->ip_protocol); + msg->err = _udp_pcb_init(msg->tcpip_if, msg->ip_protocol) == ESP_OK ? ERR_OK : ERR_IF; return msg->err; }