From 99b54ac384340bf4c7b17ec86ade77acf450fc4c Mon Sep 17 00:00:00 2001 From: David Cermak Date: Mon, 13 Jan 2025 14:55:35 +0100 Subject: [PATCH] fix(mdns): Fix name mangling not to use strcpy() Since it was flagged by clang-tidy as insecture API --- components/mdns/mdns.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c index b4d18364c..5a097df0d 100644 --- a/components/mdns/mdns.c +++ b/components/mdns/mdns.c @@ -253,12 +253,13 @@ static char *_mdns_mangle_name(char *in) } sprintf(ret, "%s-2", in); } else { - ret = malloc(strlen(in) + 2); //one extra byte in case 9-10 or 99-100 etc + size_t in_len = strlen(in); + ret = malloc(in_len + 2); //one extra byte in case 9-10 or 99-100 etc if (ret == NULL) { HOOK_MALLOC_FAILED; return NULL; } - strcpy(ret, in); + memcpy(ret, in, in_len); int baseLen = p - in; //length of 'bla' in 'bla-123' //overwrite suffix with new suffix sprintf(ret + baseLen, "-%d", suffix + 1);