From 9a7bd90ad99642079e0fef758d589d3c470b551f Mon Sep 17 00:00:00 2001 From: David Cermak Date: Thu, 1 Dec 2022 18:07:23 +0100 Subject: [PATCH] fix(esp_modem): Exit data mode only after state change Previously, we set the notification also for event causing permature PPP mode exit --- components/esp_modem/src/esp_modem_netif.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/esp_modem/src/esp_modem_netif.cpp b/components/esp_modem/src/esp_modem_netif.cpp index 56a75f13b..b92eba2f9 100644 --- a/components/esp_modem/src/esp_modem_netif.cpp +++ b/components/esp_modem/src/esp_modem_netif.cpp @@ -21,7 +21,7 @@ void Netif::on_ppp_changed(void *arg, esp_event_base_t event_base, int32_t event_id, void *event_data) { auto *ppp = static_cast(arg); - if (event_id < NETIF_PP_PHASE_OFFSET) { + if (event_id > NETIF_PPP_ERRORNONE && event_id < NETIF_PP_PHASE_OFFSET) { ESP_LOGI("esp_modem_netif", "PPP state changed event %" PRId32, event_id); // only notify the modem on state/error events, ignoring phase transitions ppp->signal.set(PPP_EXIT);