From a06fb7714b28ead0ee64a3eb342b665481d7c3e3 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Fri, 17 Feb 2023 19:20:56 +0100 Subject: [PATCH] fix(mdns): Removed unused internal lock from mdns_server struct --- components/mdns/mdns.c | 11 +---------- components/mdns/private_include/mdns_private.h | 1 - 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c index c568c0720..957c5e480 100644 --- a/components/mdns/mdns.c +++ b/components/mdns/mdns.c @@ -5384,16 +5384,10 @@ esp_err_t mdns_init(void) s_esp_netifs[i].netif = NULL; } - _mdns_server->lock = xSemaphoreCreateMutex(); - if (!_mdns_server->lock) { - err = ESP_ERR_NO_MEM; - goto free_server; - } - _mdns_server->action_queue = xQueueCreate(MDNS_ACTION_QUEUE_LEN, sizeof(mdns_action_t *)); if (!_mdns_server->action_queue) { err = ESP_ERR_NO_MEM; - goto free_lock; + goto free_server; } _mdns_server->action_sema = xSemaphoreCreateBinary(); @@ -5460,8 +5454,6 @@ free_event_handlers: vSemaphoreDelete(_mdns_server->action_sema); free_queue: vQueueDelete(_mdns_server->action_queue); -free_lock: - vSemaphoreDelete(_mdns_server->lock); free_server: free(_mdns_server); _mdns_server = NULL; @@ -5509,7 +5501,6 @@ void mdns_free(void) free(h); } vSemaphoreDelete(_mdns_server->action_sema); - vSemaphoreDelete(_mdns_server->lock); free(_mdns_server); _mdns_server = NULL; } diff --git a/components/mdns/private_include/mdns_private.h b/components/mdns/private_include/mdns_private.h index 885cef722..b6f35e16c 100644 --- a/components/mdns/private_include/mdns_private.h +++ b/components/mdns/private_include/mdns_private.h @@ -382,7 +382,6 @@ typedef struct mdns_server_s { const char *hostname; const char *instance; mdns_srv_item_t *services; - SemaphoreHandle_t lock; QueueHandle_t action_queue; SemaphoreHandle_t action_sema; mdns_tx_packet_t *tx_queue_head;