From ae381b779f0680af96a033cb06a915b0075be2c2 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Tue, 7 Dec 2021 16:17:53 +0100 Subject: [PATCH] mdns: Fix potential null deref reported by fuzzer test * Original commit: espressif/esp-idf@cb5653fd940a9cd41e8554a6d753fab46e0459d7 --- components/mdns/mdns.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c index cb150ebee..18c23d3fd 100644 --- a/components/mdns/mdns.c +++ b/components/mdns/mdns.c @@ -2936,7 +2936,8 @@ static bool _mdns_question_matches(mdns_parsed_question_t * question, uint16_t t if (type == MDNS_TYPE_A || type == MDNS_TYPE_AAAA) { return true; } else if (type == MDNS_TYPE_PTR || type == MDNS_TYPE_SDPTR) { - if (!strcasecmp(service->service->service, question->service) + if (question->service && question->proto && question->domain + && !strcasecmp(service->service->service, question->service) && !strcasecmp(service->service->proto, question->proto) && !strcasecmp(MDNS_DEFAULT_DOMAIN, question->domain)) { return true;