espressif/esp-protocols
1
0
Fork 1
mirror of https://github.com/espressif/esp-protocols.git synced 2025-07-30 10:47:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #821 from lolrobbe2/fix-urc-line-handler-modem

Browse Source 
fix(modem): Consume buffer after handled URC
This commit is contained in:
david-cermak
2025-06-24 10:22:45 +02:00
committed by GitHub
parent d1c912c833 6eceb28f7d
commit b143894874
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
components/esp_modem/src/esp_modem_dte.cpp
View File

@ -1,5 +1,5 @@
/* /*
* SPDX-FileCopyrightText: 2021-2024 Espressif Systems (Shanghai) CO LTD * SPDX-FileCopyrightText: 2021-2025 Espressif Systems (Shanghai) CO LTD
* *
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
@ -368,18 +368,23 @@ void DTE::on_read(got_line_cb on_read_cb)
bool DTE::command_cb::process_line(uint8_t *data, size_t consumed, size_t len) bool DTE::command_cb::process_line(uint8_t *data, size_t consumed, size_t len)
{ {
#ifdef CONFIG_ESP_MODEM_URC_HANDLER #ifdef CONFIG_ESP_MODEM_URC_HANDLER
command_result commandResult = command_result::FAIL;
if (urc_handler) { if (urc_handler) {
urc_handler(data, consumed + len); commandResult = urc_handler(data, consumed + len);
} }
if (result != command_result::TIMEOUT || got_line == nullptr) { if (result != command_result::TIMEOUT && got_line == nullptr) {
return false; // this line has been processed already (got OK or FAIL previously) return false; // this line has been processed already (got OK or FAIL previously)
} }
#endif #endif
if (memchr(data + consumed, separator, len)) { if (memchr(data + consumed, separator, len)) {
result = got_line(data, consumed + len); result = got_line(data + consumed, consumed + len);
if (result == command_result::OK || result == command_result::FAIL) { if (result == command_result::OK || result == command_result::FAIL) {
signal.set(GOT_LINE); signal.set(GOT_LINE);
#ifdef CONFIG_ESP_MODEM_URC_HANDLER
return commandResult == command_result::OK;
#else
return true; return true;
#endif
} }
} }
return false; return false;