From e7273c46ecbce8874ce2590040f31be3300ffe38 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Fri, 24 Jan 2025 15:20:11 +0100 Subject: [PATCH] fix(mdns): Fix potential NULL deref when sending sub-buy Closes coverity reported issue: 473829 Dereference null return value --- components/mdns/mdns.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c index f5f12cc13..12539a435 100644 --- a/components/mdns/mdns.c +++ b/components/mdns/mdns.c @@ -2399,6 +2399,9 @@ static void _mdns_send_bye_subtype(mdns_srv_item_t *service, const char *instanc for (j = 0; j < MDNS_IP_PROTOCOL_MAX; j++) { if (mdns_is_netif_ready(i, j)) { mdns_tx_packet_t *packet = _mdns_alloc_packet_default((mdns_if_t)i, (mdns_ip_protocol_t)j); + if (packet == NULL) { + return; + } packet->flags = MDNS_FLAGS_QR_AUTHORITATIVE; if (!_mdns_alloc_answer(&packet->answers, MDNS_TYPE_PTR, service->service, NULL, true, true)) { _mdns_free_tx_packet(packet);