From 3c145f17822c5158371536ed04ae238ef76542f9 Mon Sep 17 00:00:00 2001 From: Benoit Blanchon Date: Thu, 13 Jan 2022 18:44:57 +0100 Subject: [PATCH] Add assertions to comfort Clang-Tidy --- src/ArduinoJson/MsgPack/MsgPackDeserializer.hpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/ArduinoJson/MsgPack/MsgPackDeserializer.hpp b/src/ArduinoJson/MsgPack/MsgPackDeserializer.hpp index 555b762f..41da6f06 100644 --- a/src/ArduinoJson/MsgPack/MsgPackDeserializer.hpp +++ b/src/ArduinoJson/MsgPack/MsgPackDeserializer.hpp @@ -48,6 +48,11 @@ class MsgPackDeserializer { bool allowValue = filter.allowValue(); + if (allowValue) { + // callers pass a null pointer only when value must be ignored + ARDUINOJSON_ASSERT(variant != 0); + } + switch (code) { case 0xc0: // already null @@ -422,6 +427,8 @@ class MsgPackDeserializer { VariantData *member; if (memberFilter.allow()) { + ARDUINOJSON_ASSERT(object); + // Save key in memory pool. // This MUST be done before adding the slot. key = _stringStorage.save();