From 41b2e629f7a74b80723e7be3ed021e780bdb11d9 Mon Sep 17 00:00:00 2001 From: Benoit Blanchon Date: Wed, 28 Nov 2018 12:40:18 +0100 Subject: [PATCH] Increased test coverage --- test/JsonVariant/compare.cpp | 24 +++++++++++++++++++ .../MsgPackDeserializer/deserializeObject.cpp | 3 +-- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/test/JsonVariant/compare.cpp b/test/JsonVariant/compare.cpp index 976a7ed1..ac533a67 100644 --- a/test/JsonVariant/compare.cpp +++ b/test/JsonVariant/compare.cpp @@ -252,6 +252,30 @@ TEST_CASE("JsonVariant comparisons") { REQUIRE_FALSE(variant1 == variant3); } + SECTION("Variants containing linked raws") { + variant1.set(serialized("0hello" + 1)); // make sure they have + variant2.set(serialized("1hello" + 1)); // different addresses + variant3.set(serialized("world")); + + REQUIRE(variant1 == variant2); + REQUIRE_FALSE(variant1 != variant2); + + REQUIRE(variant1 != variant3); + REQUIRE_FALSE(variant1 == variant3); + } + + SECTION("Variants containing owned raws") { + variant1.set(serialized(std::string("hello"))); + variant2.set(serialized(std::string("hello"))); + variant3.set(serialized(std::string("world"))); + + REQUIRE(variant1 == variant2); + REQUIRE_FALSE(variant1 != variant2); + + REQUIRE(variant1 != variant3); + REQUIRE_FALSE(variant1 == variant3); + } + SECTION("Variants containing double") { variant1.set(42.0); variant2.set(42.0); diff --git a/test/MsgPackDeserializer/deserializeObject.cpp b/test/MsgPackDeserializer/deserializeObject.cpp index 9909b570..445c1ce6 100644 --- a/test/MsgPackDeserializer/deserializeObject.cpp +++ b/test/MsgPackDeserializer/deserializeObject.cpp @@ -47,8 +47,7 @@ TEST_CASE("deserialize MsgPack object") { } SECTION("key is str 16") { - const char* input = - "\x82\xdb\x00\x00\x00\x03one\x01\xdb\x00\x00\x00\x03two\x02"; + const char* input = "\x82\xda\x00\x03one\x01\xda\x00\x03two\x02"; DeserializationError error = deserializeMsgPack(doc, input); JsonObject obj = doc.as();