Copy JsonArray and JsonObject, instead of storing pointers (fixes #780)

test/JsonObject/remove.cpp

@@ -9,47 +9,64 @@
 TEST_CASE("JsonObject::remove()") {
   DynamicJsonDocument doc;
   JsonObject obj = doc.to<JsonObject>();
+  obj["a"] = 0;
+  obj["b"] = 1;
+  obj["c"] = 2;
+  std::string result;
 
-  SECTION("SizeDecreased_WhenValuesAreRemoved") {
-    obj["hello"] = 1;
-
-    obj.remove("hello");
-
-    REQUIRE(0 == obj.size());
-  }
-
-  SECTION("SizeUntouched_WhenRemoveIsCalledWithAWrongKey") {
-    obj["hello"] = 1;
-
-    obj.remove("world");
-
-    REQUIRE(1 == obj.size());
-  }
-
-  SECTION("RemoveByIterator") {
-    obj["a"] = 0;
-    obj["b"] = 1;
-    obj["c"] = 2;
-
-    for (JsonObject::iterator it = obj.begin(); it != obj.end(); ++it) {
-      if (it->value() == 1) obj.remove(it);
+  SECTION("remove(key)") {
+    SECTION("Remove first") {
+      obj.remove("a");
+      serializeJson(obj, result);
+      REQUIRE("{\"b\":1,\"c\":2}" == result);
     }
 
-    std::string result;
-    serializeJson(obj, result);
-    REQUIRE("{\"a\":0,\"c\":2}" == result);
+    SECTION("Remove middle") {
+      obj.remove("b");
+      serializeJson(obj, result);
+      REQUIRE("{\"a\":0,\"c\":2}" == result);
+    }
+
+    SECTION("Remove last") {
+      obj.remove("c");
+      serializeJson(obj, result);
+      REQUIRE("{\"a\":0,\"b\":1}" == result);
+    }
+  }
+
+  SECTION("remove(iterator)") {
+    JsonObject::iterator it = obj.begin();
+
+    SECTION("Remove first") {
+      obj.remove(it);
+      serializeJson(obj, result);
+      REQUIRE("{\"b\":1,\"c\":2}" == result);
+    }
+
+    SECTION("Remove middle") {
+      ++it;
+      obj.remove(it);
+      serializeJson(obj, result);
+      REQUIRE("{\"a\":0,\"c\":2}" == result);
+    }
+
+    SECTION("Remove last") {
+      it += 2;
+      obj.remove(it);
+      serializeJson(obj, result);
+      REQUIRE("{\"a\":0,\"b\":1}" == result);
+    }
   }
 
 #ifdef HAS_VARIABLE_LENGTH_ARRAY
   SECTION("key is a vla") {
-    obj["hello"] = 1;
-
     int i = 16;
     char vla[i];
-    strcpy(vla, "hello");
+    strcpy(vla, "b");
     obj.remove(vla);
 
-    REQUIRE(0 == obj.size());
+    serializeJson(obj, result);
+    REQUIRE("{\"a\":0,\"c\":2}" == result);
   }
 #endif
 }