diff --git a/extras/tests/JsonDocument/MemberProxy.cpp b/extras/tests/JsonDocument/MemberProxy.cpp index e3e0bec8..816054f4 100644 --- a/extras/tests/JsonDocument/MemberProxy.cpp +++ b/extras/tests/JsonDocument/MemberProxy.cpp @@ -382,24 +382,6 @@ TEST_CASE("Deduplicate keys") { Allocate(sizeofString("example")), }); } - - SECTION("string literals") { - doc[0]["example"] = 1; - doc[1]["example"] = 2; - doc.shrinkToFit(); - - const char* key1 = doc[0].as().begin()->key().c_str(); - const char* key2 = doc[1].as().begin()->key().c_str(); - CHECK(key1 == key2); - - REQUIRE(spy.log() == - AllocatorLog{ - Allocate(sizeofPool()), - Allocate(sizeofStaticStringPool()), - Reallocate(sizeofPool(), sizeofPool(6)), - Reallocate(sizeofStaticStringPool(), sizeofStaticStringPool(1)), - }); - } } TEST_CASE("MemberProxy under memory constraints") { diff --git a/extras/tests/ResourceManager/saveString.cpp b/extras/tests/ResourceManager/saveString.cpp index 544b8090..88e61c47 100644 --- a/extras/tests/ResourceManager/saveString.cpp +++ b/extras/tests/ResourceManager/saveString.cpp @@ -23,12 +23,15 @@ TEST_CASE("ResourceManager::saveStaticString()") { SpyingAllocator spy; ResourceManager resources(&spy); - auto a = resources.saveStaticString("hello"); - auto b = resources.saveStaticString("world"); - REQUIRE(a != b); + auto str1 = "hello"; + auto str2 = "world"; - auto c = resources.saveStaticString("hello"); - REQUIRE(a == c); + auto id1 = resources.saveStaticString(str1); + auto id2 = resources.saveStaticString(str2); + REQUIRE(id1 != id2); + + auto id3 = resources.saveStaticString(str1); + REQUIRE(id1 == id3); resources.shrinkToFit(); REQUIRE(spy.log() ==