feedc0de/ArduinoJson
1
0
Fork 0
forked from bblanchon/ArduinoJson
Code Pull Requests Activity

Made JsonDocument's destructor protected (fixes #1480)

Browse Source
This commit is contained in:
Benoit Blanchon
2021-01-27 09:59:51 +01:00
parent 322d13de0d
commit c70a491f59
4 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -1,6 +1,11 @@
ArduinoJson: change log ArduinoJson: change log
======================= =======================
HEAD
----
* Made `JsonDocument`'s destructor protected (issue #1480)
v6.17.2 (2020-11-14) v6.17.2 (2020-11-14)
------- -------

3
extras/tests/FailingBuilds/CMakeLists.txt
View File

@ -36,3 +36,6 @@ build_should_fail(read_long_long)
add_executable(write_long_long write_long_long.cpp) add_executable(write_long_long write_long_long.cpp)
set_property(TARGET write_long_long PROPERTY CXX_STANDARD 11) set_property(TARGET write_long_long PROPERTY CXX_STANDARD 11)
build_should_fail(write_long_long) build_should_fail(write_long_long)
add_executable(delete_jsondocument delete_jsondocument.cpp)
build_should_fail(delete_jsondocument)

12
extras/tests/FailingBuilds/delete_jsondocument.cpp Normal file
View File

@ -0,0 +1,12 @@
// ArduinoJson - arduinojson.org
// Copyright Benoit Blanchon 2014-2021
// MIT License
#include <ArduinoJson.h>
struct Stream {};
int main() {
JsonDocument* doc = new DynamicJsonDocument(42);
delete doc;
}

2
src/ArduinoJson/Document/JsonDocument.hpp
View File

@ -310,6 +310,8 @@ class JsonDocument : public Visitable {
_data.setNull(); _data.setNull();
} }
~JsonDocument() {}
void replacePool(MemoryPool pool) { void replacePool(MemoryPool pool) {
_pool = pool; _pool = pool;
} }