Renamed JsonSink::append() into write() to match Arduino's Print class

This commit is contained in:
Benoît Blanchon
2014-07-01 13:33:00 +02:00
parent 1401665129
commit c84860e3f4
7 changed files with 36 additions and 37 deletions

View File

@ -41,19 +41,19 @@ private:
{ {
size_t n = 0; size_t n = 0;
n += sb.append("["); n += sb.write("[");
for (int i = 0; i < itemCount; i++) for (int i = 0; i < itemCount; i++)
{ {
if (i > 0) if (i > 0)
{ {
n += sb.append(","); n += sb.write(",");
} }
n += items[i].writeTo(sb); n += items[i].writeTo(sb);
} }
n += sb.append("]"); n += sb.write("]");
return n; return n;
} }

View File

@ -49,7 +49,7 @@ private:
{ {
size_t n = 0; size_t n = 0;
n += sink.append('{'); n += sink.write('{');
for (int i = 0; i < itemCount; i++) for (int i = 0; i < itemCount; i++)
{ {
@ -57,15 +57,15 @@ private:
if (i > 0) if (i > 0)
{ {
n += sink.append(','); n += sink.write(',');
} }
n += key.writeTo(sink); n += key.writeTo(sink);
n += sink.append(':'); n += sink.write(':');
n += items[i].value.writeTo(sink); n += items[i].value.writeTo(sink);
} }
n += sink.append('}'); n += sink.write('}');
return n; return n;
} }

View File

@ -9,14 +9,14 @@ class JsonSink
{ {
public: public:
virtual size_t append(char c) = 0; virtual size_t write(char c) = 0;
size_t append(const char* s) size_t write(const char* s)
{ {
size_t n = 0; size_t n = 0;
while (*s) while (*s)
{ {
n += append(*s++); n += write(*s++);
} }
return n; return n;
} }

View File

@ -10,7 +10,7 @@
size_t JsonValue::writeBooleanTo(JsonSink& sb) size_t JsonValue::writeBooleanTo(JsonSink& sb)
{ {
return sb.append(content.boolean ? "true" : "false"); return sb.write(content.boolean ? "true" : "false");
} }
size_t JsonValue::writeNumberTo(JsonSink& sb) size_t JsonValue::writeNumberTo(JsonSink& sb)
@ -19,7 +19,7 @@ size_t JsonValue::writeNumberTo(JsonSink& sb)
_snprintf(tmp, sizeof(tmp), "%lg", content.number); _snprintf(tmp, sizeof(tmp), "%lg", content.number);
return sb.append(tmp); return sb.write(tmp);
} }
size_t JsonValue::writeObjectTo(JsonSink& sink) size_t JsonValue::writeObjectTo(JsonSink& sink)
@ -27,7 +27,7 @@ size_t JsonValue::writeObjectTo(JsonSink& sink)
if (content.object) if (content.object)
return ((JsonObjectBase*)content.object)->writeTo(sink); return ((JsonObjectBase*)content.object)->writeTo(sink);
else else
return sink.append("null"); return sink.write("null");
} }
size_t JsonValue::writeStringTo(JsonSink& sink) size_t JsonValue::writeStringTo(JsonSink& sink)
@ -36,54 +36,54 @@ size_t JsonValue::writeStringTo(JsonSink& sink)
if (!s) if (!s)
{ {
return sink.append("null"); return sink.write("null");
} }
size_t n = 0; size_t n = 0;
n += sink.append('\"'); n += sink.write('\"');
while (*s) while (*s)
{ {
switch (*s) switch (*s)
{ {
case '"': case '"':
n += sink.append("\\\""); n += sink.write("\\\"");
break; break;
case '\\': case '\\':
n += sink.append("\\\\"); n += sink.write("\\\\");
break; break;
case '\b': case '\b':
n += sink.append("\\b"); n += sink.write("\\b");
break; break;
case '\f': case '\f':
n += sink.append("\\f"); n += sink.write("\\f");
break; break;
case '\n': case '\n':
n += sink.append("\\n"); n += sink.write("\\n");
break; break;
case '\r': case '\r':
n += sink.append("\\r"); n += sink.write("\\r");
break; break;
case '\t': case '\t':
n += sink.append("\\t"); n += sink.write("\\t");
break; break;
default: default:
n += sink.append(*s); n += sink.write(*s);
break; break;
} }
s++; s++;
} }
n += sink.append('\"'); n += sink.write('\"');
return n; return n;
} }

View File

@ -26,7 +26,7 @@ namespace JsonGeneratorTests
TEST_METHOD(Null) TEST_METHOD(Null)
{ {
append((char*)0); write((char*)0);
assertReturns(4); assertReturns(4);
assertResultIs("null"); assertResultIs("null");
@ -34,7 +34,7 @@ namespace JsonGeneratorTests
TEST_METHOD(EmptyString) TEST_METHOD(EmptyString)
{ {
append(""); write("");
assertReturns(2); assertReturns(2);
assertResultIs("\"\""); assertResultIs("\"\"");
@ -42,17 +42,17 @@ namespace JsonGeneratorTests
TEST_METHOD(OneString) TEST_METHOD(OneString)
{ {
append("ABCD"); write("ABCD");
assertReturns(6); assertReturns(6);
assertResultIs("\"ABCD\""); assertResultIs("\"ABCD\"");
} }
TEST_METHOD(OneTwoStrings) TEST_METHOD(OneTwoStrings)
{ {
append("ABCD"); write("ABCD");
assertReturns(6); assertReturns(6);
append("EFGH"); write("EFGH");
assertReturns(6); assertReturns(6);
assertResultIs("\"ABCD\"\"EFGH\""); assertResultIs("\"ABCD\"\"EFGH\"");
@ -60,31 +60,31 @@ namespace JsonGeneratorTests
TEST_METHOD(OverCapacity) TEST_METHOD(OverCapacity)
{ {
append("ABCDEFGHIJKLMNOPQRSTUVWXYZ"); write("ABCDEFGHIJKLMNOPQRSTUVWXYZ");
assertReturns(19); assertReturns(19);
assertResultIs("\"ABCDEFGHIJKLMNOPQR"); assertResultIs("\"ABCDEFGHIJKLMNOPQR");
append("ABC"); write("ABC");
assertReturns(0); assertReturns(0);
assertResultIs("\"ABCDEFGHIJKLMNOPQR"); assertResultIs("\"ABCDEFGHIJKLMNOPQR");
} }
TEST_METHOD(SpecialChars) TEST_METHOD(SpecialChars)
{ {
append("\\\"\b\f\n\r\t"); write("\\\"\b\f\n\r\t");
assertReturns(16); assertReturns(16);
assertResultIs("\"\\\\\\\"\\b\\f\\n\\r\\t\""); assertResultIs("\"\\\\\\\"\\b\\f\\n\\r\\t\"");
} }
TEST_METHOD(Number) TEST_METHOD(Number)
{ {
append(3.14); write(3.14);
assertReturns(4); assertReturns(4);
assertResultIs("3.14"); assertResultIs("3.14");
} }
template<typename T> template<typename T>
void append(T value) void write(T value)
{ {
returnValue = JsonValue(value).writeTo(*sb); returnValue = JsonValue(value).writeTo(*sb);
} }

View File

@ -5,7 +5,7 @@
#include "StringBuilder.h" #include "StringBuilder.h"
size_t StringBuilder::append(char c) size_t StringBuilder::write(char c)
{ {
if (length >= capacity) return 0; if (length >= capacity) return 0;

View File

@ -16,8 +16,7 @@ public:
buffer[0] = 0; buffer[0] = 0;
} }
virtual size_t append(char c); virtual size_t write(char c);
size_t append(const char* c);
private: private:
char* buffer; char* buffer;