diff --git a/CHANGELOG.md b/CHANGELOG.md index 78cd12ac..f7a3fca9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,11 @@ ArduinoJson: change log ======================= +HEAD +---- + +* Fix `9.22337e+18 is outside the range of representable values of type 'long'` + v6.19.4 (2022-04-05) ------- diff --git a/extras/tests/MsgPackSerializer/serializeVariant.cpp b/extras/tests/MsgPackSerializer/serializeVariant.cpp index 1fd8ba18..c0919590 100644 --- a/extras/tests/MsgPackSerializer/serializeVariant.cpp +++ b/extras/tests/MsgPackSerializer/serializeVariant.cpp @@ -109,6 +109,7 @@ TEST_CASE("serialize MsgPack value") { SECTION("float 32") { checkVariant(1.25, "\xCA\x3F\xA0\x00\x00"); + checkVariant(9.22337204e+18f, "\xca\x5f\x00\x00\x00"); } SECTION("float 64") { diff --git a/extras/tests/Numbers/CMakeLists.txt b/extras/tests/Numbers/CMakeLists.txt index 9bcf3341..05e1e894 100644 --- a/extras/tests/Numbers/CMakeLists.txt +++ b/extras/tests/Numbers/CMakeLists.txt @@ -2,7 +2,10 @@ # Copyright © 2014-2022, Benoit BLANCHON # MIT License -add_executable(NumbersTests +set(CMAKE_CXX_STANDARD 11) +set(CMAKE_CXX_STANDARD_REQUIRED OFF) + +add_executable(NumbersTests convertNumber.cpp parseFloat.cpp parseDouble.cpp diff --git a/extras/tests/Numbers/convertNumber.cpp b/extras/tests/Numbers/convertNumber.cpp index 1c36aa06..8c193dc3 100644 --- a/extras/tests/Numbers/convertNumber.cpp +++ b/extras/tests/Numbers/convertNumber.cpp @@ -75,4 +75,62 @@ TEST_CASE("canConvertNumber()") { CHECK((canConvertNumber(128)) == true); CHECK((canConvertNumber(255)) == true); } + + SECTION("float -> int32_t") { + CHECK((canConvertNumber(0)) == true); + CHECK((canConvertNumber(-2.147483904e9f)) == false); + CHECK((canConvertNumber(-2.147483648e+9f)) == true); + CHECK((canConvertNumber(2.14748352e+9f)) == true); + CHECK((canConvertNumber(2.14748365e+9f)) == false); + } + + SECTION("double -> int32_t") { + CHECK((canConvertNumber(0)) == true); + CHECK((canConvertNumber(-2.147483649e+9)) == false); + CHECK((canConvertNumber(-2.147483648e+9)) == true); + CHECK((canConvertNumber(2.147483647e+9)) == true); + CHECK((canConvertNumber(2.147483648e+9)) == false); + } + + SECTION("float -> uint32_t") { + CHECK((canConvertNumber(0)) == true); + CHECK((canConvertNumber(-1.401298e-45f)) == false); + CHECK((canConvertNumber(4.29496704e+9f)) == true); + CHECK((canConvertNumber(4.294967296e+9f)) == false); + } + +#if ARDUINOJSON_HAS_LONG_LONG + SECTION("float -> int64_t") { + CHECK((canConvertNumber(0)) == true); + CHECK((canConvertNumber(-9.22337204e+18f)) == true); + CHECK((canConvertNumber(9.22337149e+18f)) == true); + CHECK((canConvertNumber(9.22337204e+18f)) == false); + } + + SECTION("double -> int64_t") { + CHECK((canConvertNumber(0)) == true); + CHECK((canConvertNumber(-9.2233720368547758e+18)) == true); + CHECK((canConvertNumber(9.2233720368547748e+18)) == true); + CHECK((canConvertNumber(9.2233720368547758e+18)) == false); + } + + SECTION("float -> uint64_t") { + CHECK((canConvertNumber(0)) == true); + CHECK((canConvertNumber(-1.401298e-45f)) == false); + CHECK((canConvertNumber(1.844674297419792384e+19f)) == + true); + CHECK((canConvertNumber(1.8446744073709551616e+19f)) == + false); + } + + SECTION("double -> uint64_t") { + CHECK((canConvertNumber(0)) == true); + CHECK((canConvertNumber(-4.94065645841247e-324)) == + false); + CHECK((canConvertNumber(1.8446744073709549568e+19)) == + true); + CHECK((canConvertNumber(1.8446744073709551616e+19)) == + false); + } +#endif } diff --git a/src/ArduinoJson/Numbers/FloatTraits.hpp b/src/ArduinoJson/Numbers/FloatTraits.hpp index 0af77f3b..4d5782b7 100644 --- a/src/ArduinoJson/Numbers/FloatTraits.hpp +++ b/src/ArduinoJson/Numbers/FloatTraits.hpp @@ -12,6 +12,7 @@ #include #include #include +#include namespace ARDUINOJSON_NAMESPACE { @@ -116,6 +117,22 @@ struct FloatTraits { return forge(0x7FEFFFFF, 0xFFFFFFFF); } + template // int64_t + static T highest_for( + typename enable_if::value && is_signed::value && + sizeof(TOut) == 8, + signed>::type* = 0) { + return forge(0x43DFFFFF, 0xFFFFFFFF); // 9.2233720368547748e+18 + } + + template // uint64_t + static T highest_for( + typename enable_if::value && is_unsigned::value && + sizeof(TOut) == 8, + unsigned>::type* = 0) { + return forge(0x43EFFFFF, 0xFFFFFFFF); // 1.8446744073709549568e+19 + } + static T lowest() { return forge(0xFFEFFFFF, 0xFFFFFFFF); } @@ -212,6 +229,38 @@ struct FloatTraits { return forge(0x7f7fffff); } + template // int32_t + static T highest_for( + typename enable_if::value && is_signed::value && + sizeof(TOut) == 4, + signed>::type* = 0) { + return forge(0x4EFFFFFF); // 2.14748352E9 + } + + template // uint32_t + static T highest_for( + typename enable_if::value && is_unsigned::value && + sizeof(TOut) == 4, + unsigned>::type* = 0) { + return forge(0x4F7FFFFF); // 4.29496704E9 + } + + template // int64_t + static T highest_for( + typename enable_if::value && is_signed::value && + sizeof(TOut) == 8, + signed>::type* = 0) { + return forge(0x5EFFFFFF); // 9.22337148709896192E18 + } + + template // uint64_t + static T highest_for( + typename enable_if::value && is_unsigned::value && + sizeof(TOut) == 8, + unsigned>::type* = 0) { + return forge(0x5F7FFFFF); // 1.844674297419792384E19 + } + static T lowest() { return forge(0xFf7fffff); } diff --git a/src/ArduinoJson/Numbers/convertNumber.hpp b/src/ArduinoJson/Numbers/convertNumber.hpp index 87547f5b..6dd400ed 100644 --- a/src/ArduinoJson/Numbers/convertNumber.hpp +++ b/src/ArduinoJson/Numbers/convertNumber.hpp @@ -15,6 +15,7 @@ #endif #include +#include #include #include @@ -95,17 +96,34 @@ canConvertNumber(TIn value) { return value <= TIn(numeric_limits::highest()); } -// float -> int32 -// float -> int64 +// float32 -> int16 +// float64 -> int32 template -typename enable_if::value && - !is_floating_point::value, +typename enable_if::value && is_integral::value && + sizeof(TOut) < sizeof(TIn), bool>::type canConvertNumber(TIn value) { return value >= numeric_limits::lowest() && value <= numeric_limits::highest(); } +// float32 -> int32 +// float32 -> uint32 +// float32 -> int64 +// float32 -> uint64 +// float64 -> int64 +// float64 -> uint64 +template +typename enable_if::value && is_integral::value && + sizeof(TOut) >= sizeof(TIn), + bool>::type +canConvertNumber(TIn value) { + // Avoid error "9.22337e+18 is outside the range of representable values of + // type 'long'" + return value >= numeric_limits::lowest() && + value <= FloatTraits::template highest_for(); +} + template TOut convertNumber(TIn value) { return canConvertNumber(value) ? TOut(value) : 0;