feedc0de/ArduinoJson
1
0
Fork 0
forked from bblanchon/ArduinoJson
Code Pull Requests Activity

Change link() to shallowCopy() (issue #1343)

Browse Source 
Instead of storing a pointer, the function copies the `VariantData`.

Benefits:
* smaller code
* no impact on programs that don't use this feature

Drawbacks:
* changes to the original variant are not always reflected on the copy
* modifying the original from the shallow copy leads to UB
This commit is contained in:
Benoit Blanchon
2022-07-05 17:07:43 +02:00
parent 3b3ab8c4e1
commit cd8373ad32
36 changed files with 78 additions and 543 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extras/tests/JsonVariant/isnull.cpp
View File

@ -70,16 +70,16 @@ TEST_CASE("JsonVariant::isNull()") {
REQUIRE(variant.isNull() == true);
}
SECTION("returns true for a linked null") {
SECTION("returns true for a shallow null copy") {
StaticJsonDocument<128> doc2;
variant.link(doc2);
variant.shallowCopy(doc2);
CHECK(variant.isNull() == true);
}
SECTION("returns false for a linked array") {
SECTION("returns false for a shallow array copy") {
StaticJsonDocument<128> doc2;
doc2[0] = 42;
variant.link(doc2);
variant.shallowCopy(doc2);
CHECK(variant.isNull() == false);
}