diff --git a/extras/tests/JsonVariant/undefined.cpp b/extras/tests/JsonVariant/undefined.cpp index c0c5896d..8c5fdcc2 100644 --- a/extras/tests/JsonVariant/undefined.cpp +++ b/extras/tests/JsonVariant/undefined.cpp @@ -67,4 +67,30 @@ TEST_CASE("JsonVariant undefined") { REQUIRE(variant.is() == false); } } + + SECTION("set()") { + SECTION("long") { + REQUIRE(variant.set(42L) == false); + } + + SECTION("unsigned") { + REQUIRE(variant.set(42U) == false); + } + + SECTION("const char*") { + REQUIRE(variant.set("42") == false); + } + + SECTION("Serialized") { + REQUIRE(variant.set(serialized("42")) == false); + } + + SECTION("double") { + REQUIRE(variant.set(42.0) == false); + } + + SECTION("bool") { + REQUIRE(variant.set(true) == false); + } + } } diff --git a/src/ArduinoJson/Variant/ConverterImpl.hpp b/src/ArduinoJson/Variant/ConverterImpl.hpp index 38636216..caf7eae0 100644 --- a/src/ArduinoJson/Variant/ConverterImpl.hpp +++ b/src/ArduinoJson/Variant/ConverterImpl.hpp @@ -121,7 +121,6 @@ struct Converter::value>::type> { template <> struct Converter { static bool toJson(VariantRef variant, const char* value) { - // TODO: don't pass pool return variantSetString(getData(variant), adaptString(value), getPool(variant)); }