diff --git a/CHANGELOG.md b/CHANGELOG.md index 04ddebaa..1cee9ef1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,10 @@ HEAD * Add option ARDUINOJSON_DECODE_UNICODE to enable it * Converted `JsonArray::copyFrom()/copyTo()` to free functions `copyArray()` * Renamed `JsonArray::copyFrom()` and `JsonObject::copyFrom()` to `set()` +* Renamed `JsonArray::get()` to `getElement()` +* Renamed `JsonArray::add()` (without arg) to `addElement()` +* Renamed `JsonObject::get()` to `getMember()` +* Renamed `JsonObject::getOrCreate()` to `getOrAddMember()` v6.8.0-beta (2019-01-30) ----------- diff --git a/src/ArduinoJson/Array/ArrayImpl.hpp b/src/ArduinoJson/Array/ArrayImpl.hpp index c8ca0c5e..df014927 100644 --- a/src/ArduinoJson/Array/ArrayImpl.hpp +++ b/src/ArduinoJson/Array/ArrayImpl.hpp @@ -11,12 +11,12 @@ namespace ARDUINOJSON_NAMESPACE { template inline ArrayRef ArrayShortcuts::createNestedArray() const { - return impl()->add().template to(); + return impl()->addElement().template to(); } template inline ObjectRef ArrayShortcuts::createNestedObject() const { - return impl()->add().template to(); + return impl()->addElement().template to(); } } // namespace ARDUINOJSON_NAMESPACE diff --git a/src/ArduinoJson/Array/ArrayRef.hpp b/src/ArduinoJson/Array/ArrayRef.hpp index 9716ec99..f4e67e31 100644 --- a/src/ArduinoJson/Array/ArrayRef.hpp +++ b/src/ArduinoJson/Array/ArrayRef.hpp @@ -101,8 +101,7 @@ class ArrayRef : public ArrayRefBase, return ArrayConstRef(_data); } - using ArrayShortcuts::add; - VariantRef add() const { + VariantRef addElement() const { return VariantRef(_pool, arrayAdd(_data, _pool)); } @@ -126,7 +125,7 @@ class ArrayRef : public ArrayRefBase, } // Gets the value at the specified index. - FORCE_INLINE VariantRef get(size_t index) const { + FORCE_INLINE VariantRef getElement(size_t index) const { return VariantRef(_pool, _data ? _data->get(index) : 0); } diff --git a/src/ArduinoJson/Array/ArrayShortcuts.hpp b/src/ArduinoJson/Array/ArrayShortcuts.hpp index 94eec35d..221f3fd1 100644 --- a/src/ArduinoJson/Array/ArrayShortcuts.hpp +++ b/src/ArduinoJson/Array/ArrayShortcuts.hpp @@ -29,14 +29,14 @@ class ArrayShortcuts { // std::string, String, ObjectRef template FORCE_INLINE bool add(const T &value) const { - return impl()->add().set(value); + return impl()->addElement().set(value); } // // bool add(TValue); // TValue = char*, const char*, const __FlashStringHelper* template FORCE_INLINE bool add(T *value) const { - return impl()->add().set(value); + return impl()->addElement().set(value); } private: diff --git a/src/ArduinoJson/Array/ElementProxy.hpp b/src/ArduinoJson/Array/ElementProxy.hpp index 597e8c00..eff7e5b6 100644 --- a/src/ArduinoJson/Array/ElementProxy.hpp +++ b/src/ArduinoJson/Array/ElementProxy.hpp @@ -24,7 +24,7 @@ class ElementProxy : public VariantOperators >, : _array(array), _index(index) {} FORCE_INLINE this_type& operator=(const this_type& src) { - getElement().set(src.as()); + getUpstreamElement().set(src.as()); return *this; } @@ -35,7 +35,7 @@ class ElementProxy : public VariantOperators >, // std::string, String, ArrayRef, ObjectRef template FORCE_INLINE this_type& operator=(const T& src) { - getElement().set(src); + getUpstreamElement().set(src); return *this; } // @@ -43,27 +43,27 @@ class ElementProxy : public VariantOperators >, // TValue = char*, const char*, const __FlashStringHelper* template FORCE_INLINE this_type& operator=(T* src) { - getElement().set(src); + getUpstreamElement().set(src); return *this; } FORCE_INLINE bool isNull() const { - return getElement().isNull(); + return getUpstreamElement().isNull(); } template FORCE_INLINE typename VariantAs::type as() const { - return getElement().template as(); + return getUpstreamElement().template as(); } template FORCE_INLINE bool is() const { - return getElement().template is(); + return getUpstreamElement().template is(); } template FORCE_INLINE typename VariantTo::type to() const { - return getElement().template to(); + return getUpstreamElement().template to(); } // Replaces the value @@ -73,53 +73,56 @@ class ElementProxy : public VariantOperators >, // std::string, String, ArrayRef, ObjectRef template FORCE_INLINE bool set(const TValue& value) const { - return getElement().set(value); + return getUpstreamElement().set(value); } // // bool set(TValue) // TValue = char*, const char*, const __FlashStringHelper* template FORCE_INLINE bool set(TValue* value) const { - return getElement().set(value); + return getUpstreamElement().set(value); } template void accept(Visitor& visitor) const { - return getElement().accept(visitor); + return getUpstreamElement().accept(visitor); } FORCE_INLINE size_t size() const { - return getElement().size(); + return getUpstreamElement().size(); } template - VariantRef get(TNestedKey* key) const { - return getElement().get(key); + VariantRef getMember(TNestedKey* key) const { + return getUpstreamElement().getMember(key); } template - VariantRef get(const TNestedKey& key) const { - return getElement().get(key); + VariantRef getMember(const TNestedKey& key) const { + return getUpstreamElement().getMember(key); } template - VariantRef getOrCreate(TNestedKey* key) const { - return getElement().getOrCreate(key); + VariantRef getOrAddMember(TNestedKey* key) const { + return getUpstreamElement().getOrAddMember(key); } template - VariantRef getOrCreate(const TNestedKey& key) const { - return getElement().getOrCreate(key); + VariantRef getOrAddMember(const TNestedKey& key) const { + return getUpstreamElement().getOrAddMember(key); } - using ArrayShortcuts::add; - VariantRef add() const { - return getElement().add(); + VariantRef addElement() const { + return getUpstreamElement().addElement(); + } + + VariantRef getElement(size_t index) const { + return getUpstreamElement().getElement(index); } private: - FORCE_INLINE VariantRef getElement() const { - return _array.get(_index); + FORCE_INLINE VariantRef getUpstreamElement() const { + return _array.getElement(_index); } TArray _array; diff --git a/src/ArduinoJson/Document/JsonDocument.hpp b/src/ArduinoJson/Document/JsonDocument.hpp index 7b9ffef9..4898731e 100644 --- a/src/ArduinoJson/Document/JsonDocument.hpp +++ b/src/ArduinoJson/Document/JsonDocument.hpp @@ -83,7 +83,7 @@ class JsonDocument : public Visitable { } ArrayRef createNestedArray() { - return add().to(); + return addElement().to(); } // createNestedArray(char*) @@ -91,18 +91,18 @@ class JsonDocument : public Visitable { // createNestedArray(const __FlashStringHelper*) template ArrayRef createNestedArray(TChar* key) { - return getOrCreate(key).template to(); + return getOrAddMember(key).template to(); } // createNestedArray(const std::string&) // createNestedArray(const String&) template ArrayRef createNestedArray(const TString& key) { - return getOrCreate(key).template to(); + return getOrAddMember(key).template to(); } ObjectRef createNestedObject() { - return add().to(); + return addElement().to(); } // createNestedObject(char*) @@ -110,14 +110,14 @@ class JsonDocument : public Visitable { // createNestedObject(const __FlashStringHelper*) template ObjectRef createNestedObject(TChar* key) { - return getOrCreate(key).template to(); + return getOrAddMember(key).template to(); } // createNestedObject(const std::string&) // createNestedObject(const String&) template ObjectRef createNestedObject(const TString& key) { - return getOrCreate(key).template to(); + return getOrAddMember(key).template to(); } // operator[](const std::string&) @@ -164,51 +164,51 @@ class JsonDocument : public Visitable { } FORCE_INLINE VariantConstRef operator[](size_t index) const { - return VariantConstRef(_data.get(index)); + return VariantConstRef(_data.getElement(index)); } - FORCE_INLINE VariantRef get(size_t index) { - return VariantRef(&_pool, _data.get(index)); + FORCE_INLINE VariantRef getElement(size_t index) { + return VariantRef(&_pool, _data.getElement(index)); } - // get(char*) const - // get(const char*) const - // get(const __FlashStringHelper*) const + // getMember(char*) const + // getMember(const char*) const + // getMember(const __FlashStringHelper*) const template - FORCE_INLINE VariantRef get(TChar* key) { - return VariantRef(&_pool, _data.get(adaptString(key))); + FORCE_INLINE VariantRef getMember(TChar* key) { + return VariantRef(&_pool, _data.getMember(adaptString(key))); } - // get(const std::string&) const - // get(const String&) const + // getMember(const std::string&) const + // getMember(const String&) const template FORCE_INLINE typename enable_if::value, VariantRef>::type - get(const TString& key) { - return VariantRef(&_pool, _data.get(adaptString(key))); + getMember(const TString& key) { + return VariantRef(&_pool, _data.getMember(adaptString(key))); } - // getOrCreate(char*) - // getOrCreate(const char*) - // getOrCreate(const __FlashStringHelper*) + // getOrAddMember(char*) + // getOrAddMember(const char*) + // getOrAddMember(const __FlashStringHelper*) template - FORCE_INLINE VariantRef getOrCreate(TChar* key) { - return VariantRef(&_pool, _data.getOrCreate(adaptString(key), &_pool)); + FORCE_INLINE VariantRef getOrAddMember(TChar* key) { + return VariantRef(&_pool, _data.getOrAddMember(adaptString(key), &_pool)); } - // getOrCreate(const std::string&) - // getOrCreate(const String&) + // getOrAddMember(const std::string&) + // getOrAddMember(const String&) template - FORCE_INLINE VariantRef getOrCreate(const TString& key) { - return VariantRef(&_pool, _data.getOrCreate(adaptString(key), &_pool)); + FORCE_INLINE VariantRef getOrAddMember(const TString& key) { + return VariantRef(&_pool, _data.getOrAddMember(adaptString(key), &_pool)); } - FORCE_INLINE VariantRef add() { - return VariantRef(&_pool, _data.add(&_pool)); + FORCE_INLINE VariantRef addElement() { + return VariantRef(&_pool, _data.addElement(&_pool)); } template FORCE_INLINE bool add(const TValue& value) { - return add().set(value); + return addElement().set(value); } // add(char*) const @@ -216,7 +216,7 @@ class JsonDocument : public Visitable { // add(const __FlashStringHelper*) const template FORCE_INLINE bool add(TChar* value) { - return add().set(value); + return addElement().set(value); } protected: diff --git a/src/ArduinoJson/Object/MemberProxy.hpp b/src/ArduinoJson/Object/MemberProxy.hpp index 92fd30a9..5dea050c 100644 --- a/src/ArduinoJson/Object/MemberProxy.hpp +++ b/src/ArduinoJson/Object/MemberProxy.hpp @@ -25,18 +25,18 @@ class MemberProxy : public VariantOperators >, : _object(variant), _key(key) {} FORCE_INLINE operator VariantConstRef() const { - return getMember(); + return getUpstreamMember(); } FORCE_INLINE this_type &operator=(const this_type &src) { - getOrCreateMember().set(src); + getOrAddUpstreamMember().set(src); return *this; } template FORCE_INLINE typename enable_if::value, this_type &>::type operator=(const TValue &src) { - getOrCreateMember().set(src); + getOrAddUpstreamMember().set(src); return *this; } @@ -45,33 +45,33 @@ class MemberProxy : public VariantOperators >, // operator=(const __FlashStringHelper*) const template FORCE_INLINE this_type &operator=(TChar *src) { - getOrCreateMember().set(src); + getOrAddUpstreamMember().set(src); return *this; } FORCE_INLINE bool isNull() const { - return getMember().isNull(); + return getUpstreamMember().isNull(); } template FORCE_INLINE typename VariantAs::type as() const { - return getMember().template as(); + return getUpstreamMember().template as(); } template FORCE_INLINE bool is() const { - return getMember().template is(); + return getUpstreamMember().template is(); } template FORCE_INLINE typename VariantTo::type to() { - return getOrCreateMember().template to(); + return getOrAddUpstreamMember().template to(); } template FORCE_INLINE typename enable_if::value, bool>::type set( const TValue &value) { - return getOrCreateMember().set(value); + return getOrAddUpstreamMember().set(value); } // set(char*) const @@ -79,56 +79,60 @@ class MemberProxy : public VariantOperators >, // set(const __FlashStringHelper*) const template FORCE_INLINE bool set(const TChar *value) { - return getOrCreateMember().set(value); + return getOrAddUpstreamMember().set(value); } template void accept(Visitor &visitor) const { - return getMember().accept(visitor); + return getUpstreamMember().accept(visitor); } - using ArrayShortcuts::add; - FORCE_INLINE VariantRef add() const { - return getOrCreateMember().add(); + FORCE_INLINE VariantRef addElement() const { + return getOrAddUpstreamMember().addElement(); } - // get(char*) const - // get(const char*) const - // get(const __FlashStringHelper*) const + // getElement(size_t) const + FORCE_INLINE VariantRef getElement(size_t index) const { + return getUpstreamMember().getElement(index); + } + + // getMember(char*) const + // getMember(const char*) const + // getMember(const __FlashStringHelper*) const template - FORCE_INLINE VariantRef get(TChar *key) const { - return getMember().get(key); + FORCE_INLINE VariantRef getMember(TChar *key) const { + return getUpstreamMember().getMember(key); } - // get(const std::string&) const - // get(const String&) const + // getMember(const std::string&) const + // getMember(const String&) const template - FORCE_INLINE VariantRef get(const TString &key) const { - return getMember().get(key); + FORCE_INLINE VariantRef getMember(const TString &key) const { + return getUpstreamMember().getMember(key); } - // getOrCreate(char*) const - // getOrCreate(const char*) const - // getOrCreate(const __FlashStringHelper*) const + // getOrAddMember(char*) const + // getOrAddMember(const char*) const + // getOrAddMember(const __FlashStringHelper*) const template - FORCE_INLINE VariantRef getOrCreate(TChar *key) const { - return getOrCreateMember().getOrCreate(key); + FORCE_INLINE VariantRef getOrAddMember(TChar *key) const { + return getOrAddUpstreamMember().getOrAddMember(key); } - // getOrCreate(const std::string&) const - // getOrCreate(const String&) const + // getOrAddMember(const std::string&) const + // getOrAddMember(const String&) const template - FORCE_INLINE VariantRef getOrCreate(const TString &key) const { - return getOrCreateMember().getOrCreate(key); + FORCE_INLINE VariantRef getOrAddMember(const TString &key) const { + return getOrAddUpstreamMember().getOrAddMember(key); } private: - FORCE_INLINE VariantRef getMember() const { - return _object.get(_key); + FORCE_INLINE VariantRef getUpstreamMember() const { + return _object.getMember(_key); } - FORCE_INLINE VariantRef getOrCreateMember() const { - return _object.getOrCreate(_key); + FORCE_INLINE VariantRef getOrAddUpstreamMember() const { + return _object.getOrAddMember(_key); } TObject _object; diff --git a/src/ArduinoJson/Object/ObjectImpl.hpp b/src/ArduinoJson/Object/ObjectImpl.hpp index 03551c85..6136cf0a 100644 --- a/src/ArduinoJson/Object/ObjectImpl.hpp +++ b/src/ArduinoJson/Object/ObjectImpl.hpp @@ -13,26 +13,26 @@ template template inline ArrayRef ObjectShortcuts::createNestedArray( const TString& key) const { - return impl()->getOrCreate(key).template to(); + return impl()->getOrAddMember(key).template to(); } template template inline ArrayRef ObjectShortcuts::createNestedArray(TChar* key) const { - return impl()->getOrCreate(key).template to(); + return impl()->getOrAddMember(key).template to(); } template template inline ObjectRef ObjectShortcuts::createNestedObject( const TString& key) const { - return impl()->getOrCreate(key).template to(); + return impl()->getOrAddMember(key).template to(); } template template inline ObjectRef ObjectShortcuts::createNestedObject( TChar* key) const { - return impl()->getOrCreate(key).template to(); + return impl()->getOrAddMember(key).template to(); } } // namespace ARDUINOJSON_NAMESPACE diff --git a/src/ArduinoJson/Object/ObjectRef.hpp b/src/ArduinoJson/Object/ObjectRef.hpp index 05b456ef..7c74e195 100644 --- a/src/ArduinoJson/Object/ObjectRef.hpp +++ b/src/ArduinoJson/Object/ObjectRef.hpp @@ -82,18 +82,18 @@ class ObjectConstRef : public ObjectRefBase, return iterator(); } - // get(const std::string&) const - // get(const String&) const + // getMember(const std::string&) const + // getMember(const String&) const template - FORCE_INLINE VariantConstRef get(const TString& key) const { + FORCE_INLINE VariantConstRef getMember(const TString& key) const { return get_impl(adaptString(key)); } - // get(char*) const - // get(const char*) const - // get(const __FlashStringHelper*) const + // getMember(char*) const + // getMember(const char*) const + // getMember(const __FlashStringHelper*) const template - FORCE_INLINE VariantConstRef get(TChar* key) const { + FORCE_INLINE VariantConstRef getMember(TChar* key) const { return get_impl(adaptString(key)); } @@ -166,33 +166,33 @@ class ObjectRef : public ObjectRefBase, return _data->copyFrom(*src._data, _pool); } - // get(const std::string&) const - // get(const String&) const + // getMember(const std::string&) const + // getMember(const String&) const template - FORCE_INLINE VariantRef get(const TString& key) const { + FORCE_INLINE VariantRef getMember(const TString& key) const { return get_impl(adaptString(key)); } - // get(char*) const - // get(const char*) const - // get(const __FlashStringHelper*) const + // getMember(char*) const + // getMember(const char*) const + // getMember(const __FlashStringHelper*) const template - FORCE_INLINE VariantRef get(TChar* key) const { + FORCE_INLINE VariantRef getMember(TChar* key) const { return get_impl(adaptString(key)); } - // getOrCreate(const std::string&) const - // getOrCreate(const String&) const + // getOrAddMember(const std::string&) const + // getOrAddMember(const String&) const template - FORCE_INLINE VariantRef getOrCreate(const TString& key) const { + FORCE_INLINE VariantRef getOrAddMember(const TString& key) const { return getOrCreate_impl(adaptString(key)); } - // getOrCreate(char*) const - // getOrCreate(const char*) const - // getOrCreate(const __FlashStringHelper*) const + // getOrAddMember(char*) const + // getOrAddMember(const char*) const + // getOrAddMember(const __FlashStringHelper*) const template - FORCE_INLINE VariantRef getOrCreate(TChar* key) const { + FORCE_INLINE VariantRef getOrAddMember(TChar* key) const { return getOrCreate_impl(adaptString(key)); } diff --git a/src/ArduinoJson/Variant/VariantData.hpp b/src/ArduinoJson/Variant/VariantData.hpp index de441da8..419f806e 100644 --- a/src/ArduinoJson/Variant/VariantData.hpp +++ b/src/ArduinoJson/Variant/VariantData.hpp @@ -285,17 +285,23 @@ class VariantData { return isCollection() ? _content.asCollection.size() : 0; } - VariantData *get(size_t index) const { + VariantData *addElement(MemoryPool *pool) { + if (isNull()) toArray(); + if (!isArray()) return 0; + return _content.asCollection.add(pool); + } + + VariantData *getElement(size_t index) const { return isArray() ? _content.asCollection.get(index) : 0; } template - VariantData *get(TAdaptedString key) const { + VariantData *getMember(TAdaptedString key) const { return isObject() ? _content.asCollection.get(key) : 0; } template - VariantData *getOrCreate(TAdaptedString key, MemoryPool *pool) { + VariantData *getOrAddMember(TAdaptedString key, MemoryPool *pool) { if (isNull()) toObject(); if (!isObject()) return 0; VariantData *var = _content.asCollection.get(key); @@ -303,12 +309,6 @@ class VariantData { return _content.asCollection.add(key, pool); } - VariantData *add(MemoryPool *pool) { - if (isNull()) toArray(); - if (!isArray()) return 0; - return _content.asCollection.add(pool); - } - private: uint8_t type() const { return _flags & VALUE_MASK; diff --git a/src/ArduinoJson/Variant/VariantFunctions.hpp b/src/ArduinoJson/Variant/VariantFunctions.hpp index 6ddbbed8..62de5ba6 100644 --- a/src/ArduinoJson/Variant/VariantFunctions.hpp +++ b/src/ArduinoJson/Variant/VariantFunctions.hpp @@ -147,19 +147,19 @@ inline CollectionData *variantToObject(VariantData *var) { } inline NO_INLINE VariantData *variantAdd(VariantData *var, MemoryPool *pool) { - return var != 0 ? var->add(pool) : 0; + return var != 0 ? var->addElement(pool) : 0; } template NO_INLINE VariantData *variantGetOrCreate(VariantData *var, TChar *key, MemoryPool *pool) { - return var != 0 ? var->getOrCreate(adaptString(key), pool) : 0; + return var != 0 ? var->getOrAddMember(adaptString(key), pool) : 0; } template NO_INLINE VariantData *variantGetOrCreate(VariantData *var, const TString &key, MemoryPool *pool) { - return var != 0 ? var->getOrCreate(adaptString(key), pool) : 0; + return var != 0 ? var->getOrAddMember(adaptString(key), pool) : 0; } } // namespace ARDUINOJSON_NAMESPACE diff --git a/src/ArduinoJson/Variant/VariantImpl.hpp b/src/ArduinoJson/Variant/VariantImpl.hpp index d18ed2d6..6dfddd7f 100644 --- a/src/ArduinoJson/Variant/VariantImpl.hpp +++ b/src/ArduinoJson/Variant/VariantImpl.hpp @@ -102,32 +102,32 @@ inline VariantConstRef VariantConstRef::operator[](size_t index) const { return ArrayConstRef(_data != 0 ? _data->asArray() : 0)[index]; } -inline VariantRef VariantRef::add() const { +inline VariantRef VariantRef::addElement() const { return VariantRef(_pool, variantAdd(_data, _pool)); } -inline VariantRef VariantRef::get(size_t index) const { - return VariantRef(_pool, _data != 0 ? _data->get(index) : 0); +inline VariantRef VariantRef::getElement(size_t index) const { + return VariantRef(_pool, _data != 0 ? _data->getElement(index) : 0); } template -inline VariantRef VariantRef::get(TChar *key) const { - return VariantRef(_pool, _data != 0 ? _data->get(adaptString(key)) : 0); +inline VariantRef VariantRef::getMember(TChar *key) const { + return VariantRef(_pool, _data != 0 ? _data->getMember(adaptString(key)) : 0); } template inline typename enable_if::value, VariantRef>::type -VariantRef::get(const TString &key) const { - return VariantRef(_pool, _data != 0 ? _data->get(adaptString(key)) : 0); +VariantRef::getMember(const TString &key) const { + return VariantRef(_pool, _data != 0 ? _data->getMember(adaptString(key)) : 0); } template -inline VariantRef VariantRef::getOrCreate(TChar *key) const { +inline VariantRef VariantRef::getOrAddMember(TChar *key) const { return VariantRef(_pool, variantGetOrCreate(_data, key, _pool)); } template -inline VariantRef VariantRef::getOrCreate(const TString &key) const { +inline VariantRef VariantRef::getOrAddMember(const TString &key) const { return VariantRef(_pool, variantGetOrCreate(_data, key, _pool)); } } // namespace ARDUINOJSON_NAMESPACE diff --git a/src/ArduinoJson/Variant/VariantRef.hpp b/src/ArduinoJson/Variant/VariantRef.hpp index fc05a45e..ce65637e 100644 --- a/src/ArduinoJson/Variant/VariantRef.hpp +++ b/src/ArduinoJson/Variant/VariantRef.hpp @@ -280,32 +280,31 @@ class VariantRef : public VariantRefBase, typename enable_if::value, VariantRef>::type to() const; - VariantRef add() const; - using ArrayShortcuts::add; + VariantRef addElement() const; - FORCE_INLINE VariantRef get(size_t) const; + FORCE_INLINE VariantRef getElement(size_t) const; - // get(const char*) const - // get(const __FlashStringHelper*) const + // getMember(const char*) const + // getMember(const __FlashStringHelper*) const template - FORCE_INLINE VariantRef get(TChar *) const; + FORCE_INLINE VariantRef getMember(TChar *) const; - // get(const std::string&) const - // get(const String&) const + // getMember(const std::string&) const + // getMember(const String&) const template FORCE_INLINE typename enable_if::value, VariantRef>::type - get(const TString &) const; + getMember(const TString &) const; - // getOrCreate(char*) const - // getOrCreate(const char*) const - // getOrCreate(const __FlashStringHelper*) const + // getOrAddMember(char*) const + // getOrAddMember(const char*) const + // getOrAddMember(const __FlashStringHelper*) const template - FORCE_INLINE VariantRef getOrCreate(TChar *) const; + FORCE_INLINE VariantRef getOrAddMember(TChar *) const; - // getOrCreate(const std::string&) const - // getOrCreate(const String&) const + // getOrAddMember(const std::string&) const + // getOrAddMember(const String&) const template - FORCE_INLINE VariantRef getOrCreate(const TString &) const; + FORCE_INLINE VariantRef getOrAddMember(const TString &) const; private: MemoryPool *_pool; diff --git a/test/ElementProxy/add.cpp b/test/ElementProxy/add.cpp index 1652d074..0f18e674 100644 --- a/test/ElementProxy/add.cpp +++ b/test/ElementProxy/add.cpp @@ -9,7 +9,7 @@ using namespace ARDUINOJSON_NAMESPACE; TEST_CASE("ElementProxy::add()") { DynamicJsonDocument doc(4096); - doc.add(); + doc.addElement(); ElementProxy ep = doc[0]; SECTION("add(int)") { diff --git a/test/ElementProxy/set.cpp b/test/ElementProxy/set.cpp index 3d52b61d..d172121b 100644 --- a/test/ElementProxy/set.cpp +++ b/test/ElementProxy/set.cpp @@ -9,7 +9,7 @@ using namespace ARDUINOJSON_NAMESPACE; TEST_CASE("ElementProxy::set()") { DynamicJsonDocument doc(4096); - doc.add(); + doc.addElement(); ElementProxy ep = doc[0]; SECTION("set(int)") { diff --git a/test/JsonArray/get.cpp b/test/JsonArray/get.cpp index 2905f1d5..0b5956da 100644 --- a/test/JsonArray/get.cpp +++ b/test/JsonArray/get.cpp @@ -11,6 +11,6 @@ TEST_CASE("JsonArray::get()") { JsonArray array = doc.as(); SECTION("Overflow") { - REQUIRE(array.get(3).isNull()); + REQUIRE(array.getElement(3).isNull()); } } diff --git a/test/JsonVariant/CMakeLists.txt b/test/JsonVariant/CMakeLists.txt index aa05d82e..15767f8a 100644 --- a/test/JsonVariant/CMakeLists.txt +++ b/test/JsonVariant/CMakeLists.txt @@ -8,7 +8,6 @@ add_executable(JsonVariantTests compare.cpp copy.cpp createNested.cpp - get.cpp is.cpp isnull.cpp memoryUsage.cpp diff --git a/test/JsonVariant/add.cpp b/test/JsonVariant/add.cpp index f3801456..ce899034 100644 --- a/test/JsonVariant/add.cpp +++ b/test/JsonVariant/add.cpp @@ -12,13 +12,6 @@ TEST_CASE("JsonVariant::add()") { DynamicJsonDocument doc(4096); JsonVariant var = doc.to(); - SECTION("No argument") { - JsonVariant nested = var.add(); - - REQUIRE(var.is() == true); - REQUIRE(nested.isNull() == true); - } - SECTION("integer") { var.add(42); diff --git a/test/JsonVariant/get.cpp b/test/JsonVariant/get.cpp deleted file mode 100644 index 872dab62..00000000 --- a/test/JsonVariant/get.cpp +++ /dev/null @@ -1,29 +0,0 @@ -// ArduinoJson - arduinojson.org -// Copyright Benoit Blanchon 2014-2019 -// MIT License - -#include -#include - -TEST_CASE("JsonVariant::get()") { - DynamicJsonDocument doc(4096); - JsonVariant var = doc.to(); - - SECTION("get(const char*)") { - var["value"] = 42; - - REQUIRE(var.get("value") == 42); - } - - SECTION("get(std::string)") { - var["value"] = 42; - - REQUIRE(var.get(std::string("value")) == 42); - } - - SECTION("get(int)") { - var.add().set(42); - - REQUIRE(var.get(0) == 42); - } -}