Fixed a typo

.travis.yml

@@ -2,5 +2,11 @@ language: c++
 compiler:
   - gcc
   - clang
-before_script: cmake .
-script: make && make test
+before_install:
+  - sudo pip install cpp-coveralls
+before_script:
+  - cmake -DCOVERAGE=true .
+script:
+  - make && make test
+after_success:
+  - coveralls --include include --include src --gcov-options '\-lp'

CHANGELOG.md

@@ -1,20 +1,25 @@
 Arduino JSON: change log
 ========================
 
+v4.1
+----
+
+* Added DynamicJsonBuffer (issue #19)
+
 v4.0
 ----
 
 * Unified parser and generator API (issue #23)
 * Updated library layout, now requires Arduino 1.0.6 or newer
 
-**BREAKING CHANGE**: API changed significantly, see `doc/Migrating to the new API.md`.
+**BREAKING CHANGE**: API changed significantly, see [Migrating code to the new API](https://github.com/bblanchon/ArduinoJson/wiki/Migrating-code-to-the-new-API).
 
 
 v3.4
 ----
 
 * Fixed escaped char parsing (issue #16)
-  
+
 
 v3.3
 ----

CMakeLists.txt

@@ -11,5 +11,10 @@ if(MSVC)
 	add_definitions(-D_CRT_SECURE_NO_WARNINGS -W4)
 endif()
 
+if(${COVERAGE})
+	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -coverage")
+	set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -coverage")
+endif()
+
 add_subdirectory(src)
 add_subdirectory(test)

README.md

@@ -1,7 +1,7 @@
 Arduino JSON library
 ====================
 
-[![Build Status](https://travis-ci.org/bblanchon/ArduinoJson.svg?branch=master)](https://travis-ci.org/bblanchon/ArduinoJson)
+[![Build Status](https://travis-ci.org/bblanchon/ArduinoJson.svg?branch=master)](https://travis-ci.org/bblanchon/ArduinoJson) [![Coverage Status](https://img.shields.io/coveralls/bblanchon/ArduinoJson.svg)](https://coveralls.io/r/bblanchon/ArduinoJson?branch=master)
 
 *An elegant and efficient JSON library for embedded systems.*
 
@@ -35,8 +35,6 @@ Quick start
     double latitude    = root["data"][0];
     double longitude   = root["data"][1];
 
-[See complete guide](/doc/Decoding JSON.md)
-
 #### Encoding / Generating
    
     StaticJsonBuffer<200> jsonBuffer;
@@ -53,7 +51,11 @@ Quick start
     // This prints:
     // {"sensor":"gps","time":1351824120,"data":[48.756080,2.302038]}
 
-[See complete guide](/doc/Encoding JSON.md)
+
+Documentation
+-------------
+
+The documentation is available online in the [Arduino JSON wiki](https://github.com/bblanchon/ArduinoJson/wiki) 
 
 Testimonials
 ------------

doc/Avoiding pitfalls.md

@@ -1,102 +0,0 @@
-Avoiding common pitfalls in Arduino JSON
-========================================
-
-As `StaticJsonBuffer` is the corner stone of this library, you'll see that every pitfall listed here are related to a wrong understanding of the memory model.
-
-Make sure you read [Arduino JSON memory model](Memory model.md) before going further.
-
-## 1. Make `StaticJsonBuffer` big enough
-
-By design, the library has no way to tell you why `parseArray()` or `parseObject()` failed.
-
-There are basically two reasons why they may fail:
-
-1. the JSON string is invalid,
-2. the JSON string contains more values that the buffer can store.
-
-So, if you are sure the JSON string is correct and you still can't parse it, you should try to increase the size of the `StaticJsonBuffer`.
-
-## 2. Make sure everything fits in memory
-
-You may go into unpredictable trouble if you allocate more memory than your processor really has.
-It's a very common issue in embedded development.
-
-To diagnose this, look at every big objects in you code and sum their size to check that they fit in RAM.
-
-For example, don't do this:
-
-    char json[1024];                // 1 KB
-    StaticJsonBuffer<512> buffer;   // 514 B
-
-because it may be too big for a processor with only 2 KB: you need free memory to store other variables and the call stack.
-
-That is why an 8-bit processor is not able to parse long and complex JSON strings.
-
-## 3. Keep the `StaticJsonBuffer` in memory long enough
-
-Remember that `StaticJsonBuffer`'s function return references.
-References don't contain data, they are just pointer to the actual.
-So they can only work if the actual data is in memory.
-
-For example, don't do this:
-
-    JsonArray& getArray(char* json)
-    {
-        StaticJsonBuffer<200> buffer;
-        return buffer.parseArray(json); 
-    }
-
-because the local variable `buffer` will be *removed* from memory when the function `parseArray()` returns, and the `JsonArray&` will point to an invalid location.
-
-## 4. Don't reuse the same `StaticJsonBuffer`
-
-During is lifetime a `StaticJsonBuffer` growth until it's discarded. If you try to reuse the same instance several time, it will rapidly get full.
-
-For this reason, you should not use a global variable for your `StaticJsonBuffer`. I don't think there is any scenario in which a global `StaticJsonBuffer` would be a valid option.
-
-The best practice is to declare it in a local scope, so that it's discarded as soon as possible. My advice it to declare it in a function which unique role is to handle the JSON serialization.
-
-## 5. Keep the JSON string in memory long enough
-
-The library never make memory duplication.
-This has an important implication on string values, it means that the library will return pointer to chunks of the string.
-
-For instance, let's imagine that you parse `["hello","world"]`, like this:
-
-    char[] json = "[\"hello\",\"world\"]";
-    StaticJsonBuffer<32> buffer;
-    JsonArray& array = buffer.parseArray(json);
-
-    const char* first = array[0];
-    const char* second = array[1];
-
-In that case, both `first` and `second` are pointers to the content of the original string `json`.
-So this will only work if `json` is still in memory.
-
-## 6. JSON string is altered
-
-If you read carefully the previous section, you may have come to the conclusion that the JSON parser modifies the JSON string.
-
-Indeed, the parser modifies the string for two reasons:
-
-1. it inserts `\0` to terminate substrings,
-2. it translate escaped characters like `\n` or `\t`.
-
-Most of the time this wont be an issue, but there are some corner cases that can be problematic.
-
-Let take the example bellow:
-
-    char[] json = "[\"hello\",\"world\"]";
-    StaticJsonBuffer<32> buffer;
-    JsonArray& array = buffer.parseArray(json);
-
-If you replace it by:
-
-    char* json = "[\"hello\",\"world\"]";
-    StaticJsonBuffer<32> buffer;
-    JsonArray& array = buffer.parseArray(json);
-
-Depending on your platform, you may have an exception because the parser tries to write at a location that is read-only.
-In the first case `char json[]` declares an array of `char` initialized to the specified string.
-In the second case `char* json` declares a pointer to a read-only string, in fact it should be a `const char*` instead of a `char*`.
-

doc/Contributing.md

@@ -1,15 +0,0 @@
-Contributing to Arduino JSON
-============================
-
-If you want to contribute to the project, please:
-
-1. Use GitHub pull request feature
-2. Follow the coding conventions
-3. Write tests
-
-About the coding conventions: I try to follow the [Google C++ Style Guide](http://google-styleguide.googlecode.com/svn/trunk/cppguide.html) with few variations to match the Arduino conventions.
-
-I use [ClangFormat](http://clang.llvm.org/docs/ClangFormat.html) to format the code for me.
-I use [CppLint](http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py) to detect non-compliant stuff.
-
-You should have a look at the `scripts/` folder as it contains a few helpers scripts.

doc/Decoding JSON.md

@@ -1,148 +0,0 @@
-Decoding JSON with Arduino JSON
-===============================
-
-Before writing any code, don't forget to include the header:
-
-    #include <ArduinoJson.h>
-
-For instructions on how to install the library, please read [Using the library with Arduino](Using the library with Arduino.md) or [Using the library without Arduino](Using the library without Arduino.md).
-
-## Example
-
-Here an example that parse the string `{"sensor":"gps","time":1351824120,"data":[48.756080,2.302038]}`:
-
-    char json[] = "{\"sensor\":\"gps\",\"time\":1351824120,\"data\":[48.756080,2.302038]}";
-    
-    //
-    // Step 1: Reserve memory space
-    //
-    StaticJsonBuffer<200> jsonBuffer;
-    
-    //
-    // Step 2: Deserialize the JSON string
-    //
-    JsonObject& root = jsonBuffer.parseObject(json);
-
-    if (!root.success())
-    {
-      Serial.println("parseObject() failed");
-      return;
-    }
-
-    //
-    // Step 3: Retrieve the values
-    //
-    const char* sensor    = root["sensor"];
-    long        time      = root["time"];
-    double      latitude  = root["data"][0];
-    double      longitude = root["data"][1];
-
-## Step 1: Reserve memory space
-
-Arduino JSON uses a preallocated memory pool to store the object tree, this is done by the `StaticJsonBuffer`.
-
-Before continuing please read the page [Arduino JSON memory model](Memory model.md) that explains everything you need to know about `StaticJsonBuffer`.
-
-## Step 2: Parse the JSON string
-
-You invoke the JSON parser through the instance of `StaticJsonBuffer`.
-It exposes two functions for parsing JSON:
-
-1. `parseArray()` that returns a reference to a `JsonArray`
-2. `parseObject()` that returns a reference to a `JsonObject`
-
-Let's see an example.
-Say we want to parse `{"sensor":"gps","time":1351824120,"data":[48.756080,2.302038]}`, it's an object so we call `parseObject()` as follows:
-
-    char json[] = "{\"sensor\":\"gps\",\"time\":1351824120,\"data\":[48.756080,2.302038]}";
-
-    JsonObject& root = jsonBuffer.parseObject(json);
-
-As you can see `parseObject()` takes a `char*` as a parameter.
-Be careful, it's not a `const char*`, the memory must be writable.
-Indeed, the parser will modify the string in two cases:
-
-1. to insert string endings (character `\0`),
-2. to translate escaped characters (like `\n` or `\t`).
-
-Another thing that you must keep in mind is that the string (`char json[]` in the example above) must stay in memory during the whole parsing process.
-That is because the in memory object tree will store pointer to chunks of the string, so as to avoid any memory duplication. 
-
-Now, to check if the parsing was successful, you can call `JsonObject::success()`:
-
-    if (!root.success())
-    {
-        // Parsing fail
-    }
-
-The result can be `false` for tree reasons:
-
-1. the JSON string is invalid,
-2. the JSON string doesn't represent an object,
-3. the `StaticJsonBuffer` is too small.
-
-We just saw how to parse an object, there is nothing more to say for arrays, the procedure is exactly the same.
-
-## Step 3: Retrieve the values
-
-Now that the object or array is in memory, you can extract the data very easily.
-
-In this section, we'll see how to do it with a `JsonObject`.
-Once again, there is nothing more to say about arrays, `JsonArray` works exactly the same as `JsonObject`.
-
-#### Subscript operator
-
-The simplest way is to use the subscript operator of `JsonObject`:
-    
-    const char* sensor = root["sensor"];
-    long time = root["time"];
-
-You can chain the subscript operator if you have nested arrays or objects:
-
-    double latitude  = root["data"][0];
-    double longitude = root["data"][1];
-
-But alternatively, you can get a reference to the nested array:
-
-    JsonArray& nestedArray = root["data"];
-
-#### Casting values
-
-In the previous examples, the values were implicitly casted to the target type.
-You can also do this explicitly
-
-    const char* sensor = root["sensor"].asString();
-    long time = root["time"].as<long>();
-    JsonArray& nestedArray = root["data"].asArray();
-
-If the actual value doesn't match the target type, a default value will be return:
-
-1. `false` for boolean values
-2. `0` for integer values
-3. `NULL` for string values
-4. `JsonArray::invalid()` for nested arrays
-5. `JsonObject::invalid()` for nested object
-
-#### Check values
-
-If you want to know if some value is present, call `containsKey()`:
-
-    if (root.contains("extra"))
-    {
-        // root["extra"] is valid
-    }
-
-If you want to check the type value has a certain type, call `is<T>()`:
-
-    if (root["extra"].is<JsonArray&>())
-    {
-        // root["extra"] is an array
-    }
-
-You can also iterate through the key-value pairs of the object:
-
-    for (JsonObject::itertor it=root.begin(); it!=root.end(); ++it)
-    {
-      Serial.println(it->key);
-      Serial.println(i->value.asString());
-    }

doc/Encoding JSON.md

@@ -1,140 +0,0 @@
-Encoding JSON with Arduino JSON
-===============================
-
-Before writing any code, don't forget to include the header:
-
-    #include <ArduinoJson.h>
-
-For instructions on how to install the library, please read [Using the library with Arduino](Using the library with Arduino.md) or [Using the library without Arduino](Using the library without Arduino.md).
-
-## Example
-
-Here is an example to generate `{"sensor":"gps","time":1351824120,"data":[48.756080,2.302038]}`
-
-    //
-    // Step 1: Reserve memory space
-    //
-    StaticJsonBuffer<200> jsonBuffer;
-
-    //
-    // Step 2: Build object tree in memory
-    //
-    JsonObject& root = jsonBuffer.createObject();
-    root["sensor"] = "gps";
-    root["time"] = 1351824120;
-
-    JsonArray& data = root.createNestedArray("data");
-    data.add(48.756080, 6);  // 6 is the number of decimals to print
-    data.add(2.302038, 6);   // if not specified, 2 digits are printed
-
-    //
-    // Step 3: Generate the JSON string
-    //
-    root.printTo(Serial);
-
-## Step 1: Reserve memory space
-
-Arduino JSON uses a preallocated memory pool to store the object tree, this is done by the `StaticJsonBuffer`.
-
-Before continuing please read the page [Arduino JSON memory model](Memory model.md) that explains everything you need to know about `StaticJsonBuffer`.
-
-## Step 2: Build object tree in memory
-
-Now that you have enough memory hold by the `StaticJsonBuffer`, you can use it to build your in-memory representation of the JSON string.
-
-#### Arrays
-
-You create an array like this:
-
-    JsonArray& array = jsonBuffer.createArray();
-
-Don't forget the `&` after `JsonArray`, it needs to be a reference to the array.
-
-Then you can add strings, integer, booleans, etc:
-
-    array.add("bazinga!");
-    array.add(42);
-    array.add(true);
-
-There are two syntaxes for floating point values:
-
-	array.add(3.1415, 4);  // 4 digits: "3.1415"
-    array.add(3.1415);	   // 2 digits: "3.14"
-
-> ##### About floating point precision
-> The overload of `add()` with 2 parameters allows you to specify the number of decimals to save in the JSON string.
-> When you use the overload with one parameter, you use the default number of decimals which is 2.
-> Note that this behavior is the exact same as Arduino's `Print::print(double,int);` which is implemented by `Serial`, so you may already be familiar with this behavior.
-
-You can add a nested array or object if you have a reference to it.
-Or simpler, you can create nested array or nested objects from the array:
-
-    JsonArray&  nestedArray  = array.createNestedArray();
-    JsonObject& nestedObject = array.createNestedObject();
-
-#### Objects
-
-You create an object like this:
-
-    JsonObject& object = jsonBuffer.createObject();
-
-Again, don't forget the `&` after `JsonObject`, it needs to be a reference to the object.
-
-Then you can add strings, integer, booleans, etc:
-
-    object["key1"] = "bazinga!";
-    object["key2"] = 42;
-    object["key3"] = true;
-
-As for the arrays, there are two syntaxes for the floating point values:
-
-	object["key4"].set(3.1415, 4);  // 4 digits "3.1415"
-    object["key5"] = 3.1415;	    // default: 2 digits "3.14"
-
-You can add a nested array or object if you have a reference to it.
-Or simpler, you can create nested array or nested objects from the object:
-
-    JsonArray&  nestedArray  = object.createNestedArray("key6");
-    JsonObject& nestedObject = object.createNestedObject("key7");
-
-> ##### Other JsonObject functions
-> * `object.add(key, value)` is a synonym for `object[key] = value`
-> * `object.containsKey(key)` returns `true` is the `key` is present in `object`
-> * `object.remove(key)` removes the `value` associated with `key`
-
-## Step 3: Generate the JSON string
-
-There are two ways tho get the resulting JSON string.
-
-Depending on your project, you may need to dump the string in a classic `char[]` or send it to a `Print` implementation like `Serial` or `EthernetClient `.
-
-Both ways are the easy way :-)
-
-#### Use a classic `char[]`
-
-Whether you have a `JsonArray&` or a `JsonObject&`, simply call `printTo()` with the destination buffer, like so:
-
-	char buffer[256];
-    array.printTo(buffer, sizeof(buffer));
-
-> ##### Want an indented output?
-> By default the generated JSON is as small as possible. It contains no extra space, nor line break.
-> But if you want an indented, more readable output, you can.
-> Simply call `prettyPrintTo` instead of `printTo()`:
-> 
->     array.prettyPrintTo(buffer, sizeof(buffer));
-
-#### Send to a `Print` implementation
-
-It's very likely that the generated JSON will end up in a stream like `Serial` or `EthernetClient `, so you can save some time and memory by doing this:
-
-    array.printTo(Serial);
-
-And, of course if you need an indented JSON string:
-
-    array.prettyPrintTo(Serial);
-
-> ##### About the Print interface
-> The library is designed to send the JSON string to an implementation of the `Print` interface that is part of Arduino.
-> In the example above we used `Serial`, but they are many other implementations that would work as well, including: `HardwareSerial`,  `SoftwareSerial`, `LiquidCrystal`, `EthernetClient`, `WiFiClient`, `Wire`...
-> When you use this library out of the Arduino environment, it will use it's own implementation of `Print` and everything will be the same.

doc/Memory model.md

@@ -1,58 +0,0 @@
-Arduino JSON memory model
-=========================
-
-## Fixed memory allocation
-
-### Introducing `StaticJsonBuffer`
-
-Arduino JSON uses a preallocated memory pool to store the object tree, this is done by the `StaticJsonBuffer` class.
-
-Before using any function of the library you need to create a `StaticJsonBuffer`. Then you can use this instance to create arrays and objects, or parse a JSON string.
-
-`StaticJsonBuffer` has a template parameter that determines its capacity. For example, the following line create a `StaticJsonBuffer` with a capacity of 200 bytes:
-
-    StaticJsonBuffer<200> jsonBuffer;
-
-The bigger the buffer is, the more complex the object tree can be, but also the more memory you need.
-
-### How to determine the buffer size?
-
-So the big question you should have in mind right now is *How can I determine the size?*.
-
-There are basically two approaches here:
-
-1. either you can predict the content of the object tree,
-2. or, you know how much memory is available.
-
-In the first case, you know some constraints on the object tree. For instance, let's say that your know in advance (and by that I mean "at compilation time") that you want to generate an object with 3 values, one of them being an array with 2 values, like the following:
-
-    {"sensor":"gps","time":1351824120,"data":[48.756080,2.302038]}
-
-To determine the memory usage of this object tree, you use the two macros `JSON_ARRAY_SIZE(n)` and `JSON_OBJECT_SIZE(n)`, both take the number of elements as an argument.
-For the example above, it would be:
-
-    const int BUFFER_SIZE = JSON_OBJECT_SIZE(3) + JSON_ARRAY_SIZE(2);
-    StaticJsonBuffer<BUFFER_SIZE> jsonBuffer;
-
-In the second case, let's say you dynamically generate a JSON object tree of a random complexity so you can't put a limit based on that. But on the other hand, you don't want your program to crash because the object tree doesn't fit in memory.
-The solution here is to determine how much memory is available, or in other words how much memory you can afford for the JSON object tree.
-
-### Why choosing fixed allocation?
-
-This fixed allocation approach may seem a bit strange, especially if your a desktop application developer used to dynamic allocation, but it make a lot of sense in an embedded context:
-
-1. the code is smaller
-2. it uses less memory
-3. it doesn't create memory fragmentation
-4. it predictable
-
-Don't forget that the memory is "freed" as soon as the `StaticJsonBuffer` is out of scope, like any other variable. It only hold the memory for a short amount of time.
-
-## Memory usage
-
-#### Object size for 8-bit AVR
-
-| Type                    | Size       |
-|-------------------------|------------|
-| JsonArray of N element  | 4 + 8 * N  |
-| JsonObject of N element | 4 + 10 * N |

doc/Migrating code to new API.md

@@ -1,80 +0,0 @@
-Migrating code written for Arduino JSON v3 to v4
-================================================
-
-Arduino JSON v4 was a major rewrite of the library, and the API changed significantly.
-
-## Includes
-
-Arduino JSON v3 had two include files:
-
-    #include <JsonParser.h>
-    #include <JsonGenerator.h>
-
-Arduino JSON v4 only has one:
-
-	#include <ArduinoJson.h>
-
-## Namespaces
-
-Arduino JSON v3 had two namespaces:
-
-	using namespace ArduinoJson::Parser;
-	using namespace ArduinoJson::Generator;
-
-Arduino JSON v4 doesn't require the `using namespace` statement.
-It has a namespace but the `using namespace` is done in the header file.
-
-## StaticJsonBuffer
-
-Arduino JSON v3 had different memory allocation models for the parser:
-
-	JsonParser<16> parser; // 16 being the capacity in "tokens"
-
-and for the generator:
-
-	JsonArray<4> array; // 4 being the number of element
-	JsonObject<4> object;
-
-Arduino JSON v4 only has one memory allocation model:
-
-	StaticJsonBuffer<128> buffer; // 128 being the capacity in bytes
-
-## Return values for the parser
-
-Arduino JSON v3 returned value types:
-
-	JsonArray array = parser.parseArray(json);
-	JsonObject object = parser.parseObject(json);
-
-Arduino JSON v4 returns references types:
-
-	JsonArray& array = buffer.parseArray(json);
-	JsonObject& object = buffer.parseObject(json);
-
-Everything else is compatible
-
-## Creating arrays and objects
-
-Arduino JSON v3 allowed to create `JsonArray` and `JsonObject` directly:
-
-	JsonArray<4> array;
-	JsonObject<4> object;
-
-Arduino JSON v4 requires that you use a `StaticJsonBuffer` for that:
-
-	JsonArray& array = buffer.createArray();
-	JsonObject& object = buffer.createObject();
-
-Note: you don't have to specify the capacity anymore.
-
-## Printable interface
-
-Arduino JSON v3 used to implement the Printable interface, which allowed statements like:
-
-    Serial.print(array);
-
-But Arduino JSON v4 doesn't, instead you need to write this:
-
-	array.printTo(Serial);
-
-Note: there was a good reason for removing that feature, and it's reducing the size of `JsonArray` and `JsonObject`.

doc/Using the library with Arduino.md

@@ -1,30 +0,0 @@
-Using the library with Arduino
-==============================
-
-This library is primarily design to be used with the Arduino IDE and therefore has a simplified setup procedure for that environment.
-If you don't use the Arduino IDE, please read [Using the library without Arduino](Using the library without Arduino.md).
-
-## Install the library
-
-[Download the zip package](https://github.com/bblanchon/ArduinoJson/releases) and extract it to:
-
-    <your Arduino Sketch folder>/libraries/ArduinoJson
-
-Then restart the Arduino IDE.
-
-## Run the examples sketches
-
-Click `File` / `Example` / `ArduinoJson`.
-
-![Screen capture of Arduino IDE](http://i.imgur.com/g5UwkVh.png)
-
-## Use the library in your sketches
-
-Just add the following line at the top of your program:
-
-    #include <ArduinoJson.h>
-
-Then follow the instructions:
-
-1. [Parsing JSON](Parsin JSON.md)
-2. [Generating JSON](Generating JSON.md)

doc/Using the library without Arduino.md

@@ -1,37 +0,0 @@
-Using the library without Arduino
-=================================
-
-This library is primarily design to be used with the Arduino IDE and therefore has a simplified setup procedure for that environment.
-If you use the Arduino IDE, please read [Using the library with Arduino](Using the library with Arduino.md).
-
-However, it can be used without Arduino IDE with very little effort.
-
-## Compiling the library
-
-Step 1: Download source code:
-
-    git clone https://github.com/bblanchon/ArduinoJson.git
-
-Step 2: Generate the `Makefile` for your environment
-
-    cd ArduinoJson
-    cmake .
-
-Step 3: Build
-
-	make
-
-## File paths
-
-Assuming you installed the library into `<arduino-json>`, you need to add:
-
-1. `<arduino-json>/include` to your include path
-2. `<arduino-json>/lib` to your library path
-
-
-----------
-
-You are now ready to follow the instructions:
-
-1. [Parsing JSON](Parsin JSON.md)
-2. [Generating JSON](Generating JSON.md)

include/ArduinoJson.h

@@ -4,6 +4,7 @@
 // Arduino JSON library
 // https://github.com/bblanchon/ArduinoJson
 
+#include "../include/ArduinoJson/DynamicJsonBuffer.hpp"
 #include "../include/ArduinoJson/JsonArray.hpp"
 #include "../include/ArduinoJson/JsonObject.hpp"
 #include "../include/ArduinoJson/StaticJsonBuffer.hpp"

include/ArduinoJson/DynamicJsonBuffer.hpp

@@ -0,0 +1,67 @@
+// Copyright Benoit Blanchon 2014
+// MIT License
+//
+// Arduino JSON library
+// https://github.com/bblanchon/ArduinoJson
+
+#pragma once
+
+#include "JsonBuffer.hpp"
+
+namespace ArduinoJson {
+
+// Implements a JsonBuffer with dynamic memory allocation.
+// You are strongly encouraged to consider using StaticJsonBuffer which is much
+// more suitable for embedded systems.
+class DynamicJsonBuffer : public JsonBuffer {
+ public:
+  DynamicJsonBuffer() : _next(NULL), _size(0) {}
+
+  ~DynamicJsonBuffer() { delete _next; }
+
+  size_t size() const { return _size + (_next ? _next->size() : 0); }
+
+  size_t blockCount() const { return 1 + (_next ? _next->blockCount() : 0); }
+
+  static const size_t BLOCK_CAPACITY = 32;
+
+ protected:
+  virtual void* alloc(size_t bytes) {
+    if (canAllocInThisBlock(bytes))
+      return allocInThisBlock(bytes);
+    else if (canAllocInOtherBlocks(bytes))
+      return allocInOtherBlocks(bytes);
+    else
+      return NULL;
+  }
+
+ private:
+  bool canAllocInThisBlock(size_t bytes) const {
+    return _size + bytes <= BLOCK_CAPACITY;
+  }
+
+  void* allocInThisBlock(size_t bytes) {
+    void* p = _buffer + _size;
+    _size += bytes;
+    return p;
+  }
+
+  bool canAllocInOtherBlocks(size_t bytes) const {
+    // by design a DynamicJsonBuffer can't alloc a block bigger than
+    // BLOCK_CAPACITY
+    return bytes <= BLOCK_CAPACITY;
+  }
+
+  void* allocInOtherBlocks(size_t bytes) {
+    if (!_next) {
+      _next = new DynamicJsonBuffer();
+      if (!_next) return NULL;
+    }
+    return _next->alloc(bytes);
+  }
+
+  DynamicJsonBuffer* _next;
+  size_t _size;
+  uint8_t _buffer[BLOCK_CAPACITY];
+};
+}

include/ArduinoJson/Internals/ListIterator.hpp

@@ -7,6 +7,7 @@
 #pragma once
 
 #include "ListNode.hpp"
+#include "ListConstIterator.hpp"
 
 namespace ArduinoJson {
 namespace Internals {
@@ -33,6 +34,8 @@ class ListIterator {
     return *this;
   }
 
+  operator ListConstIterator<T>() const { return ListConstIterator<T>(_node); }
+
  private:
   ListNode<T> *_node;
 };

include/ArduinoJson/StaticJsonBuffer.hpp

@@ -22,10 +22,10 @@ class StaticJsonBuffer : public JsonBuffer {
   size_t size() const { return _size; }
 
  protected:
-  virtual void* alloc(size_t size) {
-    if (_size + size > CAPACITY) return NULL;
+  virtual void* alloc(size_t bytes) {
+    if (_size + bytes > CAPACITY) return NULL;
     void* p = &_buffer[_size];
-    _size += size;
+    _size += bytes;
     return p;
   }
 

scripts/build-arduino-package.sh

@@ -12,7 +12,6 @@ rm -f $OUTPUT
 # create zip
 "$ZIP" a $OUTPUT \
 	ArduinoJson/CHANGELOG.md \
-	ArduinoJson/doc \
 	ArduinoJson/examples \
 	ArduinoJson/include \
 	ArduinoJson/keywords.txt \

src/CMakeLists.txt

@@ -38,5 +38,10 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "(GNU)")
 	)
 endif()
 
+if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+	add_definitions(
+		-Wc++11-compat
+	)
+endif()
 
 add_library(ArduinoJson ${SRC_FILES} ${INC_FILES})

src/Internals/List.cpp

@@ -31,5 +31,5 @@ void List<T>::removeNode(node_type *nodeToRemove) {
   }
 }
 
-template class List<JsonPair>;
-template class List<JsonVariant>;
+template class ArduinoJson::Internals::List<JsonPair>;
+template class ArduinoJson::Internals::List<JsonVariant>;

test/DynamicJsonBuffer_Array_Tests.cpp

@@ -0,0 +1,32 @@
+// Copyright Benoit Blanchon 2014
+// MIT License
+//
+// Arduino JSON library
+// https://github.com/bblanchon/ArduinoJson
+
+#include <gtest/gtest.h>
+#include <ArduinoJson.h>
+
+TEST(DynamicJsonBuffer_Array_Tests, GrowsWithArray) {
+  DynamicJsonBuffer jsonBuffer;
+
+  JsonArray &array = jsonBuffer.createArray();
+  ASSERT_EQ(JSON_ARRAY_SIZE(0), jsonBuffer.size());
+
+  array.add("hello");
+  ASSERT_EQ(JSON_ARRAY_SIZE(1), jsonBuffer.size());
+
+  array.add("world");
+  ASSERT_EQ(JSON_ARRAY_SIZE(2), jsonBuffer.size());
+}
+
+TEST(DynamicJsonBuffer_Array_Tests, CanAdd1000Values) {
+  DynamicJsonBuffer jsonBuffer;
+
+  JsonArray &array = jsonBuffer.createArray();
+
+  for (int i = 1; i <= 1000; i++) {
+    array.add("hello");
+    ASSERT_EQ(array.size(), i);
+  }
+}

test/DynamicJsonBuffer_Basic_Tests.cpp

@@ -0,0 +1,63 @@
+// Copyright Benoit Blanchon 2014
+// MIT License
+//
+// Arduino JSON library
+// https://github.com/bblanchon/ArduinoJson
+
+#include <gtest/gtest.h>
+
+#define protected public
+#include <ArduinoJson/DynamicJsonBuffer.hpp>
+
+using namespace ArduinoJson;
+
+class DynamicJsonBuffer_Basic_Tests : public testing::Test {
+ protected:
+  DynamicJsonBuffer buffer;
+};
+
+TEST_F(DynamicJsonBuffer_Basic_Tests, InitialSizeIsZero) {
+  ASSERT_EQ(0, buffer.size());
+}
+
+TEST_F(DynamicJsonBuffer_Basic_Tests, InitialBlockCountIsOne) {
+  ASSERT_EQ(1, buffer.blockCount());
+}
+
+TEST_F(DynamicJsonBuffer_Basic_Tests, SizeIncreasesAfterAlloc) {
+  buffer.alloc(1);
+  ASSERT_EQ(1, buffer.size());
+  buffer.alloc(1);
+  ASSERT_EQ(2, buffer.size());
+  buffer.alloc(DynamicJsonBuffer::BLOCK_CAPACITY);
+  ASSERT_EQ(2 + DynamicJsonBuffer::BLOCK_CAPACITY, buffer.size());
+}
+
+TEST_F(DynamicJsonBuffer_Basic_Tests, BlockCountDoesntChangeWhenNotFull) {
+  buffer.alloc(DynamicJsonBuffer::BLOCK_CAPACITY);
+  ASSERT_EQ(1, buffer.blockCount());
+}
+
+TEST_F(DynamicJsonBuffer_Basic_Tests, BlockCountChangesWhenFull) {
+  buffer.alloc(DynamicJsonBuffer::BLOCK_CAPACITY);
+  buffer.alloc(1);
+  ASSERT_EQ(2, buffer.blockCount());
+}
+
+TEST_F(DynamicJsonBuffer_Basic_Tests, CanAllocLessThanBlockCapacity) {
+  void* p1 = buffer.alloc(DynamicJsonBuffer::BLOCK_CAPACITY);
+  ASSERT_TRUE(p1);
+  void* p2 = buffer.alloc(DynamicJsonBuffer::BLOCK_CAPACITY);
+  ASSERT_TRUE(p2);
+}
+
+TEST_F(DynamicJsonBuffer_Basic_Tests, CantAllocMoreThanBlockCapacity) {
+  void* p = buffer.alloc(DynamicJsonBuffer::BLOCK_CAPACITY + 1);
+  ASSERT_FALSE(p);
+}
+
+TEST_F(DynamicJsonBuffer_Basic_Tests, ReturnDifferentPointer) {
+  void* p1 = buffer.alloc(1);
+  void* p2 = buffer.alloc(2);
+  ASSERT_NE(p1, p2);
+}

test/DynamicJsonBuffer_Object_Tests.cpp

@@ -0,0 +1,24 @@
+// Copyright Benoit Blanchon 2014
+// MIT License
+//
+// Arduino JSON library
+// https://github.com/bblanchon/ArduinoJson
+
+#include <gtest/gtest.h>
+#include <ArduinoJson.h>
+
+TEST(DynamicJsonBuffer_Object_Tests, GrowsWithObject) {
+  DynamicJsonBuffer json;
+
+  JsonObject &obj = json.createObject();
+  ASSERT_EQ(JSON_OBJECT_SIZE(0), json.size());
+
+  obj["hello"];
+  ASSERT_EQ(JSON_OBJECT_SIZE(1), json.size());
+
+  obj["world"];
+  ASSERT_EQ(JSON_OBJECT_SIZE(2), json.size());
+
+  obj["world"];  // <- same value, should not grow
+  ASSERT_EQ(JSON_OBJECT_SIZE(2), json.size());
+}

test/GbathreeBug.cpp

@@ -10,16 +10,16 @@
 
 class GbathreeBug : public testing::Test {
  public:
-  GbathreeBug() : object(buffer.parseObject(getJson())) {}
+  GbathreeBug() : _object(_buffer.parseObject(getJson())) {}
 
  protected:
-  char json[1024];
-  StaticJsonBuffer<10000> buffer;
-  const JsonObject& object;
+  char _json[1024];
+  DynamicJsonBuffer _buffer;
+  const JsonObject& _object;
 
  private:
   char* getJson() {
-    strcpy(json,
+    strcpy(_json,
            "{\"protocol_name\":\"fluorescence\",\"repeats\":1,\"wait\":0,"
            "\"averages\":1,\"measurements\":3,\"meas2_light\":15,\"meas1_"
            "baseline\":0,\"act_light\":20,\"pulsesize\":25,\"pulsedistance\":"
@@ -30,46 +30,46 @@ class GbathreeBug : public testing::Test {
            "\"measlights\":[[15,15,15,15],[15,15,15,15],[15,15,15,15],[15,15,"
            "15,15]],\"measlights2\":[[15,15,15,15],[15,15,15,15],[15,15,15,15],"
            "[15,15,15,15]],\"altc\":[2,2,2,2],\"altd\":[2,2,2,2]}");
-    return json;
+    return _json;
   }
 };
 
-TEST_F(GbathreeBug, Success) { EXPECT_TRUE(object.success()); }
+TEST_F(GbathreeBug, Success) { EXPECT_TRUE(_object.success()); }
 
 TEST_F(GbathreeBug, ProtocolName) {
-  EXPECT_STREQ("fluorescence", object.at("protocol_name").asString());
+  EXPECT_STREQ("fluorescence", _object.at("protocol_name").asString());
 }
 
-TEST_F(GbathreeBug, Repeats) { EXPECT_EQ(1, object["repeats"]); }
+TEST_F(GbathreeBug, Repeats) { EXPECT_EQ(1, _object["repeats"]); }
 
-TEST_F(GbathreeBug, Wait) { EXPECT_EQ(0, object["wait"]); }
+TEST_F(GbathreeBug, Wait) { EXPECT_EQ(0, _object["wait"]); }
 
-TEST_F(GbathreeBug, Measurements) { EXPECT_EQ(3, object["measurements"]); }
+TEST_F(GbathreeBug, Measurements) { EXPECT_EQ(3, _object["measurements"]); }
 
-TEST_F(GbathreeBug, Meas2_Light) { EXPECT_EQ(15, object["meas2_light"]); }
+TEST_F(GbathreeBug, Meas2_Light) { EXPECT_EQ(15, _object["meas2_light"]); }
 
-TEST_F(GbathreeBug, Meas1_Baseline) { EXPECT_EQ(0, object["meas1_baseline"]); }
+TEST_F(GbathreeBug, Meas1_Baseline) { EXPECT_EQ(0, _object["meas1_baseline"]); }
 
-TEST_F(GbathreeBug, Act_Light) { EXPECT_EQ(20, object["act_light"]); }
+TEST_F(GbathreeBug, Act_Light) { EXPECT_EQ(20, _object["act_light"]); }
 
-TEST_F(GbathreeBug, Pulsesize) { EXPECT_EQ(25, object["pulsesize"]); }
+TEST_F(GbathreeBug, Pulsesize) { EXPECT_EQ(25, _object["pulsesize"]); }
 
 TEST_F(GbathreeBug, Pulsedistance) {
-  EXPECT_EQ(10000, object["pulsedistance"]);
+  EXPECT_EQ(10000, _object["pulsedistance"]);
 }
 
-TEST_F(GbathreeBug, Actintensity1) { EXPECT_EQ(50, object["actintensity1"]); }
+TEST_F(GbathreeBug, Actintensity1) { EXPECT_EQ(50, _object["actintensity1"]); }
 
-TEST_F(GbathreeBug, Actintensity2) { EXPECT_EQ(255, object["actintensity2"]); }
+TEST_F(GbathreeBug, Actintensity2) { EXPECT_EQ(255, _object["actintensity2"]); }
 
-TEST_F(GbathreeBug, Measintensity) { EXPECT_EQ(255, object["measintensity"]); }
+TEST_F(GbathreeBug, Measintensity) { EXPECT_EQ(255, _object["measintensity"]); }
 
-TEST_F(GbathreeBug, Calintensity) { EXPECT_EQ(255, object["calintensity"]); }
+TEST_F(GbathreeBug, Calintensity) { EXPECT_EQ(255, _object["calintensity"]); }
 
 TEST_F(GbathreeBug, Pulses) {
   // "pulses":[50,50,50]
 
-  JsonArray& array = object.at("pulses");
+  JsonArray& array = _object.at("pulses");
   EXPECT_TRUE(array.success());
 
   EXPECT_EQ(3, array.size());
@@ -82,7 +82,7 @@ TEST_F(GbathreeBug, Pulses) {
 TEST_F(GbathreeBug, Act) {
   // "act":[2,1,2,2]
 
-  JsonArray& array = object.at("act");
+  JsonArray& array = _object.at("act");
   EXPECT_TRUE(array.success());
 
   EXPECT_EQ(4, array.size());
@@ -95,7 +95,7 @@ TEST_F(GbathreeBug, Act) {
 TEST_F(GbathreeBug, Detectors) {
   // "detectors":[[34,34,34,34],[34,34,34,34],[34,34,34,34],[34,34,34,34]]
 
-  JsonArray& array = object.at("detectors");
+  JsonArray& array = _object.at("detectors");
   EXPECT_TRUE(array.success());
   EXPECT_EQ(4, array.size());
 
@@ -110,7 +110,7 @@ TEST_F(GbathreeBug, Detectors) {
 TEST_F(GbathreeBug, Alta) {
   // alta:[2,2,2,2]
 
-  JsonArray& array = object.at("alta");
+  JsonArray& array = _object.at("alta");
   EXPECT_TRUE(array.success());
 
   EXPECT_EQ(4, array.size());
@@ -123,7 +123,7 @@ TEST_F(GbathreeBug, Alta) {
 TEST_F(GbathreeBug, Altb) {
   // altb:[2,2,2,2]
 
-  JsonArray& array = object.at("altb");
+  JsonArray& array = _object.at("altb");
   EXPECT_TRUE(array.success());
 
   EXPECT_EQ(4, array.size());
@@ -136,7 +136,7 @@ TEST_F(GbathreeBug, Altb) {
 TEST_F(GbathreeBug, Measlights) {
   // "measlights":[[15,15,15,15],[15,15,15,15],[15,15,15,15],[15,15,15,15]]
 
-  JsonArray& array = object.at("measlights");
+  JsonArray& array = _object.at("measlights");
   EXPECT_TRUE(array.success());
   EXPECT_EQ(4, array.size());
 
@@ -152,7 +152,7 @@ TEST_F(GbathreeBug, Measlights) {
 TEST_F(GbathreeBug, Measlights2) {
   // "measlights2":[[15,15,15,15],[15,15,15,15],[15,15,15,15],[15,15,15,15]]
 
-  JsonArray& array = object.at("measlights2");
+  JsonArray& array = _object.at("measlights2");
   EXPECT_TRUE(array.success());
   EXPECT_EQ(4, array.size());
 
@@ -167,7 +167,7 @@ TEST_F(GbathreeBug, Measlights2) {
 TEST_F(GbathreeBug, Altc) {
   // altc:[2,2,2,2]
 
-  JsonArray& array = object.at("altc");
+  JsonArray& array = _object.at("altc");
   EXPECT_TRUE(array.success());
 
   EXPECT_EQ(4, array.size());
@@ -180,7 +180,7 @@ TEST_F(GbathreeBug, Altc) {
 TEST_F(GbathreeBug, Altd) {
   // altd:[2,2,2,2]
 
-  JsonArray& array = object.at("altd");
+  JsonArray& array = _object.at("altd");
   EXPECT_TRUE(array.success());
 
   EXPECT_EQ(4, array.size());

test/IntegrationTests.cpp

@@ -13,34 +13,34 @@ class IntegrationTests : public testing::TestWithParam<const char*> {
  protected:
   virtual void SetUp() {
     _input = GetParam();
-    strcpy(inputBuffer, _input);
+    strcpy(_inputBuffer, _input);
   }
 
   void parseThenPrint(char* input, char* output) {
-    StaticJsonBuffer<10000> json;
-    json.parseObject(input).printTo(output, MAX_JSON_SIZE);
+    DynamicJsonBuffer buffer;
+    buffer.parseObject(input).printTo(output, MAX_JSON_SIZE);
   }
 
   void parseThenPrettyPrint(char* input, char* output) {
-    StaticJsonBuffer<10000> json;
-    json.parseObject(input).prettyPrintTo(output, MAX_JSON_SIZE);
+    DynamicJsonBuffer buffer;
+    buffer.parseObject(input).prettyPrintTo(output, MAX_JSON_SIZE);
   }
 
   const char* _input;
-  char inputBuffer[MAX_JSON_SIZE];
-  char outputBuffer[MAX_JSON_SIZE];
-  char intermediateBuffer[MAX_JSON_SIZE];
+  char _inputBuffer[MAX_JSON_SIZE];
+  char _outputBuffer[MAX_JSON_SIZE];
+  char _intermediateBuffer[MAX_JSON_SIZE];
 };
 
 TEST_P(IntegrationTests, ParseThenPrint) {
-  parseThenPrint(inputBuffer, outputBuffer);
-  ASSERT_STREQ(_input, outputBuffer);
+  parseThenPrint(_inputBuffer, _outputBuffer);
+  ASSERT_STREQ(_input, _outputBuffer);
 }
 
 TEST_P(IntegrationTests, ParseThenPrettyPrintThenParseThenPrint) {
-  parseThenPrettyPrint(inputBuffer, intermediateBuffer);
-  parseThenPrint(intermediateBuffer, outputBuffer);
-  ASSERT_STREQ(_input, outputBuffer);
+  parseThenPrettyPrint(_inputBuffer, _intermediateBuffer);
+  parseThenPrint(_intermediateBuffer, _outputBuffer);
+  ASSERT_STREQ(_input, _outputBuffer);
 }
 
 INSTANTIATE_TEST_CASE_P(

test/Issue34.cpp

@@ -0,0 +1,39 @@
+// Copyright Benoit Blanchon 2014
+// MIT License
+//
+// Arduino JSON library
+// https://github.com/bblanchon/ArduinoJson
+
+#include <gtest/gtest.h>
+#include <ArduinoJson.h>
+
+class Issue34 : public testing::Test {
+ protected:
+  template <typename T>
+  void test_with_value(T expected) {
+    StaticJsonBuffer<JSON_OBJECT_SIZE(1)> jsonBuffer;
+
+    JsonObject& jsonObject = jsonBuffer.createObject();
+
+    jsonObject["key"] = expected;
+    T actual = jsonObject["key"];
+
+    ASSERT_EQ(expected, actual);
+  }
+};
+
+TEST_F(Issue34, int8_t) { test_with_value<int8_t>(1); }
+
+TEST_F(Issue34, uint8_t) { test_with_value<uint8_t>(2); }
+
+TEST_F(Issue34, int16_t) { test_with_value<int16_t>(3); }
+
+TEST_F(Issue34, uint16_t) { test_with_value<uint16_t>(4); }
+
+TEST_F(Issue34, int32_t) { test_with_value<int32_t>(5); }
+
+TEST_F(Issue34, uint32_t) { test_with_value<uint32_t>(6); }
+
+TEST_F(Issue34, float) { test_with_value<float>(7); }
+
+TEST_F(Issue34, double) { test_with_value<double>(8); }

test/JsonArray_Container_Tests.cpp

@@ -9,7 +9,7 @@
 
 class JsonArray_Container_Tests : public ::testing::Test {
  protected:
-  JsonArray_Container_Tests() : array(json.createArray()) {}
+  JsonArray_Container_Tests() : _array(_jsonBuffer.createArray()) {}
 
   template <typename T>
   void firstMustEqual(T expected) {
@@ -31,56 +31,56 @@ class JsonArray_Container_Tests : public ::testing::Test {
     itemMustReference(1, expected);
   }
 
-  void sizeMustBe(int expected) { EXPECT_EQ(expected, array.size()); }
+  void sizeMustBe(int expected) { EXPECT_EQ(expected, _array.size()); }
 
-  StaticJsonBuffer<256> json;
-  JsonArray& array;
+  DynamicJsonBuffer _jsonBuffer;
+  JsonArray& _array;
 
  private:
   template <typename T>
   void itemMustEqual(int index, T expected) {
-    EXPECT_EQ(expected, array[index].as<T>());
+    EXPECT_EQ(expected, _array[index].as<T>());
   }
 
   template <typename T>
   void itemMustReference(int index, const T& expected) {
-    EXPECT_EQ(&expected, &array[index].as<T&>());
+    EXPECT_EQ(&expected, &_array[index].as<T&>());
   }
 };
 
 TEST_F(JsonArray_Container_Tests, SuccessIsTrue) {
-  EXPECT_TRUE(array.success());
+  EXPECT_TRUE(_array.success());
 }
 
 TEST_F(JsonArray_Container_Tests, InitialSizeIsZero) { sizeMustBe(0); }
 
 TEST_F(JsonArray_Container_Tests, Grow_WhenValuesAreAdded) {
-  array.add("hello");
+  _array.add("hello");
   sizeMustBe(1);
 
-  array.add("world");
+  _array.add("world");
   sizeMustBe(2);
 }
 
 TEST_F(JsonArray_Container_Tests, CanStoreIntegers) {
-  array.add(123);
-  array.add(456);
+  _array.add(123);
+  _array.add(456);
 
   firstMustEqual(123);
   secondMustEqual(456);
 }
 
 TEST_F(JsonArray_Container_Tests, CanStoreDoubles) {
-  array.add(123.45);
-  array.add(456.78);
+  _array.add(123.45);
+  _array.add(456.78);
 
   firstMustEqual(123.45);
   secondMustEqual(456.78);
 }
 
 TEST_F(JsonArray_Container_Tests, CanStoreBooleans) {
-  array.add(true);
-  array.add(false);
+  _array.add(true);
+  _array.add(false);
 
   firstMustEqual(true);
   secondMustEqual(false);
@@ -90,46 +90,46 @@ TEST_F(JsonArray_Container_Tests, CanStoreStrings) {
   const char* firstString = "h3110";
   const char* secondString = "w0r1d";
 
-  array.add(firstString);
-  array.add(secondString);
+  _array.add(firstString);
+  _array.add(secondString);
 
   firstMustEqual(firstString);
   secondMustEqual(secondString);
 }
 
 TEST_F(JsonArray_Container_Tests, CanStoreNestedArrays) {
-  JsonArray& innerarray1 = json.createArray();
-  JsonArray& innerarray2 = json.createArray();
+  JsonArray& inner_array1 = _jsonBuffer.createArray();
+  JsonArray& inner_array2 = _jsonBuffer.createArray();
 
-  array.add(innerarray1);
-  array.add(innerarray2);
+  _array.add(inner_array1);
+  _array.add(inner_array2);
 
-  firstMustReference(innerarray1);
-  secondMustReference(innerarray2);
+  firstMustReference(inner_array1);
+  secondMustReference(inner_array2);
 }
 
 TEST_F(JsonArray_Container_Tests, CanStoreNestedObjects) {
-  JsonObject& innerObject1 = json.createObject();
-  JsonObject& innerObject2 = json.createObject();
+  JsonObject& innerObject1 = _jsonBuffer.createObject();
+  JsonObject& innerObject2 = _jsonBuffer.createObject();
 
-  array.add(innerObject1);
-  array.add(innerObject2);
+  _array.add(innerObject1);
+  _array.add(innerObject2);
 
   firstMustReference(innerObject1);
   secondMustReference(innerObject2);
 }
 
 TEST_F(JsonArray_Container_Tests, CanCreateNestedArrays) {
-  JsonArray& innerarray1 = array.createNestedArray();
-  JsonArray& innerarray2 = array.createNestedArray();
+  JsonArray& inner_array1 = _array.createNestedArray();
+  JsonArray& inner_array2 = _array.createNestedArray();
 
-  firstMustReference(innerarray1);
-  secondMustReference(innerarray2);
+  firstMustReference(inner_array1);
+  secondMustReference(inner_array2);
 }
 
 TEST_F(JsonArray_Container_Tests, CanCreateNestedObjects) {
-  JsonObject& innerObject1 = array.createNestedObject();
-  JsonObject& innerObject2 = array.createNestedObject();
+  JsonObject& innerObject1 = _array.createNestedObject();
+  JsonObject& innerObject2 = _array.createNestedObject();
 
   firstMustReference(innerObject1);
   secondMustReference(innerObject2);

test/JsonArray_Iterator_Tests.cpp

@@ -7,21 +7,32 @@
 #include <gtest/gtest.h>
 #include <ArduinoJson.h>
 
-TEST(JsonArray_Iterator_Test, SimpleTest) {
-  StaticJsonBuffer<100> jsonBuffer;
+template <typename TIterator>
+static void run_iterator_test() {
+  StaticJsonBuffer<JSON_ARRAY_SIZE(2)> jsonBuffer;
 
   JsonArray &array = jsonBuffer.createArray();
   array.add(12);
   array.add(34);
 
-  JsonArray::iterator it = array.begin();
-  JsonArray::iterator end = array.end();
+  TIterator it = array.begin();
+  TIterator end = array.end();
 
   EXPECT_NE(end, it);
-  EXPECT_EQ(12, it->as<int>());
+  EXPECT_EQ(12, it->template as<int>());
+  EXPECT_EQ(12, static_cast<int>(*it));
   ++it;
   EXPECT_NE(end, it);
-  EXPECT_EQ(34, it->as<int>());
+  EXPECT_EQ(34, it->template as<int>());
+  EXPECT_EQ(34, static_cast<int>(*it));
   ++it;
   EXPECT_EQ(end, it);
 }
+
+TEST(JsonArray_Iterator_Test, RunItertorToEnd) {
+  run_iterator_test<JsonArray::iterator>();
+}
+
+TEST(JsonArray_Iterator_Test, RunConstItertorToEnd) {
+  run_iterator_test<JsonArray::const_iterator>();
+}

test/JsonArray_PrettyPrintTo_Tests.cpp

@@ -9,20 +9,20 @@
 
 class JsonArray_PrettyPrintTo_Tests : public testing::Test {
  public:
-  JsonArray_PrettyPrintTo_Tests() : array(json.createArray()) {}
+  JsonArray_PrettyPrintTo_Tests() : array(jsonBuffer.createArray()) {}
 
  protected:
-  StaticJsonBuffer<200> json;
+  DynamicJsonBuffer jsonBuffer;
   JsonArray& array;
 
   void outputMustBe(const char* expected) {
-    size_t n = array.prettyPrintTo(buffer, sizeof(buffer));
-    EXPECT_STREQ(expected, buffer);
+    size_t n = array.prettyPrintTo(_buffer, sizeof(_buffer));
+    EXPECT_STREQ(expected, _buffer);
     EXPECT_EQ(strlen(expected), n);
   }
 
  private:
-  char buffer[256];
+  char _buffer[256];
 };
 
 TEST_F(JsonArray_PrettyPrintTo_Tests, Empty) { outputMustBe("[]"); }

test/JsonObject_Container_Tests.cpp

@@ -9,118 +9,118 @@
 
 class JsonObject_Container_Tests : public ::testing::Test {
  public:
-  JsonObject_Container_Tests() : object(json.createObject()) {}
+  JsonObject_Container_Tests() : _object(_jsonBuffer.createObject()) {}
 
  protected:
-  StaticJsonBuffer<256> json;
-  JsonObject& object;
+  DynamicJsonBuffer _jsonBuffer;
+  JsonObject& _object;
 };
 
 TEST_F(JsonObject_Container_Tests, InitialSizeIsZero) {
-  EXPECT_EQ(0, object.size());
+  EXPECT_EQ(0, _object.size());
 }
 
 TEST_F(JsonObject_Container_Tests, Grow_WhenValuesAreAdded) {
-  object["hello"];
-  EXPECT_EQ(1, object.size());
+  _object["hello"];
+  EXPECT_EQ(1, _object.size());
 
-  object["world"];
-  EXPECT_EQ(2, object.size());
+  _object["world"];
+  EXPECT_EQ(2, _object.size());
 }
 
 TEST_F(JsonObject_Container_Tests, DoNotGrow_WhenSameValueIsAdded) {
-  object["hello"];
-  EXPECT_EQ(1, object.size());
+  _object["hello"];
+  EXPECT_EQ(1, _object.size());
 
-  object["hello"];
-  EXPECT_EQ(1, object.size());
+  _object["hello"];
+  EXPECT_EQ(1, _object.size());
 }
 
 TEST_F(JsonObject_Container_Tests, Shrink_WhenValuesAreRemoved) {
-  object["hello"];
-  object["world"];
+  _object["hello"];
+  _object["world"];
 
-  object.remove("hello");
-  EXPECT_EQ(1, object.size());
+  _object.remove("hello");
+  EXPECT_EQ(1, _object.size());
 
-  object.remove("world");
-  EXPECT_EQ(0, object.size());
+  _object.remove("world");
+  EXPECT_EQ(0, _object.size());
 }
 
 TEST_F(JsonObject_Container_Tests,
        DoNotShrink_WhenRemoveIsCalledWithAWrongKey) {
-  object["hello"];
-  object["world"];
+  _object["hello"];
+  _object["world"];
 
-  object.remove(":-P");
+  _object.remove(":-P");
 
-  EXPECT_EQ(2, object.size());
+  EXPECT_EQ(2, _object.size());
 }
 
 TEST_F(JsonObject_Container_Tests, CanStoreIntegers) {
-  object["hello"] = 123;
-  object["world"] = 456;
+  _object["hello"] = 123;
+  _object["world"] = 456;
 
-  EXPECT_EQ(123, object["hello"].as<int>());
-  EXPECT_EQ(456, object["world"].as<int>());
+  EXPECT_EQ(123, _object["hello"].as<int>());
+  EXPECT_EQ(456, _object["world"].as<int>());
 }
 
 TEST_F(JsonObject_Container_Tests, CanStoreDoubles) {
-  object["hello"] = 123.45;
-  object["world"] = 456.78;
+  _object["hello"] = 123.45;
+  _object["world"] = 456.78;
 
-  EXPECT_EQ(123.45, object["hello"].as<double>());
-  EXPECT_EQ(456.78, object["world"].as<double>());
+  EXPECT_EQ(123.45, _object["hello"].as<double>());
+  EXPECT_EQ(456.78, _object["world"].as<double>());
 }
 
 TEST_F(JsonObject_Container_Tests, CanStoreBooleans) {
-  object["hello"] = true;
-  object["world"] = false;
+  _object["hello"] = true;
+  _object["world"] = false;
 
-  EXPECT_TRUE(object["hello"].as<bool>());
-  EXPECT_FALSE(object["world"].as<bool>());
+  EXPECT_TRUE(_object["hello"].as<bool>());
+  EXPECT_FALSE(_object["world"].as<bool>());
 }
 
 TEST_F(JsonObject_Container_Tests, CanStoreStrings) {
-  object["hello"] = "h3110";
-  object["world"] = "w0r1d";
+  _object["hello"] = "h3110";
+  _object["world"] = "w0r1d";
 
-  EXPECT_STREQ("h3110", object["hello"].as<const char*>());
-  EXPECT_STREQ("w0r1d", object["world"].as<const char*>());
+  EXPECT_STREQ("h3110", _object["hello"].as<const char*>());
+  EXPECT_STREQ("w0r1d", _object["world"].as<const char*>());
 }
 
 TEST_F(JsonObject_Container_Tests, CanStoreInnerArrays) {
-  JsonArray& innerarray1 = json.createArray();
-  JsonArray& innerarray2 = json.createArray();
+  JsonArray& innerarray1 = _jsonBuffer.createArray();
+  JsonArray& innerarray2 = _jsonBuffer.createArray();
 
-  object["hello"] = innerarray1;
-  object["world"] = innerarray2;
+  _object["hello"] = innerarray1;
+  _object["world"] = innerarray2;
 
-  EXPECT_EQ(&innerarray1, &object["hello"].asArray());
-  EXPECT_EQ(&innerarray2, &object["world"].asArray());
+  EXPECT_EQ(&innerarray1, &_object["hello"].asArray());
+  EXPECT_EQ(&innerarray2, &_object["world"].asArray());
 }
 
 TEST_F(JsonObject_Container_Tests, CanStoreInnerObjects) {
-  JsonObject& innerObject1 = json.createObject();
-  JsonObject& innerObject2 = json.createObject();
+  JsonObject& innerObject1 = _jsonBuffer.createObject();
+  JsonObject& innerObject2 = _jsonBuffer.createObject();
 
-  object["hello"] = innerObject1;
-  object["world"] = innerObject2;
+  _object["hello"] = innerObject1;
+  _object["world"] = innerObject2;
 
-  EXPECT_EQ(&innerObject1, &object["hello"].asObject());
-  EXPECT_EQ(&innerObject2, &object["world"].asObject());
+  EXPECT_EQ(&innerObject1, &_object["hello"].asObject());
+  EXPECT_EQ(&innerObject2, &_object["world"].asObject());
 }
 
 TEST_F(JsonObject_Container_Tests, ContainsKeyReturnFalseForNonExistingKey) {
-  EXPECT_FALSE(object.containsKey("hello"));
+  EXPECT_FALSE(_object.containsKey("hello"));
 }
 
 TEST_F(JsonObject_Container_Tests, ContainsKeyReturnTrueForDefinedValue) {
-  object.add("hello", 42);
-  EXPECT_TRUE(object.containsKey("hello"));
+  _object.add("hello", 42);
+  EXPECT_TRUE(_object.containsKey("hello"));
 }
 
 TEST_F(JsonObject_Container_Tests, ContainsKeyReturnFalseForUndefinedValue) {
-  object.add("hello");
-  EXPECT_FALSE(object.containsKey("hello"));
+  _object.add("hello");
+  EXPECT_FALSE(_object.containsKey("hello"));
 }

test/JsonObject_Iterator_Tests.cpp

@@ -10,39 +10,39 @@
 
 class JsonObject_Iterator_Test : public testing::Test {
  public:
-  JsonObject_Iterator_Test() : object(_buffer.createObject()) {
-    object["ab"] = 12;
-    object["cd"] = 34;
+  JsonObject_Iterator_Test() : _object(_buffer.createObject()) {
+    _object["ab"] = 12;
+    _object["cd"] = 34;
   }
 
  protected:
-  StaticJsonBuffer<256> _buffer;
-  JsonObject& object;
+  StaticJsonBuffer<JSON_OBJECT_SIZE(2)> _buffer;
+  JsonObject& _object;
 };
 
 TEST_F(JsonObject_Iterator_Test, NonConstIterator) {
-  JsonObject::iterator it = object.begin();
-  ASSERT_NE(object.end(), it);
+  JsonObject::iterator it = _object.begin();
+  ASSERT_NE(_object.end(), it);
   EXPECT_STREQ("ab", it->key);
   EXPECT_EQ(12, it->value);
   it->key = "a.b";
   it->value = 1.2;
   ++it;
-  ASSERT_NE(object.end(), it);
+  ASSERT_NE(_object.end(), it);
   EXPECT_STREQ("cd", it->key);
   EXPECT_EQ(34, it->value);
   it->key = "c.d";
   it->value = 3.4;
   ++it;
-  ASSERT_EQ(object.end(), it);
+  ASSERT_EQ(_object.end(), it);
 
-  ASSERT_EQ(2, object.size());
-  EXPECT_EQ(1.2, object["a.b"]);
-  EXPECT_EQ(3.4, object["c.d"]);
+  ASSERT_EQ(2, _object.size());
+  EXPECT_EQ(1.2, _object["a.b"]);
+  EXPECT_EQ(3.4, _object["c.d"]);
 }
 
 TEST_F(JsonObject_Iterator_Test, ConstIterator) {
-  const JsonObject& const_object = object;
+  const JsonObject& const_object = _object;
   JsonObject::const_iterator it = const_object.begin();
 
   ASSERT_NE(const_object.end(), it);

test/JsonObject_PrettyPrintTo_Tests.cpp

@@ -9,14 +9,14 @@
 
 class JsonObject_PrettyPrintTo_Tests : public testing::Test {
  public:
-  JsonObject_PrettyPrintTo_Tests() : object(json.createObject()) {}
+  JsonObject_PrettyPrintTo_Tests() : _object(_jsonBuffer.createObject()) {}
 
  protected:
-  StaticJsonBuffer<300> json;
-  JsonObject &object;
+  DynamicJsonBuffer _jsonBuffer;
+  JsonObject &_object;
 
   void outputMustBe(const char *expected) {
-    size_t n = object.prettyPrintTo(buffer, sizeof(buffer));
+    size_t n = _object.prettyPrintTo(buffer, sizeof(buffer));
     EXPECT_STREQ(expected, buffer);
     EXPECT_EQ(strlen(expected), n);
   }
@@ -28,7 +28,7 @@ class JsonObject_PrettyPrintTo_Tests : public testing::Test {
 TEST_F(JsonObject_PrettyPrintTo_Tests, EmptyObject) { outputMustBe("{}"); }
 
 TEST_F(JsonObject_PrettyPrintTo_Tests, OneMember) {
-  object["key"] = "value";
+  _object["key"] = "value";
 
   outputMustBe(
       "{\r\n"
@@ -37,8 +37,8 @@ TEST_F(JsonObject_PrettyPrintTo_Tests, OneMember) {
 }
 
 TEST_F(JsonObject_PrettyPrintTo_Tests, TwoMembers) {
-  object["key1"] = "value1";
-  object["key2"] = "value2";
+  _object["key1"] = "value1";
+  _object["key2"] = "value2";
 
   outputMustBe(
       "{\r\n"
@@ -48,8 +48,8 @@ TEST_F(JsonObject_PrettyPrintTo_Tests, TwoMembers) {
 }
 
 TEST_F(JsonObject_PrettyPrintTo_Tests, EmptyNestedContainers) {
-  object.createNestedObject("key1");
-  object.createNestedArray("key2");
+  _object.createNestedObject("key1");
+  _object.createNestedArray("key2");
 
   outputMustBe(
       "{\r\n"
@@ -59,10 +59,10 @@ TEST_F(JsonObject_PrettyPrintTo_Tests, EmptyNestedContainers) {
 }
 
 TEST_F(JsonObject_PrettyPrintTo_Tests, NestedContainers) {
-  JsonObject &nested1 = object.createNestedObject("key1");
+  JsonObject &nested1 = _object.createNestedObject("key1");
   nested1["a"] = 1;
 
-  JsonArray &nested2 = object.createNestedArray("key2");
+  JsonArray &nested2 = _object.createNestedArray("key2");
   nested2.add(2);
 
   outputMustBe(

test/JsonParser_Array_Tests.cpp

@@ -42,7 +42,7 @@ class JsonParser_Array_Tests : public testing::Test {
     EXPECT_STREQ(expected, _array->at(index).as<const char *>());
   }
 
-  StaticJsonBuffer<256> _jsonBuffer;
+  DynamicJsonBuffer _jsonBuffer;
   JsonArray *_array;
   char _jsonString[256];
 };

test/JsonParser_Nested_Tests.cpp

@@ -8,7 +8,7 @@
 #include <ArduinoJson.h>
 
 TEST(JsonParser_Nested_Tests, ArrayNestedInObject) {
-  StaticJsonBuffer<256> jsonBuffer;
+  DynamicJsonBuffer jsonBuffer;
   char jsonString[] = " { \"ab\" : [ 1 , 2 ] , \"cd\" : [ 3 , 4 ] } ";
 
   JsonObject &object = jsonBuffer.parseObject(jsonString);
@@ -31,7 +31,7 @@ TEST(JsonParser_Nested_Tests, ArrayNestedInObject) {
 }
 
 TEST(JsonParser_Nested_Tests, ObjectNestedInArray) {
-  StaticJsonBuffer<256> jsonBuffer;
+  DynamicJsonBuffer jsonBuffer;
   char jsonString[] =
       " [ { \"a\" : 1 , \"b\" : 2 } , { \"c\" : 3 , \"d\" : 4 } ] ";
 

test/JsonParser_NestingLimit_Tests.cpp

@@ -31,14 +31,14 @@ class JsonParser_NestingLimit_Tests : public testing::Test {
 
  private:
   bool tryParseArray(const char *json) {
-    StaticJsonBuffer<256> buffer;
+    DynamicJsonBuffer buffer;
     char s[256];
     strcpy(s, json);
     return buffer.parseArray(s, _nestingLimit).success();
   }
 
   bool tryParseObject(const char *json) {
-    StaticJsonBuffer<256> buffer;
+    DynamicJsonBuffer buffer;
     char s[256];
     strcpy(s, json);
     return buffer.parseObject(s, _nestingLimit).success();

test/JsonParser_Object_Tests.cpp

@@ -30,7 +30,7 @@ class JsonParser_Object_Test : public testing::Test {
   }
 
  private:
-  StaticJsonBuffer<256> _jsonBuffer;
+  DynamicJsonBuffer _jsonBuffer;
   JsonObject *_object;
   char _jsonString[256];
 };

test/JsonVariant_Copy_Tests.cpp

@@ -9,59 +9,59 @@
 
 class JsonVariant_Copy_Tests : public ::testing::Test {
  protected:
-  StaticJsonBuffer<200> json;
-  JsonVariant variant1;
-  JsonVariant variant2;
+  DynamicJsonBuffer _jsonBuffer;
+  JsonVariant _variant1;
+  JsonVariant _variant2;
 };
 
 TEST_F(JsonVariant_Copy_Tests, IntegersAreCopiedByValue) {
-  variant1 = 123;
-  variant2 = variant1;
-  variant1 = 456;
+  _variant1 = 123;
+  _variant2 = _variant1;
+  _variant1 = 456;
 
-  EXPECT_EQ(123, variant2.as<int>());
+  EXPECT_EQ(123, _variant2.as<int>());
 }
 
 TEST_F(JsonVariant_Copy_Tests, DoublesAreCopiedByValue) {
-  variant1 = 123.45;
-  variant2 = variant1;
-  variant1 = 456.78;
+  _variant1 = 123.45;
+  _variant2 = _variant1;
+  _variant1 = 456.78;
 
-  EXPECT_EQ(123.45, variant2.as<double>());
+  EXPECT_EQ(123.45, _variant2.as<double>());
 }
 
 TEST_F(JsonVariant_Copy_Tests, BooleansAreCopiedByValue) {
-  variant1 = true;
-  variant2 = variant1;
-  variant1 = false;
+  _variant1 = true;
+  _variant2 = _variant1;
+  _variant1 = false;
 
-  EXPECT_TRUE(variant2.as<bool>());
+  EXPECT_TRUE(_variant2.as<bool>());
 }
 
 TEST_F(JsonVariant_Copy_Tests, StringsAreCopiedByValue) {
-  variant1 = "hello";
-  variant2 = variant1;
-  variant1 = "world";
+  _variant1 = "hello";
+  _variant2 = _variant1;
+  _variant1 = "world";
 
-  EXPECT_STREQ("hello", variant2.as<const char *>());
+  EXPECT_STREQ("hello", _variant2.as<const char *>());
 }
 
 TEST_F(JsonVariant_Copy_Tests, ObjectsAreCopiedByReference) {
-  JsonObject &object = json.createObject();
+  JsonObject &object = _jsonBuffer.createObject();
 
-  variant1 = object;
+  _variant1 = object;
 
   object["hello"] = "world";
 
-  EXPECT_EQ(1, variant1.asObject().size());
+  EXPECT_EQ(1, _variant1.asObject().size());
 }
 
 TEST_F(JsonVariant_Copy_Tests, ArraysAreCopiedByReference) {
-  JsonArray &array = json.createArray();
+  JsonArray &array = _jsonBuffer.createArray();
 
-  variant1 = array;
+  _variant1 = array;
 
   array.add("world");
 
-  EXPECT_EQ(1, variant1.asArray().size());
+  EXPECT_EQ(1, _variant1.asArray().size());
 }

test/JsonVariant_Storage_Tests.cpp

@@ -11,18 +11,18 @@ class JsonVariant_Storage_Tests : public ::testing::Test {
  protected:
   template <typename T>
   void testValue(T expected) {
-    actual.set(expected);
-    EXPECT_EQ(expected, actual.as<T>());
+    _actual.set(expected);
+    EXPECT_EQ(expected, _actual.as<T>());
   }
 
   template <typename T>
   void testReference(T &expected) {
-    actual.set(expected);
-    EXPECT_EQ(expected, actual.as<T &>());
+    _actual.set(expected);
+    EXPECT_EQ(expected, _actual.as<T &>());
   }
 
  private:
-  JsonVariant actual;
+  JsonVariant _actual;
 };
 
 TEST_F(JsonVariant_Storage_Tests, Double) { testValue<double>(123.45); }
@@ -41,8 +41,8 @@ TEST_F(JsonVariant_Storage_Tests, ULong) { testValue<unsigned long>(123UL); }
 TEST_F(JsonVariant_Storage_Tests, UShort) { testValue<unsigned short>(123); }
 
 TEST_F(JsonVariant_Storage_Tests, CanStoreObject) {
-  StaticJsonBuffer<200> json;
-  JsonObject &object = json.createObject();
+  DynamicJsonBuffer jsonBuffer;
+  JsonObject &object = jsonBuffer.createObject();
 
   testReference(object);
 }

test/JsonVariant_Subscript_Tests.cpp

@@ -9,56 +9,56 @@
 
 class JsonVariant_Subscript_Tests : public ::testing::Test {
  protected:
-  StaticJsonBuffer<200> buffer;
-  JsonVariant variant;
+  DynamicJsonBuffer _jsonBuffer;
+  JsonVariant _variant;
 };
 
 TEST_F(JsonVariant_Subscript_Tests, Array) {
-  JsonArray &array = buffer.createArray();
+  JsonArray &array = _jsonBuffer.createArray();
   array.add("element at index 0");
   array.add("element at index 1");
 
-  variant = array;
+  _variant = array;
 
-  EXPECT_EQ(2, variant.size());
-  EXPECT_STREQ("element at index 0", variant[0].asString());
-  EXPECT_STREQ("element at index 1", variant[1].asString());
-  EXPECT_FALSE(variant[-1].success());
-  EXPECT_FALSE(variant[3].success());
-  EXPECT_FALSE(variant["0"].success());
+  EXPECT_EQ(2, _variant.size());
+  EXPECT_STREQ("element at index 0", _variant[0].asString());
+  EXPECT_STREQ("element at index 1", _variant[1].asString());
+  EXPECT_FALSE(_variant[-1].success());
+  EXPECT_FALSE(_variant[3].success());
+  EXPECT_FALSE(_variant["0"].success());
 }
 
 TEST_F(JsonVariant_Subscript_Tests, Object) {
-  JsonObject &object = buffer.createObject();
+  JsonObject &object = _jsonBuffer.createObject();
   object["a"] = "element at key \"a\"";
   object["b"] = "element at key \"b\"";
 
-  variant = object;
+  _variant = object;
 
-  EXPECT_EQ(2, variant.size());
-  EXPECT_STREQ("element at key \"a\"", variant["a"].asString());
-  EXPECT_STREQ("element at key \"b\"", variant["b"].asString());
-  EXPECT_FALSE(variant["c"].success());
-  EXPECT_FALSE(variant[0].success());
+  EXPECT_EQ(2, _variant.size());
+  EXPECT_STREQ("element at key \"a\"", _variant["a"].asString());
+  EXPECT_STREQ("element at key \"b\"", _variant["b"].asString());
+  EXPECT_FALSE(_variant["c"].success());
+  EXPECT_FALSE(_variant[0].success());
 }
 
 TEST_F(JsonVariant_Subscript_Tests, Undefined) {
-  variant = JsonVariant();
-  EXPECT_EQ(0, variant.size());
-  EXPECT_FALSE(variant["0"].success());
-  EXPECT_FALSE(variant[0].success());
+  _variant = JsonVariant();
+  EXPECT_EQ(0, _variant.size());
+  EXPECT_FALSE(_variant["0"].success());
+  EXPECT_FALSE(_variant[0].success());
 }
 
 TEST_F(JsonVariant_Subscript_Tests, Invalid) {
-  variant = JsonVariant::invalid();
-  EXPECT_EQ(0, variant.size());
-  EXPECT_FALSE(variant["0"].success());
-  EXPECT_FALSE(variant[0].success());
+  _variant = JsonVariant::invalid();
+  EXPECT_EQ(0, _variant.size());
+  EXPECT_FALSE(_variant["0"].success());
+  EXPECT_FALSE(_variant[0].success());
 }
 
 TEST_F(JsonVariant_Subscript_Tests, String) {
-  variant = "hello world";
-  EXPECT_EQ(0, variant.size());
-  EXPECT_FALSE(variant["0"].success());
-  EXPECT_FALSE(variant[0].success());
+  _variant = "hello world";
+  EXPECT_EQ(0, _variant.size());
+  EXPECT_FALSE(_variant["0"].success());
+  EXPECT_FALSE(_variant[0].success());
 }

test/QuotedString_ExtractFrom_Tests.cpp

@@ -41,6 +41,12 @@ TEST_F(QuotedString_ExtractFrom_Tests, NoQuotes) {
   resultMustBe(0);
 }
 
+TEST_F(QuotedString_ExtractFrom_Tests, MissingClosingQuote) {
+  whenInputIs("\"hello world");
+
+  resultMustBe(0);
+}
+
 TEST_F(QuotedString_ExtractFrom_Tests, EmptySingleQuotedString) {
   whenInputIs("''");
 

test/StringBuilderTests.cpp

@@ -11,18 +11,22 @@ using namespace ArduinoJson::Internals;
 
 class StringBuilderTests : public testing::Test {
  protected:
-  virtual void SetUp() { sb = new StringBuilder(buffer, sizeof(buffer)); }
+  virtual void SetUp() {
+    _stringBuilder = new StringBuilder(_buffer, sizeof(_buffer));
+  }
 
-  void print(const char *value) { returnValue = sb->print(value); }
+  virtual void TearDown() { delete _stringBuilder; }
 
-  void outputMustBe(const char *expected) { EXPECT_STREQ(expected, buffer); }
+  void print(const char *value) { _returnValue = _stringBuilder->print(value); }
 
-  void resultMustBe(size_t expected) { EXPECT_EQ(expected, returnValue); }
+  void outputMustBe(const char *expected) { EXPECT_STREQ(expected, _buffer); }
+
+  void resultMustBe(size_t expected) { EXPECT_EQ(expected, _returnValue); }
 
  private:
-  char buffer[20];
-  Print *sb;
-  size_t returnValue;
+  char _buffer[20];
+  Print *_stringBuilder;
+  size_t _returnValue;
 };
 
 TEST_F(StringBuilderTests, InitialState) { outputMustBe(""); }