feedc0de/Catch2
1
0
Fork 0
forked from catchorg/Catch2
Code Pull Requests Activity

Use Detail::make_unique<T> in more places

Browse Source
This commit is contained in:
Martin Hořeňovský
2021-08-11 22:51:59 +02:00
parent 3ec63324a8
commit 3579c055c8
3 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/catch2/catch_session.cpp
+4 -10
View File
@@ -43,19 +43,13 @@ namespace Catch {
return createReporter(config->getReporterName(), config);
}
// On older platforms, returning unique_ptr<ListeningReporter>
// when the return type is unique_ptr<IStreamingReporter>
// doesn't compile without a std::move call. However, this causes
// a warning on newer platforms. Thus, we have to work around
// it a bit and downcast the pointer manually.
auto ret = Detail::unique_ptr<IStreamingReporter>(new ListeningReporter(config));
auto& multi = static_cast<ListeningReporter&>(*ret);
auto multi = Detail::make_unique<ListeningReporter>(config);
auto const& listeners = Catch::getRegistryHub().getReporterRegistry().getListeners();
for (auto const& listener : listeners) {
multi.addListener(listener->create(Catch::ReporterConfig(config)));
multi->addListener(listener->create(Catch::ReporterConfig(config)));
}
multi.addReporter(createReporter(config->getReporterName(), config));
return ret;
multi->addReporter(createReporter(config->getReporterName(), config));
return multi;
}
class TestGroup {