feedc0de/Catch2
1
0 Fork 0
forked from catchorg/Catch2
Code Pull Requests Activity

Use Catch::StringMaker for output in WithinRelMatcher (#2846)

Browse Source 
The WithinRelMatcher does not listen to the precision specification; it just naively pipes to stringstream. If you specify the precision, that has no impact on the outputted values when the match fails.

This fix makes the WithinRelMatcher listen to the precision (https://github.com/catchorg/Catch2/blob/devel/docs/tostring.md#floating-point-precision) specified by: Catch::StringMaker<float>::precision
This commit is contained in:
Ian Bell authored and GitHub committed 2024-04-15 13:35:39 +02:00
1 parent 029fe3b460
commit 53ddf37af4
9 files changed
+81 -81
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/catch2/matchers/catch_matchers_floating_point.cpp
+1 -1
View File
@@ -176,7 +176,7 @@ namespace Detail {
std::string WithinRelMatcher::describe() const {
Catch::ReusableStringStream sstr;
sstr << "and " << m_target << " are within " << m_epsilon * 100. << "% of each other";
sstr << "and " << ::Catch::Detail::stringify(m_target) << " are within " << m_epsilon * 100. << "% of each other";
return sstr.str();
}