Clean up extraneous copies in Messages

This removes 109 allocations from running `tests/SelfTest`
(437057 -> 436948).
This commit is contained in:
Martin Hořeňovský committed 2023-01-28 22:14:37 +01:00
1 parent 356dfc1439
commit 906552f8c8
6 files changed
+11 -13

No files matched your search

@@ -60,10 +60,9 @@ namespace Catch {
// Copy message into messages list.
// !TBD This should have been done earlier, somewhere
MessageBuilder builder( assertionResult.getTestMacroName(), assertionResult.getSourceInfo(), assertionResult.getResultType() );
builder << assertionResult.getMessage();
builder.m_info.message = builder.m_stream.str();
builder.m_info.message = static_cast<std::string>(assertionResult.getMessage());
infoMessages.push_back( builder.m_info );
infoMessages.push_back( CATCH_MOVE(builder.m_info) );
}
}