feedc0de/Catch2
1
0
Fork 0
forked from catchorg/Catch2
Code Pull Requests Activity

Cleanup StringRef impl a bit

Browse Source
This commit is contained in:
Martin Hořeňovský
2021-11-23 23:16:46 +01:00
parent c95072408f
commit b9baae6d93
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/catch2/internal/catch_stringref.cpp
+5 -5
View File
@@ -17,12 +17,12 @@ namespace Catch {
: StringRef( rawChars, static_cast<StringRef::size_type>(std::strlen(rawChars) ) )
{}
auto StringRef::operator == ( StringRef const& other ) const noexcept -> bool {
auto StringRef::operator == ( StringRef other ) const noexcept -> bool {
return m_size == other.m_size
&& (std::memcmp( m_start, other.m_start, m_size ) == 0);
}
bool StringRef::operator<(StringRef const& rhs) const noexcept {
bool StringRef::operator<(StringRef rhs) const noexcept {
if (m_size < rhs.m_size) {
return strncmp(m_start, rhs.m_start, m_size) <= 0;
}
@@ -50,8 +50,8 @@ namespace Catch {
}
}
auto operator << ( std::ostream& os, StringRef const& str ) -> std::ostream& {
return os.write(str.data(), str.size());
auto operator << ( std::ostream& os, StringRef str ) -> std::ostream& {
return os.write(str.data(), static_cast<std::streamsize>(str.size()));
}
std::string operator+(StringRef lhs, StringRef rhs) {
@@ -62,7 +62,7 @@ namespace Catch {
return ret;
}
auto operator+=( std::string& lhs, StringRef const& rhs ) -> std::string& {
auto operator+=( std::string& lhs, StringRef rhs ) -> std::string& {
lhs.append(rhs.data(), rhs.size());
return lhs;
}