Update CI image to macOS 14

Catch2 has long since required a standard newer than C++98 so we
can safely ignore any warnings related to such old standards.

.bazelrc

@@ -1,6 +1,3 @@
-# Enable Bzlmod for every Bazel command
-common --enable_bzlmod
-
 build --enable_platform_specific_config
 
 build:gcc9 --cxxopt=-std=c++2a

.clang-tidy

@@ -34,7 +34,7 @@ Checks: >-
   -modernize-pass-by-value,
 
   performance-*,
-  performance-enum-size,
+  -performance-enum-size,
 
   portability-*,
 
@@ -49,7 +49,6 @@ Checks: >-
   -readability-implicit-bool-conversion,
   -readability-isolate-declaration,
   -readability-magic-numbers,
-  -readability-math-missing-parentheses, #no, 'a + B * C' obeying math rules is not confusing,
   -readability-named-parameter,
   -readability-qualified-auto,
   -readability-redundant-access-specifiers,

.conan/test_package/CMakeLists.txt

@@ -1,5 +1,5 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.15)
-project(PackageTest LANGUAGES CXX)
+project(PackageTest CXX)
 
 find_package(Catch2 CONFIG REQUIRED)
 

.conan/test_package/conanfile.py

@@ -3,14 +3,12 @@
 from conan import ConanFile
 from conan.tools.cmake import CMake, cmake_layout
 from conan.tools.build import can_run
-from conan.tools.files import save, load
 import os
 
 
 class TestPackageConan(ConanFile):
     settings = "os", "compiler", "build_type", "arch"
-    generators = "CMakeToolchain", "CMakeDeps", "VirtualRunEnv"
+    generators = "CMakeToolchain", "CMakeDeps"
-    test_type = "explicit"
 
     def requirements(self):
         self.requires(self.tested_reference_str)
@@ -18,12 +16,6 @@ class TestPackageConan(ConanFile):
     def layout(self):
         cmake_layout(self)
 
-    def generate(self):
-        save(self, os.path.join(self.build_folder, "package_folder"),
-             self.dependencies[self.tested_reference_str].package_folder)
-        save(self, os.path.join(self.build_folder, "license"),
-             self.dependencies[self.tested_reference_str].license)
-
     def build(self):
         cmake = CMake(self)
         cmake.configure()
@@ -34,7 +26,8 @@ class TestPackageConan(ConanFile):
             cmd = os.path.join(self.cpp.build.bindir, "test_package")
             self.run(cmd, env="conanrun")
 
-            package_folder = load(self, os.path.join(self.build_folder, "package_folder"))
+        # If we are on conan 2 we can check the license info is populated
-            license = load(self, os.path.join(self.build_folder, "license"))
+        if hasattr(self, 'dependencies'):
-            assert os.path.isfile(os.path.join(package_folder, "licenses", "LICENSE.txt"))
+            catch2 = self.dependencies["catch2"]
-            assert license == 'BSL-1.0'
+            assert os.path.exists(f'{catch2.package_folder}/licenses/LICENSE.txt')
+            assert catch2.license == 'BSL-1.0'

.github/workflows/linux-bazel-builds.yml

@@ -1,4 +1,4 @@
-name: Linux Builds (Bazel)
+name: Bazel build
 
 on: [push, pull_request]
 
@@ -7,18 +7,18 @@ jobs:
     name: Linux Ubuntu 22.04 Bazel build <GCC 11.2.0>
     runs-on: ubuntu-22.04
     strategy:
-      fail-fast: false
       matrix:
         compilation_mode: [fastbuild, dbg, opt]
 
     steps:
     - uses: actions/checkout@v4
 
-    - name: Mount Bazel cache
+    - name: Mount bazel cache
       uses: actions/cache@v3
       with:
         path: "/home/runner/.cache/bazel"
         key: bazel-ubuntu22-gcc11
 
-    - name: Build
+    - name: Build Catch2
-      run: bazelisk build --compilation_mode=${{matrix.compilation_mode}} //...
+      run: |
+        bazelisk build --compilation_mode=${{matrix.compilation_mode}} //...

.github/workflows/linux-meson-builds.yml

@@ -1,4 +1,4 @@
-name: Linux Builds (Meson)
+name: Linux builds (meson)
 
 on: [push, pull_request]
 
@@ -7,7 +7,6 @@ jobs:
     name: meson ${{matrix.cxx}}, C++${{matrix.std}}, ${{matrix.build_type}}
     runs-on: ubuntu-22.04
     strategy:
-      fail-fast: false
       matrix:
         cxx:
           - g++-11
@@ -26,7 +25,7 @@ jobs:
         sudo apt-get update
         sudo apt-get install -y meson ninja-build ${{matrix.other_pkgs}}
 
-    - name: Configure
+    - name: Configure build
       env:
         CXX: ${{matrix.cxx}}
         CXXFLAGS: -std=c++${{matrix.std}} ${{matrix.cxxflags}}
@@ -35,10 +34,11 @@ jobs:
       run: |
         meson -Dbuildtype=${{matrix.build_type}} ${{runner.workspace}}/meson-build
 
-    - name: Build
+    - name: Build tests + lib
       working-directory: ${{runner.workspace}}/meson-build
       run: ninja
 
-    - name: Test
+    - name: Run tests
       working-directory: ${{runner.workspace}}/meson-build
-      run: meson test --verbose
+      run: |
+        meson test --verbose

.github/workflows/linux-other-builds.yml

@@ -1,73 +1,72 @@
 # The builds in this file are more complex (e.g. they need custom CMake
 # configuration) and thus are unsuitable to the simple build matrix
 # approach used in simple-builds
-name: Linux Builds (Complex)
+name: Linux builds (complex)
 
 on: [push, pull_request]
 
 jobs:
   build:
     name: ${{matrix.build_description}}, ${{matrix.cxx}}, C++${{matrix.std}} ${{matrix.build_type}}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-20.04
     strategy:
-      fail-fast: false
       matrix:
         # We add builds one by one in this case, because there are no
         # dimensions that are shared across the builds
         include:
 
           # Single surrogate header build
-          - cxx: clang++-14
+          - cxx: clang++-10
             build_description: Surrogates build
             build_type: Debug
             std: 14
-            other_pkgs: clang-14
+            other_pkgs: clang-10
             cmake_configurations: -DCATCH_BUILD_SURROGATES=ON
 
-          # Extras and examples with gcc-11
+          # Extras and examples with gcc-7
-          - cxx: g++-11
+          - cxx: g++-7
             build_description: Extras + Examples
             build_type: Debug
             std: 14
-            other_pkgs: g++-11
+            other_pkgs: g++-7
             cmake_configurations: -DCATCH_BUILD_EXTRA_TESTS=ON -DCATCH_BUILD_EXAMPLES=ON -DCATCH_ENABLE_CMAKE_HELPER_TESTS=ON
-          - cxx: g++-11
+          - cxx: g++-7
             build_description: Extras + Examples
             build_type: Release
             std: 14
-            other_pkgs: g++-11
+            other_pkgs: g++-7
             cmake_configurations: -DCATCH_BUILD_EXTRA_TESTS=ON -DCATCH_BUILD_EXAMPLES=ON -DCATCH_ENABLE_CMAKE_HELPER_TESTS=ON
 
-          # Extras and examples with Clang-14
+          # Extras and examples with Clang-10
-          - cxx: clang++-14
+          - cxx: clang++-10
             build_description: Extras + Examples
             build_type: Debug
             std: 17
-            other_pkgs: clang-14
+            other_pkgs: clang-10
             cmake_configurations: -DCATCH_BUILD_EXTRA_TESTS=ON -DCATCH_BUILD_EXAMPLES=ON -DCATCH_ENABLE_CMAKE_HELPER_TESTS=ON
-          - cxx: clang++-14
+          - cxx: clang++-10
             build_description: Extras + Examples
             build_type: Release
             std: 17
-            other_pkgs: clang-14
+            other_pkgs: clang-10
             cmake_configurations: -DCATCH_BUILD_EXTRA_TESTS=ON -DCATCH_BUILD_EXAMPLES=ON -DCATCH_ENABLE_CMAKE_HELPER_TESTS=ON
 
-          # Configure tests with Clang-14
+          # Configure tests with Clang-10
-          - cxx: clang++-14
+          - cxx: clang++-10
             build_description: CMake configuration tests
             build_type: Debug
             std: 14
-            other_pkgs: clang-14
+            other_pkgs: clang-10
             cmake_configurations: -DCATCH_ENABLE_CONFIGURE_TESTS=ON
 
-          # Valgrind test Clang-14
+          # Valgrind test Clang-10
-          # - cxx: clang++-14
+          - cxx: clang++-10
-          #   build_description: Valgrind tests
+            build_description: Valgrind tests
-          #   build_type: Debug
+            build_type: Debug
-          #   std: 14
+            std: 14
-          #   other_pkgs: clang-14 valgrind
+            other_pkgs: clang-10 valgrind
-          #   cmake_configurations: -DMEMORYCHECK_COMMAND=`which valgrind` -DMEMORYCHECK_COMMAND_OPTIONS="-q --track-origins=yes --leak-check=full --num-callers=50 --show-leak-kinds=definite --error-exitcode=1"
+            cmake_configurations: -DMEMORYCHECK_COMMAND=`which valgrind` -DMEMORYCHECK_COMMAND_OPTIONS="-q --track-origins=yes --leak-check=full --num-callers=50 --show-leak-kinds=definite --error-exitcode=1"
-          #   other_ctest_args: -T memcheck -LE uses-python
+            other_ctest_args: -T memcheck -LE uses-python
 
 
     steps:
@@ -79,51 +78,77 @@ jobs:
         sudo apt-get install -y ninja-build ${{matrix.other_pkgs}}
 
     - name: Configure build
+      working-directory: ${{runner.workspace}}
+      env:
+        CXX: ${{matrix.cxx}}
+        CXXFLAGS: ${{matrix.cxxflags}}
       # Note: $GITHUB_WORKSPACE is distinct from ${{runner.workspace}}.
       #       This is important
       run: |
-        cmake --preset basic-tests -GNinja \
+        cmake -Bbuild -H$GITHUB_WORKSPACE \
               -DCMAKE_BUILD_TYPE=${{matrix.build_type}} \
-              -DCMAKE_CXX_COMPILER=${{matrix.cxx}} \
               -DCMAKE_CXX_STANDARD=${{matrix.std}} \
-              ${{matrix.cmake_configurations}}
+              -DCMAKE_CXX_STANDARD_REQUIRED=ON \
+              -DCMAKE_CXX_EXTENSIONS=OFF \
+              -DCATCH_DEVELOPMENT_BUILD=ON \
+              ${{matrix.cmake_configurations}} \
+              -G Ninja
 
-    - name: Build
+    - name: Build tests + lib
-      run: cmake --build build
+      working-directory: ${{runner.workspace}}/build
-
+      run: ninja
-    - name: Test
-      run: ctest --test-dir build -j --output-on-failure
 
+    - name: Run tests
+      env:
+          CTEST_OUTPUT_ON_FAILURE: 1
+      working-directory: ${{runner.workspace}}/build
+      run: ctest -C ${{matrix.build_type}} -j `nproc` ${{matrix.other_ctest_args}}
   clang-tidy:
-    name: clang-tidy
+    name: clang-tidy ${{matrix.version}}, ${{matrix.build_description}}, C++${{matrix.std}} ${{matrix.build_type}}
     runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        include:
+          - version: "15"
+            build_description: all
+            build_type: Debug
+            std: 17
+            other_pkgs: ''
+            cmake_configurations: -DCATCH_BUILD_EXAMPLES=ON -DCATCH_ENABLE_CMAKE_HELPER_TESTS=ON
     steps:
     - uses: actions/checkout@v4
 
     - name: Prepare environment
       run: |
         sudo apt-get update
-        sudo apt-get install -y ninja-build clang-15 clang-tidy-15
+        sudo apt-get install -y ninja-build clang-${{matrix.version}} clang-tidy-${{matrix.version}} ${{matrix.other_pkgs}}
 
-    - name: Configure
+    - name: Configure build
+      working-directory: ${{runner.workspace}}
+      env:
+        CXX: clang++-${{matrix.version}}
+        CXXFLAGS: ${{matrix.cxxflags}}
       # Note: $GITHUB_WORKSPACE is distinct from ${{runner.workspace}}.
       #       This is important
       run: |
-        clangtidy="clang-tidy-15;-use-color"
+        clangtidy="clang-tidy-${{matrix.version}};-use-color"
         # Use a dummy compiler/linker/ar/ranlib to effectively disable the
         # compilation and only run clang-tidy.
-        cmake --preset basic-tests -GNinja \
+        cmake -Bbuild -H$GITHUB_WORKSPACE \
-              -DCMAKE_AR=/usr/bin/true \
+              -DCMAKE_BUILD_TYPE=${{matrix.build_type}} \
-              -DCMAKE_BUILD_TYPE=Debug \
+              -DCMAKE_CXX_STANDARD=${{matrix.std}} \
+              -DCMAKE_CXX_STANDARD_REQUIRED=ON \
+              -DCMAKE_CXX_EXTENSIONS=OFF \
+              -DCATCH_DEVELOPMENT_BUILD=ON \
               -DCMAKE_CXX_CLANG_TIDY="$clangtidy" \
-              -DCMAKE_CXX_COMPILER_AR=/usr/bin/true \
               -DCMAKE_CXX_COMPILER_LAUNCHER=/usr/bin/true \
-              -DCMAKE_CXX_COMPILER=clang++-15 \
+              -DCMAKE_AR=/usr/bin/true \
-              -DCMAKE_CXX_LINK_EXECUTABLE=/usr/bin/true \
+              -DCMAKE_CXX_COMPILER_AR=/usr/bin/true \
-              -DCMAKE_CXX_STANDARD=17 \
               -DCMAKE_RANLIB=/usr/bin/true \
-              -DCATCH_BUILD_EXAMPLES=ON \
+              -DCMAKE_CXX_LINK_EXECUTABLE=/usr/bin/true \
-              -DCATCH_ENABLE_CMAKE_HELPER_TESTS=ON
+              ${{matrix.cmake_configurations}} \
+              -G Ninja
 
     - name: Run clang-tidy
-      run: cmake --build build
+      working-directory: ${{runner.workspace}}/build
+      run: ninja

.github/workflows/linux-simple-builds.yml

@@ -1,30 +1,23 @@
-name: Linux Builds (Basic)
+name: Linux builds (basic)
 
 on: [push, pull_request]
 
 jobs:
   build:
     name: ${{matrix.cxx}}, C++${{matrix.std}}, ${{matrix.build_type}}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-20.04
     strategy:
-      fail-fast: false
       matrix:
         cxx:
           - g++-7
           - g++-8
           - g++-9
           - g++-10
-          - g++-11
-          - g++-12
           - clang++-6.0
           - clang++-7
           - clang++-8
           - clang++-9
           - clang++-10
-          - clang++-11
-          - clang++-12
-          - clang++-13
-          - clang++-14
         build_type: [Debug, Release]
         std: [14]
         include:
@@ -36,10 +29,6 @@ jobs:
             other_pkgs: g++-9
           - cxx: g++-10
             other_pkgs: g++-10
-          - cxx: g++-11
-            other_pkgs: g++-11
-          - cxx: g++-12
-            other_pkgs: g++-12
           - cxx: clang++-6.0
             other_pkgs: clang-6.0
           - cxx: clang++-7
@@ -50,64 +39,79 @@ jobs:
             other_pkgs: clang-9
           - cxx: clang++-10
             other_pkgs: clang-10
-          - cxx: clang++-11
+          # Clang 6 + C++17
-            other_pkgs: clang-11
+          # does not work with the default libstdc++ version thanks
-          - cxx: clang++-12
+          # to a disagreement on variant implementation.
-            other_pkgs: clang-12
+          # - cxx: clang++-6.0
-          - cxx: clang++-13
+          #   build_type: Debug
-            other_pkgs: clang-13
+          #   std: 17
-          - cxx: clang++-14
+          #   other_pkgs: clang-6.0
-            other_pkgs: clang-14
+          # - cxx: clang++-6.0
-          # Clang 14 + C++17
+          #   build_type: Release
-          - cxx: clang++-14
+          #   std: 17
+          #   other_pkgs: clang-6.0
+          # Clang 10 + C++17
+          - cxx: clang++-10
             build_type: Debug
             std: 17
-            other_pkgs: clang-14
+            other_pkgs: clang-10
-          - cxx: clang++-14
+          - cxx: clang++-10
             build_type: Release
             std: 17
-            other_pkgs: clang-14
+            other_pkgs: clang-10
-          - cxx: clang++-14
+          - cxx: clang++-10
             build_type: Debug
             std: 20
-            other_pkgs: clang-14
+            other_pkgs: clang-10
-          - cxx: clang++-14
+          - cxx: clang++-10
             build_type: Release
             std: 20
-            other_pkgs: clang-14
+            other_pkgs: clang-10
-          - cxx: g++-11
+          - cxx: g++-10
             build_type: Debug
             std: 20
-            other_pkgs: g++-11
+            other_pkgs: g++-10
-          - cxx: g++-11
+          - cxx: g++-10
             build_type: Release
             std: 20
-            other_pkgs: g++-11
+            other_pkgs: g++-10
 
     steps:
     - uses: actions/checkout@v4
 
-    - name: Add repositories for older compilers
+    - name: Add repositories for older GCC
       run: |
-        sudo apt-add-repository 'deb http://azure.archive.ubuntu.com/ubuntu/ focal main'
+        sudo apt-add-repository 'deb http://azure.archive.ubuntu.com/ubuntu/ bionic main'
-        sudo apt-add-repository 'deb http://azure.archive.ubuntu.com/ubuntu/ focal universe'
+        sudo apt-add-repository 'deb http://azure.archive.ubuntu.com/ubuntu/ bionic universe'
+      if: ${{ matrix.cxx == 'g++-5' || matrix.cxx == 'g++-6' }}
 
     - name: Prepare environment
       run: |
         sudo apt-get update
         sudo apt-get install -y ninja-build ${{matrix.other_pkgs}}
 
-    - name: Configure
+    - name: Configure build
+      working-directory: ${{runner.workspace}}
+      env:
+        CXX: ${{matrix.cxx}}
+        CXXFLAGS: ${{matrix.cxxflags}}
       # Note: $GITHUB_WORKSPACE is distinct from ${{runner.workspace}}.
       #       This is important
       run: |
-        cmake --preset basic-tests -GNinja \
+        cmake -Bbuild -H$GITHUB_WORKSPACE \
               -DCMAKE_BUILD_TYPE=${{matrix.build_type}} \
-              -DCMAKE_CXX_COMPILER=${{matrix.cxx}} \
+              -DCMAKE_CXX_STANDARD=${{matrix.std}} \
-              -DCMAKE_CXX_STANDARD=${{matrix.std}}
+              -DCMAKE_CXX_STANDARD_REQUIRED=ON \
+              -DCMAKE_CXX_EXTENSIONS=OFF \
+              -DCATCH_DEVELOPMENT_BUILD=ON \
+              -G Ninja
 
-    - name: Build
+    - name: Build tests + lib
-      run: cmake --build build
+      working-directory: ${{runner.workspace}}/build
+      run: ninja
 
-    - name: Test
+    - name: Run tests
-      run: ctest --test-dir build -j --output-on-failure
+      env:
+          CTEST_OUTPUT_ON_FAILURE: 1
+      working-directory: ${{runner.workspace}}/build
+      run: ctest -C ${{matrix.build_type}} -j `nproc`

.github/workflows/mac-builds.yml

@@ -1,32 +1,47 @@
-name: Mac Builds
+name: Mac builds
 
 on: [push, pull_request]
 
 jobs:
   build:
-    # From macos-14 forward, the baseline "macos-X" image is Arm based,
+    runs-on: macos-14
-    # and not Intel based.
-    runs-on: ${{matrix.image}}
     strategy:
-      fail-fast: false
       matrix:
-        image: [macos-13, macos-14, macos-15]
+        cxx:
+          - g++-11
+          - clang++
         build_type: [Debug, Release]
         std: [14, 17]
+        include:
+          - build_type: Debug
+            examples: ON
+            extra_tests: ON
 
     steps:
     - uses: actions/checkout@v4
 
-    - name: Configure
+    - name: Configure build
+      working-directory: ${{runner.workspace}}
+      env:
+        CXX: ${{matrix.cxx}}
+        CXXFLAGS: ${{matrix.cxxflags}}
+      # Note: $GITHUB_WORKSPACE is distinct from ${{runner.workspace}}.
+      #       This is important
       run: |
-        cmake --preset basic-tests -GNinja \
+        cmake -Bbuild -H$GITHUB_WORKSPACE \
               -DCMAKE_BUILD_TYPE=${{matrix.build_type}} \
               -DCMAKE_CXX_STANDARD=${{matrix.std}} \
-              -DCATCH_BUILD_EXAMPLES=ON \
+              -DCMAKE_CXX_STANDARD_REQUIRED=ON \
-              -DCATCH_BUILD_EXTRA_TESTS=ON
+              -DCATCH_DEVELOPMENT_BUILD=ON \
+              -DCATCH_BUILD_EXAMPLES=${{matrix.examples}} \
+              -DCATCH_BUILD_EXTRA_TESTS=${{matrix.examples}}
 
-    - name: Build
+    - name: Build tests + lib
-      run: cmake --build build
+      working-directory: ${{runner.workspace}}/build
+      run: make -j `sysctl -n hw.ncpu`
 
-    - name: Test
+    - name: Run tests
-      run: ctest --test-dir build -j --output-on-failure
+      env:
+          CTEST_OUTPUT_ON_FAILURE: 1
+      working-directory: ${{runner.workspace}}/build
+      run: ctest -C ${{matrix.build_type}} -j `sysctl -n hw.ncpu`

.github/workflows/package-manager-builds.yaml

@@ -5,16 +5,16 @@ on: [push, pull_request]
 jobs:
   conan_builds:
     name: Conan ${{matrix.conan_version}}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-20.04
     strategy:
       matrix:
         conan_version:
-          - '1.63'
+          - '1.62'
-          - '2.1'
+          - '2.0'
 
         include:
           # Conan 1 has default profiles installed
-          - conan_version: '1.63'
+          - conan_version: '1.62'
             profile_generate: 'false'
 
     steps:

.github/workflows/validate-header-guards.yml

@@ -5,7 +5,7 @@ on: [push, pull_request]
 jobs:
   build:
     # Set the type of machine to run on
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-20.04
     steps:
 
       - name: Checkout source code

.github/workflows/windows-simple-builds.yml

@@ -1,4 +1,4 @@
-name: Windows Builds (Basic)
+name: Windows builds (basic)
 
 on: [push, pull_request]
 
@@ -7,9 +7,8 @@ jobs:
     name: ${{matrix.os}}, ${{matrix.std}}, ${{matrix.build_type}}, ${{matrix.platform}}
     runs-on: ${{matrix.os}}
     strategy:
-      fail-fast: false
       matrix:
-        os: [windows-2019, windows-2022, windows-2025]
+        os: [windows-2019, windows-2022]
         platform: [Win32, x64]
         build_type: [Debug, Release]
         std: [14, 17]
@@ -17,15 +16,22 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Configure build
+        working-directory: ${{runner.workspace}}
         run: |
-          cmake --preset all-tests `
+          cmake -S $Env:GITHUB_WORKSPACE               `
-                -A ${{matrix.platform}} `
+                -B ${{runner.workspace}}/build         `
-                -DCMAKE_CXX_STANDARD=${{matrix.std}} `
+                -DCMAKE_CXX_STANDARD=${{matrix.std}}   `
+                -A ${{matrix.platform}}                `
+                --preset all-tests
 
       - name: Build tests
+        working-directory: ${{runner.workspace}}
         run: cmake --build build --config ${{matrix.build_type}} --parallel %NUMBER_OF_PROCESSORS%
         shell: cmd
 
       - name: Run tests
-        run: ctest --test-dir build -C ${{matrix.build_type}} -j %NUMBER_OF_PROCESSORS% --output-on-failure
+        working-directory: ${{runner.workspace}}/build
+        env:
+            CTEST_OUTPUT_ON_FAILURE: 1
+        run: ctest -C ${{matrix.build_type}} -j %NUMBER_OF_PROCESSORS%
         shell: cmd

.gitignore

@@ -25,9 +25,8 @@ Build
 cmake-build-*
 benchmark-dir
 .conan/test_package/build
-**/CMakeUserPresets.json
+.conan/test_package/CMakeUserPresets.json
 bazel-*
-MODULE.bazel.lock
 build-fuzzers
 debug-build
 .vscode
@@ -37,4 +36,3 @@ msvc-sln*
 docs/doxygen
 *.cache
 compile_commands.json
-**/*.unapproved.txt

BUILD.bazel

@@ -56,8 +56,6 @@ expand_template(
         "#cmakedefine CATCH_CONFIG_WCHAR": "",
         "#cmakedefine CATCH_CONFIG_WINDOWS_CRTDBG": "",
         "#cmakedefine CATCH_CONFIG_WINDOWS_SEH": "",
-        "#cmakedefine CATCH_CONFIG_USE_BUILTIN_CONSTANT_P": "",
-        "#cmakedefine CATCH_CONFIG_NO_USE_BUILTIN_CONSTANT_P": "",
     },
     template = "src/catch2/catch_user_config.hpp.in",
 )
@@ -68,7 +66,7 @@ expand_template(
 cc_library(
     name = "catch2_generated",
     hdrs = ["catch2/catch_user_config.hpp"],
-    include_prefix = ".",  # to manipulate -I of dependencies
+    include_prefix = ".",  # to manipulate -I of dependenices
     visibility = ["//visibility:public"],
 )
 

CMake/Catch2Config.cmake.in

@@ -1,9 +1,10 @@
 @PACKAGE_INIT@
 
+
 # Avoid repeatedly including the targets
 if(NOT TARGET Catch2::Catch2)
-  # Provide path for scripts
+    # Provide path for scripts
-  list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}")
+    list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}")
 
-  include(${CMAKE_CURRENT_LIST_DIR}/Catch2Targets.cmake)
+    include(${CMAKE_CURRENT_LIST_DIR}/Catch2Targets.cmake)
 endif()

CMake/CatchConfigOptions.cmake

@@ -14,6 +14,7 @@
 #
 # For detailed docs look into docs/configuration.md
 
+
 macro(AddOverridableConfigOption OptionBaseName)
   option(CATCH_CONFIG_${OptionBaseName} "Read docs/configuration.md for details" OFF)
   option(CATCH_CONFIG_NO_${OptionBaseName} "Read docs/configuration.md for details" OFF)
@@ -43,7 +44,6 @@ set(_OverridableOptions
   "WINDOWS_SEH"
   "GETENV"
   "EXPERIMENTAL_STATIC_ANALYSIS_SUPPORT"
-  "USE_BUILTIN_CONSTANT_P"
 )
 
 foreach(OptionName ${_OverridableOptions})
@@ -73,9 +73,9 @@ foreach(OptionName ${_OtherConfigOptions})
   AddConfigOption(${OptionName})
 endforeach()
 if(DEFINED BUILD_SHARED_LIBS)
-  set(CATCH_CONFIG_SHARED_LIBRARY ${BUILD_SHARED_LIBS})
+    set(CATCH_CONFIG_SHARED_LIBRARY ${BUILD_SHARED_LIBS})
 else()
-  set(CATCH_CONFIG_SHARED_LIBRARY "")
+    set(CATCH_CONFIG_SHARED_LIBRARY "")
 endif()
 
 set(CATCH_CONFIG_DEFAULT_REPORTER "console" CACHE STRING "Read docs/configuration.md for details. The name of the reporter should be without quotes.")

CMake/CatchMiscFunctions.cmake

@@ -8,107 +8,107 @@
 
 include(CheckCXXCompilerFlag)
 function(add_cxx_flag_if_supported_to_targets flagname targets)
-  string(MAKE_C_IDENTIFIER ${flagname} flag_identifier)
+    string(MAKE_C_IDENTIFIER ${flagname} flag_identifier )
-  check_cxx_compiler_flag("${flagname}" HAVE_FLAG_${flag_identifier})
+    check_cxx_compiler_flag("${flagname}" HAVE_FLAG_${flag_identifier})
 
-  if(HAVE_FLAG_${flag_identifier})
+    if (HAVE_FLAG_${flag_identifier})
-    foreach(target ${targets})
+        foreach(target ${targets})
-      target_compile_options(${target} PRIVATE ${flagname})
+            target_compile_options(${target} PRIVATE ${flagname})
-    endforeach()
+        endforeach()
-  endif()
+    endif()
 endfunction()
 
 # Assumes that it is only called for development builds, where warnings
 # and Werror is desired, so it also enables Werror.
 function(add_warnings_to_targets targets)
-  LIST(LENGTH targets TARGETS_LEN)
+    LIST(LENGTH targets TARGETS_LEN)
-  # For now we just assume 2 possibilities: msvc and msvc-like compilers,
+    # For now we just assume 2 possibilities: msvc and msvc-like compilers,
-  # and other.
+    # and other.
-  if(MSVC)
+    if (MSVC)
-    foreach(target ${targets})
+        foreach(target ${targets})
-      # Force MSVC to consider everything as encoded in utf-8
+            # Force MSVC to consider everything as encoded in utf-8
-      target_compile_options(${target} PRIVATE /utf-8)
+            target_compile_options( ${target} PRIVATE /utf-8 )
-      # Enable Werror equivalent
+            # Enable Werror equivalent
-      if(CATCH_ENABLE_WERROR)
+            if (CATCH_ENABLE_WERROR)
-        target_compile_options(${target} PRIVATE /WX)
+                target_compile_options( ${target} PRIVATE /WX )
-      endif()
+            endif()
 
-      # MSVC is currently handled specially
+            # MSVC is currently handled specially
-      if(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
+            if ( CMAKE_CXX_COMPILER_ID MATCHES "MSVC" )
-        STRING(REGEX REPLACE "/W[0-9]" "/W4" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) # override default warning level
+                STRING(REGEX REPLACE "/W[0-9]" "/W4" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) # override default warning level
-        target_compile_options(${target} PRIVATE /w44265 /w44061 /w44062 /w45038)
+                target_compile_options( ${target} PRIVATE /w44265 /w44061 /w44062 /w45038 )
-      endif()
+            endif()
-    endforeach()
+        endforeach()
-  endif()
 
-  if(NOT MSVC)
-    set(CHECKED_WARNING_FLAGS
-      "-Wabsolute-value"
-      "-Wall"
-      "-Wcall-to-pure-virtual-from-ctor-dtor"
-      "-Wcast-align"
-      "-Wcatch-value"
-      "-Wdangling"
-      "-Wdeprecated"
-      "-Wdeprecated-register"
-      "-Wexceptions"
-      "-Wexit-time-destructors"
-      "-Wextra"
-      "-Wextra-semi"
-      "-Wfloat-equal"
-      "-Wglobal-constructors"
-      "-Winit-self"
-      "-Wmisleading-indentation"
-      "-Wmismatched-new-delete"
-      "-Wmismatched-return-types"
-      "-Wmismatched-tags"
-      "-Wmissing-braces"
-      "-Wmissing-declarations"
-      "-Wmissing-noreturn"
-      "-Wmissing-prototypes"
-      "-Wmissing-variable-declarations"
-      "-Wnon-virtual-dtor"
-      "-Wnull-dereference"
-      "-Wold-style-cast"
-      "-Woverloaded-virtual"
-      "-Wparentheses"
-      "-Wpedantic"
-      "-Wredundant-decls"
-      "-Wreorder"
-      "-Wreturn-std-move"
-      "-Wshadow"
-      "-Wstrict-aliasing"
-      "-Wsubobject-linkage"
-      "-Wsuggest-destructor-override"
-      "-Wsuggest-override"
-      "-Wundef"
-      "-Wuninitialized"
-      "-Wunneeded-internal-declaration"
-      "-Wunreachable-code-aggressive"
-      "-Wunused"
-      "-Wunused-function"
-      "-Wunused-parameter"
-      "-Wvla"
-      "-Wweak-vtables"
-
-      # This is a useful warning, but our tests sometimes rely on
-      # functions being present, but not picked (e.g. various checks
-      # for stringification implementation ordering).
-      # Ergo, we should use it every now and then, but we cannot
-      # enable it by default.
-      # "-Wunused-member-function"
-    )
-    foreach(warning ${CHECKED_WARNING_FLAGS})
-      add_cxx_flag_if_supported_to_targets(${warning} "${targets}")
-    endforeach()
-
-    if(CATCH_ENABLE_WERROR)
-      foreach(target ${targets})
-        # Enable Werror equivalent
-        target_compile_options(${target} PRIVATE -Werror)
-      endforeach()
     endif()
-  endif()
+
+    if (NOT MSVC)
+        set(CHECKED_WARNING_FLAGS
+          "-Wabsolute-value"
+          "-Wall"
+          "-Wcall-to-pure-virtual-from-ctor-dtor"
+          "-Wcast-align"
+          "-Wcatch-value"
+          "-Wdangling"
+          "-Wdeprecated"
+          "-Wdeprecated-register"
+          "-Wexceptions"
+          "-Wexit-time-destructors"
+          "-Wextra"
+          "-Wextra-semi"
+          "-Wfloat-equal"
+          "-Wglobal-constructors"
+          "-Winit-self"
+          "-Wmisleading-indentation"
+          "-Wmismatched-new-delete"
+          "-Wmismatched-return-types"
+          "-Wmismatched-tags"
+          "-Wmissing-braces"
+          "-Wmissing-declarations"
+          "-Wmissing-noreturn"
+          "-Wmissing-prototypes"
+          "-Wmissing-variable-declarations"
+          "-Wnull-dereference"
+          "-Wold-style-cast"
+          "-Woverloaded-virtual"
+          "-Wparentheses"
+          "-Wpedantic"
+          "-Wredundant-decls"
+          "-Wreorder"
+          "-Wreturn-std-move"
+          "-Wshadow"
+          "-Wstrict-aliasing"
+          "-Wsubobject-linkage"
+          "-Wsuggest-destructor-override"
+          "-Wsuggest-override"
+          "-Wundef"
+          "-Wuninitialized"
+          "-Wunneeded-internal-declaration"
+          "-Wunreachable-code-aggressive"
+          "-Wunused"
+          "-Wunused-function"
+          "-Wunused-parameter"
+          "-Wvla"
+          "-Wweak-vtables"
+
+          # This is a useful warning, but our tests sometimes rely on
+          # functions being present, but not picked (e.g. various checks
+          # for stringification implementation ordering).
+          # Ergo, we should use it every now and then, but we cannot
+          # enable it by default.
+          # "-Wunused-member-function"
+        )
+        foreach(warning ${CHECKED_WARNING_FLAGS})
+            add_cxx_flag_if_supported_to_targets(${warning} "${targets}")
+        endforeach()
+
+        if (CATCH_ENABLE_WERROR)
+            foreach(target ${targets})
+                # Enable Werror equivalent
+                target_compile_options( ${target} PRIVATE -Werror )
+            endforeach()
+        endif()
+    endif()
 endfunction()
 
 # Adds flags required for reproducible build to the target

CMakeLists.txt

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.10)
 
 # detect if Catch is being bundled,
 # disable testsuite in that case
@@ -8,8 +8,6 @@ else()
   set(NOT_SUBPROJECT OFF)
 endif()
 
-set_property(GLOBAL PROPERTY USE_FOLDERS ON)
-
 option(CATCH_INSTALL_DOCS "Install documentation alongside library" ON)
 option(CATCH_INSTALL_EXTRAS "Install extras (CMake scripts, debugger helpers) alongside library" ON)
 option(CATCH_DEVELOPMENT_BUILD "Build tests, enable warnings, enable Werror, etc" OFF)
@@ -26,26 +24,30 @@ cmake_dependent_option(CATCH_BUILD_SURROGATES "Enable generating and building su
 cmake_dependent_option(CATCH_ENABLE_CONFIGURE_TESTS "Enable CMake configuration tests. WARNING: VERY EXPENSIVE" OFF "CATCH_DEVELOPMENT_BUILD" OFF)
 cmake_dependent_option(CATCH_ENABLE_CMAKE_HELPER_TESTS "Enable CMake helper tests. WARNING: VERY EXPENSIVE" OFF "CATCH_DEVELOPMENT_BUILD" OFF)
 
+
 # Catch2's build breaks if done in-tree. You probably should not build
 # things in tree anyway, but we can allow projects that include Catch2
 # as a subproject to build in-tree as long as it is not in our tree.
-if(CMAKE_BINARY_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
+if (CMAKE_BINARY_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
-  message(FATAL_ERROR "Building in-source is not supported! Create a build dir and remove ${CMAKE_SOURCE_DIR}/CMakeCache.txt")
+    message(FATAL_ERROR "Building in-source is not supported! Create a build dir and remove ${CMAKE_SOURCE_DIR}/CMakeCache.txt")
 endif()
 
 project(Catch2
-  VERSION 3.8.1 # CML version placeholder, don't delete
+  VERSION 3.5.3 # CML version placeholder, don't delete
   LANGUAGES CXX
-  HOMEPAGE_URL "https://github.com/catchorg/Catch2"
+  # HOMEPAGE_URL is not supported until CMake version 3.12, which
+  # we do not target yet.
+  # HOMEPAGE_URL "https://github.com/catchorg/Catch2"
   DESCRIPTION "A modern, C++-native, unit test framework."
 )
 
+
 # Provide path for scripts. We first add path to the scripts we don't use,
 # but projects including us might, and set the path up to parent scope.
 # Then we also add path that we use to configure the project, but is of
 # no use to top level projects.
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/extras")
-if(NOT NOT_SUBPROJECT)
+if (NOT NOT_SUBPROJECT)
   set(CMAKE_MODULE_PATH "${CMAKE_MODULE_PATH}" PARENT_SCOPE)
 endif()
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/CMake")
@@ -66,129 +68,136 @@ set(CATCH_CMAKE_CONFIG_DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/Catch2")
 # are built during these tests, so this is required here, before
 # the subdirectories are added.
 if(CATCH_TEST_USE_WMAIN)
-  set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /ENTRY:wmainCRTStartup")
+    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /ENTRY:wmainCRTStartup")
 endif()
 
+
 # Basic paths
 set(CATCH_DIR ${CMAKE_CURRENT_SOURCE_DIR})
 set(SOURCES_DIR ${CATCH_DIR}/src/catch2)
 set(SELF_TEST_DIR ${CATCH_DIR}/tests/SelfTest)
+set(BENCHMARK_DIR ${CATCH_DIR}/tests/Benchmark)
+set(EXAMPLES_DIR ${CATCH_DIR}/examples)
 
 # We need to bring-in the variables defined there to this scope
 add_subdirectory(src)
 
 # Build tests only if requested
-if(BUILD_TESTING AND CATCH_BUILD_TESTING AND NOT_SUBPROJECT)
+if (BUILD_TESTING AND CATCH_BUILD_TESTING AND NOT_SUBPROJECT)
-  find_package(PythonInterp 3 REQUIRED)
+    find_package(PythonInterp 3 REQUIRED)
-  if(NOT PYTHONINTERP_FOUND)
+    if (NOT PYTHONINTERP_FOUND)
-    message(FATAL_ERROR "Python not found, but required for tests")
+        message(FATAL_ERROR "Python not found, but required for tests")
-  endif()
+    endif()
-  set(CMAKE_FOLDER "tests")
+    add_subdirectory(tests)
-  add_subdirectory(tests)
 endif()
 
 if(CATCH_BUILD_EXAMPLES)
-  set(CMAKE_FOLDER "Examples")
+    add_subdirectory(examples)
-  add_subdirectory(examples)
 endif()
 
 if(CATCH_BUILD_EXTRA_TESTS)
-  set(CMAKE_FOLDER "tests/ExtraTests")
+    add_subdirectory(tests/ExtraTests)
-  add_subdirectory(tests/ExtraTests)
 endif()
 
 if(CATCH_BUILD_FUZZERS)
-  set(CMAKE_FOLDER "fuzzing")
+    add_subdirectory(fuzzing)
-  add_subdirectory(fuzzing)
 endif()
 
-if(CATCH_DEVELOPMENT_BUILD)
+if (CATCH_DEVELOPMENT_BUILD)
-  add_warnings_to_targets("${CATCH_WARNING_TARGETS}")
+    add_warnings_to_targets("${CATCH_WARNING_TARGETS}")
 endif()
 
 # Only perform the installation steps when Catch is not being used as
 # a subproject via `add_subdirectory`, or the destinations will break,
 # see https://github.com/catchorg/Catch2/issues/1373
-if(NOT_SUBPROJECT)
+if (NOT_SUBPROJECT)
-  configure_package_config_file(
+    configure_package_config_file(
-    ${CMAKE_CURRENT_LIST_DIR}/CMake/Catch2Config.cmake.in
+        ${CMAKE_CURRENT_LIST_DIR}/CMake/Catch2Config.cmake.in
-    ${CMAKE_CURRENT_BINARY_DIR}/Catch2Config.cmake
+        ${CMAKE_CURRENT_BINARY_DIR}/Catch2Config.cmake
-    INSTALL_DESTINATION
+        INSTALL_DESTINATION
-      ${CATCH_CMAKE_CONFIG_DESTINATION}
+          ${CATCH_CMAKE_CONFIG_DESTINATION}
-  )
+    )
-
+
-  write_basic_package_version_file(
+    write_basic_package_version_file(
-    "${CMAKE_CURRENT_BINARY_DIR}/Catch2ConfigVersion.cmake"
+      "${CMAKE_CURRENT_BINARY_DIR}/Catch2ConfigVersion.cmake"
-    COMPATIBILITY
+      COMPATIBILITY
-      SameMajorVersion
+        SameMajorVersion
-  )
-
-  install(
-    FILES
-      "${CMAKE_CURRENT_BINARY_DIR}/Catch2Config.cmake"
-      "${CMAKE_CURRENT_BINARY_DIR}/Catch2ConfigVersion.cmake"
-    DESTINATION
-      ${CATCH_CMAKE_CONFIG_DESTINATION}
-  )
-
-  # Install documentation
-  if(CATCH_INSTALL_DOCS)
-    install(
-      DIRECTORY
-        docs/
-      DESTINATION
-        "${CMAKE_INSTALL_DOCDIR}"
-      PATTERN "doxygen" EXCLUDE
     )
-  endif()
 
-  if(CATCH_INSTALL_EXTRAS)
-    # Install CMake scripts
     install(
       FILES
-        "extras/ParseAndAddCatchTests.cmake"
+        "${CMAKE_CURRENT_BINARY_DIR}/Catch2Config.cmake"
-        "extras/Catch.cmake"
+        "${CMAKE_CURRENT_BINARY_DIR}/Catch2ConfigVersion.cmake"
-        "extras/CatchAddTests.cmake"
-        "extras/CatchShardTests.cmake"
-        "extras/CatchShardTestsImpl.cmake"
       DESTINATION
         ${CATCH_CMAKE_CONFIG_DESTINATION}
     )
 
-    # Install debugger helpers
+    # Install documentation
+    if(CATCH_INSTALL_DOCS)
+      install(
+        DIRECTORY
+          docs/
+        DESTINATION
+          "${CMAKE_INSTALL_DOCDIR}"
+        PATTERN "doxygen" EXCLUDE
+      )
+    endif()
+
+    if(CATCH_INSTALL_EXTRAS)
+        # Install CMake scripts
+        install(
+          FILES
+            "extras/ParseAndAddCatchTests.cmake"
+            "extras/Catch.cmake"
+            "extras/CatchAddTests.cmake"
+            "extras/CatchShardTests.cmake"
+            "extras/CatchShardTestsImpl.cmake"
+          DESTINATION
+            ${CATCH_CMAKE_CONFIG_DESTINATION}
+        )
+    
+        # Install debugger helpers
+        install(
+          FILES
+            "extras/gdbinit"
+            "extras/lldbinit"
+          DESTINATION
+            ${CMAKE_INSTALL_DATAROOTDIR}/Catch2
+        )
+    endif()
+
+    ## Provide some pkg-config integration
+    set(PKGCONFIG_INSTALL_DIR
+        "${CMAKE_INSTALL_DATAROOTDIR}/pkgconfig"
+        CACHE PATH "Path where catch2.pc is installed"
+    )
+    configure_file(
+      ${CMAKE_CURRENT_SOURCE_DIR}/CMake/catch2.pc.in
+      ${CMAKE_CURRENT_BINARY_DIR}/catch2.pc
+      @ONLY
+    )
+    configure_file(
+      ${CMAKE_CURRENT_SOURCE_DIR}/CMake/catch2-with-main.pc.in
+      ${CMAKE_CURRENT_BINARY_DIR}/catch2-with-main.pc
+      @ONLY
+    )
     install(
       FILES
-        "extras/gdbinit"
+        "${CMAKE_CURRENT_BINARY_DIR}/catch2.pc"
-        "extras/lldbinit"
+        "${CMAKE_CURRENT_BINARY_DIR}/catch2-with-main.pc"
       DESTINATION
-        ${CMAKE_INSTALL_DATAROOTDIR}/Catch2
+        ${PKGCONFIG_INSTALL_DIR}
     )
-  endif()
 
-  ## Provide some pkg-config integration
+    # CPack/CMake started taking the package version from project version 3.12
-  set(PKGCONFIG_INSTALL_DIR
+    # So we need to set the version manually for older CMake versions
-    "${CMAKE_INSTALL_DATAROOTDIR}/pkgconfig"
+    if(${CMAKE_VERSION} VERSION_LESS "3.12.0")
-    CACHE PATH "Path where catch2.pc is installed"
+        set(CPACK_PACKAGE_VERSION ${PROJECT_VERSION})
-  )
+    endif()
-  configure_file(
-    ${CMAKE_CURRENT_SOURCE_DIR}/CMake/catch2.pc.in
-    ${CMAKE_CURRENT_BINARY_DIR}/catch2.pc
-    @ONLY
-  )
-  configure_file(
-    ${CMAKE_CURRENT_SOURCE_DIR}/CMake/catch2-with-main.pc.in
-    ${CMAKE_CURRENT_BINARY_DIR}/catch2-with-main.pc
-    @ONLY
-  )
-  install(
-    FILES
-      "${CMAKE_CURRENT_BINARY_DIR}/catch2.pc"
-      "${CMAKE_CURRENT_BINARY_DIR}/catch2-with-main.pc"
-    DESTINATION
-      ${PKGCONFIG_INSTALL_DIR}
-  )
 
-  set(CPACK_PACKAGE_CONTACT "https://github.com/catchorg/Catch2/")
+    set(CPACK_PACKAGE_CONTACT "https://github.com/catchorg/Catch2/")
 
-  include(CPack)
+
-endif()
+    include( CPack )
+
+endif(NOT_SUBPROJECT)

CMakePresets.json

@@ -3,14 +3,9 @@
     "configurePresets": [
         {
             "name": "basic-tests",
-            "binaryDir": "build",
-            "installDir": "build/install",
             "displayName": "Basic development build",
             "description": "Enables development build with basic tests that are cheap to build and run",
             "cacheVariables": {
-                "CMAKE_CXX_EXTENSIONS": "OFF",
-                "CMAKE_CXX_STANDARD_REQUIRED": "ON",
-                "CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
                 "CATCH_DEVELOPMENT_BUILD": "ON"
             }
         },

MAINTAINERS.md

@@ -1,11 +0,0 @@
-<a id="top"></a>
-# Catch2 Maintainers
-
-## Current
-
-* Chris Thrasher ([@christhrasher](https://github.com/ChrisThrasher)), gpg key: 56FB686C9DFC8E2C
-* Martin Hořeňovský ([@horenmar](https://github.com/horenmar)), gpg key: E29C46F3B8A7502860793B7DECC9C20E314B2360
-
-## Retired
-
-* Phil Nash ([@philsquared](https://github.com/philsquared))

MODULE.bazel

@@ -1,4 +1,3 @@
 module(name = "catch2")
 
-bazel_dep(name = "bazel_skylib", version = "1.7.1")
+bazel_dep(name = "bazel_skylib", version = "1.5.0")
-bazel_dep(name = "rules_cc", version = "0.0.17")

WORKSPACE.bazel

@@ -0,0 +1,16 @@
+workspace(name = "catch2")
+
+load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
+
+http_archive(
+    name = "bazel_skylib",
+    sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94",
+    urls = [
+        "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz",
+        "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz",
+    ],
+)
+
+load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
+
+bazel_skylib_workspace()

conanfile.py

@@ -1,11 +1,9 @@
 #!/usr/bin/env python
-from conan import ConanFile
+from conan import ConanFile, tools, __version__ as conan_version
 from conan.tools.cmake import CMake, CMakeToolchain, CMakeDeps, cmake_layout
-from conan.tools.files import copy, rmdir
+from conan.tools import files, scm
-from conan.tools.build import check_min_cppstd
-from conan.tools.scm import Version
-from conan.errors import ConanInvalidConfiguration
 import os
+import shutil
 import re
 
 required_conan_version = ">=1.53.0"
@@ -18,32 +16,11 @@ class CatchConan(ConanFile):
     homepage = url
     license = "BSL-1.0"
     version = "latest"
+
+    exports = "LICENSE.txt"
+    exports_sources = ("src/*", "CMakeLists.txt", "CMake/*", "extras/*")
+
     settings = "os", "compiler", "build_type", "arch"
-    extension_properties = {"compatibility_cppstd": False}
-
-    options = {
-        "shared": [True, False],
-        "fPIC": [True, False],
-    }
-    default_options = {
-        "shared": False,
-        "fPIC": True,
-    }
-
-    @property
-    def _min_cppstd(self):
-        return "14"
-
-    @property
-    def _compilers_minimum_version(self):
-        return {
-            "gcc": "7",
-            "Visual Studio": "15",
-            "msvc": "191",
-            "clang": "5",
-            "apple-clang": "10",
-        }
-
 
     def set_version(self):
         pattern = re.compile(r"\w*VERSION (\d+\.\d+\.\d+) # CML version placeholder, don't delete")
@@ -55,57 +32,39 @@ class CatchConan(ConanFile):
 
         self.output.info(f'Using version: {self.version}')
 
-    def export(self):
-        copy(self, "LICENSE.txt", src=self.recipe_folder, dst=self.export_folder)
-
-    def export_sources(self):
-        copy(self, "CMakeLists.txt", src=self.recipe_folder, dst=self.export_sources_folder)
-        copy(self, "src/*", src=self.recipe_folder, dst=self.export_sources_folder)
-        copy(self, "extras/*", src=self.recipe_folder, dst=self.export_sources_folder)
-        copy(self, "CMake/*", src=self.recipe_folder, dst=self.export_sources_folder)
-
-    def config_options(self):
-        if self.settings.os == "Windows":
-            del self.options.fPIC
-
-    def configure(self):
-        if self.options.shared:
-            self.options.rm_safe("fPIC")
-
     def layout(self):
         cmake_layout(self)
 
-    def validate(self):
-        if self.settings.compiler.get_safe("cppstd"):
-            check_min_cppstd(self, self._min_cppstd)
-        # INFO: Conan 1.x does not specify cppstd by default, so we need to check the compiler version instead.
-        minimum_version = self._compilers_minimum_version.get(str(self.settings.compiler), False)
-        if minimum_version and Version(self.settings.compiler.version) < minimum_version:
-            raise ConanInvalidConfiguration(f"{self.ref} requires C++{self._min_cppstd}, which your compiler doesn't support")
-
     def generate(self):
         tc = CMakeToolchain(self)
-        tc.cache_variables["BUILD_TESTING"] = False
-        tc.cache_variables["CATCH_INSTALL_DOCS"] = False
-        tc.cache_variables["CATCH_INSTALL_EXTRAS"] = True
         tc.generate()
 
         deps = CMakeDeps(self)
         deps.generate()
 
-    def build(self):
+    def _configure_cmake(self):
         cmake = CMake(self)
-        cmake.configure()
+
+        # These are option variables. The toolchain in conan 2 doesn't appear to
+        # set these correctly so you have to do it in the configure variables.
+        cmake.configure(variables= {
+            "BUILD_TESTING": "OFF",
+            "CATCH_INSTALL_DOCS": "OFF",
+            "CATCH_INSTALL_EXTRAS": "ON",
+            }
+        )
+        return cmake
+
+    def build(self):
+        cmake = self._configure_cmake()
         cmake.build()
 
     def package(self):
-        copy(self, "LICENSE.txt", src=str(self.recipe_folder), dst=os.path.join(self.package_folder, "licenses"))
+        cmake = self._configure_cmake()
-        cmake = CMake(self)
         cmake.install()
-        rmdir(self, os.path.join(self.package_folder, "share"))
+
-        rmdir(self, os.path.join(self.package_folder, "lib", "cmake"))
+        os.mkdir(f'{self.package_folder}/licenses/')
-        copy(self, "*.cmake", src=os.path.join(self.export_sources_folder, "extras"),
+        shutil.copy2(f'{self.recipe_folder}/LICENSE.txt', f'{self.package_folder}/licenses/')
-                              dst=os.path.join(self.package_folder, "lib", "cmake", "Catch2"))
 
     def package_info(self):
         lib_suffix = "d" if self.settings.build_type == "Debug" else ""
@@ -116,7 +75,6 @@ class CatchConan(ConanFile):
 
         # Catch2
         self.cpp_info.components["catch2base"].set_property("cmake_file_name", "Catch2::Catch2")
-        self.cpp_info.components["catch2base"].set_property("cmake_target_name", "Catch2::Catch2")
         self.cpp_info.components["catch2base"].set_property("pkg_config_name", "catch2")
         self.cpp_info.components["catch2base"].libs = ["Catch2" + lib_suffix]
         self.cpp_info.components["catch2base"].builddirs.append("lib/cmake/Catch2")

docs/assertions.md

@@ -110,7 +110,7 @@ Expects that an exception is thrown that, when converted to a string, matches th
 
 e.g.
 ```cpp
-REQUIRE_THROWS_WITH( openThePodBayDoors(), ContainsSubstring( "afraid" ) && ContainsSubstring( "can't do that" ) );
+REQUIRE_THROWS_WITH( openThePodBayDoors(), Contains( "afraid" ) && Contains( "can't do that" ) );
 REQUIRE_THROWS_WITH( dismantleHal(), "My mind is going" );
 ```
 

docs/cmake-integration.md

@@ -8,7 +8,6 @@
 [`CATCH_CONFIG_*` customization options in CMake](#catch_config_-customization-options-in-cmake)<br>
 [Installing Catch2 from git repository](#installing-catch2-from-git-repository)<br>
 [Installing Catch2 from vcpkg](#installing-catch2-from-vcpkg)<br>
-[Installing Catch2 from Bazel](#installing-catch2-from-bazel)<br>
 
 Because we use CMake to build Catch2, we also provide a couple of
 integration points for our users.
@@ -81,11 +80,12 @@ to your CMake module path.
 
 `Catch.cmake` provides function `catch_discover_tests` to get tests from
 a target. This function works by running the resulting executable with
-`--list-test` flag, and then parsing the output to find all existing tests.
+`--list-test-names-only` flag, and then parsing the output to find all
+existing tests.
 
 #### Usage
 ```cmake
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 project(baz LANGUAGES CXX VERSION 0.0.1)
 
@@ -127,8 +127,6 @@ catch_discover_tests(target
                      [OUTPUT_PREFIX prefix]
                      [OUTPUT_SUFFIX suffix]
                      [DISCOVERY_MODE <POST_BUILD|PRE_TEST>]
-                     [SKIP_IS_FAILURE]
-                     [ADD_TAGS_AS_LABELS]
 )
 ```
 
@@ -212,15 +210,6 @@ execution (useful e.g. in cross-compilation environments).
 calling ``catch_discover_tests``. This provides a mechanism for globally
 selecting a preferred test discovery behavior.
 
-* `SKIP_IS_FAILURE`
-
-Skipped tests will be marked as failed instead.
-
-* `ADD_TAGS_AS_LABELS`
-
-Add the tags from tests as labels to CTest.
-
-
 ### `ParseAndAddCatchTests.cmake`
 
 ⚠ This script is [deprecated](https://github.com/catchorg/Catch2/pull/2120)
@@ -239,7 +228,7 @@ parsed are *silently ignored*.
 #### Usage
 
 ```cmake
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 project(baz LANGUAGES CXX VERSION 0.0.1)
 

docs/command-line.md

@@ -123,7 +123,7 @@ specs. You can:
     This allows test cases that are tagged with **either** "[some-tag]" **or**
     "[other-tag]". A test case with both will obviously also pass the filter.
 
-    Note that commas take precedence over simple concatenation. This means
+    Note that commas take precendence over simple concatenation. This means
     that `[a][b],[c]` accepts tests that are tagged with either both "[a]" and
     "[b]", or tests that are tagged with just "[c]".
 
@@ -145,7 +145,7 @@ only tests that match the positive filters are included.
 
 You can also match test names with special characters by escaping them
 with a backslash (`"\"`), e.g. a test named `"Do A, then B"` is matched
-by `"Do A\, then B"` test spec. Backslash also escapes itself.
+by "Do A\, then B" test spec. Backslash also escapes itself.
 
 
 ### Examples
@@ -194,8 +194,7 @@ verbose and human-friendly output.
 
 Reporters are also individually configurable. To pass configuration options
 to the reporter, you append `::key=value` to the reporter specification
-as many times as you want, e.g. `--reporter xml::out=someFile.xml` or
+as many times as you want, e.g. `--reporter xml::out=someFile.xml`.
-`--reporter custom::colour-mode=ansi::Xoption=2`.
 
 The keys must either be prefixed by "X", in which case they are not parsed
 by Catch2 and are only passed down to the reporter, or one of options

docs/configuration.md

@@ -158,14 +158,11 @@ by using `_NO_` in the macro, e.g. `CATCH_CONFIG_NO_CPP17_UNCAUGHT_EXCEPTIONS`.
     CATCH_CONFIG_ANDROID_LOGWRITE           // Use android's logging system for debug output
     CATCH_CONFIG_GLOBAL_NEXTAFTER           // Use nextafter{,f,l} instead of std::nextafter
     CATCH_CONFIG_GETENV                     // System has a working `getenv`
-    CATCH_CONFIG_USE_BUILTIN_CONSTANT_P     // Use __builtin_constant_p to trigger warnings
 
 > [`CATCH_CONFIG_ANDROID_LOGWRITE`](https://github.com/catchorg/Catch2/issues/1743) and [`CATCH_CONFIG_GLOBAL_NEXTAFTER`](https://github.com/catchorg/Catch2/pull/1739) were introduced in Catch2 2.10.0
 
 > `CATCH_CONFIG_GETENV` was [introduced](https://github.com/catchorg/Catch2/pull/2562) in Catch2 3.2.0
 
-> `CATCH_CONFIG_USE_BUILTIN_CONSTANT_P` was introduced in Catch2 vX.Y.Z
-
 Currently Catch enables `CATCH_CONFIG_WINDOWS_SEH` only when compiled with MSVC, because some versions of MinGW do not have the necessary Win32 API support.
 
 `CATCH_CONFIG_POSIX_SIGNALS` is on by default, except when Catch is compiled under `Cygwin`, where it is disabled by default (but can be force-enabled by defining `CATCH_CONFIG_POSIX_SIGNALS`).
@@ -186,12 +183,6 @@ With the exception of `CATCH_CONFIG_EXPERIMENTAL_REDIRECT`,
 these toggles can be disabled by using `_NO_` form of the toggle,
 e.g. `CATCH_CONFIG_NO_WINDOWS_SEH`.
 
-`CATCH_CONFIG_USE_BUILTIN_CONSTANT_P` is ON by default for Clang and GCC
-(but as far as possible, not for other compilers masquerading for these
-two). However, it can cause bugs where the enclosed code is evaluated, even
-though it should not be, e.g. in [#2925](https://github.com/catchorg/Catch2/issues/2925).
-
-
 ### `CATCH_CONFIG_FAST_COMPILE`
 This compile-time flag speeds up compilation of assertion macros by ~20%,
 by disabling the generation of assertion-local try-catch blocks for

docs/contributing.md

@@ -107,7 +107,8 @@ cmake -B debug-build -S . -DCMAKE_BUILD_TYPE=Debug --preset all-tests
 cmake --build debug-build
 
 # 4. Run the tests using CTest
-ctest -j 4 --output-on-failure -C Debug --test-dir debug-build
+cd debug-build
+ctest -j 4 --output-on-failure -C Debug
 ```
 <sup><a href='/tools/scripts/buildAndTest.sh#L6-L19' title='File snippet `catch2-build-and-test` was extracted from'>snippet source</a> | <a href='#snippet-catch2-build-and-test' title='Navigate to start of snippet `catch2-build-and-test`'>anchor</a></sup>
 <!-- endSnippet -->

docs/deprecations.md

@@ -35,19 +35,6 @@ being aborted (when using `--abort` or `--abortx`). It is however
 **NOT** invoked for test cases that are [explicitly skipped using the `SKIP`
 macro](skipping-passing-failing.md#top).
 
-
-### Non-const function for `TEST_CASE_METHOD`
-
-> Deprecated in Catch2 vX.Y.Z
-
-Currently, the member function generated for `TEST_CASE_METHOD` is
-not `const` qualified. In the future, the generated member function will
-be `const` qualified, just as `TEST_CASE_PERSISTENT_FIXTURE` does.
-
-If you are mutating the fixture instance from within the test case, and
-want to keep doing so in the future, mark the mutated members as `mutable`.
-
-
 ---
 
 [Home](Readme.md#top)

docs/generators.md

@@ -21,10 +21,7 @@ The "Generators" `TEST_CASE` will be entered 3 times, and the value of
 `i` will be 1, 3, and 5 in turn. `GENERATE`s can also be used multiple
 times at the same scope, in which case the result will be a cartesian
 product of all elements in the generators. This means that in the snippet
-below, the test case will be run 6 (2\*3) times. The `GENERATE` macro
+below, the test case will be run 6 (2\*3) times.
-is defined in the `catch_generators.hpp` header, so compiling
-the code examples below also requires
-`#include <catch2/generators/catch_generators.hpp>`.
 
 ```cpp
 TEST_CASE("Generators") {
@@ -106,7 +103,7 @@ a test case,
 * 2 fundamental generators
   * `SingleValueGenerator<T>` -- contains only single element
   * `FixedValuesGenerator<T>` -- contains multiple elements
-* 5 generic generators that modify other generators (defined in `catch2/generators/catch_generators_adapters.hpp`)
+* 5 generic generators that modify other generators
   * `FilterGenerator<T, Predicate>` -- filters out elements from a generator
   for which the predicate returns "false"
   * `TakeGenerator<T>` -- takes first `n` elements from a generator
@@ -114,11 +111,11 @@ a test case,
   * `MapGenerator<T, U, Func>` -- returns the result of applying `Func`
   on elements from a different generator
   * `ChunkGenerator<T>` -- returns chunks (inside `std::vector`) of n elements from a generator
-* 4 specific purpose generators (defined in `catch2/generators/catch_generators_random.hpp`)
+* 4 specific purpose generators
   * `RandomIntegerGenerator<Integral>` -- generates random Integrals from range
   * `RandomFloatGenerator<Float>` -- generates random Floats from range
-  * `RangeGenerator<T>(first, last)` -- generates all values inside a `[first, last)` arithmetic range (defined in `catch2/generators/catch_generators_range.hpp`)
+  * `RangeGenerator<T>(first, last)` -- generates all values inside a `[first, last)` arithmetic range
-  * `IteratorGenerator<T>` -- copies and returns values from an iterator range (defined in `catch2/generators/catch_generators_range.hpp`)
+  * `IteratorGenerator<T>` -- copies and returns values from an iterator range
 
 > `ChunkGenerator<T>`, `RandomIntegerGenerator<Integral>`, `RandomFloatGenerator<Float>` and `RangeGenerator<T>` were introduced in Catch2 2.7.0.
 
@@ -219,8 +216,8 @@ For floating point generators, the situation is much more complex.
 Generally Catch2 only promises reproducibility (or even just correctness!)
 on platforms that obey the IEEE-754 standard. Furthermore, reproducibility
 only applies between binaries that perform floating point math in the
-same way, e.g. if you compile a binary targeting the x87 FPU and another
+same way, e.g. if you compile a binary targetting the x87 FPU and another
-one targeting SSE2 for floating point math, their results will vary.
+one targetting SSE2 for floating point math, their results will vary.
 Similarly, binaries compiled with compiler flags that relax the IEEE-754
 adherence, e.g. `-ffast-math`, might provide different results than those
 compiled for strict IEEE-754 adherence.

docs/list-of-examples.md

@@ -8,7 +8,6 @@
 - Assertion: [REQUIRE, CHECK](../examples/030-Asn-Require-Check.cpp)
 - Fixture: [Sections](../examples/100-Fix-Section.cpp)
 - Fixture: [Class-based fixtures](../examples/110-Fix-ClassFixture.cpp)
-- Fixture: [Persistent fixtures](../examples/111-Fix-PersistentFixture.cpp)
 - BDD: [SCENARIO, GIVEN, WHEN, THEN](../examples/120-Bdd-ScenarioGivenWhenThen.cpp)
 - Listener: [Listeners](../examples/210-Evt-EventListeners.cpp)
 - Configuration: [Provide your own output streams](../examples/231-Cfg-OutputStreams.cpp)

docs/logging.md

@@ -114,10 +114,6 @@ Similar to `INFO`, but messages are not limited to their own scope: They are rem
 
 The message is always reported but does not fail the test.
 
-**SUCCEED(** _message expression_ **)**
-
-The message is reported and the test case succeeds.
-
 **FAIL(** _message expression_ **)**
 
 The message is reported and the test case fails.

docs/matchers.md

@@ -210,36 +210,15 @@ The other miscellaneous matcher utility is exception matching.
 
 #### Matching exceptions
 
-Because exceptions are a bit special, Catch2 has a separate macro for them.
+Catch2 provides a utility macro for asserting that an expression
-
+throws exception of specific type, and that the exception has desired
-
+properties. The macro is `REQUIRE_THROWS_MATCHES(expr, ExceptionType, Matcher)`.
-The basic form is
-
-```
-REQUIRE_THROWS_MATCHES(expr, ExceptionType, Matcher)
-```
-
-and it checks that the `expr` throws an exception, that exception is derived
-from the `ExceptionType` type, and then `Matcher::match` is called on
-the caught exception.
 
 > `REQUIRE_THROWS_MATCHES` macro lives in `catch2/matchers/catch_matchers.hpp`
 
-For one-off checks you can use the `Predicate` matcher above, e.g.
 
-```cpp
+Catch2 currently provides two matchers for exceptions.
-REQUIRE_THROWS_MATCHES(parse(...),
+These are:
-                       parse_error,
-                       Predicate<parse_error>([] (parse_error const& err) -> bool { return err.line() == 1; })
-);
-```
-
-but if you intend to thoroughly test your error reporting, I recommend
-defining a specialized matcher.
-
-
-Catch2 also provides 2 built-in matchers for checking the error message
-inside an exception (it must be derived from `std::exception`):
 * `Message(std::string message)`.
 * `MessageMatches(Matcher matcher)`.
 
@@ -257,7 +236,10 @@ REQUIRE_THROWS_MATCHES(throwsDerivedException(),  DerivedException,  Message("De
 REQUIRE_THROWS_MATCHES(throwsDerivedException(),  DerivedException,  MessageMatches(StartsWith("DerivedException")));
 ```
 
-> the exception message matchers live in `catch2/matchers/catch_matchers_exception.hpp`
+Note that `DerivedException` in the example above has to derive from
+`std::exception` for the example to work.
+
+> the exception message matcher lives in `catch2/matchers/catch_matchers_exception.hpp`
 
 
 ### Generic range Matchers

docs/other-macros.md

@@ -93,6 +93,30 @@ TEST_CASE("STATIC_CHECK showcase", "[traits]") {
 
 ## Test case related macros
 
+* `METHOD_AS_TEST_CASE`
+
+`METHOD_AS_TEST_CASE( member-function-pointer, description )` lets you
+register a member function of a class as a Catch2 test case. The class
+will be separately instantiated for each method registered in this way.
+
+```cpp
+class TestClass {
+    std::string s;
+
+public:
+    TestClass()
+        :s( "hello" )
+    {}
+
+    void testCase() {
+        REQUIRE( s == "hello" );
+    }
+};
+
+
+METHOD_AS_TEST_CASE( TestClass::testCase, "Use class's method as a test case", "[class]" )
+```
+
 * `REGISTER_TEST_CASE`
 
 `REGISTER_TEST_CASE( function, description )` let's you register

docs/release-notes.md

@@ -2,12 +2,6 @@
 
 # Release notes
 **Contents**<br>
-[3.8.1](#381)<br>
-[3.8.0](#380)<br>
-[3.7.1](#371)<br>
-[3.7.0](#370)<br>
-[3.6.0](#360)<br>
-[3.5.4](#354)<br>
 [3.5.3](#353)<br>
 [3.5.2](#352)<br>
 [3.5.1](#351)<br>
@@ -67,126 +61,6 @@
 [Even Older versions](#even-older-versions)<br>
 
 
-## 3.8.1
-
-### Fixes
-* Fixed bug where catch_discover_tests fails when no TEST_CASEs are present (#2962)
-* Fixed Clang 19 -Wc++20-extensions warning (#2968)
-
-
-## 3.8.0
-
-### Improvements
-* Added `std::initializer_list` overloads for `(Unordered)RangeEquals` matcher (#2915, #2919)
-* Added explicit casts to silence GCC's `Wconversion` (#2875)
-* Made the use of `builtin_constant_p` tricks in assertion macros configurable (#2925)
-  * It is used to prod GCC-like compilers into providing warnings for the asserted expressions, but the compilers miscompile it annoyingly often.
-* Cleaned out Clang-Tidy's `performance-enum-size` warnings
-* Added support for using `from_range` generator with iterators with `value_type = const T` (#2926)
-  * This is not correct `value_type` typedef, but it is used in the wild and the change does not make the code meaningfully worse.
-
-### Fixes
-* Fixed crash when stringifying pre-1970 (epoch) dates on Windows (#2944)
-
-### Miscellaneous
-* Fixes and improvements for `catch_discover_tests` CMake helper
-  * Removed redundant `CTEST_FILE` param when creating the indirection file for `PRE_TEST` discovery mode (#2936)
-  * Rewrote the test discovery logic to use output from the JSON reporter
-    * This means that `catch_discover_tests` now requires CMake 3.19 or newer
-  * Added `ADD_TAGS_AS_LABELS` option. If specified, each CTest test will be labeled with corresponding Catch2's test tag
-* Bumped up the minimum required CMake version to build Catch2 to 3.16
-* Meson build now provides option to avoid installing Catch2
-* Bazel build is moved to Bzlmod.
-
-
-## 3.7.1
-
-### Improvements
-* Applied the JUnit reporter's optimization from last release to the SonarQube reporter
-* Suppressed `-Wuseless-cast` in `CHECK_THROWS_MATCHES` (#2904)
-* Standardize exit codes for various failures
-  * Running no tests is now guaranteed to exit with 2 (without the `--allow-running-no-tests` flag)
-  * All tests skipped is now always 4 (...)
-  * Assertion failures are now always 42
-  * and so on
-
-### Fixes
-* Fixed out-of-bounds access when the arg parser encounters single `-` as an argument (#2905)
-
-### Miscellaneous
-* Added `catch_config_prefix_messages.hpp` to meson build (#2903)
-* `catch_discover_tests` now supports skipped tests (#2873)
-  * You can get the old behaviour by calling `catch_discover_tests` with `SKIP_IS_FAILURE` option.
-
-
-## 3.7.0
-
-### Improvements
-* Slightly improved compile times of benchmarks
-* Made the resolution estimation in benchmarks slightly more precise
-* Added new test case macro, `TEST_CASE_PERSISTENT_FIXTURE` (#2885, #1602)
-  * Unlike `TEST_CASE_METHOD`, the same underlying instance is used for all partial runs of that test case
-* **MASSIVELY** improved performance of the JUnit reporter when handling successful assertions (#2897)
-  * For 1 test case and 10M assertions, the new reporter runs 3x faster and uses up only 8 MB of memory, while the old one needs 7 GB of memory.
-* Reworked how output redirects works.
-  * Combining a reporter writing to stdout with capturing reporter no longer leads to the capturing reporter seeing all of the other reporter's output.
-  * The file based redirect no longer opens up a new temporary file for each partial test case run, so it will not run out of temporary files when running many tests in single process.
-
-### Miscellaneous
-* Better documentation for matchers on thrown exceptions (`REQUIRE_THROWS_MATCHES`)
-* Improved `catch_discover_tests`'s handling of environment paths (#2878)
-  * It won't reorder paths in `DL_PATHS` or `DYLD_FRAMEWORK_PATHS` args
-  * It won't overwrite the environment paths for test discovery
-
-
-## 3.6.0
-
-### Fixes
-* Fixed Windows ARM64 build by fixing the preprocessor condition guarding use `_umul128` intrinsic.
-* Fixed Windows ARM64EC build by removing intrinsic pragma it does not understand. (#2858)
-  * Why doesn't the x64-emulation build mode understand x64 pragmas? Don't ask me, ask the MSVC guys.
-* Fixed the JUnit reporter sometimes crashing when reporting a fatal error. (#1210, #2855)
-  * The binary will still exit, but through the original error, rather than secondary error inside the reporter.
-  * The underlying fix applies to all reporters, not just the JUnit one, but only JUnit was currently causing troubles.
-
-### Improvements
-* Disable `-Wnon-virtual-dtor` in Decomposer and Matchers (#2854)
-* `precision` in floating point stringmakers defaults to `max_digits10`.
-  * This means that floating point values will be printed with enough precision to disambiguate any two floats.
-* Column wrapping ignores ansi colour codes when calculating string width (#2833, #2849)
-  * This makes the output much more readable when the provided messages contain colour codes.
-
-### Miscellaneous
-* Conan support improvements
-  * `compatibility_cppstr` is set to False. (#2860)
-    * This means that Conan won't let you mix library and project with different C++ standard settings.
-  * The implementation library CMake target name through Conan is properly set to `Catch2::Catch2` (#2861)
-* `SelfTest` target can be built through Bazel (#2857)
-
-
-## 3.5.4
-
-### Fixes
-* Fixed potential compilation error when asked to generate random integers whose type did not match `std::(u)int*_t`.
-  * This manifested itself when generating random `size_t`s on MacOS
-* Added missing outlined destructor causing `Wdelete-incomplete` when compiling against libstdc++ in C++23 mode (#2852)
-* Fixed regression where decomposing assertion with const instance of `std::foo_ordering` would not compile
-
-### Improvements
-* Reintroduced support for GCC 5 and 6 (#2836)
-  * As with VS2017, if they start causing trouble again, they will be dropped again.
-* Added workaround for targeting newest MacOS (Sonoma) using GCC (#2837, #2839)
-* `CATCH_CONFIG_DEFAULT_REPORTER` can now be an arbitrary reporter spec
-  * Previously it could only be a plain reporter name, so it was impossible to compile in custom arguments to the reporter.
-* Improved performance of generating 64bit random integers by 20+%
-
-### Miscellaneous
-* Significantly improved Conan in-tree recipe (#2831)
-* `DL_PATHS` in `catch_discover_tests` now supports multiple arguments (#2852, #2736)
-* Fixed preprocessor logic for checking whether we expect reproducible floating point results in tests.
-* Improved the floating point tests structure to avoid `Wunused` when the reproducibility tests are disabled (#2845)
-
-
 ## 3.5.3
 
 ### Fixes

docs/test-cases-and-sections.md

@@ -48,7 +48,7 @@ For more detail on command line selection see [the command line docs](command-li
 Tag names are not case sensitive and can contain any ASCII characters.
 This means that tags `[tag with spaces]` and `[I said "good day"]`
 are both allowed tags and can be filtered on. However, escapes are not
-supported and `[\]]` is not a valid tag.
+supported however and `[\]]` is not a valid tag.
 
 The same tag can be specified multiple times for a single test case,
 but only one of the instances of identical tags will be kept. Which one

docs/test-fixtures.md

@@ -1,30 +1,9 @@
 <a id="top"></a>
 # Test fixtures
 
-**Contents**<br>
+## Defining test fixtures
-[Non-Templated test fixtures](#non-templated-test-fixtures)<br>
-[Templated test fixtures](#templated-test-fixtures)<br>
-[Signature-based parameterised test fixtures](#signature-based-parametrised-test-fixtures)<br>
-[Template fixtures with types specified in template type lists](#template-fixtures-with-types-specified-in-template-type-lists)<br>
 
-## Non-Templated test fixtures
+Although Catch allows you to group tests together as [sections within a test case](test-cases-and-sections.md), it can still be convenient, sometimes, to group them using a more traditional test fixture. Catch fully supports this too. You define the test fixture as a simple structure:
-
-Although Catch2 allows you to group tests together as 
-[sections within a test case](test-cases-and-sections.md), it can still 
-be convenient, sometimes, to group them using a more traditional test. 
-Catch2 fully supports this too with 3 different macros for 
-non-templated test fixtures. They are: 
-
-| Macro    | Description |
-|----------|-------------|
-|1. `TEST_CASE_METHOD(className, ...)`| Creates a uniquely named class which inherits from the class specified by `className`. The test function will be a member of this derived class. An instance of the derived class will be created for every partial run of the test case. |
-|2. `METHOD_AS_TEST_CASE(member-function, ...)`| Uses `member-function` as the test function. An instance of the class will be created for each partial run of the test case. |
-|3. `TEST_CASE_PERSISTENT_FIXTURE(className, ...)`| Creates a uniquely named class which inherits from the class specified by `className`. The test function will be a member of this derived class. An instance of the derived class will be created at the start of the test run. That instance will be destroyed once the entire test case has ended. |
-
-### 1. `TEST_CASE_METHOD`
-
-
-You define a `TEST_CASE_METHOD` test fixture as a simple structure:
 
 ```c++
 class UniqueTestsFixture {
@@ -51,116 +30,8 @@ class UniqueTestsFixture {
  }
 ```
 
-The two test cases here will create uniquely-named derived classes of 
+The two test cases here will create uniquely-named derived classes of UniqueTestsFixture and thus can access the `getID()` protected method and `conn` member variables. This ensures that both the test cases are able to create a DBConnection using the same method (DRY principle) and that any ID's created are unique such that the order that tests are executed does not matter.
-UniqueTestsFixture and thus can access the `getID()` protected method 
-and `conn` member variables. This ensures that both the test cases 
-are able to create a DBConnection using the same method 
-(DRY principle) and that any ID's created are unique such that the 
-order that tests are executed does not matter. 
 
-### 2. `METHOD_AS_TEST_CASE`
-
-`METHOD_AS_TEST_CASE` lets you register a member function of a class 
-as a Catch2 test case. The class will be separately instantiated 
-for each method registered in this way.
-
-```cpp
-class TestClass {
-    std::string s;
-
-public:
-    TestClass()
-        :s( "hello" )
-    {}
-
-    void testCase() {
-        REQUIRE( s == "hello" );
-    }
-};
-
-
-METHOD_AS_TEST_CASE( TestClass::testCase, "Use class's method as a test case", "[class]" )
-```
-
-This type of fixture is similar to [TEST_CASE_METHOD](#1-test_case_method) except in this 
-case it will directly use the provided class to create an object rather than a derived 
-class.
-
-### 3. `TEST_CASE_PERSISTENT_FIXTURE`
-
-> [Introduced](https://github.com/catchorg/Catch2/pull/2885) in Catch2 3.7.0
-
-`TEST_CASE_PERSISTENT_FIXTURE` behaves in the same way as
-[TEST_CASE_METHOD](#1-test_case_method) except that there will only be
-one instance created throughout the entire run of a test case. To 
-demonstrate this have a look at the following example:
-
-```cpp
-class ClassWithExpensiveSetup {
-public:
-    ClassWithExpensiveSetup() {
-        // expensive construction
-        std::this_thread::sleep_for( std::chrono::seconds( 2 ) );
-    }
-
-    ~ClassWithExpensiveSetup() noexcept {
-        // expensive destruction
-        std::this_thread::sleep_for( std::chrono::seconds( 1 ) );
-    }
-
-    int getInt() const { return 42; }
-};
-
-struct MyFixture {
-    mutable int myInt = 0;
-    ClassWithExpensiveSetup expensive;
-};
-
-TEST_CASE_PERSISTENT_FIXTURE( MyFixture, "Tests with MyFixture" ) {
-
-    const int val = myInt++;
-
-    SECTION( "First partial run" ) {
-        const auto otherValue = expensive.getInt();
-        REQUIRE( val == 0 );
-        REQUIRE( otherValue == 42 );
-    }
-
-    SECTION( "Second partial run" ) { REQUIRE( val == 1 ); }
-}
-```
-
-This example demonstrates two possible use-cases of this fixture type:
-1. Improve test run times by reducing the amount of expensive and 
-redundant setup and tear-down required.
-2. Reusing results from the previous partial run, in the current
-partial run.
-
-This test case will be executed twice as there are two leaf sections.
-On the first run `val` will be `0` and on the second run `val` will be 
-`1`. This demonstrates that we were able to use the results of the
-previous partial run in subsequent partial runs.
-
-Additionally, we are simulating an expensive object using 
-`std::this_thread::sleep_for`, but real world use-cases could be:
-1. Creating a D3D12/Vulkan device
-2. Connecting to a database
-3. Loading a file.
-
-The fixture object (`MyFixture`) will be constructed just before the
-test case begins, and it will be destroyed just after the test case 
-ends. Therefore, this expensive object will only be created and 
-destroyed once during the execution of this test case. If we had used 
-`TEST_CASE_METHOD`, `MyFixture` would have been created and destroyed 
-twice during the execution of this test case.
-
-NOTE: The member function which runs the test case is `const`. Therefore 
-if you want to mutate any member of the fixture it must be marked as
-`mutable` as shown in this example. This is to make it clear that
-the initial state of the fixture is intended to mutate during the
-execution of the test case.
-
-## Templated test fixtures
 
 Catch2 also provides `TEMPLATE_TEST_CASE_METHOD` and
 `TEMPLATE_PRODUCT_TEST_CASE_METHOD` that can be used together
@@ -222,7 +93,7 @@ _While there is an upper limit on the number of types you can specify
 in single `TEMPLATE_TEST_CASE_METHOD` or `TEMPLATE_PRODUCT_TEST_CASE_METHOD`,
 the limit is very high and should not be encountered in practice._
 
-## Signature-based parameterised test fixtures
+## Signature-based parametrised test fixtures
 
 > [Introduced](https://github.com/catchorg/Catch2/issues/1609) in Catch2 2.8.0.
 

docs/tostring.md

@@ -75,7 +75,7 @@ CATCH_TRANSLATE_EXCEPTION( MyType const& ex ) {
 
 Enums that already have a `<<` overload for `std::ostream` will convert to strings as expected.
 If you only need to convert enums to strings for test reporting purposes you can provide a `StringMaker` specialisations as any other type.
-However, as a convenience, Catch provides the `CATCH_REGISTER_ENUM` helper macro that will generate the `StringMaker` specialisation for you with minimal code.
+However, as a convenience, Catch provides the `REGISTER_ENUM` helper macro that will generate the `StringMaker` specialisation for you with minimal code.
 Simply provide it the (qualified) enum name, followed by all the enum values, and you're done!
 
 E.g.

examples/111-Fix-PersistentFixture.cpp

@@ -1,74 +0,0 @@
-
-//              Copyright Catch2 Authors
-// Distributed under the Boost Software License, Version 1.0.
-//   (See accompanying file LICENSE.txt or copy at
-//        https://www.boost.org/LICENSE_1_0.txt)
-
-// SPDX-License-Identifier: BSL-1.0
-
-// Fixture.cpp
-
-// Catch2 has three ways to express fixtures:
-// - Sections
-// - Traditional class-based fixtures that are created and destroyed on every
-// partial run
-// - Traditional class-based fixtures that are created at the start of a test
-// case and destroyed at the end of a test case (this file)
-
-// main() provided by linkage to Catch2WithMain
-
-#include <catch2/catch_test_macros.hpp>
-
-#include <thread>
-
-class ClassWithExpensiveSetup {
-public:
-    ClassWithExpensiveSetup() {
-        // Imagine some really expensive set up here.
-        // e.g.
-        // setting up a D3D12/Vulkan Device,
-        // connecting to a database,
-        // loading a file
-        // etc etc etc
-        std::this_thread::sleep_for( std::chrono::seconds( 2 ) );
-    }
-
-    ~ClassWithExpensiveSetup() noexcept {
-        // We can do any clean up of the expensive class in the destructor
-        // e.g.
-        // destroy D3D12/Vulkan Device,
-        // disconnecting from a database,
-        // release file handle
-        // etc etc etc
-        std::this_thread::sleep_for( std::chrono::seconds( 1 ) );
-    }
-
-    int getInt() const { return 42; }
-};
-
-struct MyFixture {
-
-    // The test case member function is const.
-    // Therefore we need to mark any member of the fixture
-    // that needs to mutate as mutable.
-    mutable int myInt = 0;
-    ClassWithExpensiveSetup expensive;
-};
-
-// Only one object of type MyFixture will be instantiated for the run
-// of this test case even though there are two leaf sections.
-// This is useful if your test case requires an object that is
-// expensive to create and could be reused for each partial run of the
-// test case.
-TEST_CASE_PERSISTENT_FIXTURE( MyFixture, "Tests with MyFixture" ) {
-
-    const int val = myInt++;
-
-    SECTION( "First partial run" ) {
-        const auto otherValue = expensive.getInt();
-        REQUIRE( val == 0 );
-        REQUIRE( otherValue == 42 );
-    }
-
-    SECTION( "Second partial run" ) { REQUIRE( val == 1 ); }
-}

examples/CMakeLists.txt

@@ -1,47 +1,50 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required( VERSION 3.10 )
-project(Catch2Examples LANGUAGES CXX)
+
+project( Catch2Examples LANGUAGES CXX )
+
+message( STATUS "Examples included" )
 
-message(STATUS "Examples included")
 
 # Some one-offs first:
 # 1) Tests and main in one file
-add_executable(010-TestCase
+add_executable( 010-TestCase
   010-TestCase.cpp
 )
 
 # 2) Tests and main across two files
-add_executable(020-MultiFile
+add_executable( 020-MultiFile
   020-TestCase-1.cpp
   020-TestCase-2.cpp
 )
 
 add_executable(231-Cfg_OutputStreams
-  231-Cfg-OutputStreams.cpp
+    231-Cfg-OutputStreams.cpp
 )
 target_link_libraries(231-Cfg_OutputStreams Catch2_buildall_interface)
 target_compile_definitions(231-Cfg_OutputStreams PUBLIC CATCH_CONFIG_NOSTDOUT)
 
 # These examples use the standard separate compilation
-set(SOURCES_IDIOMATIC_EXAMPLES
+set( SOURCES_IDIOMATIC_EXAMPLES
-  030-Asn-Require-Check.cpp
+    030-Asn-Require-Check.cpp
-  100-Fix-Section.cpp
+    100-Fix-Section.cpp
-  110-Fix-ClassFixture.cpp
+    110-Fix-ClassFixture.cpp
-  111-Fix-PersistentFixture.cpp
+    120-Bdd-ScenarioGivenWhenThen.cpp
-  120-Bdd-ScenarioGivenWhenThen.cpp
+    210-Evt-EventListeners.cpp
-  210-Evt-EventListeners.cpp
+    232-Cfg-CustomMain.cpp
-  232-Cfg-CustomMain.cpp
+    300-Gen-OwnGenerator.cpp
-  300-Gen-OwnGenerator.cpp
+    301-Gen-MapTypeConversion.cpp
-  301-Gen-MapTypeConversion.cpp
+    302-Gen-Table.cpp
-  302-Gen-Table.cpp
+    310-Gen-VariablesInGenerators.cpp
-  310-Gen-VariablesInGenerators.cpp
+    311-Gen-CustomCapture.cpp
-  311-Gen-CustomCapture.cpp
 )
 
-string(REPLACE ".cpp" "" BASENAMES_IDIOMATIC_EXAMPLES "${SOURCES_IDIOMATIC_EXAMPLES}")
+string( REPLACE ".cpp" "" BASENAMES_IDIOMATIC_EXAMPLES "${SOURCES_IDIOMATIC_EXAMPLES}" )
-set(TARGETS_IDIOMATIC_EXAMPLES ${BASENAMES_IDIOMATIC_EXAMPLES})
+set( TARGETS_IDIOMATIC_EXAMPLES ${BASENAMES_IDIOMATIC_EXAMPLES} )
 
-foreach(name ${TARGETS_IDIOMATIC_EXAMPLES})
+
-  add_executable(${name} ${name}.cpp)
+foreach( name ${TARGETS_IDIOMATIC_EXAMPLES} )
+    add_executable( ${name}
+      ${EXAMPLES_DIR}/${name}.cpp )
 endforeach()
 
 set(ALL_EXAMPLE_TARGETS
@@ -50,9 +53,10 @@ set(ALL_EXAMPLE_TARGETS
   020-MultiFile
 )
 
-foreach(name ${ALL_EXAMPLE_TARGETS})
+foreach( name ${ALL_EXAMPLE_TARGETS} )
-  target_link_libraries(${name} Catch2WithMain)
+    target_link_libraries( ${name} Catch2WithMain )
 endforeach()
 
+
 list(APPEND CATCH_WARNING_TARGETS ${ALL_EXAMPLE_TARGETS})
 set(CATCH_WARNING_TARGETS ${CATCH_WARNING_TARGETS} PARENT_SCOPE)

extras/Catch.cmake

@@ -38,8 +38,6 @@ same as the Catch name; see also ``TEST_PREFIX`` and ``TEST_SUFFIX``.
                          [OUTPUT_PREFIX prefix]
                          [OUTPUT_SUFFIX suffix]
                          [DISCOVERY_MODE <POST_BUILD|PRE_TEST>]
-                         [SKIP_IS_FAILURE]
-                         [ADD_TAGS_AS_LABELS]
     )
 
   ``catch_discover_tests`` sets up a post-build command on the test executable
@@ -126,14 +124,7 @@ same as the Catch name; see also ``TEST_PREFIX`` and ``TEST_SUFFIX``.
     test executable and when the tests are executed themselves. This requires
     cmake/ctest >= 3.22.
 
-  ``DL_FRAMEWORK_PATHS path...``
+  `DISCOVERY_MODE mode``
-    Specifies paths that need to be set for the dynamic linker to find libraries
-    packaged as frameworks on Apple platforms when running the test executable
-    (DYLD_FRAMEWORK_PATH). These paths will both be set when retrieving the list
-    of test cases from the test executable and when the tests are executed themselves.
-    This requires cmake/ctest >= 3.22.
-
-  ``DISCOVERY_MODE mode``
     Provides control over when ``catch_discover_tests`` performs test discovery.
     By default, ``POST_BUILD`` sets up a post-build command to perform test discovery
     at build time. In certain scenarios, like cross-compiling, this ``POST_BUILD``
@@ -146,12 +137,6 @@ same as the Catch name; see also ``TEST_PREFIX`` and ``TEST_SUFFIX``.
     calling ``catch_discover_tests``. This provides a mechanism for globally selecting
     a preferred test discovery behavior without having to modify each call site.
 
-  ``SKIP_IS_FAILURE``
-    Disables skipped test detection.
-
-  ``ADD_TAGS_AS_LABELS``
-    Adds all test tags as CTest labels.
-
 #]=======================================================================]
 
 #------------------------------------------------------------------------------
@@ -159,27 +144,22 @@ function(catch_discover_tests TARGET)
 
   cmake_parse_arguments(
     ""
-    "SKIP_IS_FAILURE;ADD_TAGS_AS_LABELS"
+    ""
     "TEST_PREFIX;TEST_SUFFIX;WORKING_DIRECTORY;TEST_LIST;REPORTER;OUTPUT_DIR;OUTPUT_PREFIX;OUTPUT_SUFFIX;DISCOVERY_MODE"
-    "TEST_SPEC;EXTRA_ARGS;PROPERTIES;DL_PATHS;DL_FRAMEWORK_PATHS"
+    "TEST_SPEC;EXTRA_ARGS;PROPERTIES;DL_PATHS"
     ${ARGN}
   )
 
-  if(${CMAKE_VERSION} VERSION_LESS "3.19")
-    message(FATAL_ERROR "This script requires JSON support from CMake version 3.19 or greater.")
-  endif()
-
   if(NOT _WORKING_DIRECTORY)
     set(_WORKING_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}")
   endif()
   if(NOT _TEST_LIST)
     set(_TEST_LIST ${TARGET}_TESTS)
   endif()
-  if(_DL_PATHS AND ${CMAKE_VERSION} VERSION_LESS "3.22.0")
+  if (_DL_PATHS)
-    message(FATAL_ERROR "The DL_PATHS option requires at least cmake 3.22")
+    if(${CMAKE_VERSION} VERSION_LESS "3.22.0")
-  endif()
+        message(FATAL_ERROR "The DL_PATHS option requires at least cmake 3.22")
-  if(_DL_FRAMEWORK_PATHS AND ${CMAKE_VERSION} VERSION_LESS "3.22.0")
+    endif()
-    message(FATAL_ERROR "The DL_FRAMEWORK_PATHS option requires at least cmake 3.22")
   endif()
   if(NOT _DISCOVERY_MODE)
     if(NOT CMAKE_CATCH_DISCOVER_TESTS_DISCOVERY_MODE)
@@ -187,7 +167,7 @@ function(catch_discover_tests TARGET)
     endif()
     set(_DISCOVERY_MODE ${CMAKE_CATCH_DISCOVER_TESTS_DISCOVERY_MODE})
   endif()
-  if(NOT _DISCOVERY_MODE MATCHES "^(POST_BUILD|PRE_TEST)$")
+  if (NOT _DISCOVERY_MODE MATCHES "^(POST_BUILD|PRE_TEST)$")
     message(FATAL_ERROR "Unknown DISCOVERY_MODE: ${_DISCOVERY_MODE}")
   endif()
 
@@ -204,9 +184,6 @@ function(catch_discover_tests TARGET)
     TARGET ${TARGET}
     PROPERTY CROSSCOMPILING_EMULATOR
   )
-  if(NOT _SKIP_IS_FAILURE)
-    set(_PROPERTIES ${_PROPERTIES} SKIP_RETURN_CODE 4)
-  endif()
 
   if(_DISCOVERY_MODE STREQUAL "POST_BUILD")
     add_custom_command(
@@ -228,9 +205,7 @@ function(catch_discover_tests TARGET)
               -D "TEST_OUTPUT_PREFIX=${_OUTPUT_PREFIX}"
               -D "TEST_OUTPUT_SUFFIX=${_OUTPUT_SUFFIX}"
               -D "TEST_DL_PATHS=${_DL_PATHS}"
-              -D "TEST_DL_FRAMEWORK_PATHS=${_DL_FRAMEWORK_PATHS}"
               -D "CTEST_FILE=${ctest_tests_file}"
-              -D "ADD_TAGS_AS_LABELS=${_ADD_TAGS_AS_LABELS}"
               -P "${_CATCH_DISCOVER_TESTS_SCRIPT}"
       VERBATIM
     )
@@ -275,8 +250,7 @@ function(catch_discover_tests TARGET)
       "      TEST_OUTPUT_SUFFIX"     " [==[" "${_OUTPUT_SUFFIX}"          "]==]"   "\n"
       "      CTEST_FILE"             " [==[" "${ctest_tests_file}"        "]==]"   "\n"
       "      TEST_DL_PATHS"          " [==[" "${_DL_PATHS}"               "]==]"   "\n"
-      "      TEST_DL_FRAMEWORK_PATHS" " [==[" "${_DL_FRAMEWORK_PATHS}"     "]==]"   "\n"
+      "      CTEST_FILE"             " [==[" "${CTEST_FILE}"              "]==]"   "\n"
-      "      ADD_TAGS_AS_LABELS"     " [==[" "${_ADD_TAGS_AS_LABELS}"     "]==]"   "\n"
       "    )"                                                                      "\n"
       "  endif()"                                                                  "\n"
       "  include(\"${ctest_tests_file}\")"                                         "\n"
@@ -303,10 +277,22 @@ function(catch_discover_tests TARGET)
     endif()
   endif()
 
-  # Add discovered tests to directory TEST_INCLUDE_FILES
+  if(NOT ${CMAKE_VERSION} VERSION_LESS "3.10.0")
-  set_property(DIRECTORY
+    # Add discovered tests to directory TEST_INCLUDE_FILES
-    APPEND PROPERTY TEST_INCLUDE_FILES "${ctest_include_file}"
+    set_property(DIRECTORY
-  )
+      APPEND PROPERTY TEST_INCLUDE_FILES "${ctest_include_file}"
+    )
+  else()
+    # Add discovered tests as directory TEST_INCLUDE_FILE if possible
+    get_property(test_include_file_set DIRECTORY PROPERTY TEST_INCLUDE_FILE SET)
+    if (NOT ${test_include_file_set})
+      set_property(DIRECTORY
+        PROPERTY TEST_INCLUDE_FILE "${ctest_include_file}"
+      )
+    else()
+      message(FATAL_ERROR "Cannot set more than one TEST_INCLUDE_FILE")
+    endif()
+  endif()
 
 endfunction()
 

extras/CatchAddTests.cmake

@@ -21,12 +21,11 @@ function(catch_discover_tests_impl)
   cmake_parse_arguments(
     ""
     ""
-    "TEST_EXECUTABLE;TEST_WORKING_DIR;TEST_OUTPUT_DIR;TEST_OUTPUT_PREFIX;TEST_OUTPUT_SUFFIX;TEST_PREFIX;TEST_REPORTER;TEST_SPEC;TEST_SUFFIX;TEST_LIST;CTEST_FILE"
+    "TEST_EXECUTABLE;TEST_WORKING_DIR;TEST_DL_PATHS;TEST_OUTPUT_DIR;TEST_OUTPUT_PREFIX;TEST_OUTPUT_SUFFIX;TEST_PREFIX;TEST_REPORTER;TEST_SPEC;TEST_SUFFIX;TEST_LIST;CTEST_FILE"
-    "TEST_EXTRA_ARGS;TEST_PROPERTIES;TEST_EXECUTOR;TEST_DL_PATHS;TEST_DL_FRAMEWORK_PATHS;ADD_TAGS_AS_LABELS"
+    "TEST_EXTRA_ARGS;TEST_PROPERTIES;TEST_EXECUTOR"
     ${ARGN}
   )
 
-  set(add_tags "${_ADD_TAGS_AS_LABELS}")
   set(prefix "${_TEST_PREFIX}")
   set(suffix "${_TEST_SUFFIX}")
   set(spec ${_TEST_SPEC})
@@ -37,8 +36,6 @@ function(catch_discover_tests_impl)
   set(output_prefix ${_TEST_OUTPUT_PREFIX})
   set(output_suffix ${_TEST_OUTPUT_SUFFIX})
   set(dl_paths ${_TEST_DL_PATHS})
-  set(dl_framework_paths ${_TEST_DL_FRAMEWORK_PATHS})
-  set(environment_modifications "")
   set(script)
   set(suite)
   set(tests)
@@ -59,33 +56,30 @@ function(catch_discover_tests_impl)
   endif()
 
   if(dl_paths)
-    cmake_path(CONVERT "$ENV{${dl_paths_variable_name}}" TO_NATIVE_PATH_LIST env_dl_paths)
+    cmake_path(CONVERT "${dl_paths}" TO_NATIVE_PATH_LIST paths)
-    list(PREPEND env_dl_paths "${dl_paths}")
-    cmake_path(CONVERT "${env_dl_paths}" TO_NATIVE_PATH_LIST paths)
     set(ENV{${dl_paths_variable_name}} "${paths}")
   endif()
 
-  if(APPLE AND dl_framework_paths)
-    cmake_path(CONVERT "$ENV{DYLD_FRAMEWORK_PATH}" TO_NATIVE_PATH_LIST env_dl_framework_paths)
-    list(PREPEND env_dl_framework_paths "${dl_framework_paths}")
-    cmake_path(CONVERT "${env_dl_framework_paths}" TO_NATIVE_PATH_LIST paths)
-    set(ENV{DYLD_FRAMEWORK_PATH} "${paths}")
-  endif()
-
   execute_process(
-    COMMAND ${_TEST_EXECUTOR} "${_TEST_EXECUTABLE}" ${spec} --list-tests --reporter json
+    COMMAND ${_TEST_EXECUTOR} "${_TEST_EXECUTABLE}" ${spec} --list-tests --verbosity quiet
-    OUTPUT_VARIABLE listing_output
+    OUTPUT_VARIABLE output
     RESULT_VARIABLE result
     WORKING_DIRECTORY "${_TEST_WORKING_DIR}"
   )
   if(NOT ${result} EQUAL 0)
     message(FATAL_ERROR
-      "Error listing tests from executable '${_TEST_EXECUTABLE}':\n"
+      "Error running test executable '${_TEST_EXECUTABLE}':\n"
       "  Result: ${result}\n"
-      "  Output: ${listing_output}\n"
+      "  Output: ${output}\n"
     )
   endif()
 
+  # Make sure to escape ; (semicolons) in test names first, because
+  # that'd break the foreach loop for "Parse output" later and create
+  # wrongly splitted and thus failing test cases (false positives)
+  string(REPLACE ";" "\;" output "${output}")
+  string(REPLACE "\n" ";" output "${output}")
+
   # Prepare reporter
   if(reporter)
     set(reporter_arg "--reporter ${reporter}")
@@ -105,7 +99,7 @@ function(catch_discover_tests_impl)
       )
     elseif(NOT ${reporter_check_result} EQUAL 0)
       message(FATAL_ERROR
-        "Error checking for reporter in test executable '${_TEST_EXECUTABLE}':\n"
+        "Error running test executable '${_TEST_EXECUTABLE}':\n"
         "  Result: ${reporter_check_result}\n"
         "  Output: ${reporter_check_output}\n"
       )
@@ -123,103 +117,50 @@ function(catch_discover_tests_impl)
   if(dl_paths)
     foreach(path ${dl_paths})
       cmake_path(NATIVE_PATH path native_path)
-      list(PREPEND environment_modifications "${dl_paths_variable_name}=path_list_prepend:${native_path}")
+      list(APPEND environment_modifications "${dl_paths_variable_name}=path_list_prepend:${native_path}")
     endforeach()
   endif()
 
-  if(APPLE AND dl_framework_paths)
+  # Parse output
-    foreach(path ${dl_framework_paths})
+  foreach(line ${output})
-      cmake_path(NATIVE_PATH path native_path)
+    set(test "${line}")
-      list(PREPEND environment_modifications "DYLD_FRAMEWORK_PATH=path_list_prepend:${native_path}")
-    endforeach()
-  endif()
-
-  # Parse JSON output for list of tests/class names/tags
-  string(JSON version GET "${listing_output}" "version")
-  if(NOT version STREQUAL "1")
-    message(FATAL_ERROR "Unsupported catch output version: '${version}'")
-  endif()
-
-  # Speed-up reparsing by cutting away unneeded parts of JSON.
-  string(JSON test_listing GET "${listing_output}" "listings" "tests")
-  string(JSON num_tests LENGTH "${test_listing}")
-
-  # Exit early if no tests are detected
-  if(num_tests STREQUAL "0")
-    return()
-  endif()
-
-  # CMake's foreach-RANGE is inclusive, so we have to subtract 1
-  math(EXPR num_tests "${num_tests} - 1")
-
-  foreach(idx RANGE ${num_tests})
-    string(JSON single_test GET ${test_listing} ${idx})
-    string(JSON test_tags GET "${single_test}" "tags")
-    string(JSON plain_name GET "${single_test}" "name")
-
     # Escape characters in test case names that would be parsed by Catch2
     # Note that the \ escaping must happen FIRST! Do not change the order.
-    set(escaped_name "${plain_name}")
+    set(test_name "${test}")
-    foreach(char \\ , [ ] ;)
+    foreach(char \\ , [ ])
-      string(REPLACE ${char} "\\${char}" escaped_name "${escaped_name}")
+      string(REPLACE ${char} "\\${char}" test_name "${test_name}")
     endforeach(char)
     # ...add output dir
     if(output_dir)
-      string(REGEX REPLACE "[^A-Za-z0-9_]" "_" escaped_name_clean "${escaped_name}")
+      string(REGEX REPLACE "[^A-Za-z0-9_]" "_" test_name_clean "${test_name}")
-      set(output_dir_arg "--out ${output_dir}/${output_prefix}${escaped_name_clean}${output_suffix}")
+      set(output_dir_arg "--out ${output_dir}/${output_prefix}${test_name_clean}${output_suffix}")
     endif()
 
     # ...and add to script
     add_command(add_test
-      "${prefix}${plain_name}${suffix}"
+      "${prefix}${test}${suffix}"
       ${_TEST_EXECUTOR}
       "${_TEST_EXECUTABLE}"
-      "${escaped_name}"
+      "${test_name}"
       ${extra_args}
       "${reporter_arg}"
       "${output_dir_arg}"
     )
     add_command(set_tests_properties
-      "${prefix}${plain_name}${suffix}"
+      "${prefix}${test}${suffix}"
       PROPERTIES
       WORKING_DIRECTORY "${_TEST_WORKING_DIR}"
       ${properties}
     )
 
-    if(add_tags)
-      string(JSON num_tags LENGTH "${test_tags}")
-      math(EXPR num_tags "${num_tags} - 1")
-      set(tag_list "")
-      if(num_tags GREATER_EQUAL "0")
-        foreach(tag_idx RANGE ${num_tags})
-          string(JSON a_tag GET "${test_tags}" "${tag_idx}")
-          # Catch2's tags can contain semicolons, which are list element separators
-          # in CMake, so we have to escape them. Ideally we could use the [=[...]=]
-          # syntax for this, but CTest currently keeps the square quotes in the label
-          # name. So we add 2 backslashes to escape it instead.
-          # **IMPORTANT**: The number of backslashes depends on how many layers
-          #                of CMake the tag goes. If this script is changed, the
-          #                number of backslashes to escape may change as well.
-          string(REPLACE ";" "\\;" a_tag "${a_tag}")
-          list(APPEND tag_list "${a_tag}")
-        endforeach()
-
-        add_command(set_tests_properties
-          "${prefix}${plain_name}${suffix}"
-          PROPERTIES
-          LABELS "${tag_list}"
-        )
-      endif()
-    endif(add_tags)
-
     if(environment_modifications)
       add_command(set_tests_properties
-        "${prefix}${plain_name}${suffix}"
+        "${prefix}${test}${suffix}"
         PROPERTIES
         ENVIRONMENT_MODIFICATION "${environment_modifications}")
     endif()
 
-    list(APPEND tests "${prefix}${plain_name}${suffix}")
+    list(APPEND tests "${prefix}${test}${suffix}")
   endforeach()
 
   # Create a list of all discovered tests, which users may use to e.g. set
@@ -246,8 +187,6 @@ if(CMAKE_SCRIPT_MODE_FILE)
     TEST_OUTPUT_PREFIX ${TEST_OUTPUT_PREFIX}
     TEST_OUTPUT_SUFFIX ${TEST_OUTPUT_SUFFIX}
     TEST_DL_PATHS ${TEST_DL_PATHS}
-    TEST_DL_FRAMEWORK_PATHS ${TEST_DL_FRAMEWORK_PATHS}
     CTEST_FILE ${CTEST_FILE}
-    ADD_TAGS_AS_LABELS ${ADD_TAGS_AS_LABELS}
   )
 endif()

extras/CatchShardTests.cmake

@@ -11,7 +11,7 @@
 #  * REPORTER    - reporter spec to use for tests
 #  * TEST_SPEC   - test spec used for filtering tests
 function(catch_add_sharded_tests TARGET)
-  if(${CMAKE_VERSION} VERSION_LESS "3.10.0")
+  if (${CMAKE_VERSION} VERSION_LESS "3.10.0")
     message(FATAL_ERROR "add_sharded_catch_tests only supports CMake versions 3.10.0 and up")
   endif()
 
@@ -23,7 +23,7 @@ function(catch_add_sharded_tests TARGET)
     ${ARGN}
   )
   
-  if(NOT DEFINED _SHARD_COUNT)
+  if (NOT DEFINED _SHARD_COUNT)
     set(_SHARD_COUNT 2)
   endif()
 
@@ -61,6 +61,8 @@ function(catch_add_sharded_tests TARGET)
             -P "${shard_impl_script_file}"
     VERBATIM
   )
+
+
 endfunction()
 
 

extras/CatchShardTestsImpl.cmake

@@ -25,10 +25,10 @@ if(NOT EXISTS "${TEST_BINARY}")
 endif()
 
 set(other_args "")
-if(TEST_SPEC)
+if (TEST_SPEC)
   set(other_args "${other_args} ${TEST_SPEC}")
 endif()
-if(REPORTER_SPEC)
+if (REPORTER_SPEC)
   set(other_args "${other_args} --reporter ${REPORTER_SPEC}")
 endif()
 

extras/ParseAndAddCatchTests.cmake

@@ -56,7 +56,7 @@
 #                                                                                                  #
 #==================================================================================================#
 
-if(CMAKE_MINIMUM_REQUIRED_VERSION VERSION_LESS 2.8.8)
+if (CMAKE_MINIMUM_REQUIRED_VERSION VERSION_LESS 2.8.8)
   message(FATAL_ERROR "ParseAndAddCatchTests requires CMake 2.8.8 or newer")
 endif()
 
@@ -67,9 +67,9 @@ option(PARSE_CATCH_TESTS_ADD_TARGET_IN_TEST_NAME "Add target name to the test na
 option(PARSE_CATCH_TESTS_ADD_TO_CONFIGURE_DEPENDS "Add test file to CMAKE_CONFIGURE_DEPENDS property" OFF)
 
 function(ParseAndAddCatchTests_PrintDebugMessage)
-  if(PARSE_CATCH_TESTS_VERBOSE)
+    if(PARSE_CATCH_TESTS_VERBOSE)
-    message(STATUS "ParseAndAddCatchTests: ${ARGV}")
+            message(STATUS "ParseAndAddCatchTests: ${ARGV}")
-  endif()
+    endif()
 endfunction()
 
 # This removes the contents between
@@ -90,161 +90,163 @@ endfunction()
 
 # Worker function
 function(ParseAndAddCatchTests_ParseFile SourceFile TestTarget)
-  # If SourceFile is an object library, do not scan it (as it is not a file). Exit without giving a warning about a missing file.
+    # If SourceFile is an object library, do not scan it (as it is not a file). Exit without giving a warning about a missing file.
-  if(SourceFile MATCHES "\\\$<TARGET_OBJECTS:.+>")
+    if(SourceFile MATCHES "\\\$<TARGET_OBJECTS:.+>")
-    ParseAndAddCatchTests_PrintDebugMessage("Detected OBJECT library: ${SourceFile} this will not be scanned for tests.")
+        ParseAndAddCatchTests_PrintDebugMessage("Detected OBJECT library: ${SourceFile} this will not be scanned for tests.")
-    return()
+        return()
-  endif()
-  # According to CMake docs EXISTS behavior is well-defined only for full paths.
-  get_filename_component(SourceFile ${SourceFile} ABSOLUTE)
-  if(NOT EXISTS ${SourceFile})
-    message(WARNING "Cannot find source file: ${SourceFile}")
-    return()
-  endif()
-  ParseAndAddCatchTests_PrintDebugMessage("parsing ${SourceFile}")
-  file(STRINGS ${SourceFile} Contents NEWLINE_CONSUME)
-
-  # Remove block and fullline comments
-  ParseAndAddCatchTests_RemoveComments(Contents)
-
-  # Find definition of test names
-  # https://regex101.com/r/JygOND/1
-  string(REGEX MATCHALL "[ \t]*(CATCH_)?(TEMPLATE_)?(TEST_CASE_METHOD|SCENARIO|TEST_CASE)[ \t]*\\([ \t\n]*\"[^\"]*\"[ \t\n]*(,[ \t\n]*\"[^\"]*\")?(,[ \t\n]*[^\,\)]*)*\\)[ \t\n]*\{+[ \t]*(//[^\n]*[Tt][Ii][Mm][Ee][Oo][Uu][Tt][ \t]*[0-9]+)*" Tests "${Contents}")
-
-  if(PARSE_CATCH_TESTS_ADD_TO_CONFIGURE_DEPENDS AND Tests)
-    ParseAndAddCatchTests_PrintDebugMessage("Adding ${SourceFile} to CMAKE_CONFIGURE_DEPENDS property")
-    set_property(
-      DIRECTORY
-      APPEND
-      PROPERTY CMAKE_CONFIGURE_DEPENDS ${SourceFile}
-    )
-  endif()
-
-  # check CMP0110 policy for new add_test() behavior
-  if(POLICY CMP0110)
-    cmake_policy(GET CMP0110 _cmp0110_value) # new add_test() behavior
-  else()
-    # just to be thorough explicitly set the variable
-    set(_cmp0110_value)
-  endif()
-
-  foreach(TestName ${Tests})
-    # Strip newlines
-    string(REGEX REPLACE "\\\\\n|\n" "" TestName "${TestName}")
-
-    # Get test type and fixture if applicable
-    string(REGEX MATCH "(CATCH_)?(TEMPLATE_)?(TEST_CASE_METHOD|SCENARIO|TEST_CASE)[ \t]*\\([^,^\"]*" TestTypeAndFixture "${TestName}")
-    string(REGEX MATCH "(CATCH_)?(TEMPLATE_)?(TEST_CASE_METHOD|SCENARIO|TEST_CASE)" TestType "${TestTypeAndFixture}")
-    string(REGEX REPLACE "${TestType}\\([ \t]*" "" TestFixture "${TestTypeAndFixture}")
-
-    # Get string parts of test definition
-    string(REGEX MATCHALL "\"+([^\\^\"]|\\\\\")+\"+" TestStrings "${TestName}")
-
-    # Strip wrapping quotation marks
-    string(REGEX REPLACE "^\"(.*)\"$" "\\1" TestStrings "${TestStrings}")
-    string(REPLACE "\";\"" ";" TestStrings "${TestStrings}")
-
-    # Validate that a test name and tags have been provided
-    list(LENGTH TestStrings TestStringsLength)
-    if(TestStringsLength GREATER 2 OR TestStringsLength LESS 1)
-      message(FATAL_ERROR "You must provide a valid test name and tags for all tests in ${SourceFile}")
     endif()
-
+    # According to CMake docs EXISTS behavior is well-defined only for full paths.
-    # Assign name and tags
+    get_filename_component(SourceFile ${SourceFile} ABSOLUTE)
-    list(GET TestStrings 0 Name)
+    if(NOT EXISTS ${SourceFile})
-    if("${TestType}" STREQUAL "SCENARIO")
+        message(WARNING "Cannot find source file: ${SourceFile}")
-      set(Name "Scenario: ${Name}")
+        return()
-    endif()
-    if(PARSE_CATCH_TESTS_ADD_FIXTURE_IN_TEST_NAME AND "${TestType}" MATCHES "(CATCH_)?TEST_CASE_METHOD" AND TestFixture)
-      set(CTestName "${TestFixture}:${Name}")
-    else()
-      set(CTestName "${Name}")
-    endif()
-    if(PARSE_CATCH_TESTS_ADD_TARGET_IN_TEST_NAME)
-      set(CTestName "${TestTarget}:${CTestName}")
-    endif()
-    # add target to labels to enable running all tests added from this target
-    set(Labels ${TestTarget})
-    if(TestStringsLength EQUAL 2)
-      list(GET TestStrings 1 Tags)
-      string(TOLOWER "${Tags}" Tags)
-      # remove target from labels if the test is hidden
-      if("${Tags}" MATCHES ".*\\[!?(hide|\\.)\\].*")
-        list(REMOVE_ITEM Labels ${TestTarget})
-      endif()
-      string(REPLACE "]" ";" Tags "${Tags}")
-      string(REPLACE "[" "" Tags "${Tags}")
-    else()
-      # unset tags variable from previous loop
-      unset(Tags)
     endif()
+    ParseAndAddCatchTests_PrintDebugMessage("parsing ${SourceFile}")
+    file(STRINGS ${SourceFile} Contents NEWLINE_CONSUME)
 
-    list(APPEND Labels ${Tags})
+    # Remove block and fullline comments
+    ParseAndAddCatchTests_RemoveComments(Contents)
 
-    set(HiddenTagFound OFF)
+    # Find definition of test names
-    foreach(label ${Labels})
+    # https://regex101.com/r/JygOND/1
-      string(REGEX MATCH "^!hide|^\\." result ${label})
+    string(REGEX MATCHALL "[ \t]*(CATCH_)?(TEMPLATE_)?(TEST_CASE_METHOD|SCENARIO|TEST_CASE)[ \t]*\\([ \t\n]*\"[^\"]*\"[ \t\n]*(,[ \t\n]*\"[^\"]*\")?(,[ \t\n]*[^\,\)]*)*\\)[ \t\n]*\{+[ \t]*(//[^\n]*[Tt][Ii][Mm][Ee][Oo][Uu][Tt][ \t]*[0-9]+)*" Tests "${Contents}")
-      if(result)
-        set(HiddenTagFound ON)
-        break()
-      endif()
-    endforeach(label)
-    if(PARSE_CATCH_TESTS_NO_HIDDEN_TESTS AND ${HiddenTagFound} AND ${CMAKE_VERSION} VERSION_LESS "3.9")
-      ParseAndAddCatchTests_PrintDebugMessage("Skipping test \"${CTestName}\" as it has [!hide], [.] or [.foo] label")
-    else()
-      ParseAndAddCatchTests_PrintDebugMessage("Adding test \"${CTestName}\"")
-      if(Labels)
-        ParseAndAddCatchTests_PrintDebugMessage("Setting labels to ${Labels}")
-      endif()
 
-      # Escape commas in the test spec
+    if(PARSE_CATCH_TESTS_ADD_TO_CONFIGURE_DEPENDS AND Tests)
-      string(REPLACE "," "\\," Name ${Name})
+      ParseAndAddCatchTests_PrintDebugMessage("Adding ${SourceFile} to CMAKE_CONFIGURE_DEPENDS property")
-
-      # Work around CMake 3.18.0 change in `add_test()`, before the escaped quotes were necessary,
-      # only with CMake 3.18.0 the escaped double quotes confuse the call. This change is reverted in 3.18.1
-      # And properly introduced in 3.19 with the CMP0110 policy
-      if(_cmp0110_value STREQUAL "NEW" OR ${CMAKE_VERSION} VERSION_EQUAL "3.18")
-        ParseAndAddCatchTests_PrintDebugMessage("CMP0110 set to NEW, no need for add_test(\"\") workaround")
-      else()
-        ParseAndAddCatchTests_PrintDebugMessage("CMP0110 set to OLD adding \"\" for add_test() workaround")
-        set(CTestName "\"${CTestName}\"")
-      endif()
-
-      # Handle template test cases
-      if("${TestTypeAndFixture}" MATCHES ".*TEMPLATE_.*")
-        set(Name "${Name} - *")
-      endif()
-
-      # Add the test and set its properties
-      add_test(NAME "${CTestName}" COMMAND ${OptionalCatchTestLauncher} $<TARGET_FILE:${TestTarget}> ${Name} ${AdditionalCatchParameters})
-      # Old CMake versions do not document VERSION_GREATER_EQUAL, so we use VERSION_GREATER with 3.8 instead
-      if(PARSE_CATCH_TESTS_NO_HIDDEN_TESTS AND ${HiddenTagFound} AND ${CMAKE_VERSION} VERSION_GREATER "3.8")
-        ParseAndAddCatchTests_PrintDebugMessage("Setting DISABLED test property")
-        set_tests_properties("${CTestName}" PROPERTIES DISABLED ON)
-      else()
-        set_tests_properties("${CTestName}" PROPERTIES FAIL_REGULAR_EXPRESSION "No tests ran"
-                                                LABELS "${Labels}")
-      endif()
       set_property(
-        TARGET ${TestTarget}
+        DIRECTORY
         APPEND
-        PROPERTY ParseAndAddCatchTests_TESTS "${CTestName}")
+        PROPERTY CMAKE_CONFIGURE_DEPENDS ${SourceFile}
-      set_property(
+      )
-        SOURCE ${SourceFile}
-        APPEND
-        PROPERTY ParseAndAddCatchTests_TESTS "${CTestName}")
     endif()
-  endforeach()
+
+    # check CMP0110 policy for new add_test() behavior
+    if(POLICY CMP0110)
+        cmake_policy(GET CMP0110 _cmp0110_value) # new add_test() behavior
+    else()
+        # just to be thorough explicitly set the variable
+        set(_cmp0110_value)
+    endif()
+
+    foreach(TestName ${Tests})
+        # Strip newlines
+        string(REGEX REPLACE "\\\\\n|\n" "" TestName "${TestName}")
+
+        # Get test type and fixture if applicable
+        string(REGEX MATCH "(CATCH_)?(TEMPLATE_)?(TEST_CASE_METHOD|SCENARIO|TEST_CASE)[ \t]*\\([^,^\"]*" TestTypeAndFixture "${TestName}")
+        string(REGEX MATCH "(CATCH_)?(TEMPLATE_)?(TEST_CASE_METHOD|SCENARIO|TEST_CASE)" TestType "${TestTypeAndFixture}")
+        string(REGEX REPLACE "${TestType}\\([ \t]*" "" TestFixture "${TestTypeAndFixture}")
+
+        # Get string parts of test definition
+        string(REGEX MATCHALL "\"+([^\\^\"]|\\\\\")+\"+" TestStrings "${TestName}")
+
+        # Strip wrapping quotation marks
+        string(REGEX REPLACE "^\"(.*)\"$" "\\1" TestStrings "${TestStrings}")
+        string(REPLACE "\";\"" ";" TestStrings "${TestStrings}")
+
+        # Validate that a test name and tags have been provided
+        list(LENGTH TestStrings TestStringsLength)
+        if(TestStringsLength GREATER 2 OR TestStringsLength LESS 1)
+            message(FATAL_ERROR "You must provide a valid test name and tags for all tests in ${SourceFile}")
+        endif()
+
+        # Assign name and tags
+        list(GET TestStrings 0 Name)
+        if("${TestType}" STREQUAL "SCENARIO")
+            set(Name "Scenario: ${Name}")
+        endif()
+        if(PARSE_CATCH_TESTS_ADD_FIXTURE_IN_TEST_NAME AND "${TestType}" MATCHES "(CATCH_)?TEST_CASE_METHOD" AND TestFixture )
+            set(CTestName "${TestFixture}:${Name}")
+        else()
+            set(CTestName "${Name}")
+        endif()
+        if(PARSE_CATCH_TESTS_ADD_TARGET_IN_TEST_NAME)
+            set(CTestName "${TestTarget}:${CTestName}")
+        endif()
+        # add target to labels to enable running all tests added from this target
+        set(Labels ${TestTarget})
+        if(TestStringsLength EQUAL 2)
+            list(GET TestStrings 1 Tags)
+            string(TOLOWER "${Tags}" Tags)
+            # remove target from labels if the test is hidden
+            if("${Tags}" MATCHES ".*\\[!?(hide|\\.)\\].*")
+                list(REMOVE_ITEM Labels ${TestTarget})
+            endif()
+            string(REPLACE "]" ";" Tags "${Tags}")
+            string(REPLACE "[" "" Tags "${Tags}")
+        else()
+          # unset tags variable from previous loop
+          unset(Tags)
+        endif()
+
+        list(APPEND Labels ${Tags})
+
+        set(HiddenTagFound OFF)
+        foreach(label ${Labels})
+            string(REGEX MATCH "^!hide|^\\." result ${label})
+            if(result)
+                set(HiddenTagFound ON)
+                break()
+            endif(result)
+        endforeach(label)
+        if(PARSE_CATCH_TESTS_NO_HIDDEN_TESTS AND ${HiddenTagFound} AND ${CMAKE_VERSION} VERSION_LESS "3.9")
+            ParseAndAddCatchTests_PrintDebugMessage("Skipping test \"${CTestName}\" as it has [!hide], [.] or [.foo] label")
+        else()
+            ParseAndAddCatchTests_PrintDebugMessage("Adding test \"${CTestName}\"")
+            if(Labels)
+                ParseAndAddCatchTests_PrintDebugMessage("Setting labels to ${Labels}")
+            endif()
+
+            # Escape commas in the test spec
+            string(REPLACE "," "\\," Name ${Name})
+
+            # Work around CMake 3.18.0 change in `add_test()`, before the escaped quotes were necessary,
+            # only with CMake 3.18.0 the escaped double quotes confuse the call. This change is reverted in 3.18.1
+            # And properly introduced in 3.19 with the CMP0110 policy
+            if(_cmp0110_value STREQUAL "NEW" OR ${CMAKE_VERSION} VERSION_EQUAL "3.18")
+                ParseAndAddCatchTests_PrintDebugMessage("CMP0110 set to NEW, no need for add_test(\"\") workaround")
+            else()
+                ParseAndAddCatchTests_PrintDebugMessage("CMP0110 set to OLD adding \"\" for add_test() workaround")
+                set(CTestName "\"${CTestName}\"")
+            endif()
+
+            # Handle template test cases
+            if("${TestTypeAndFixture}" MATCHES ".*TEMPLATE_.*")
+              set(Name "${Name} - *")
+            endif()
+
+            # Add the test and set its properties
+            add_test(NAME "${CTestName}" COMMAND ${OptionalCatchTestLauncher} $<TARGET_FILE:${TestTarget}> ${Name} ${AdditionalCatchParameters})
+            # Old CMake versions do not document VERSION_GREATER_EQUAL, so we use VERSION_GREATER with 3.8 instead
+            if(PARSE_CATCH_TESTS_NO_HIDDEN_TESTS AND ${HiddenTagFound} AND ${CMAKE_VERSION} VERSION_GREATER "3.8")
+                ParseAndAddCatchTests_PrintDebugMessage("Setting DISABLED test property")
+                set_tests_properties("${CTestName}" PROPERTIES DISABLED ON)
+            else()
+                set_tests_properties("${CTestName}" PROPERTIES FAIL_REGULAR_EXPRESSION "No tests ran"
+                                                        LABELS "${Labels}")
+            endif()
+            set_property(
+              TARGET ${TestTarget}
+              APPEND
+              PROPERTY ParseAndAddCatchTests_TESTS "${CTestName}")
+            set_property(
+              SOURCE ${SourceFile}
+              APPEND
+              PROPERTY ParseAndAddCatchTests_TESTS "${CTestName}")
+        endif()
+
+
+    endforeach()
 endfunction()
 
 # entry point
 function(ParseAndAddCatchTests TestTarget)
-  message(DEPRECATION "ParseAndAddCatchTest: function deprecated because of possibility of missed test cases. Consider using 'catch_discover_tests' from 'Catch.cmake'")
+    message(DEPRECATION "ParseAndAddCatchTest: function deprecated because of possibility of missed test cases. Consider using 'catch_discover_tests' from 'Catch.cmake'")
-  ParseAndAddCatchTests_PrintDebugMessage("Started parsing ${TestTarget}")
+    ParseAndAddCatchTests_PrintDebugMessage("Started parsing ${TestTarget}")
-  get_target_property(SourceFiles ${TestTarget} SOURCES)
+    get_target_property(SourceFiles ${TestTarget} SOURCES)
-  ParseAndAddCatchTests_PrintDebugMessage("Found the following sources: ${SourceFiles}")
+    ParseAndAddCatchTests_PrintDebugMessage("Found the following sources: ${SourceFiles}")
-  foreach(SourceFile ${SourceFiles})
+    foreach(SourceFile ${SourceFiles})
-    ParseAndAddCatchTests_ParseFile(${SourceFile} ${TestTarget})
+        ParseAndAddCatchTests_ParseFile(${SourceFile} ${TestTarget})
-  endforeach()
+    endforeach()
-  ParseAndAddCatchTests_PrintDebugMessage("Finished parsing ${TestTarget}")
+    ParseAndAddCatchTests_PrintDebugMessage("Finished parsing ${TestTarget}")
 endfunction()

fuzzing/CMakeLists.txt

@@ -15,6 +15,6 @@ target_compile_features(fuzzhelper PUBLIC cxx_std_17)
 target_link_options(fuzzhelper PUBLIC "-fsanitize=fuzzer")
 
 foreach(fuzzer TestSpecParser XmlWriter textflow)
-  add_executable(fuzz_${fuzzer} fuzz_${fuzzer}.cpp)
+add_executable(fuzz_${fuzzer} fuzz_${fuzzer}.cpp)
-  target_link_libraries(fuzz_${fuzzer} PRIVATE fuzzhelper)
+target_link_libraries(fuzz_${fuzzer} PRIVATE fuzzhelper)
 endforeach()

meson.build

@@ -8,7 +8,7 @@
 project(
   'catch2',
   'cpp',
-  version: '3.8.1', # CML version placeholder, don't delete
+  version: '3.5.3', # CML version placeholder, don't delete
   license: 'BSL-1.0',
   meson_version: '>=0.54.1',
 )

meson_options.txt

@@ -1,2 +1 @@
 option('tests', type: 'boolean', value: true, description: 'Build the unit tests')
-option('install', type: 'boolean', value: true, description: 'Install the library')

src/CMakeLists.txt

@@ -40,6 +40,7 @@ set(BENCHMARK_SOURCES
 )
 set(BENCHMARK_FILES ${BENCHMARK_HEADERS} ${BENCHMARK_SOURCES})
 
+
 set(IMPL_HEADERS
  "${PROJECT_BINARY_DIR}/generated-includes/catch2/catch_user_config.hpp"
   ${SOURCES_DIR}/catch_user_config.hpp.in
@@ -47,7 +48,6 @@ set(IMPL_HEADERS
   ${SOURCES_DIR}/catch_approx.hpp
   ${SOURCES_DIR}/catch_assertion_info.hpp
   ${SOURCES_DIR}/catch_assertion_result.hpp
-  ${SOURCES_DIR}/catch_case_sensitive.hpp
   ${SOURCES_DIR}/catch_config.hpp
   ${SOURCES_DIR}/catch_get_random_seed.hpp
   ${SOURCES_DIR}/catch_message.hpp
@@ -67,13 +67,13 @@ set(IMPL_HEADERS
   ${SOURCES_DIR}/catch_version_macros.hpp
   ${SOURCES_DIR}/internal/catch_assertion_handler.hpp
   ${SOURCES_DIR}/internal/catch_case_insensitive_comparisons.hpp
+  ${SOURCES_DIR}/internal/catch_case_sensitive.hpp
   ${SOURCES_DIR}/internal/catch_clara.hpp
   ${SOURCES_DIR}/internal/catch_commandline.hpp
   ${SOURCES_DIR}/internal/catch_compare_traits.hpp
   ${SOURCES_DIR}/internal/catch_compiler_capabilities.hpp
   ${SOURCES_DIR}/internal/catch_config_android_logwrite.hpp
   ${SOURCES_DIR}/internal/catch_config_counter.hpp
-  ${SOURCES_DIR}/internal/catch_config_prefix_messages.hpp
   ${SOURCES_DIR}/internal/catch_config_static_analysis_support.hpp
   ${SOURCES_DIR}/internal/catch_config_uncaught_exceptions.hpp
   ${SOURCES_DIR}/internal/catch_config_wchar.hpp
@@ -194,6 +194,7 @@ set(IMPL_SOURCES
   ${SOURCES_DIR}/internal/catch_random_seed_generation.cpp
   ${SOURCES_DIR}/internal/catch_reporter_registry.cpp
   ${SOURCES_DIR}/internal/catch_reporter_spec_parser.cpp
+  ${SOURCES_DIR}/internal/catch_result_type.cpp
   ${SOURCES_DIR}/internal/catch_reusable_string_stream.cpp
   ${SOURCES_DIR}/internal/catch_run_context.cpp
   ${SOURCES_DIR}/internal/catch_section.cpp
@@ -347,23 +348,44 @@ source_group("generated headers"
 )
 
 add_library(Catch2 ${ALL_FILES})
-if(CATCH_ENABLE_REPRODUCIBLE_BUILD)
+if (CATCH_ENABLE_REPRODUCIBLE_BUILD)
-  add_build_reproducibility_settings(Catch2)
+    add_build_reproducibility_settings(Catch2)
 endif()
 add_library(Catch2::Catch2 ALIAS Catch2)
 
-if(ANDROID)
+if (ANDROID)
-  target_link_libraries(Catch2 PRIVATE log)
+    target_link_libraries(Catch2 PRIVATE log)
 endif()
 
 set_target_properties(Catch2 PROPERTIES
-  DEBUG_POSTFIX "d"
+                          DEBUG_POSTFIX "d"
-  VERSION ${PROJECT_VERSION}
+                                VERSION ${PROJECT_VERSION}
-  SOVERSION ${PROJECT_VERSION}
+                              SOVERSION ${PROJECT_VERSION})
-)
 
-# require C++14
+# depend on bunch of C++11 and C++14 features to have C++14 enabled by default
-target_compile_features(Catch2 PUBLIC cxx_std_14)
+target_compile_features(Catch2
+  PUBLIC
+    cxx_alignas
+    cxx_alignof
+    cxx_attributes
+    cxx_auto_type
+    cxx_constexpr
+    cxx_defaulted_functions
+    cxx_deleted_functions
+    cxx_final
+    cxx_lambdas
+    cxx_noexcept
+    cxx_override
+    cxx_range_for
+    cxx_rvalue_references
+    cxx_static_assert
+    cxx_strong_enums
+    cxx_trailing_return_types
+    cxx_unicode_literals
+    cxx_user_literals
+    cxx_variable_templates
+    cxx_variadic_macros
+)
 
 configure_file(
   "${SOURCES_DIR}/catch_user_config.hpp.in"
@@ -379,97 +401,124 @@ target_include_directories(Catch2
 
 
 add_library(Catch2WithMain
-  ${SOURCES_DIR}/internal/catch_main.cpp
+    ${SOURCES_DIR}/internal/catch_main.cpp
 )
-if(CATCH_ENABLE_REPRODUCIBLE_BUILD)
+if (CATCH_ENABLE_REPRODUCIBLE_BUILD)
-  add_build_reproducibility_settings(Catch2WithMain)
+    add_build_reproducibility_settings(Catch2WithMain)
 endif()
 add_library(Catch2::Catch2WithMain ALIAS Catch2WithMain)
 target_link_libraries(Catch2WithMain PUBLIC Catch2)
 set_target_properties(Catch2WithMain
   PROPERTIES
     OUTPUT_NAME "Catch2Main"
-    VERSION ${PROJECT_VERSION}
+        VERSION ${PROJECT_VERSION}
-    SOVERSION ${PROJECT_VERSION}
+      SOVERSION ${PROJECT_VERSION}
 )
 set_target_properties(Catch2WithMain PROPERTIES DEBUG_POSTFIX "d")
 
-if(NOT_SUBPROJECT)
+if (NOT_SUBPROJECT)
-  # create and install an export set for catch target as Catch2::Catch
+    # create and install an export set for catch target as Catch2::Catch
-  install(
+    install(
-    TARGETS
+      TARGETS
-      Catch2
+        Catch2
-      Catch2WithMain
+        Catch2WithMain
-    EXPORT
+      EXPORT
-      Catch2Targets
+        Catch2Targets
-    LIBRARY DESTINATION
+      LIBRARY DESTINATION
-      ${CMAKE_INSTALL_LIBDIR}
+        ${CMAKE_INSTALL_LIBDIR}
-    ARCHIVE DESTINATION
+      ARCHIVE DESTINATION
-      ${CMAKE_INSTALL_LIBDIR}
+        ${CMAKE_INSTALL_LIBDIR}
-    RUNTIME DESTINATION
+      RUNTIME DESTINATION
-      ${CMAKE_INSTALL_BINDIR}
+        ${CMAKE_INSTALL_BINDIR}
-  )
+    )
 
-  install(
+
-    EXPORT
+    install(
-      Catch2Targets
+      EXPORT
-    NAMESPACE
+        Catch2Targets
-      Catch2::
+      NAMESPACE
-    DESTINATION
+        Catch2::
-      ${CATCH_CMAKE_CONFIG_DESTINATION}
+      DESTINATION
-  )
+        ${CATCH_CMAKE_CONFIG_DESTINATION}
-  # Install the headers
+    )
-  install(
+    # Install the headers
-    DIRECTORY
+    install(
-      "${SOURCES_DIR}"
+      DIRECTORY
-      "${PROJECT_BINARY_DIR}/generated-includes/catch2" # Also install the generated header
+        "${SOURCES_DIR}"
-    DESTINATION
+        "${PROJECT_BINARY_DIR}/generated-includes/catch2" # Also install the generated header
-      "${CMAKE_INSTALL_INCLUDEDIR}"
+      DESTINATION
-    FILES_MATCHING
+        "${CMAKE_INSTALL_INCLUDEDIR}"
-      PATTERN "*.hpp"
+      FILES_MATCHING
-  )
+        PATTERN "*.hpp"
+    )
 endif()
 
 # Some tests require a full recompilation of Catch2 lib with different
 # compilation flags. They can link against this target to recompile all
 # the sources into the binary.
-if(CATCH_BUILD_EXAMPLES OR CATCH_BUILD_EXTRA_TESTS)
+if (CATCH_BUILD_EXAMPLES OR CATCH_BUILD_EXTRA_TESTS)
-  add_library(Catch2_buildall_interface INTERFACE)
+    add_library(Catch2_buildall_interface INTERFACE)
-  target_sources(Catch2_buildall_interface INTERFACE
+    target_sources(Catch2_buildall_interface INTERFACE
-    ${ALL_FILES}
+      ${ALL_FILES}
-    # Also include main entry point
+      # Also include main entry point
-    ${SOURCES_DIR}/internal/catch_main.cpp
+      ${SOURCES_DIR}/internal/catch_main.cpp
-  )
+    )
-  target_include_directories(Catch2_buildall_interface
+    target_include_directories(Catch2_buildall_interface
-    INTERFACE
+      INTERFACE
-      $<BUILD_INTERFACE:${SOURCES_DIR}/..>
+        $<BUILD_INTERFACE:${SOURCES_DIR}/..>
-      $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/generated-includes>
+        $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/generated-includes>
-      $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
+        $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
-  )
+    )
-  target_compile_definitions(Catch2_buildall_interface INTERFACE CATCH_CONFIG_STATIC)
+    target_compile_definitions(Catch2_buildall_interface
-  target_compile_features(Catch2_buildall_interface INTERFACE cxx_std_14)
+      INTERFACE
+        CATCH_CONFIG_STATIC
+    )
+    target_compile_features(Catch2_buildall_interface
+      INTERFACE
+        cxx_alignas
+        cxx_alignof
+        cxx_attributes
+        cxx_auto_type
+        cxx_constexpr
+        cxx_defaulted_functions
+        cxx_deleted_functions
+        cxx_final
+        cxx_lambdas
+        cxx_noexcept
+        cxx_override
+        cxx_range_for
+        cxx_rvalue_references
+        cxx_static_assert
+        cxx_strong_enums
+        cxx_trailing_return_types
+        cxx_unicode_literals
+        cxx_user_literals
+        cxx_variable_templates
+        cxx_variadic_macros
+    )
 endif()
 
 list(APPEND CATCH_WARNING_TARGETS Catch2 Catch2WithMain)
 set(CATCH_WARNING_TARGETS ${CATCH_WARNING_TARGETS} PARENT_SCOPE)
 
+
 # We still do not support building dynamic library with hidden visibility
 # so we want to check & warn users if they do this. However, we won't abort
 # the configuration step so that we don't have to also provide an override.
-if(BUILD_SHARED_LIBS)
+if (BUILD_SHARED_LIBS)
-  set_target_properties(Catch2 Catch2WithMain
-    PROPERTIES
-      WINDOWS_EXPORT_ALL_SYMBOLS ON
-  )
-
-  get_target_property(_VisPreset Catch2 CXX_VISIBILITY_PRESET)
-  if(NOT MSVC AND _VisPreset STREQUAL "hidden")
     set_target_properties(Catch2 Catch2WithMain
       PROPERTIES
-        CXX_VISIBILITY_PRESET "default"
+        WINDOWS_EXPORT_ALL_SYMBOLS ON
-        VISIBILITY_INLINES_HIDDEN OFF
     )
-    message(WARNING "Setting Catch2's visibility to default."
+
-                    " Hidden visibility is not supported.")
+    get_target_property(_VisPreset Catch2 CXX_VISIBILITY_PRESET)
-  endif()
+    if (NOT MSVC AND _VisPreset STREQUAL "hidden")
+        set_target_properties(Catch2 Catch2WithMain
+          PROPERTIES
+            CXX_VISIBILITY_PRESET "default"
+            VISIBILITY_INLINES_HIDDEN OFF
+        )
+        message(WARNING "Setting Catch2's visibility to default."
+                        " Hidden visibility is not supported.")
+    endif()
 endif()

src/catch2/benchmark/catch_benchmark.hpp

@@ -45,12 +45,12 @@ namespace Catch {
                 : fun(CATCH_MOVE(func)), name(CATCH_MOVE(benchmarkName)) {}
 
             template <typename Clock>
-            ExecutionPlan prepare(const IConfig &cfg, Environment env) {
+            ExecutionPlan prepare(const IConfig &cfg, Environment env) const {
                 auto min_time = env.clock_resolution.mean * Detail::minimum_ticks;
                 auto run_time = std::max(min_time, std::chrono::duration_cast<decltype(min_time)>(cfg.benchmarkWarmupTime()));
                 auto&& test = Detail::run_for_at_least<Clock>(std::chrono::duration_cast<IDuration>(run_time), 1, fun);
                 int new_iters = static_cast<int>(std::ceil(min_time * test.iterations / test.elapsed));
-                return { new_iters, test.elapsed / test.iterations * new_iters * cfg.benchmarkSamples(), CATCH_MOVE(fun), std::chrono::duration_cast<FDuration>(cfg.benchmarkWarmupTime()), Detail::warmup_iterations };
+                return { new_iters, test.elapsed / test.iterations * new_iters * cfg.benchmarkSamples(), fun, std::chrono::duration_cast<FDuration>(cfg.benchmarkWarmupTime()), Detail::warmup_iterations };
             }
 
             template <typename Clock = default_clock>
@@ -97,7 +97,7 @@ namespace Catch {
             }
 
             // sets lambda to be used in fun *and* executes benchmark!
-            template <typename Fun, std::enable_if_t<!Detail::is_related_v<Fun, Benchmark>, int> = 0>
+            template <typename Fun, std::enable_if_t<!Detail::is_related<Fun, Benchmark>::value, int> = 0>
                 Benchmark & operator=(Fun func) {
                 auto const* cfg = getCurrentContext().getConfig();
                 if (!cfg->skipBenchmarks()) {

src/catch2/benchmark/catch_outlier_classification.hpp

@@ -19,7 +19,7 @@ namespace Catch {
             int high_mild = 0;      // 1.5 to 3 times IQR above Q3
             int high_severe = 0;    // more than 3 times IQR above Q3
 
-            constexpr int total() const {
+            int total() const {
                 return low_severe + low_mild + high_mild + high_severe;
             }
         };

src/catch2/benchmark/detail/catch_benchmark_function.cpp

@@ -11,13 +11,7 @@
 namespace Catch {
     namespace Benchmark {
         namespace Detail {
-            struct do_nothing {
-                void operator()() const {}
-            };
-
             BenchmarkFunction::callable::~callable() = default;
-            BenchmarkFunction::BenchmarkFunction():
-                f( new model<do_nothing>{ {} } ){}
         } // namespace Detail
     } // namespace Benchmark
 } // namespace Catch

src/catch2/benchmark/detail/catch_benchmark_function.hpp

@@ -21,7 +21,8 @@ namespace Catch {
     namespace Benchmark {
         namespace Detail {
             template <typename T, typename U>
-            static constexpr bool is_related_v = std::is_same<std::decay_t<T>, std::decay_t<U>>::value;
+            struct is_related
+                : std::is_same<std::decay_t<T>, std::decay_t<U>> {};
 
             /// We need to reinvent std::function because every piece of code that might add overhead
             /// in a measurement context needs to have consistent performance characteristics so that we
@@ -34,17 +35,22 @@ namespace Catch {
             private:
                 struct callable {
                     virtual void call(Chronometer meter) const = 0;
+                    virtual Catch::Detail::unique_ptr<callable> clone() const = 0;
                     virtual ~callable(); // = default;
 
                     callable() = default;
-                    callable(callable&&) = default;
+                    callable(callable const&) = default;
-                    callable& operator=(callable&&) = default;
+                    callable& operator=(callable const&) = default;
                 };
                 template <typename Fun>
                 struct model : public callable {
                     model(Fun&& fun_) : fun(CATCH_MOVE(fun_)) {}
                     model(Fun const& fun_) : fun(fun_) {}
 
+                    Catch::Detail::unique_ptr<callable> clone() const override {
+                        return Catch::Detail::make_unique<model<Fun>>( *this );
+                    }
+
                     void call(Chronometer meter) const override {
                         call(meter, is_callable<Fun(Chronometer)>());
                     }
@@ -58,23 +64,37 @@ namespace Catch {
                     Fun fun;
                 };
 
+                struct do_nothing { void operator()() const {} };
+
+                template <typename T>
+                BenchmarkFunction(model<T>* c) : f(c) {}
+
             public:
-                BenchmarkFunction();
+                BenchmarkFunction()
+                    : f(new model<do_nothing>{ {} }) {}
 
                 template <typename Fun,
-                    std::enable_if_t<!is_related_v<Fun, BenchmarkFunction>, int> = 0>
+                    std::enable_if_t<!is_related<Fun, BenchmarkFunction>::value, int> = 0>
                     BenchmarkFunction(Fun&& fun)
                     : f(new model<std::decay_t<Fun>>(CATCH_FORWARD(fun))) {}
 
                 BenchmarkFunction( BenchmarkFunction&& that ) noexcept:
                     f( CATCH_MOVE( that.f ) ) {}
 
+                BenchmarkFunction(BenchmarkFunction const& that)
+                    : f(that.f->clone()) {}
+
                 BenchmarkFunction&
                 operator=( BenchmarkFunction&& that ) noexcept {
                     f = CATCH_MOVE( that.f );
                     return *this;
                 }
 
+                BenchmarkFunction& operator=(BenchmarkFunction const& that) {
+                    f = that.f->clone();
+                    return *this;
+                }
+
                 void operator()(Chronometer meter) const { f->call(meter); }
 
             private:

src/catch2/benchmark/detail/catch_estimate_clock.hpp

@@ -15,6 +15,7 @@
 #include <catch2/benchmark/detail/catch_stats.hpp>
 #include <catch2/benchmark/detail/catch_measure.hpp>
 #include <catch2/benchmark/detail/catch_run_for_at_least.hpp>
+#include <catch2/benchmark/catch_clock.hpp>
 #include <catch2/internal/catch_unique_ptr.hpp>
 
 #include <algorithm>
@@ -26,17 +27,15 @@ namespace Catch {
         namespace Detail {
             template <typename Clock>
             std::vector<double> resolution(int k) {
-                const size_t points = static_cast<size_t>( k + 1 );
+                std::vector<TimePoint<Clock>> times;
-                // To avoid overhead from the branch inside vector::push_back,
+                times.reserve(static_cast<size_t>(k + 1));
-                // we allocate them all and then overwrite.
+                for ( int i = 0; i < k + 1; ++i ) {
-                std::vector<TimePoint<Clock>> times(points);
+                    times.push_back( Clock::now() );
-                for ( auto& time : times ) {
-                    time = Clock::now();
                 }
 
                 std::vector<double> deltas;
                 deltas.reserve(static_cast<size_t>(k));
-                for ( size_t idx = 1; idx < points; ++idx ) {
+                for ( size_t idx = 1; idx < times.size(); ++idx ) {
                     deltas.push_back( static_cast<double>(
                         ( times[idx] - times[idx - 1] ).count() ) );
                 }

src/catch2/benchmark/detail/catch_measure.hpp

@@ -20,7 +20,7 @@ namespace Catch {
             template <typename Clock, typename Fun, typename... Args>
             TimingOf<Fun, Args...> measure(Fun&& fun, Args&&... args) {
                 auto start = Clock::now();
-                auto&& r = Detail::complete_invoke(CATCH_FORWARD(fun), CATCH_FORWARD(args)...);
+                auto&& r = Detail::complete_invoke(fun, CATCH_FORWARD(args)...);
                 auto end = Clock::now();
                 auto delta = end - start;
                 return { delta, CATCH_FORWARD(r), 1 };

src/catch2/benchmark/detail/catch_stats.cpp

@@ -12,7 +12,6 @@
 #include <catch2/internal/catch_compiler_capabilities.hpp>
 #include <catch2/internal/catch_floating_point_helpers.hpp>
 #include <catch2/internal/catch_random_number_generator.hpp>
-#include <catch2/internal/catch_uniform_integer_distribution.hpp>
 
 #include <algorithm>
 #include <cassert>
@@ -39,7 +38,7 @@ namespace Catch {
                           double const* last,
                           Estimator& estimator ) {
                     auto n = static_cast<size_t>( last - first );
-                    Catch::uniform_integer_distribution<size_t> dist( 0, n - 1 );
+                    std::uniform_int_distribution<size_t> dist( 0, n - 1 );
 
                     sample out;
                     out.reserve( resamples );
@@ -178,7 +177,7 @@ namespace Catch {
                                              double diff = b - m;
                                              return a + diff * diff;
                                          } ) /
-                        static_cast<double>( last - first );
+                        ( last - first );
                     return std::sqrt( variance );
                 }
 
@@ -213,7 +212,7 @@ namespace Catch {
                                               double* first,
                                               double* last ) {
                 auto count = last - first;
-                double idx = static_cast<double>((count - 1) * k) / static_cast<double>(q);
+                double idx = (count - 1) * k / static_cast<double>(q);
                 int j = static_cast<int>(idx);
                 double g = idx - j;
                 std::nth_element(first, first + j, last);
@@ -316,10 +315,10 @@ namespace Catch {
 
                 double accel = sum_cubes / ( 6 * std::pow( sum_squares, 1.5 ) );
                 long n = static_cast<long>( resample.size() );
-                double prob_n = static_cast<double>(
+                double prob_n =
                     std::count_if( resample.begin(),
                                    resample.end(),
-                                   [point]( double x ) { return x < point; } )) /
+                                   [point]( double x ) { return x < point; } ) /
                     static_cast<double>( n );
                 // degenerate case with uniform samples
                 if ( Catch::Detail::directCompare( prob_n, 0. ) ) {

src/catch2/benchmark/detail/catch_timing.hpp

@@ -13,6 +13,8 @@
 #include <catch2/benchmark/catch_clock.hpp>
 #include <catch2/benchmark/detail/catch_complete_invoke.hpp>
 
+#include <type_traits>
+
 namespace Catch {
     namespace Benchmark {
         template <typename Result>

src/catch2/catch_all.hpp

@@ -26,7 +26,6 @@
 #include <catch2/catch_approx.hpp>
 #include <catch2/catch_assertion_info.hpp>
 #include <catch2/catch_assertion_result.hpp>
-#include <catch2/catch_case_sensitive.hpp>
 #include <catch2/catch_config.hpp>
 #include <catch2/catch_get_random_seed.hpp>
 #include <catch2/catch_message.hpp>
@@ -48,6 +47,7 @@
 #include <catch2/interfaces/catch_interfaces_all.hpp>
 #include <catch2/internal/catch_assertion_handler.hpp>
 #include <catch2/internal/catch_case_insensitive_comparisons.hpp>
+#include <catch2/internal/catch_case_sensitive.hpp>
 #include <catch2/internal/catch_clara.hpp>
 #include <catch2/internal/catch_commandline.hpp>
 #include <catch2/internal/catch_compare_traits.hpp>

src/catch2/catch_assertion_result.cpp

@@ -11,7 +11,7 @@
 
 namespace Catch {
 
-    AssertionResultData::AssertionResultData(ResultWas::OfType _resultType, LazyExpression const& _lazyExpression):
+    AssertionResultData::AssertionResultData(ResultWas::OfType _resultType, LazyExpression const & _lazyExpression):
         lazyExpression(_lazyExpression),
         resultType(_resultType) {}
 

src/catch2/catch_config.cpp

@@ -107,16 +107,14 @@ namespace Catch {
 
         // Insert the default reporter if user hasn't asked for a specific one
         if ( m_data.reporterSpecifications.empty() ) {
+            m_data.reporterSpecifications.push_back( {
 #if defined( CATCH_CONFIG_DEFAULT_REPORTER )
-            const auto default_spec = CATCH_CONFIG_DEFAULT_REPORTER;
+                CATCH_CONFIG_DEFAULT_REPORTER,
 #else
-            const auto default_spec = "console";
+                "console",
 #endif
-            auto parsed = parseReporterSpec(default_spec);
+                {}, {}, {}
-            CATCH_ENFORCE( parsed,
+            } );
-                           "Cannot parse the provided default reporter spec: '"
-                               << default_spec << '\'' );
-            m_data.reporterSpecifications.push_back( std::move( *parsed ) );
         }
 
         if ( enableBazelEnvSupport() ) {

src/catch2/catch_config.hpp

@@ -76,7 +76,7 @@ namespace Catch {
         WarnAbout::What warnings = WarnAbout::Nothing;
         ShowDurations showDurations = ShowDurations::DefaultForReporter;
         double minDuration = -1;
-        TestRunOrder runOrder = TestRunOrder::Randomized;
+        TestRunOrder runOrder = TestRunOrder::Declared;
         ColourMode defaultColourMode = ColourMode::PlatformDefault;
         WaitForKeypress::When waitForKeypress = WaitForKeypress::Never;
 

src/catch2/catch_message.cpp

@@ -91,7 +91,6 @@ namespace Catch {
                     m_messages.back().message += " := ";
                     start = pos;
                 }
-                break;
             default:; // noop
             }
         }

src/catch2/catch_message.hpp

@@ -94,7 +94,7 @@ namespace Catch {
     do { \
         Catch::AssertionHandler catchAssertionHandler( macroName##_catch_sr, CATCH_INTERNAL_LINEINFO, Catch::StringRef(), resultDisposition ); \
         catchAssertionHandler.handleMessage( messageType, ( Catch::MessageStream() << __VA_ARGS__ + ::Catch::StreamEndStop() ).m_stream.str() ); \
-        catchAssertionHandler.complete(); \
+        INTERNAL_CATCH_REACT( catchAssertionHandler ) \
     } while( false )
 
 ///////////////////////////////////////////////////////////////////////////////

src/catch2/catch_session.cpp

@@ -25,6 +25,7 @@
 #include <catch2/internal/catch_stdstreams.hpp>
 #include <catch2/internal/catch_istream.hpp>
 
+#include <algorithm>
 #include <cassert>
 #include <exception>
 #include <iomanip>
@@ -33,13 +34,7 @@
 namespace Catch {
 
     namespace {
-        static constexpr int TestFailureExitCode = 42;
+        const int MaxExitCode = 255;
-        static constexpr int UnspecifiedErrorExitCode = 1;
-        static constexpr int AllTestsSkippedExitCode = 4;
-        static constexpr int NoTestsRunExitCode = 2;
-        static constexpr int UnmatchedTestSpecExitCode = 3;
-        static constexpr int InvalidTestSpecExitCode = 5;
-
 
         IEventListenerPtr createReporter(std::string const& reporterName, ReporterConfig&& config) {
             auto reporter = Catch::getRegistryHub().getReporterRegistry().create(reporterName, CATCH_MOVE(config));
@@ -203,7 +198,8 @@ namespace Catch {
     }
 
     int Session::applyCommandLine( int argc, char const * const * argv ) {
-        if ( m_startupExceptions ) { return UnspecifiedErrorExitCode; }
+        if( m_startupExceptions )
+            return 1;
 
         auto result = m_cli.parse( Clara::Args( argc, argv ) );
 
@@ -219,7 +215,7 @@ namespace Catch {
                 << TextFlow::Column( result.errorMessage() ).indent( 2 )
                 << "\n\n";
             errStream->stream() << "Run with -? for usage\n\n" << std::flush;
-            return UnspecifiedErrorExitCode;
+            return MaxExitCode;
         }
 
         if( m_configData.showHelp )
@@ -289,7 +285,8 @@ namespace Catch {
     }
 
     int Session::runInternal() {
-        if ( m_startupExceptions ) { return UnspecifiedErrorExitCode; }
+        if( m_startupExceptions )
+            return 1;
 
         if (m_configData.showHelp || m_configData.libIdentify) {
             return 0;
@@ -300,7 +297,7 @@ namespace Catch {
                           << ") must be greater than the shard index ("
                           << m_configData.shardIndex << ")\n"
                           << std::flush;
-            return UnspecifiedErrorExitCode;
+            return 1;
         }
 
         CATCH_TRY {
@@ -323,7 +320,7 @@ namespace Catch {
                 for ( auto const& spec : invalidSpecs ) {
                     reporter->reportInvalidTestSpec( spec );
                 }
-                return InvalidTestSpecExitCode;
+                return 1;
             }
 
 
@@ -337,29 +334,29 @@ namespace Catch {
 
             if ( tests.hadUnmatchedTestSpecs()
                 && m_config->warnAboutUnmatchedTestSpecs() ) {
-                // UnmatchedTestSpecExitCode
+                return 3;
-                return UnmatchedTestSpecExitCode;
             }
 
             if ( totals.testCases.total() == 0
                 && !m_config->zeroTestsCountAsSuccess() ) {
-                return NoTestsRunExitCode;
+                return 2;
             }
 
             if ( totals.testCases.total() > 0 &&
                  totals.testCases.total() == totals.testCases.skipped
                 && !m_config->zeroTestsCountAsSuccess() ) {
-                return AllTestsSkippedExitCode;
+                return 4;
             }
 
-            if ( totals.assertions.failed ) { return TestFailureExitCode; }
+            // Note that on unices only the lower 8 bits are usually used, clamping
-            return 0;
+            // the return value to 255 prevents false negative when some multiple
-
+            // of 256 tests has failed
+            return (std::min) (MaxExitCode, static_cast<int>(totals.assertions.failed));
         }
 #if !defined(CATCH_CONFIG_DISABLE_EXCEPTIONS)
         catch( std::exception& ex ) {
             Catch::cerr() << ex.what() << '\n' << std::flush;
-            return UnspecifiedErrorExitCode;
+            return MaxExitCode;
         }
 #endif
     }

src/catch2/catch_test_case_info.cpp

@@ -22,26 +22,26 @@ namespace Catch {
         static_assert(sizeof(TestCaseProperties) == sizeof(TCP_underlying_type),
                       "The size of the TestCaseProperties is different from the assumed size");
 
-        constexpr TestCaseProperties operator|(TestCaseProperties lhs, TestCaseProperties rhs) {
+        TestCaseProperties operator|(TestCaseProperties lhs, TestCaseProperties rhs) {
             return static_cast<TestCaseProperties>(
                 static_cast<TCP_underlying_type>(lhs) | static_cast<TCP_underlying_type>(rhs)
             );
         }
 
-        constexpr TestCaseProperties& operator|=(TestCaseProperties& lhs, TestCaseProperties rhs) {
+        TestCaseProperties& operator|=(TestCaseProperties& lhs, TestCaseProperties rhs) {
             lhs = static_cast<TestCaseProperties>(
                 static_cast<TCP_underlying_type>(lhs) | static_cast<TCP_underlying_type>(rhs)
             );
             return lhs;
         }
 
-        constexpr TestCaseProperties operator&(TestCaseProperties lhs, TestCaseProperties rhs) {
+        TestCaseProperties operator&(TestCaseProperties lhs, TestCaseProperties rhs) {
             return static_cast<TestCaseProperties>(
                 static_cast<TCP_underlying_type>(lhs) & static_cast<TCP_underlying_type>(rhs)
             );
         }
 
-        constexpr bool applies(TestCaseProperties tcp) {
+        bool applies(TestCaseProperties tcp) {
             static_assert(static_cast<TCP_underlying_type>(TestCaseProperties::None) == 0,
                           "TestCaseProperties::None must be equal to 0");
             return tcp != TestCaseProperties::None;
@@ -80,7 +80,7 @@ namespace Catch {
             return "Anonymous test case " + std::to_string(++counter);
         }
 
-        constexpr StringRef extractFilenamePart(StringRef filename) {
+        StringRef extractFilenamePart(StringRef filename) {
             size_t lastDot = filename.size();
             while (lastDot > 0 && filename[lastDot - 1] != '.') {
                 --lastDot;
@@ -98,7 +98,7 @@ namespace Catch {
         }
 
         // Returns the upper bound on size of extra tags ([#file]+[.])
-        constexpr size_t sizeOfExtraTags(StringRef filepath) {
+        size_t sizeOfExtraTags(StringRef filepath) {
             // [.] is 3, [#] is another 3
             const size_t extras = 3 + 3;
             return extractFilenamePart(filepath).size() + extras;
@@ -259,4 +259,8 @@ namespace Catch {
         return lhs.tags < rhs.tags;
     }
 
+    TestCaseInfo const& TestCaseHandle::getTestCaseInfo() const {
+        return *m_info;
+    }
+
 } // end namespace Catch

src/catch2/catch_test_case_info.hpp

@@ -109,24 +109,14 @@ namespace Catch {
         TestCaseInfo* m_info;
         ITestInvoker* m_invoker;
     public:
-        constexpr TestCaseHandle(TestCaseInfo* info, ITestInvoker* invoker) :
+        TestCaseHandle(TestCaseInfo* info, ITestInvoker* invoker) :
             m_info(info), m_invoker(invoker) {}
 
-        void prepareTestCase() const {
-            m_invoker->prepareTestCase();
-        }
-
-        void tearDownTestCase() const {
-            m_invoker->tearDownTestCase();
-        }
-
         void invoke() const {
             m_invoker->invoke();
         }
 
-        constexpr TestCaseInfo const& getTestCaseInfo() const {
+        TestCaseInfo const& getTestCaseInfo() const;
-            return *m_info;
-        }
     };
 
     Detail::unique_ptr<TestCaseInfo>

src/catch2/catch_test_macros.hpp

@@ -43,7 +43,6 @@
   #define CATCH_TEST_CASE( ... ) INTERNAL_CATCH_TESTCASE( __VA_ARGS__ )
   #define CATCH_TEST_CASE_METHOD( className, ... ) INTERNAL_CATCH_TEST_CASE_METHOD( className, __VA_ARGS__ )
   #define CATCH_METHOD_AS_TEST_CASE( method, ... ) INTERNAL_CATCH_METHOD_AS_TEST_CASE( method, __VA_ARGS__ )
-  #define CATCH_TEST_CASE_PERSISTENT_FIXTURE( className, ... ) INTERNAL_CATCH_TEST_CASE_PERSISTENT_FIXTURE( className, __VA_ARGS__ )
   #define CATCH_REGISTER_TEST_CASE( Function, ... ) INTERNAL_CATCH_REGISTER_TESTCASE( Function, __VA_ARGS__ )
   #define CATCH_SECTION( ... ) INTERNAL_CATCH_SECTION( __VA_ARGS__ )
   #define CATCH_DYNAMIC_SECTION( ... ) INTERNAL_CATCH_DYNAMIC_SECTION( __VA_ARGS__ )
@@ -98,7 +97,6 @@
   #define CATCH_TEST_CASE( ... ) INTERNAL_CATCH_TESTCASE_NO_REGISTRATION(INTERNAL_CATCH_UNIQUE_NAME( CATCH2_INTERNAL_TEST_ ))
   #define CATCH_TEST_CASE_METHOD( className, ... ) INTERNAL_CATCH_TESTCASE_NO_REGISTRATION(INTERNAL_CATCH_UNIQUE_NAME( CATCH2_INTERNAL_TEST_ ))
   #define CATCH_METHOD_AS_TEST_CASE( method, ... )
-  #define CATCH_TEST_CASE_PERSISTENT_FIXTURE( className, ... ) INTERNAL_CATCH_TESTCASE_NO_REGISTRATION(INTERNAL_CATCH_UNIQUE_NAME( CATCH2_INTERNAL_TEST_ ))
   #define CATCH_REGISTER_TEST_CASE( Function, ... ) (void)(0)
   #define CATCH_SECTION( ... )
   #define CATCH_DYNAMIC_SECTION( ... )
@@ -144,7 +142,6 @@
   #define TEST_CASE( ... ) INTERNAL_CATCH_TESTCASE( __VA_ARGS__ )
   #define TEST_CASE_METHOD( className, ... ) INTERNAL_CATCH_TEST_CASE_METHOD( className, __VA_ARGS__ )
   #define METHOD_AS_TEST_CASE( method, ... ) INTERNAL_CATCH_METHOD_AS_TEST_CASE( method, __VA_ARGS__ )
-  #define TEST_CASE_PERSISTENT_FIXTURE( className, ... ) INTERNAL_CATCH_TEST_CASE_PERSISTENT_FIXTURE( className, __VA_ARGS__ )
   #define REGISTER_TEST_CASE( Function, ... ) INTERNAL_CATCH_REGISTER_TESTCASE( Function, __VA_ARGS__ )
   #define SECTION( ... ) INTERNAL_CATCH_SECTION( __VA_ARGS__ )
   #define DYNAMIC_SECTION( ... ) INTERNAL_CATCH_DYNAMIC_SECTION( __VA_ARGS__ )
@@ -198,7 +195,6 @@
   #define TEST_CASE( ... )  INTERNAL_CATCH_TESTCASE_NO_REGISTRATION(INTERNAL_CATCH_UNIQUE_NAME( CATCH2_INTERNAL_TEST_ ), __VA_ARGS__)
   #define TEST_CASE_METHOD( className, ... ) INTERNAL_CATCH_TESTCASE_NO_REGISTRATION(INTERNAL_CATCH_UNIQUE_NAME( CATCH2_INTERNAL_TEST_ ))
   #define METHOD_AS_TEST_CASE( method, ... )
-  #define TEST_CASE_PERSISTENT_FIXTURE( className, ... ) INTERNAL_CATCH_TESTCASE_NO_REGISTRATION(INTERNAL_CATCH_UNIQUE_NAME( CATCH2_INTERNAL_TEST_ ), __VA_ARGS__)
   #define REGISTER_TEST_CASE( Function, ... ) (void)(0)
   #define SECTION( ... )
   #define DYNAMIC_SECTION( ... )

src/catch2/catch_timer.cpp

@@ -13,7 +13,7 @@ namespace Catch {
 
     namespace {
         static auto getCurrentNanosecondsSinceEpoch() -> uint64_t {
-            return std::chrono::duration_cast<std::chrono::nanoseconds>(std::chrono::steady_clock::now().time_since_epoch()).count();
+            return std::chrono::duration_cast<std::chrono::nanoseconds>(std::chrono::high_resolution_clock::now().time_since_epoch()).count();
         }
     } // end unnamed namespace
 
@@ -30,7 +30,7 @@ namespace Catch {
         return static_cast<unsigned int>(getElapsedMicroseconds()/1000);
     }
     auto Timer::getElapsedSeconds() const -> double {
-        return static_cast<double>(getElapsedMicroseconds())/1000000.0;
+        return getElapsedMicroseconds()/1000000.0;
     }
 
 

src/catch2/catch_tostring.cpp

@@ -11,6 +11,7 @@
 #include <catch2/internal/catch_context.hpp>
 #include <catch2/internal/catch_polyfills.hpp>
 
+#include <cmath>
 #include <iomanip>
 
 namespace Catch {
@@ -21,10 +22,7 @@ namespace Detail {
         const int hexThreshold = 255;
 
         struct Endianness {
-            enum Arch : uint8_t {
+            enum Arch { Big, Little };
-                Big,
-                Little
-            };
 
             static Arch which() {
                 int one = 1;
@@ -241,13 +239,13 @@ std::string StringMaker<unsigned char>::convert(unsigned char value) {
     return ::Catch::Detail::stringify(static_cast<char>(value));
 }
 
-int StringMaker<float>::precision = std::numeric_limits<float>::max_digits10;
+int StringMaker<float>::precision = 5;
 
 std::string StringMaker<float>::convert(float value) {
     return Detail::fpToString(value, precision) + 'f';
 }
 
-int StringMaker<double>::precision = std::numeric_limits<double>::max_digits10;
+int StringMaker<double>::precision = 10;
 
 std::string StringMaker<double>::convert(double value) {
     return Detail::fpToString(value, precision);

src/catch2/catch_tostring.hpp

@@ -64,14 +64,18 @@ namespace Catch {
           return rawMemoryToString( &object, sizeof(object) );
         }
 
-        template<typename T,typename = void>
+        template<typename T>
-        static constexpr bool IsStreamInsertable_v = false;
+        class IsStreamInsertable {
+            template<typename Stream, typename U>
+            static auto test(int)
+                -> decltype(std::declval<Stream&>() << std::declval<U>(), std::true_type());
 
-        template <typename T>
+            template<typename, typename>
-        static constexpr bool IsStreamInsertable_v<
+            static auto test(...)->std::false_type;
-            T,
+
-            decltype( void( std::declval<std::ostream&>() << std::declval<T>() ) )> =
+        public:
-            true;
+            static const bool value = decltype(test<std::ostream, const T&>(0))::value;
+        };
 
         template<typename E>
         std::string convertUnknownEnumToString( E e );
@@ -116,7 +120,7 @@ namespace Catch {
     struct StringMaker {
         template <typename Fake = T>
         static
-        std::enable_if_t<::Catch::Detail::IsStreamInsertable_v<Fake>, std::string>
+        std::enable_if_t<::Catch::Detail::IsStreamInsertable<Fake>::value, std::string>
             convert(const Fake& value) {
                 ReusableStringStream rss;
                 // NB: call using the function-like syntax to avoid ambiguity with
@@ -127,7 +131,7 @@ namespace Catch {
 
         template <typename Fake = T>
         static
-        std::enable_if_t<!::Catch::Detail::IsStreamInsertable_v<Fake>, std::string>
+        std::enable_if_t<!::Catch::Detail::IsStreamInsertable<Fake>::value, std::string>
             convert( const Fake& value ) {
 #if !defined(CATCH_CONFIG_FALLBACK_STRINGIFIER)
             return Detail::convertUnstreamable(value);
@@ -519,7 +523,7 @@ namespace Catch {
     }
 
     template<typename R>
-    struct StringMaker<R, std::enable_if_t<is_range<R>::value && !::Catch::Detail::IsStreamInsertable_v<R>>> {
+    struct StringMaker<R, std::enable_if_t<is_range<R>::value && !::Catch::Detail::IsStreamInsertable<R>::value>> {
         static std::string convert( R const& range ) {
             return rangeToString( range );
         }
@@ -630,11 +634,7 @@ struct ratio_string<std::milli> {
 
 #ifdef _MSC_VER
             std::tm timeInfo = {};
-            const auto err = gmtime_s(&timeInfo, &converted);
+            gmtime_s(&timeInfo, &converted);
-            if ( err ) {
-                return "gmtime from provided timepoint has failed. This "
-                       "happens e.g. with pre-1970 dates using Microsoft libc";
-            }
 #else
             std::tm* timeInfo = std::gmtime(&converted);
 #endif

src/catch2/catch_translate_exception.hpp

@@ -25,7 +25,7 @@ namespace Catch {
         class ExceptionTranslator : public IExceptionTranslator {
         public:
 
-            constexpr ExceptionTranslator( std::string(*translateFunction)( T const& ) )
+            ExceptionTranslator( std::string(*translateFunction)( T const& ) )
             : m_translateFunction( translateFunction )
             {}
 

src/catch2/catch_user_config.hpp.in

@@ -178,15 +178,6 @@
 #endif
 
 
-#cmakedefine CATCH_CONFIG_USE_BUILTIN_CONSTANT_P
-#cmakedefine CATCH_CONFIG_NO_USE_BUILTIN_CONSTANT_P
-
-#if defined( CATCH_CONFIG_USE_BUILTIN_CONSTANT_P ) && \
-    defined( CATCH_CONFIG_NO_USE_BUILTIN_CONSTANT_P )
-#    error Cannot force USE_BUILTIN_CONSTANT_P to both ON and OFF
-#endif
-
-
 // ------
 // Simple toggle defines
 // their value is never used and they cannot be overridden

src/catch2/catch_version.cpp

@@ -36,7 +36,7 @@ namespace Catch {
     }
 
     Version const& libraryVersion() {
-        static Version version( 3, 8, 1, "", 0 );
+        static Version version( 3, 5, 3, "", 0 );
         return version;
     }
 

src/catch2/catch_version_macros.hpp

@@ -9,7 +9,7 @@
 #define CATCH_VERSION_MACROS_HPP_INCLUDED
 
 #define CATCH_VERSION_MAJOR 3
-#define CATCH_VERSION_MINOR 8
+#define CATCH_VERSION_MINOR 5
-#define CATCH_VERSION_PATCH 1
+#define CATCH_VERSION_PATCH 3
 
 #endif // CATCH_VERSION_MACROS_HPP_INCLUDED

src/catch2/generators/catch_generators_range.hpp

@@ -91,7 +91,7 @@ public:
 
 template <typename InputIterator,
           typename InputSentinel,
-          typename ResultType = std::remove_const_t<typename std::iterator_traits<InputIterator>::value_type>>
+          typename ResultType = typename std::iterator_traits<InputIterator>::value_type>
 GeneratorWrapper<ResultType> from_range(InputIterator from, InputSentinel to) {
     return GeneratorWrapper<ResultType>(Catch::Detail::make_unique<IteratorGenerator<ResultType>>(from, to));
 }

src/catch2/interfaces/catch_interfaces_capture.hpp

@@ -9,6 +9,7 @@
 #define CATCH_INTERFACES_CAPTURE_HPP_INCLUDED
 
 #include <string>
+#include <chrono>
 
 #include <catch2/internal/catch_stringref.hpp>
 #include <catch2/internal/catch_result_type.hpp>
@@ -76,7 +77,7 @@ namespace Catch {
         virtual void handleMessage
                 (   AssertionInfo const& info,
                     ResultWas::OfType resultType,
-                    std::string&& message,
+                    StringRef message,
                     AssertionReaction& reaction ) = 0;
         virtual void handleUnexpectedExceptionNotThrown
                 (   AssertionInfo const& info,

src/catch2/interfaces/catch_interfaces_config.hpp

@@ -12,6 +12,7 @@
 #include <catch2/internal/catch_stringref.hpp>
 
 #include <chrono>
+#include <iosfwd>
 #include <string>
 #include <vector>
 

src/catch2/interfaces/catch_interfaces_reporter.hpp

@@ -20,6 +20,7 @@
 #include <map>
 #include <string>
 #include <vector>
+#include <iosfwd>
 
 namespace Catch {
 

src/catch2/interfaces/catch_interfaces_test_invoker.hpp

@@ -12,8 +12,6 @@ namespace Catch {
 
     class ITestInvoker {
     public:
-        virtual void prepareTestCase();
-        virtual void tearDownTestCase();
         virtual void invoke() const = 0;
         virtual ~ITestInvoker(); // = default
     };

src/catch2/internal/catch_assertion_handler.cpp

@@ -28,8 +28,8 @@ namespace Catch {
     void AssertionHandler::handleExpr( ITransientExpression const& expr ) {
         m_resultCapture.handleExpr( m_assertionInfo, expr, m_reaction );
     }
-    void AssertionHandler::handleMessage(ResultWas::OfType resultType, std::string&& message) {
+    void AssertionHandler::handleMessage(ResultWas::OfType resultType, StringRef message) {
-        m_resultCapture.handleMessage( m_assertionInfo, resultType, CATCH_MOVE(message), m_reaction );
+        m_resultCapture.handleMessage( m_assertionInfo, resultType, message, m_reaction );
     }
 
     auto AssertionHandler::allowThrows() const -> bool {

src/catch2/internal/catch_assertion_handler.hpp

@@ -42,12 +42,12 @@ namespace Catch {
 
 
         template<typename T>
-        constexpr void handleExpr( ExprLhs<T> const& expr ) {
+        void handleExpr( ExprLhs<T> const& expr ) {
             handleExpr( expr.makeUnaryExpr() );
         }
         void handleExpr( ITransientExpression const& expr );
 
-        void handleMessage(ResultWas::OfType resultType, std::string&& message);
+        void handleMessage(ResultWas::OfType resultType, StringRef message);
 
         void handleExceptionThrownAsExpected();
         void handleUnexpectedExceptionNotThrown();

src/catch2/internal/catch_clara.cpp

@@ -76,7 +76,7 @@ namespace Catch {
                                 { TokenType::Argument,
                                   next.substr( delimiterPos + 1, next.size() ) } );
                         } else {
-                            if ( next.size() > 1 && next[1] != '-' && next.size() > 2 ) {
+                            if ( next[1] != '-' && next.size() > 2 ) {
                                 // Combined short args, e.g. "-ab" for "-a -b"
                                 for ( size_t i = 1; i < next.size(); ++i ) {
                                     m_tokenBuffer.push_back(

src/catch2/internal/catch_compiler_capabilities.hpp

@@ -62,7 +62,7 @@
 #    define CATCH_INTERNAL_SUPPRESS_SHADOW_WARNINGS \
          _Pragma( "GCC diagnostic ignored \"-Wshadow\"" )
 
-#    define CATCH_INTERNAL_CONFIG_USE_BUILTIN_CONSTANT_P
+#    define CATCH_INTERNAL_IGNORE_BUT_WARN(...) (void)__builtin_constant_p(__VA_ARGS__)
 
 #endif
 
@@ -86,45 +86,14 @@
 // clang-cl defines _MSC_VER as well as __clang__, which could cause the
 // start/stop internal suppression macros to be double defined.
 #if defined(__clang__) && !defined(_MSC_VER)
-#    define CATCH_INTERNAL_CONFIG_USE_BUILTIN_CONSTANT_P
+
 #    define CATCH_INTERNAL_START_WARNINGS_SUPPRESSION _Pragma( "clang diagnostic push" )
 #    define CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION  _Pragma( "clang diagnostic pop" )
+
 #endif // __clang__ && !_MSC_VER
 
 #if defined(__clang__)
 
-#    define CATCH_INTERNAL_SUPPRESS_GLOBALS_WARNINGS \
-         _Pragma( "clang diagnostic ignored \"-Wexit-time-destructors\"" ) \
-         _Pragma( "clang diagnostic ignored \"-Wglobal-constructors\"")
-
-#    define CATCH_INTERNAL_SUPPRESS_PARENTHESES_WARNINGS \
-         _Pragma( "clang diagnostic ignored \"-Wparentheses\"" )
-
-#    define CATCH_INTERNAL_SUPPRESS_UNUSED_VARIABLE_WARNINGS \
-         _Pragma( "clang diagnostic ignored \"-Wunused-variable\"" )
-
-#    if (__clang_major__ >= 20)
-#        define CATCH_INTERNAL_SUPPRESS_ZERO_VARIADIC_WARNINGS \
-             _Pragma( "clang diagnostic ignored \"-Wvariadic-macro-arguments-omitted\"" )
-#    elif (__clang_major__ == 19)
-#        define CATCH_INTERNAL_SUPPRESS_ZERO_VARIADIC_WARNINGS \
-	         _Pragma( "clang diagnostic ignored \"-Wc++20-extensions\"" )
-#    else
-#        define CATCH_INTERNAL_SUPPRESS_ZERO_VARIADIC_WARNINGS
-             _Pragma( "clang diagnostic ignored \"-Wgnu-zero-variadic-macro-arguments\"" )
-#    endif
-
-#    define CATCH_INTERNAL_SUPPRESS_UNUSED_TEMPLATE_WARNINGS \
-         _Pragma( "clang diagnostic ignored \"-Wunused-template\"" )
-
-#    define CATCH_INTERNAL_SUPPRESS_COMMA_WARNINGS \
-        _Pragma( "clang diagnostic ignored \"-Wcomma\"" )
-
-#    define CATCH_INTERNAL_SUPPRESS_SHADOW_WARNINGS \
-        _Pragma( "clang diagnostic ignored \"-Wshadow\"" )
-
-#endif // __clang__
-
 // As of this writing, IBM XL's implementation of __builtin_constant_p has a bug
 // which results in calls to destructors being emitted for each temporary,
 // without a matching initialization. In practice, this can result in something
@@ -141,11 +110,35 @@
 // https://developer.nvidia.com/nvidia_bug/3321845.
 //
 // Therefore, `CATCH_INTERNAL_IGNORE_BUT_WARN` is not implemented.
-#if defined( __ibmxl__ ) || defined( __CUDACC__ ) || defined( __NVCOMPILER )
+#  if !defined(__ibmxl__) && !defined(__CUDACC__) && !defined( __NVCOMPILER )
-#    define CATCH_INTERNAL_CONFIG_NO_USE_BUILTIN_CONSTANT_P
+#    define CATCH_INTERNAL_IGNORE_BUT_WARN(...) (void)__builtin_constant_p(__VA_ARGS__) /* NOLINT(cppcoreguidelines-pro-type-vararg, hicpp-vararg) */
-#endif
+#  endif
 
 
+#    define CATCH_INTERNAL_SUPPRESS_GLOBALS_WARNINGS \
+         _Pragma( "clang diagnostic ignored \"-Wexit-time-destructors\"" ) \
+         _Pragma( "clang diagnostic ignored \"-Wglobal-constructors\"")
+
+#    define CATCH_INTERNAL_SUPPRESS_PARENTHESES_WARNINGS \
+         _Pragma( "clang diagnostic ignored \"-Wparentheses\"" )
+
+#    define CATCH_INTERNAL_SUPPRESS_UNUSED_VARIABLE_WARNINGS \
+         _Pragma( "clang diagnostic ignored \"-Wunused-variable\"" )
+
+#    define CATCH_INTERNAL_SUPPRESS_ZERO_VARIADIC_WARNINGS \
+         _Pragma( "clang diagnostic ignored \"-Wgnu-zero-variadic-macro-arguments\"" )
+
+#    define CATCH_INTERNAL_SUPPRESS_UNUSED_TEMPLATE_WARNINGS \
+         _Pragma( "clang diagnostic ignored \"-Wunused-template\"" )
+
+#    define CATCH_INTERNAL_SUPPRESS_COMMA_WARNINGS \
+        _Pragma( "clang diagnostic ignored \"-Wcomma\"" )
+
+#    define CATCH_INTERNAL_SUPPRESS_SHADOW_WARNINGS \
+        _Pragma( "clang diagnostic ignored \"-Wshadow\"" )
+
+#endif // __clang__
+
 
 ////////////////////////////////////////////////////////////////////////////////
 // We know some environments not to support full POSIX signals
@@ -369,22 +362,6 @@
 #endif
 
 
-// The goal of this macro is to avoid evaluation of the arguments, but
-// still have the compiler warn on problems inside...
-#if defined( CATCH_INTERNAL_CONFIG_USE_BUILTIN_CONSTANT_P ) && \
-    !defined( CATCH_INTERNAL_CONFIG_NO_USE_BUILTIN_CONSTANT_P ) && !defined(CATCH_CONFIG_USE_BUILTIN_CONSTANT_P)
-#define CATCH_CONFIG_USE_BUILTIN_CONSTANT_P
-#endif
-
-#if defined( CATCH_CONFIG_USE_BUILTIN_CONSTANT_P ) && \
-    !defined( CATCH_CONFIG_NO_USE_BUILTIN_CONSTANT_P )
-#    define CATCH_INTERNAL_IGNORE_BUT_WARN( ... )                                              \
-        (void)__builtin_constant_p( __VA_ARGS__ ) /* NOLINT(cppcoreguidelines-pro-type-vararg, \
-                                                     hicpp-vararg) */
-#else
-#    define CATCH_INTERNAL_IGNORE_BUT_WARN( ... )
-#endif
-
 // Even if we do not think the compiler has that warning, we still have
 // to provide a macro that can be used by the code.
 #if !defined(CATCH_INTERNAL_START_WARNINGS_SUPPRESSION)
@@ -421,6 +398,13 @@
 #    define CATCH_INTERNAL_SUPPRESS_SHADOW_WARNINGS
 #endif
 
+
+// The goal of this macro is to avoid evaluation of the arguments, but
+// still have the compiler warn on problems inside...
+#if !defined(CATCH_INTERNAL_IGNORE_BUT_WARN)
+#   define CATCH_INTERNAL_IGNORE_BUT_WARN(...)
+#endif
+
 #if defined(__APPLE__) && defined(__apple_build_version__) && (__clang_major__ < 10)
 #   undef CATCH_INTERNAL_SUPPRESS_UNUSED_TEMPLATE_WARNINGS
 #elif defined(__clang__) && (__clang_major__ < 5)

src/catch2/internal/catch_console_colour.cpp

@@ -161,7 +161,7 @@ namespace {
 #endif // Windows/ ANSI/ None
 
 
-#if defined( CATCH_PLATFORM_LINUX ) || defined( CATCH_PLATFORM_MAC ) || defined( __GLIBC__ )
+#if defined( CATCH_PLATFORM_LINUX ) || defined( CATCH_PLATFORM_MAC )
 #    define CATCH_INTERNAL_HAS_ISATTY
 #    include <unistd.h>
 #endif

src/catch2/internal/catch_context.cpp

@@ -27,6 +27,12 @@ namespace Catch {
         return *Context::currentContext;
     }
 
+    void Context::setResultCapture( IResultCapture* resultCapture ) {
+        m_resultCapture = resultCapture;
+    }
+
+    void Context::setConfig( IConfig const* config ) { m_config = config; }
+
     SimplePcg32& sharedRng() {
         static SimplePcg32 s_rng;
         return s_rng;

src/catch2/internal/catch_context.hpp

@@ -26,15 +26,10 @@ namespace Catch {
         friend void cleanUpContext();
 
     public:
-        constexpr IResultCapture* getResultCapture() const {
+        IResultCapture* getResultCapture() const { return m_resultCapture; }
-            return m_resultCapture;
+        IConfig const* getConfig() const { return m_config; }
-        }
+        void setResultCapture( IResultCapture* resultCapture );
-        constexpr IConfig const* getConfig() const { return m_config; }
+        void setConfig( IConfig const* config );
-        constexpr void setResultCapture( IResultCapture* resultCapture ) {
-            m_resultCapture = resultCapture;
-        }
-        constexpr void setConfig( IConfig const* config ) { m_config = config; }
-
     };
 
     Context& getCurrentMutableContext();

src/catch2/internal/catch_decomposer.hpp

@@ -45,7 +45,7 @@
  *    when the compiler handles `ExprLhs<T> == b`, it also tries to resolve
  *    the overload set for `b == ExprLhs<T>`.
  *
- * To accommodate these use cases, decomposer ended up rather complex.
+ * To accomodate these use cases, decomposer ended up rather complex.
  *
  * 1) These types are handled by adding SFINAE overloads to our comparison
  *    operators, checking whether `T == U` are comparable with the given
@@ -110,11 +110,9 @@
 #ifdef __clang__
 #  pragma clang diagnostic push
 #  pragma clang diagnostic ignored "-Wsign-compare"
-#  pragma clang diagnostic ignored "-Wnon-virtual-dtor"
 #elif defined __GNUC__
 #  pragma GCC diagnostic push
 #  pragma GCC diagnostic ignored "-Wsign-compare"
-#  pragma GCC diagnostic ignored "-Wnon-virtual-dtor"
 #endif
 
 #if defined(CATCH_CPP20_OR_GREATER) && __has_include(<compare>)
@@ -127,12 +125,6 @@
 
 namespace Catch {
 
-    namespace Detail {
-        // This was added in C++20, but we require only C++14 for now.
-        template <typename T>
-        using RemoveCVRef_t = std::remove_cv_t<std::remove_reference_t<T>>;
-    }
-
     // Note: There is nothing that stops us from extending this,
     //       e.g. to `std::is_scalar`, but the more encompassing
     //       traits are usually also more expensive. For now we
@@ -157,13 +149,10 @@ namespace Catch {
         bool m_isBinaryExpression;
         bool m_result;
 
-    protected:
-        ~ITransientExpression() = default;
-
     public:
         constexpr auto isBinaryExpression() const -> bool { return m_isBinaryExpression; }
         constexpr auto getResult() const -> bool { return m_result; }
-        //! This function **has** to be overridden by the derived class.
+        //! This function **has** to be overriden by the derived class.
         virtual void streamReconstructedExpression( std::ostream& os ) const;
 
         constexpr ITransientExpression( bool isBinaryExpression, bool result )
@@ -171,13 +160,17 @@ namespace Catch {
             m_result( result )
         {}
 
-        constexpr ITransientExpression( ITransientExpression const& ) = default;
+        ITransientExpression() = default;
-        constexpr ITransientExpression& operator=( ITransientExpression const& ) = default;
+        ITransientExpression(ITransientExpression const&) = default;
+        ITransientExpression& operator=(ITransientExpression const&) = default;
 
         friend std::ostream& operator<<(std::ostream& out, ITransientExpression const& expr) {
             expr.streamReconstructedExpression(out);
             return out;
         }
+
+    protected:
+        ~ITransientExpression() = default;
     };
 
     void formatReconstructedExpression( std::ostream &os, std::string const& lhs, StringRef op, std::string const& rhs );
@@ -283,17 +276,17 @@ namespace Catch {
 #define CATCH_INTERNAL_DEFINE_EXPRESSION_EQUALITY_OPERATOR( id, op )           \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT&& rhs )             \
-        -> std::enable_if_t<                                                   \
+        ->std::enable_if_t<                                                    \
             Detail::conjunction<Detail::is_##id##_comparable<LhsT, RhsT>,      \
                                 Detail::negation<capture_by_value<             \
-                                    Detail::RemoveCVRef_t<RhsT>>>>::value,     \
+                                    std::remove_reference_t<RhsT>>>>::value,   \
             BinaryExpr<LhsT, RhsT const&>> {                                   \
         return {                                                               \
             static_cast<bool>( lhs.m_lhs op rhs ), lhs.m_lhs, #op##_sr, rhs }; \
     }                                                                          \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT rhs )               \
-        -> std::enable_if_t<                                                   \
+        ->std::enable_if_t<                                                    \
             Detail::conjunction<Detail::is_##id##_comparable<LhsT, RhsT>,      \
                                 capture_by_value<RhsT>>::value,                \
             BinaryExpr<LhsT, RhsT>> {                                          \
@@ -302,7 +295,7 @@ namespace Catch {
     }                                                                          \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT rhs )               \
-        -> std::enable_if_t<                                                   \
+        ->std::enable_if_t<                                                    \
             Detail::conjunction<                                               \
                 Detail::negation<Detail::is_##id##_comparable<LhsT, RhsT>>,    \
                 Detail::is_eq_0_comparable<LhsT>,                              \
@@ -316,7 +309,7 @@ namespace Catch {
     }                                                                          \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT rhs )               \
-        -> std::enable_if_t<                                                   \
+        ->std::enable_if_t<                                                    \
             Detail::conjunction<                                               \
                 Detail::negation<Detail::is_##id##_comparable<LhsT, RhsT>>,    \
                 Detail::is_eq_0_comparable<RhsT>,                              \
@@ -337,17 +330,17 @@ namespace Catch {
 #define CATCH_INTERNAL_DEFINE_EXPRESSION_COMPARISON_OPERATOR( id, op )         \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT&& rhs )             \
-        -> std::enable_if_t<                                                   \
+        ->std::enable_if_t<                                                    \
             Detail::conjunction<Detail::is_##id##_comparable<LhsT, RhsT>,      \
                                 Detail::negation<capture_by_value<             \
-                                    Detail::RemoveCVRef_t<RhsT>>>>::value,     \
+                                    std::remove_reference_t<RhsT>>>>::value,   \
             BinaryExpr<LhsT, RhsT const&>> {                                   \
         return {                                                               \
             static_cast<bool>( lhs.m_lhs op rhs ), lhs.m_lhs, #op##_sr, rhs }; \
     }                                                                          \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT rhs )               \
-        -> std::enable_if_t<                                                   \
+        ->std::enable_if_t<                                                    \
             Detail::conjunction<Detail::is_##id##_comparable<LhsT, RhsT>,      \
                                 capture_by_value<RhsT>>::value,                \
             BinaryExpr<LhsT, RhsT>> {                                          \
@@ -356,7 +349,7 @@ namespace Catch {
     }                                                                          \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT rhs )               \
-        -> std::enable_if_t<                                                   \
+        ->std::enable_if_t<                                                    \
             Detail::conjunction<                                               \
                 Detail::negation<Detail::is_##id##_comparable<LhsT, RhsT>>,    \
                 Detail::is_##id##_0_comparable<LhsT>,                          \
@@ -368,7 +361,7 @@ namespace Catch {
     }                                                                          \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT rhs )               \
-        -> std::enable_if_t<                                                   \
+        ->std::enable_if_t<                                                    \
             Detail::conjunction<                                               \
                 Detail::negation<Detail::is_##id##_comparable<LhsT, RhsT>>,    \
                 Detail::is_##id##_0_comparable<RhsT>,                          \
@@ -389,16 +382,16 @@ namespace Catch {
 #define CATCH_INTERNAL_DEFINE_EXPRESSION_OPERATOR( op )                        \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT&& rhs )             \
-        -> std::enable_if_t<                                                   \
+        ->std::enable_if_t<                                                    \
-            !capture_by_value<Detail::RemoveCVRef_t<RhsT>>::value,             \
+            !capture_by_value<std::remove_reference_t<RhsT>>::value,           \
             BinaryExpr<LhsT, RhsT const&>> {                                   \
         return {                                                               \
             static_cast<bool>( lhs.m_lhs op rhs ), lhs.m_lhs, #op##_sr, rhs }; \
     }                                                                          \
     template <typename RhsT>                                                   \
     constexpr friend auto operator op( ExprLhs&& lhs, RhsT rhs )               \
-        -> std::enable_if_t<capture_by_value<RhsT>::value,                     \
+        ->std::enable_if_t<capture_by_value<RhsT>::value,                      \
-                            BinaryExpr<LhsT, RhsT>> {                          \
+                           BinaryExpr<LhsT, RhsT>> {                           \
         return {                                                               \
             static_cast<bool>( lhs.m_lhs op rhs ), lhs.m_lhs, #op##_sr, rhs }; \
     }
@@ -430,7 +423,8 @@ namespace Catch {
 
     struct Decomposer {
         template <typename T,
-                  std::enable_if_t<!capture_by_value<Detail::RemoveCVRef_t<T>>::value,
+                  std::enable_if_t<
+                      !capture_by_value<std::remove_reference_t<T>>::value,
                       int> = 0>
         constexpr friend auto operator <= ( Decomposer &&, T && lhs ) -> ExprLhs<T const&> {
             return ExprLhs<const T&>{ lhs };

src/catch2/internal/catch_enforce.hpp

@@ -12,7 +12,7 @@
 #include <catch2/internal/catch_compiler_capabilities.hpp>
 #include <catch2/internal/catch_reusable_string_stream.hpp>
 
-#include <exception> // for `std::exception` in no-exception configuration
+#include <exception>
 
 namespace Catch {
 #if !defined(CATCH_CONFIG_DISABLE_EXCEPTIONS)

src/catch2/internal/catch_exception_translator_registry.hpp

@@ -11,6 +11,7 @@
 #include <catch2/interfaces/catch_interfaces_exception.hpp>
 #include <catch2/internal/catch_unique_ptr.hpp>
 
+#include <vector>
 #include <string>
 
 namespace Catch {

src/catch2/internal/catch_is_permutation.hpp

@@ -8,8 +8,8 @@
 #ifndef CATCH_IS_PERMUTATION_HPP_INCLUDED
 #define CATCH_IS_PERMUTATION_HPP_INCLUDED
 
+#include <algorithm>
 #include <iterator>
-#include <type_traits>
 
 namespace Catch {
     namespace Detail {
@@ -18,7 +18,6 @@ namespace Catch {
                   typename Sentinel,
                   typename T,
                   typename Comparator>
-        constexpr
         ForwardIter find_sentinel( ForwardIter start,
                                    Sentinel sentinel,
                                    T const& value,
@@ -34,7 +33,6 @@ namespace Catch {
                   typename Sentinel,
                   typename T,
                   typename Comparator>
-        constexpr
         std::ptrdiff_t count_sentinel( ForwardIter start,
                                        Sentinel sentinel,
                                        T const& value,
@@ -48,7 +46,6 @@ namespace Catch {
         }
 
         template <typename ForwardIter, typename Sentinel>
-        constexpr
         std::enable_if_t<!std::is_same<ForwardIter, Sentinel>::value,
                          std::ptrdiff_t>
         sentinel_distance( ForwardIter iter, const Sentinel sentinel ) {
@@ -61,8 +58,8 @@ namespace Catch {
         }
 
         template <typename ForwardIter>
-        constexpr std::ptrdiff_t sentinel_distance( ForwardIter first,
+        std::ptrdiff_t sentinel_distance( ForwardIter first,
-                                                    ForwardIter last ) {
+                                          ForwardIter last ) {
             return std::distance( first, last );
         }
 
@@ -71,11 +68,11 @@ namespace Catch {
                   typename ForwardIter2,
                   typename Sentinel2,
                   typename Comparator>
-        constexpr bool check_element_counts( ForwardIter1 first_1,
+        bool check_element_counts( ForwardIter1 first_1,
-                                             const Sentinel1 end_1,
+                                   const Sentinel1 end_1,
-                                             ForwardIter2 first_2,
+                                   ForwardIter2 first_2,
-                                             const Sentinel2 end_2,
+                                   const Sentinel2 end_2,
-                                             Comparator cmp ) {
+                                   Comparator cmp ) {
             auto cursor = first_1;
             while ( cursor != end_1 ) {
                 if ( find_sentinel( first_1, cursor, *cursor, cmp ) ==
@@ -105,11 +102,11 @@ namespace Catch {
                   typename ForwardIter2,
                   typename Sentinel2,
                   typename Comparator>
-        constexpr bool is_permutation( ForwardIter1 first_1,
+        bool is_permutation( ForwardIter1 first_1,
-                                       const Sentinel1 end_1,
+                             const Sentinel1 end_1,
-                                       ForwardIter2 first_2,
+                             ForwardIter2 first_2,
-                                       const Sentinel2 end_2,
+                             const Sentinel2 end_2,
-                                       Comparator cmp ) {
+                             Comparator cmp ) {
             // TODO: no optimization for stronger iterators, because we would also have to constrain on sentinel vs not sentinel types
             // TODO: Comparator has to be "both sides", e.g. a == b => b == a
             // This skips shared prefix of the two ranges

src/catch2/internal/catch_istream.cpp

@@ -14,6 +14,8 @@
 
 #include <cstdio>
 #include <fstream>
+#include <sstream>
+#include <vector>
 
 namespace Catch {
 

src/catch2/internal/catch_istream.hpp

@@ -12,6 +12,8 @@
 #include <catch2/internal/catch_unique_ptr.hpp>
 
 #include <iosfwd>
+#include <cstddef>
+#include <ostream>
 #include <string>
 
 namespace Catch {

src/catch2/internal/catch_lazy_expr.hpp

@@ -22,13 +22,13 @@ namespace Catch {
         ITransientExpression const* m_transientExpression = nullptr;
         bool m_isNegated;
     public:
-        constexpr LazyExpression( bool isNegated ):
+        LazyExpression( bool isNegated ):
             m_isNegated(isNegated)
         {}
-        constexpr LazyExpression(LazyExpression const& other) = default;
+        LazyExpression(LazyExpression const& other) = default;
         LazyExpression& operator = ( LazyExpression const& ) = delete;
 
-        constexpr explicit operator bool() const {
+        explicit operator bool() const {
             return m_transientExpression != nullptr;
         }
 

src/catch2/internal/catch_output_redirect.cpp

@@ -5,335 +5,142 @@
 //        https://www.boost.org/LICENSE_1_0.txt)
 
 // SPDX-License-Identifier: BSL-1.0
-#include <catch2/internal/catch_compiler_capabilities.hpp>
-#include <catch2/internal/catch_enforce.hpp>
 #include <catch2/internal/catch_output_redirect.hpp>
-#include <catch2/internal/catch_platform.hpp>
+#include <catch2/internal/catch_enforce.hpp>
-#include <catch2/internal/catch_reusable_string_stream.hpp>
 #include <catch2/internal/catch_stdstreams.hpp>
 
 #include <cstdio>
 #include <cstring>
-#include <iosfwd>
 #include <sstream>
 
-#if defined( CATCH_CONFIG_NEW_CAPTURE )
+#if defined(CATCH_CONFIG_NEW_CAPTURE)
-#    if defined( _MSC_VER )
+    #if defined(_MSC_VER)
-#        include <io.h> //_dup and _dup2
+    #include <io.h>      //_dup and _dup2
-#        define dup _dup
+    #define dup _dup
-#        define dup2 _dup2
+    #define dup2 _dup2
-#        define fileno _fileno
+    #define fileno _fileno
-#    else
+    #else
-#        include <unistd.h> // dup and dup2
+    #include <unistd.h>  // dup and dup2
-#    endif
+    #endif
 #endif
 
+
 namespace Catch {
 
-    namespace {
+    RedirectedStream::RedirectedStream( std::ostream& originalStream, std::ostream& redirectionStream )
-        //! A no-op implementation, used if no reporter wants output
+    :   m_originalStream( originalStream ),
-        //! redirection.
+        m_redirectionStream( redirectionStream ),
-        class NoopRedirect : public OutputRedirect {
+        m_prevBuf( m_originalStream.rdbuf() )
-            void activateImpl() override {}
+    {
-            void deactivateImpl() override {}
+        m_originalStream.rdbuf( m_redirectionStream.rdbuf() );
-            std::string getStdout() override { return {}; }
+    }
-            std::string getStderr() override { return {}; }
-            void clearBuffers() override {}
-        };
 
-        /**
+    RedirectedStream::~RedirectedStream() {
-         * Redirects specific stream's rdbuf with another's.
+        m_originalStream.rdbuf( m_prevBuf );
-         *
+    }
-         * Redirection can be stopped and started on-demand, assumes
-         * that the underlying stream's rdbuf aren't changed by other
-         * users.
-         */
-        class RedirectedStreamNew {
-            std::ostream& m_originalStream;
-            std::ostream& m_redirectionStream;
-            std::streambuf* m_prevBuf;
 
-        public:
+    RedirectedStdOut::RedirectedStdOut() : m_cout( Catch::cout(), m_rss.get() ) {}
-            RedirectedStreamNew( std::ostream& originalStream,
+    auto RedirectedStdOut::str() const -> std::string { return m_rss.str(); }
-                                 std::ostream& redirectionStream ):
-                m_originalStream( originalStream ),
-                m_redirectionStream( redirectionStream ),
-                m_prevBuf( m_originalStream.rdbuf() ) {}
 
-            void startRedirect() {
+    RedirectedStdErr::RedirectedStdErr()
-                m_originalStream.rdbuf( m_redirectionStream.rdbuf() );
+    :   m_cerr( Catch::cerr(), m_rss.get() ),
+        m_clog( Catch::clog(), m_rss.get() )
+    {}
+    auto RedirectedStdErr::str() const -> std::string { return m_rss.str(); }
+
+    RedirectedStreams::RedirectedStreams(std::string& redirectedCout, std::string& redirectedCerr)
+    :   m_redirectedCout(redirectedCout),
+        m_redirectedCerr(redirectedCerr)
+    {}
+
+    RedirectedStreams::~RedirectedStreams() {
+        m_redirectedCout += m_redirectedStdOut.str();
+        m_redirectedCerr += m_redirectedStdErr.str();
+    }
+
+#if defined(CATCH_CONFIG_NEW_CAPTURE)
+
+#if defined(_MSC_VER)
+    TempFile::TempFile() {
+        if (tmpnam_s(m_buffer)) {
+            CATCH_RUNTIME_ERROR("Could not get a temp filename");
+        }
+        if (fopen_s(&m_file, m_buffer, "w+")) {
+            char buffer[100];
+            if (strerror_s(buffer, errno)) {
+                CATCH_RUNTIME_ERROR("Could not translate errno to a string");
             }
-            void stopRedirect() { m_originalStream.rdbuf( m_prevBuf ); }
+            CATCH_RUNTIME_ERROR("Could not open the temp file: '" << m_buffer << "' because: " << buffer);
-        };
+        }
+    }
+#else
+    TempFile::TempFile() {
+        m_file = std::tmpfile();
+        if (!m_file) {
+            CATCH_RUNTIME_ERROR("Could not create a temp file.");
+        }
+    }
 
-        /**
+#endif
-         * Redirects the `std::cout`, `std::cerr`, `std::clog` streams,
-         * but does not touch the actual `stdout`/`stderr` file descriptors.
-         */
-        class StreamRedirect : public OutputRedirect {
-            ReusableStringStream m_redirectedOut, m_redirectedErr;
-            RedirectedStreamNew m_cout, m_cerr, m_clog;
 
-        public:
+    TempFile::~TempFile() {
-            StreamRedirect():
+         // TBD: What to do about errors here?
-                m_cout( Catch::cout(), m_redirectedOut.get() ),
+         std::fclose(m_file);
-                m_cerr( Catch::cerr(), m_redirectedErr.get() ),
+         // We manually create the file on Windows only, on Linux
-                m_clog( Catch::clog(), m_redirectedErr.get() ) {}
+         // it will be autodeleted
+#if defined(_MSC_VER)
+         std::remove(m_buffer);
+#endif
+    }
 
-            void activateImpl() override {
-                m_cout.startRedirect();
-                m_cerr.startRedirect();
-                m_clog.startRedirect();
-            }
-            void deactivateImpl() override {
-                m_cout.stopRedirect();
-                m_cerr.stopRedirect();
-                m_clog.stopRedirect();
-            }
-            std::string getStdout() override { return m_redirectedOut.str(); }
-            std::string getStderr() override { return m_redirectedErr.str(); }
-            void clearBuffers() override {
-                m_redirectedOut.str( "" );
-                m_redirectedErr.str( "" );
-            }
-        };
 
-#if defined( CATCH_CONFIG_NEW_CAPTURE )
+    FILE* TempFile::getFile() {
+        return m_file;
+    }
 
-        // Windows's implementation of std::tmpfile is terrible (it tries
+    std::string TempFile::getContents() {
-        // to create a file inside system folder, thus requiring elevated
+        std::stringstream sstr;
-        // privileges for the binary), so we have to use tmpnam(_s) and
+        char buffer[100] = {};
-        // create the file ourselves there.
+        std::rewind(m_file);
-        class TempFile {
+        while (std::fgets(buffer, sizeof(buffer), m_file)) {
-        public:
+            sstr << buffer;
-            TempFile( TempFile const& ) = delete;
+        }
-            TempFile& operator=( TempFile const& ) = delete;
+        return sstr.str();
-            TempFile( TempFile&& ) = delete;
+    }
-            TempFile& operator=( TempFile&& ) = delete;
 
-#    if defined( _MSC_VER )
+    OutputRedirect::OutputRedirect(std::string& stdout_dest, std::string& stderr_dest) :
-            TempFile() {
+        m_originalStdout(dup(1)),
-                if ( tmpnam_s( m_buffer ) ) {
+        m_originalStderr(dup(2)),
-                    CATCH_RUNTIME_ERROR( "Could not get a temp filename" );
+        m_stdoutDest(stdout_dest),
-                }
+        m_stderrDest(stderr_dest) {
-                if ( fopen_s( &m_file, m_buffer, "wb+" ) ) {
+        dup2(fileno(m_stdoutFile.getFile()), 1);
-                    char buffer[100];
+        dup2(fileno(m_stderrFile.getFile()), 2);
-                    if ( strerror_s( buffer, errno ) ) {
+    }
-                        CATCH_RUNTIME_ERROR(
-                            "Could not translate errno to a string" );
-                    }
-                    CATCH_RUNTIME_ERROR( "Could not open the temp file: '"
-                                         << m_buffer
-                                         << "' because: " << buffer );
-                }
-            }
-#    else
-            TempFile() {
-                m_file = std::tmpfile();
-                if ( !m_file ) {
-                    CATCH_RUNTIME_ERROR( "Could not create a temp file." );
-                }
-            }
-#    endif
 
-            ~TempFile() {
+    OutputRedirect::~OutputRedirect() {
-                // TBD: What to do about errors here?
+        Catch::cout() << std::flush;
-                std::fclose( m_file );
+        fflush(stdout);
-                // We manually create the file on Windows only, on Linux
+        // Since we support overriding these streams, we flush cerr
-                // it will be autodeleted
+        // even though std::cerr is unbuffered
-#    if defined( _MSC_VER )
+        Catch::cerr() << std::flush;
-                std::remove( m_buffer );
+        Catch::clog() << std::flush;
-#    endif
+        fflush(stderr);
-            }
 
-            std::FILE* getFile() { return m_file; }
+        dup2(m_originalStdout, 1);
-            std::string getContents() {
+        dup2(m_originalStderr, 2);
-                ReusableStringStream sstr;
-                constexpr long buffer_size = 100;
-                char buffer[buffer_size + 1] = {};
-                long current_pos = ftell( m_file );
-                CATCH_ENFORCE( current_pos >= 0,
-                               "ftell failed, errno: " << errno );
-                std::rewind( m_file );
-                while ( current_pos > 0 ) {
-                    auto read_characters =
-                        std::fread( buffer,
-                                    1,
-                                    std::min( buffer_size, current_pos ),
-                                    m_file );
-                    buffer[read_characters] = '\0';
-                    sstr << buffer;
-                    current_pos -= static_cast<long>( read_characters );
-                }
-                return sstr.str();
-            }
 
-            void clear() { std::rewind( m_file ); }
+        m_stdoutDest += m_stdoutFile.getContents();
-
+        m_stderrDest += m_stderrFile.getContents();
-        private:
+    }
-            std::FILE* m_file = nullptr;
-            char m_buffer[L_tmpnam] = { 0 };
-        };
-
-        /**
-         * Redirects the actual `stdout`/`stderr` file descriptors.
-         *
-         * Works by replacing the file descriptors numbered 1 and 2
-         * with an open temporary file.
-         */
-        class FileRedirect : public OutputRedirect {
-            TempFile m_outFile, m_errFile;
-            int m_originalOut = -1;
-            int m_originalErr = -1;
-
-            // Flushes cout/cerr/clog streams and stdout/stderr FDs
-            void flushEverything() {
-                Catch::cout() << std::flush;
-                fflush( stdout );
-                // Since we support overriding these streams, we flush cerr
-                // even though std::cerr is unbuffered
-                Catch::cerr() << std::flush;
-                Catch::clog() << std::flush;
-                fflush( stderr );
-            }
-
-        public:
-            FileRedirect():
-                m_originalOut( dup( fileno( stdout ) ) ),
-                m_originalErr( dup( fileno( stderr ) ) ) {
-                CATCH_ENFORCE( m_originalOut >= 0, "Could not dup stdout" );
-                CATCH_ENFORCE( m_originalErr >= 0, "Could not dup stderr" );
-            }
-
-            std::string getStdout() override { return m_outFile.getContents(); }
-            std::string getStderr() override { return m_errFile.getContents(); }
-            void clearBuffers() override {
-                m_outFile.clear();
-                m_errFile.clear();
-            }
-
-            void activateImpl() override {
-                // We flush before starting redirect, to ensure that we do
-                // not capture the end of message sent before activation.
-                flushEverything();
-
-                int ret;
-                ret = dup2( fileno( m_outFile.getFile() ), fileno( stdout ) );
-                CATCH_ENFORCE( ret >= 0,
-                               "dup2 to stdout has failed, errno: " << errno );
-                ret = dup2( fileno( m_errFile.getFile() ), fileno( stderr ) );
-                CATCH_ENFORCE( ret >= 0,
-                               "dup2 to stderr has failed, errno: " << errno );
-            }
-            void deactivateImpl() override {
-                // We flush before ending redirect, to ensure that we
-                // capture all messages sent while the redirect was active.
-                flushEverything();
-
-                int ret;
-                ret = dup2( m_originalOut, fileno( stdout ) );
-                CATCH_ENFORCE(
-                    ret >= 0,
-                    "dup2 of original stdout has failed, errno: " << errno );
-                ret = dup2( m_originalErr, fileno( stderr ) );
-                CATCH_ENFORCE(
-                    ret >= 0,
-                    "dup2 of original stderr has failed, errno: " << errno );
-            }
-        };
 
 #endif // CATCH_CONFIG_NEW_CAPTURE
 
-    } // end namespace
-
-    bool isRedirectAvailable( OutputRedirect::Kind kind ) {
-        switch ( kind ) {
-        // These two are always available
-        case OutputRedirect::None:
-        case OutputRedirect::Streams:
-            return true;
-#if defined( CATCH_CONFIG_NEW_CAPTURE )
-        case OutputRedirect::FileDescriptors:
-            return true;
-#endif
-        default:
-            return false;
-        }
-    }
-
-    Detail::unique_ptr<OutputRedirect> makeOutputRedirect( bool actual ) {
-        if ( actual ) {
-            // TODO: Clean this up later
-#if defined( CATCH_CONFIG_NEW_CAPTURE )
-            return Detail::make_unique<FileRedirect>();
-#else
-            return Detail::make_unique<StreamRedirect>();
-#endif
-        } else {
-            return Detail::make_unique<NoopRedirect>();
-        }
-    }
-
-    RedirectGuard scopedActivate( OutputRedirect& redirectImpl ) {
-        return RedirectGuard( true, redirectImpl );
-    }
-
-    RedirectGuard scopedDeactivate( OutputRedirect& redirectImpl ) {
-        return RedirectGuard( false, redirectImpl );
-    }
-
-    OutputRedirect::~OutputRedirect() = default;
-
-    RedirectGuard::RedirectGuard( bool activate, OutputRedirect& redirectImpl ):
-        m_redirect( &redirectImpl ),
-        m_activate( activate ),
-        m_previouslyActive( redirectImpl.isActive() ) {
-
-        // Skip cases where there is no actual state change.
-        if ( m_activate == m_previouslyActive ) { return; }
-
-        if ( m_activate ) {
-            m_redirect->activate();
-        } else {
-            m_redirect->deactivate();
-        }
-    }
-
-    RedirectGuard::~RedirectGuard() noexcept( false ) {
-        if ( m_moved ) { return; }
-        // Skip cases where there is no actual state change.
-        if ( m_activate == m_previouslyActive ) { return; }
-
-        if ( m_activate ) {
-            m_redirect->deactivate();
-        } else {
-            m_redirect->activate();
-        }
-    }
-
-    RedirectGuard::RedirectGuard( RedirectGuard&& rhs ) noexcept:
-        m_redirect( rhs.m_redirect ),
-        m_activate( rhs.m_activate ),
-        m_previouslyActive( rhs.m_previouslyActive ),
-        m_moved( false ) {
-        rhs.m_moved = true;
-    }
-
-    RedirectGuard& RedirectGuard::operator=( RedirectGuard&& rhs ) noexcept {
-        m_redirect = rhs.m_redirect;
-        m_activate = rhs.m_activate;
-        m_previouslyActive = rhs.m_previouslyActive;
-        m_moved = false;
-        rhs.m_moved = true;
-        return *this;
-    }
-
 } // namespace Catch
 
-#if defined( CATCH_CONFIG_NEW_CAPTURE )
+#if defined(CATCH_CONFIG_NEW_CAPTURE)
-#    if defined( _MSC_VER )
+    #if defined(_MSC_VER)
-#        undef dup
+    #undef dup
-#        undef dup2
+    #undef dup2
-#        undef fileno
+    #undef fileno
-#    endif
+    #endif
 #endif

src/catch2/internal/catch_output_redirect.hpp

@@ -8,69 +8,110 @@
 #ifndef CATCH_OUTPUT_REDIRECT_HPP_INCLUDED
 #define CATCH_OUTPUT_REDIRECT_HPP_INCLUDED
 
-#include <catch2/internal/catch_unique_ptr.hpp>
+#include <catch2/internal/catch_platform.hpp>
+#include <catch2/internal/catch_reusable_string_stream.hpp>
+#include <catch2/internal/catch_compiler_capabilities.hpp>
 
-#include <cassert>
+#include <cstdio>
+#include <iosfwd>
 #include <string>
 
 namespace Catch {
 
+    class RedirectedStream {
+        std::ostream& m_originalStream;
+        std::ostream& m_redirectionStream;
+        std::streambuf* m_prevBuf;
+
+    public:
+        RedirectedStream( std::ostream& originalStream, std::ostream& redirectionStream );
+        ~RedirectedStream();
+    };
+
+    class RedirectedStdOut {
+        ReusableStringStream m_rss;
+        RedirectedStream m_cout;
+    public:
+        RedirectedStdOut();
+        auto str() const -> std::string;
+    };
+
+    // StdErr has two constituent streams in C++, std::cerr and std::clog
+    // This means that we need to redirect 2 streams into 1 to keep proper
+    // order of writes
+    class RedirectedStdErr {
+        ReusableStringStream m_rss;
+        RedirectedStream m_cerr;
+        RedirectedStream m_clog;
+    public:
+        RedirectedStdErr();
+        auto str() const -> std::string;
+    };
+
+    class RedirectedStreams {
+    public:
+        RedirectedStreams(RedirectedStreams const&) = delete;
+        RedirectedStreams& operator=(RedirectedStreams const&) = delete;
+        RedirectedStreams(RedirectedStreams&&) = delete;
+        RedirectedStreams& operator=(RedirectedStreams&&) = delete;
+
+        RedirectedStreams(std::string& redirectedCout, std::string& redirectedCerr);
+        ~RedirectedStreams();
+    private:
+        std::string& m_redirectedCout;
+        std::string& m_redirectedCerr;
+        RedirectedStdOut m_redirectedStdOut;
+        RedirectedStdErr m_redirectedStdErr;
+    };
+
+#if defined(CATCH_CONFIG_NEW_CAPTURE)
+
+    // Windows's implementation of std::tmpfile is terrible (it tries
+    // to create a file inside system folder, thus requiring elevated
+    // privileges for the binary), so we have to use tmpnam(_s) and
+    // create the file ourselves there.
+    class TempFile {
+    public:
+        TempFile(TempFile const&) = delete;
+        TempFile& operator=(TempFile const&) = delete;
+        TempFile(TempFile&&) = delete;
+        TempFile& operator=(TempFile&&) = delete;
+
+        TempFile();
+        ~TempFile();
+
+        std::FILE* getFile();
+        std::string getContents();
+
+    private:
+        std::FILE* m_file = nullptr;
+    #if defined(_MSC_VER)
+        char m_buffer[L_tmpnam] = { 0 };
+    #endif
+    };
+
+
     class OutputRedirect {
-        bool m_redirectActive = false;
-        virtual void activateImpl() = 0;
-        virtual void deactivateImpl() = 0;
     public:
-        enum Kind {
+        OutputRedirect(OutputRedirect const&) = delete;
-            //! No redirect (noop implementation)
+        OutputRedirect& operator=(OutputRedirect const&) = delete;
-            None,
+        OutputRedirect(OutputRedirect&&) = delete;
-            //! Redirect std::cout/std::cerr/std::clog streams internally
+        OutputRedirect& operator=(OutputRedirect&&) = delete;
-            Streams,
-            //! Redirect the stdout/stderr file descriptors into files
-            FileDescriptors,
-        };
 
-        virtual ~OutputRedirect(); // = default;
 
-        // TODO: Do we want to check that redirect is not active before retrieving the output?
+        OutputRedirect(std::string& stdout_dest, std::string& stderr_dest);
-        virtual std::string getStdout() = 0;
+        ~OutputRedirect();
-        virtual std::string getStderr() = 0;
+
-        virtual void clearBuffers() = 0;
+    private:
-        bool isActive() const { return m_redirectActive; }
+        int m_originalStdout = -1;
-        void activate() {
+        int m_originalStderr = -1;
-            assert( !m_redirectActive && "redirect is already active" );
+        TempFile m_stdoutFile;
-            activateImpl();
+        TempFile m_stderrFile;
-            m_redirectActive = true;
+        std::string& m_stdoutDest;
-        }
+        std::string& m_stderrDest;
-        void deactivate() {
-            assert( m_redirectActive && "redirect is not active" );
-            deactivateImpl();
-            m_redirectActive = false;
-        }
     };
 
-    bool isRedirectAvailable( OutputRedirect::Kind kind);
+#endif
-    Detail::unique_ptr<OutputRedirect> makeOutputRedirect( bool actual );
-
-    class RedirectGuard {
-        OutputRedirect* m_redirect;
-        bool m_activate;
-        bool m_previouslyActive;
-        bool m_moved = false;
-
-    public:
-        RedirectGuard( bool activate, OutputRedirect& redirectImpl );
-        ~RedirectGuard() noexcept( false );
-
-        RedirectGuard( RedirectGuard const& ) = delete;
-        RedirectGuard& operator=( RedirectGuard const& ) = delete;
-
-        // C++14 needs move-able guards to return them from functions
-        RedirectGuard( RedirectGuard&& rhs ) noexcept;
-        RedirectGuard& operator=( RedirectGuard&& rhs ) noexcept;
-    };
-
-    RedirectGuard scopedActivate( OutputRedirect& redirectImpl );
-    RedirectGuard scopedDeactivate( OutputRedirect& redirectImpl );
 
 } // end namespace Catch
 

src/catch2/internal/catch_platform.hpp

@@ -11,9 +11,6 @@
 // See e.g.:
 // https://opensource.apple.com/source/CarbonHeaders/CarbonHeaders-18.1/TargetConditionals.h.auto.html
 #ifdef __APPLE__
-#  ifndef __has_extension
-#    define __has_extension(x) 0
-#  endif
 #  include <TargetConditionals.h>
 #  if (defined(TARGET_OS_OSX) && TARGET_OS_OSX == 1) || \
       (defined(TARGET_OS_MAC) && TARGET_OS_MAC == 1)

src/catch2/internal/catch_random_integer_helpers.hpp

@@ -14,34 +14,6 @@
 #include <cstdint>
 #include <type_traits>
 
-// Note: We use the usual enable-disable-autodetect dance here even though
-//       we do not support these in CMake configuration options (yet?).
-//       It is highly unlikely that we will need to make these actually
-//       user-configurable, but this will make it simpler if weend up needing
-//       it, and it provides an escape hatch to the users who need it.
-#if defined( __SIZEOF_INT128__ )
-#    define CATCH_CONFIG_INTERNAL_UINT128
-// Unlike GCC, MSVC does not polyfill umul as mulh + mul pair on ARM machines.
-// Currently we do not bother doing this ourselves, but we could if it became
-// important for perf.
-#elif defined( _MSC_VER ) && defined( _M_X64 )
-#    define CATCH_CONFIG_INTERNAL_MSVC_UMUL128
-#endif
-
-#if defined( CATCH_CONFIG_INTERNAL_UINT128 ) && \
-    !defined( CATCH_CONFIG_NO_UINT128 ) &&      \
-    !defined( CATCH_CONFIG_UINT128 )
-#define CATCH_CONFIG_UINT128
-#endif
-
-#if defined( CATCH_CONFIG_INTERNAL_MSVC_UMUL128 ) && \
-    !defined( CATCH_CONFIG_NO_MSVC_UMUL128 ) &&      \
-    !defined( CATCH_CONFIG_MSVC_UMUL128 )
-#    define CATCH_CONFIG_MSVC_UMUL128
-#    include <intrin.h>
-#endif
-
-
 namespace Catch {
     namespace Detail {
 
@@ -69,57 +41,64 @@ namespace Catch {
         struct ExtendedMultResult {
             T upper;
             T lower;
-            constexpr bool operator==( ExtendedMultResult const& rhs ) const {
+            bool operator==( ExtendedMultResult const& rhs ) const {
                 return upper == rhs.upper && lower == rhs.lower;
             }
         };
 
-        /**
+        // Returns 128 bit result of multiplying lhs and rhs
-         * Returns 128 bit result of lhs * rhs using portable C++ code
-         *
-         * This implementation is almost twice as fast as naive long multiplication,
-         * and unlike intrinsic-based approach, it supports constexpr evaluation.
-         */
         constexpr ExtendedMultResult<std::uint64_t>
-        extendedMultPortable(std::uint64_t lhs, std::uint64_t rhs) {
+        extendedMult( std::uint64_t lhs, std::uint64_t rhs ) {
+            // We use the simple long multiplication approach for
+            // correctness, we can use platform specific builtins
+            // for performance later.
+
+            // Split the lhs and rhs into two 32bit "digits", so that we can
+            // do 64 bit arithmetic to handle carry bits.
+            //            32b    32b    32b    32b
+            //     lhs                  L1     L2
+            //   * rhs                  R1     R2
+            //            ------------------------
+            //                       |  R2 * L2  |
+            //                 |  R2 * L1  |
+            //                 |  R1 * L2  |
+            //           |  R1 * L1  |
+            //           -------------------------
+            //           |  a  |  b  |  c  |  d  |
+
 #define CarryBits( x ) ( x >> 32 )
 #define Digits( x ) ( x & 0xFF'FF'FF'FF )
-            std::uint64_t lhs_low = Digits( lhs );
-            std::uint64_t rhs_low = Digits( rhs );
-            std::uint64_t low_low = ( lhs_low * rhs_low );
-            std::uint64_t high_high = CarryBits( lhs ) * CarryBits( rhs );
 
-            // We add in carry bits from low-low already
+            auto r2l2 = Digits( rhs ) * Digits( lhs );
-            std::uint64_t high_low =
+            auto r2l1 = Digits( rhs ) * CarryBits( lhs );
-                ( CarryBits( lhs ) * rhs_low ) + CarryBits( low_low );
+            auto r1l2 = CarryBits( rhs ) * Digits( lhs );
-            // Note that we can add only low bits from high_low, to avoid
+            auto r1l1 = CarryBits( rhs ) * CarryBits( lhs );
-            // overflow with large inputs
+
-            std::uint64_t low_high =
+            // Sum to columns first
-                ( lhs_low * CarryBits( rhs ) ) + Digits( high_low );
+            auto d = Digits( r2l2 );
+            auto c = CarryBits( r2l2 ) + Digits( r2l1 ) + Digits( r1l2 );
+            auto b = CarryBits( r2l1 ) + CarryBits( r1l2 ) + Digits( r1l1 );
+            auto a = CarryBits( r1l1 );
+
+            // Propagate carries between columns
+            c += CarryBits( d );
+            b += CarryBits( c );
+            a += CarryBits( b );
+
+            // Remove the used carries
+            c = Digits( c );
+            b = Digits( b );
+            a = Digits( a );
 
-            return { high_high + CarryBits( high_low ) + CarryBits( low_high ),
-                     ( low_high << 32 ) | Digits( low_low ) };
 #undef CarryBits
 #undef Digits
-        }
 
-        //! Returns 128 bit result of lhs * rhs
+            return {
-        inline ExtendedMultResult<std::uint64_t>
+                a << 32 | b, // upper 64 bits
-        extendedMult( std::uint64_t lhs, std::uint64_t rhs ) {
+                c << 32 | d  // lower 64 bits
-#if defined( CATCH_CONFIG_UINT128 )
+            };
-            auto result = __uint128_t( lhs ) * __uint128_t( rhs );
-            return { static_cast<std::uint64_t>( result >> 64 ),
-                     static_cast<std::uint64_t>( result ) };
-#elif defined( CATCH_CONFIG_MSVC_UMUL128 )
-            std::uint64_t high;
-            std::uint64_t low = _umul128( lhs, rhs, &high );
-            return { high, low };
-#else
-            return extendedMultPortable( lhs, rhs );
-#endif
         }
 
-
         template <typename UInt>
         constexpr ExtendedMultResult<UInt> extendedMult( UInt lhs, UInt rhs ) {
             static_assert( std::is_unsigned<UInt>::value,
@@ -187,7 +166,6 @@ namespace Catch {
          * get by simple casting ([0, ..., INT_MAX, INT_MIN, ..., -1])
          */
         template <typename OriginalType, typename UnsignedType>
-        constexpr
         std::enable_if_t<std::is_signed<OriginalType>::value, UnsignedType>
         transposeToNaturalOrder( UnsignedType in ) {
             static_assert(
@@ -208,7 +186,6 @@ namespace Catch {
 
         template <typename OriginalType,
                   typename UnsignedType>
-        constexpr
         std::enable_if_t<std::is_unsigned<OriginalType>::value, UnsignedType>
             transposeToNaturalOrder(UnsignedType in) {
             static_assert(