From 25356db175e6b6765780fc885393e75d96d5212a Mon Sep 17 00:00:00 2001
From: games647 <games647@users.noreply.github.com>
Date: Mon, 8 Feb 2021 11:50:58 +0100
Subject: [PATCH] Clean up CI

---
 .github/workflows/maven.yml | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 0809078b..ebad8b22 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -1,4 +1,6 @@
-# Human readable name
+# Automatically build, run unit and integration tests to detect errors early (CI provided by GitHub)
+
+# Human readable name in the actions tab
 name: Java CI
 
 # Build on every push and pull request regardless of the branch
@@ -17,26 +19,30 @@ jobs:
     # Run steps
     steps:
     # Pull changes
-    - uses: actions/checkout@v2.3.4
+    - uses: actions/checkout@v2.3
+
     # Cache artifacts - however this has the downside that we don't get notified of
     # artifact resolution failures like invalid repository
     # Nevertheless the repositories should be more stable and it makes no sense to pull
     # a same version every time
     # A dry run would make more sense
-    - uses: actions/cache@v2.1.3
+    - uses: actions/cache@v2.1
       with:
         path: ~/.m2/repository
         key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
         restore-keys: |
           ${{ runner.os }}-maven-
+
     # Setup Java
     - name: Set up JDK
       uses: actions/setup-java@v1.4.3
       with:
-        # Use Java 8, because it's minimum required version
-        java-version: 8
+        # Use Java 11, because it's minimum required version
+        java-version: 11
+
     # Build and test (included in package)
     - name: Build with Maven and test
     # Run non-interactive, package (with compile+test),
-    # ignore snapshot updates, because they are likely to have breaking changes, enforce checksums to validate posssible errors in depdendencies
-      run: mvn --batch-mode package --no-snapshot-updates --strict-checksums --file pom.xml
+    # ignore snapshot updates, because they are likely to have breaking changes, enforce checksums to validate
+    # possible errors in dependencies
+      run: mvn package test --batch-mode --no-snapshot-updates --strict-checksums --file pom.xml