Fix code formatting according to checkstyle config

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/BukkitLoginSession.java

@@ -51,8 +51,8 @@ public class BukkitLoginSession extends LoginSession {
 
     private SkinProperty skinProperty;
 
-    public BukkitLoginSession(String username, byte[] verifyToken, ClientPublicKey publicKey, boolean registered
-            , StoredProfile profile) {
+    public BukkitLoginSession(String username, byte[] verifyToken, ClientPublicKey publicKey, boolean registered,
+                              StoredProfile profile) {
         super(username, registered, profile);
 
         this.clientPublicKey = publicKey;

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/BungeeManager.java

@@ -33,6 +33,7 @@ import com.google.common.io.ByteArrayDataOutput;
 import com.google.common.io.ByteStreams;
 
 import java.io.IOException;
+import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -113,7 +114,9 @@ public class BungeeManager {
             Class<?> globalConfig = Class.forName("io.papermc.paper.configuration.GlobalConfiguration");
             Object global = globalConfig.getDeclaredMethod("get").invoke(null);
             Object proxiesConfiguration = global.getClass().getDeclaredField("proxies").get(global);
-            Object velocityConfig = proxiesConfiguration.getClass().getDeclaredField("velocity").get(proxiesConfiguration);
+
+            Field velocitySectionField = proxiesConfiguration.getClass().getDeclaredField("velocity");
+            Object velocityConfig = velocitySectionField.get(proxiesConfiguration);
 
             return velocityConfig.getClass().getDeclaredField("enabled").getBoolean(velocityConfig);
         } catch (ClassNotFoundException classNotFoundException) {
@@ -128,7 +131,9 @@ public class BungeeManager {
 
     private boolean detectProxy() {
         try {
-            if (isProxySupported("org.spigotmc.SpigotConfig", "bungee")) return true;
+            if (isProxySupported("org.spigotmc.SpigotConfig", "bungee")) {
+                return true;
+            }
         } catch (ClassNotFoundException classNotFoundException) {
             // leave stacktrace for class not found out
             plugin.getLog().warn("Cannot check for BungeeCord support: {}", classNotFoundException.getMessage());

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/FastLoginBukkit.java

@@ -120,18 +120,7 @@ public class FastLoginBukkit extends JavaPlugin implements PlatformPlugin<Comman
                 ProtocolLibListener.register(this, core.getAntiBot(), core.getConfig().getBoolean("verifyClientKeys"));
 
                 if (isPluginInstalled("floodgate")) {
-                    if (getConfig().getBoolean("floodgatePrefixWorkaround")){
-                        ManualNameChange.register(this, floodgateService);
-                        logger.info("Floodgate prefix injection workaround has been enabled.");
-                        logger.info("If you have problems joining the server, try disabling it in the configuration.");
-                    } else {
-                        logger.warn("We have detected that you are running FastLogin alongside Floodgate and ProtocolLib.");
-                        logger.warn("Currently there is an issue with FastLogin that prevents Floodgate name prefixes from showing up "
-                                + "when it is together used with ProtocolLib.");
-                        logger.warn("If you would like to use Floodgate name prefixes, you can enable an experimental workaround by changing "
-                                + "the value 'floodgatePrefixWorkaround' to true in config.yml.");
-                        logger.warn("For more information visit https://github.com/games647/FastLogin/issues/493");
-                    }
+                    printFloodgateWarning();
                 }
 
                 //if server is using paper - we need to set the skin at pre login anyway, so no need for this listener
@@ -167,6 +156,21 @@ public class FastLoginBukkit extends JavaPlugin implements PlatformPlugin<Comman
         dependencyWarnings();
     }
 
+    private void printFloodgateWarning() {
+        if (getConfig().getBoolean("floodgatePrefixWorkaround")) {
+            ManualNameChange.register(this, floodgateService);
+            logger.info("Floodgate prefix injection workaround has been enabled.");
+            logger.info("If you have problems joining the server, try disabling it in the configuration.");
+        } else {
+            logger.warn("We have detected that you are running FastLogin alongside Floodgate and ProtocolLib.");
+            logger.warn("Currently there is an issue with FastLogin that prevents Floodgate name prefixes from "
+                + "showing up when it is together used with ProtocolLib.");
+            logger.warn("If you would like to use Floodgate name prefixes, you can enable an experimental "
+                + "workaround by changing the value 'floodgatePrefixWorkaround' to true in config.yml.");
+            logger.warn("For more information visit https://github.com/games647/FastLogin/issues/493");
+        }
+    }
+
     private boolean initializeFloodgate() {
         if (getServer().getPluginManager().getPlugin("Geyser-Spigot") != null) {
             geyserService = new GeyserService(GeyserImpl.getInstance(), core);
@@ -295,16 +299,17 @@ public class FastLoginBukkit extends JavaPlugin implements PlatformPlugin<Comman
         receiver.sendMessage(message);
     }
 
-	/**
-	 * Checks if a plugin is installed on the server
-	 * @param name the name of the plugin
-	 * @return true if the plugin is installed
-	 */
-	@Override
-	public boolean isPluginInstalled(String name) {
-	    // the plugin may be enabled after FastLogin, so isPluginEnabled() won't work here
-	    return Bukkit.getServer().getPluginManager().getPlugin(name) != null;
-	}
+    /**
+     * Checks if a plugin is installed on the server
+     *
+     * @param name the name of the plugin
+     * @return true if the plugin is installed
+     */
+    @Override
+    public boolean isPluginInstalled(String name) {
+        // the plugin may be enabled after FastLogin, so isPluginEnabled() won't work here
+        return Bukkit.getServer().getPluginManager().getPlugin(name) != null;
+    }
 
     public FloodgateService getFloodgateService() {
         return floodgateService;
@@ -333,6 +338,6 @@ public class FastLoginBukkit extends JavaPlugin implements PlatformPlugin<Comman
                     + "Floodgate 2.0 from https://ci.opencollab.dev/job/GeyserMC/job/Floodgate/job/dev%252F2.0/");
             logger.warn("Don't forget to update Geyser to a supported version as well from "
                     + "https://ci.opencollab.dev/job/GeyserMC/job/Geyser/job/floodgate-2.0/");
-    	}
+        }
     }
 }

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/command/CrackedCommand.java

@@ -42,7 +42,8 @@ public class CrackedCommand extends ToggleCommand {
     }
 
     @Override
-    public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command, @NotNull String label, String[] args) {
+    public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command, @NotNull String label,
+                             String[] args) {
         if (args.length == 0) {
             onCrackedSelf(sender);
         } else {

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/command/PremiumCommand.java

@@ -49,7 +49,8 @@ public class PremiumCommand extends ToggleCommand {
     }
 
     @Override
-    public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command, @NotNull String label, String[] args) {
+    public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command, @NotNull String label,
+                             String[] args) {
         if (args.length == 0) {
             onPremiumSelf(sender);
         } else {

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/event/BukkitFastLoginAutoLoginEvent.java

@@ -36,7 +36,7 @@ import org.jetbrains.annotations.NotNull;
 
 public class BukkitFastLoginAutoLoginEvent extends Event implements FastLoginAutoLoginEvent, Cancellable {
 
-    private static final HandlerList handlers = new HandlerList();
+    private static final HandlerList HANDLERS = new HandlerList();
     private final LoginSession session;
     private final StoredProfile profile;
     private boolean cancelled;
@@ -70,10 +70,10 @@ public class BukkitFastLoginAutoLoginEvent extends Event implements FastLoginAut
 
     @Override
     public @NotNull HandlerList getHandlers() {
-        return handlers;
+        return HANDLERS;
     }
 
     public static HandlerList getHandlerList() {
-        return handlers;
+        return HANDLERS;
     }
 }

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/event/BukkitFastLoginPreLoginEvent.java

@@ -35,7 +35,7 @@ import org.jetbrains.annotations.NotNull;
 
 public class BukkitFastLoginPreLoginEvent extends Event implements FastLoginPreLoginEvent {
 
-    private static final HandlerList handlers = new HandlerList();
+    private static final HandlerList HANDLERS = new HandlerList();
     private final String username;
     private final LoginSource source;
     private final StoredProfile profile;
@@ -65,10 +65,10 @@ public class BukkitFastLoginPreLoginEvent extends Event implements FastLoginPreL
 
     @Override
     public @NotNull HandlerList getHandlers() {
-        return handlers;
+        return HANDLERS;
     }
 
     public static HandlerList getHandlerList() {
-        return handlers;
+        return HANDLERS;
     }
 }

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/event/BukkitFastLoginPremiumToggleEvent.java

@@ -34,7 +34,7 @@ import org.jetbrains.annotations.NotNull;
 
 public class BukkitFastLoginPremiumToggleEvent extends Event implements FastLoginPremiumToggleEvent {
 
-    private static final HandlerList handlers = new HandlerList();
+    private static final HandlerList HANDLERS = new HandlerList();
     private final StoredProfile profile;
     private final PremiumToggleReason reason;
 
@@ -56,10 +56,10 @@ public class BukkitFastLoginPremiumToggleEvent extends Event implements FastLogi
 
     @Override
     public @NotNull HandlerList getHandlers() {
-        return handlers;
+        return HANDLERS;
     }
 
     public static HandlerList getHandlerList() {
-        return handlers;
+        return HANDLERS;
     }
 }

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/hook/XAuthHook.java

@@ -44,12 +44,12 @@ import org.bukkit.entity.Player;
  * <p>
  * Bukkit: <a href="https://dev.bukkit.org/bukkit-plugins/xauth/">...</a>
  */
-public class xAuthHook implements AuthPlugin<Player> {
+public class XAuthHook implements AuthPlugin<Player> {
 
     private final xAuth xAuthPlugin = xAuth.getPlugin();
     private final FastLoginBukkit plugin;
 
-    public xAuthHook(FastLoginBukkit plugin) {
+    public XAuthHook(FastLoginBukkit plugin) {
         this.plugin = plugin;
     }
 

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/ConnectionListener.java

@@ -97,8 +97,8 @@ public class ConnectionListener implements Listener {
 
             String sessionId = plugin.getSessionId(player.getAddress());
             plugin.getLog().info("No on-going login session for player: {} with ID {}. ", player, sessionId);
-            plugin.getLog().info("Setups using Minecraft proxies will start delayed " +
-                "when the command from the proxy is received");
+            plugin.getLog().info("Setups using Minecraft proxies will start delayed "
+                + "when the command from the proxy is received");
         } else {
             Runnable forceLoginTask = new ForceLoginTask(plugin.getCore(), player, session);
             Bukkit.getScheduler().runTaskAsynchronously(plugin, forceLoginTask);

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/EncryptionUtil.java

@@ -34,7 +34,6 @@ import com.google.common.primitives.Longs;
 import java.io.IOException;
 import java.math.BigInteger;
 import java.nio.charset.StandardCharsets;
-import java.security.GeneralSecurityException;
 import java.security.InvalidKeyException;
 import java.security.KeyFactory;
 import java.security.KeyPair;
@@ -63,20 +62,22 @@ import javax.crypto.spec.SecretKeySpec;
  * Encryption and decryption minecraft util for connection between servers
  * and paid Minecraft account clients.
  */
-class EncryptionUtil {
+final class EncryptionUtil {
 
     public static final int VERIFY_TOKEN_LENGTH = 4;
     public static final String KEY_PAIR_ALGORITHM = "RSA";
 
     private static final int RSA_LENGTH = 1_024;
 
-    private static final PublicKey mojangSessionKey;
+    private static final PublicKey MOJANG_SESSION_KEY;
     private static final int LINE_LENGTH = 76;
-    private static final Encoder KEY_ENCODER = Base64.getMimeEncoder(LINE_LENGTH, "\n".getBytes(StandardCharsets.UTF_8));
+    private static final Encoder KEY_ENCODER = Base64.getMimeEncoder(
+        LINE_LENGTH, "\n".getBytes(StandardCharsets.UTF_8)
+    );
 
     static {
         try {
-            mojangSessionKey = loadMojangSessionKey();
+            MOJANG_SESSION_KEY = loadMojangSessionKey();
         } catch (IOException | NoSuchAlgorithmException | InvalidKeySpecException ex) {
             throw new RuntimeException("Failed to load Mojang session key", ex);
         }
@@ -119,7 +120,7 @@ class EncryptionUtil {
     /**
      * Generate the server id based on client and server data.
      *
-     * @param serverId    session for the current login attempt
+     * @param serverId     session for the current login attempt
      * @param sharedSecret shared secret between the client and the server
      * @param publicKey    public key of the server
      * @return the server id formatted as a hexadecimal string.
@@ -135,7 +136,6 @@ class EncryptionUtil {
      * @param privateKey private server key
      * @param sharedKey  the encrypted shared key
      * @return shared secret key
-     * @throws GeneralSecurityException if it fails to decrypt the data
      */
     public static SecretKey decryptSharedKey(PrivateKey privateKey, byte[] sharedKey)
         throws NoSuchPaddingException, IllegalBlockSizeException, NoSuchAlgorithmException,
@@ -151,7 +151,7 @@ class EncryptionUtil {
 
         Signature verifier = Signature.getInstance("SHA1withRSA");
         // key of the signer
-        verifier.initVerify(mojangSessionKey);
+        verifier.initVerify(MOJANG_SESSION_KEY);
         verifier.update(toSignable(clientKey).getBytes(StandardCharsets.US_ASCII));
         return verifier.verify(clientKey.signature());
     }

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/NameCheckTask.java

@@ -88,8 +88,8 @@ public class NameCheckTask extends JoinManagement<Player, CommandSender, Protoco
     //Minecraft server implementation
     //https://github.com/bergerkiller/CraftSource/blob/master/net.minecraft.server/LoginListener.java#L161
     @Override
-    public void requestPremiumLogin(ProtocolLibLoginSource source, StoredProfile profile
-        , String username, boolean registered) {
+    public void requestPremiumLogin(ProtocolLibLoginSource source, StoredProfile profile,
+                                    String username, boolean registered) {
         try {
             source.enableOnlinemode();
         } catch (Exception ex) {

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibListener.java

@@ -147,13 +147,16 @@ public class ProtocolLibListener extends PacketAdapter {
 
         BukkitLoginSession session = plugin.getSession(sender.getAddress());
         if (session == null) {
-            plugin.getLog().warn("GameProfile {} tried to send encryption response at invalid state", sender.getAddress());
+            plugin.getLog().warn("Profile {} tried to send encryption response at invalid state", sender.getAddress());
             sender.kickPlayer(plugin.getCore().getMessage("invalid-request"));
         } else {
             byte[] expectedVerifyToken = session.getVerifyToken();
             if (verifyNonce(sender, packetEvent.getPacket(), session.getClientPublicKey(), expectedVerifyToken)) {
                 packetEvent.getAsyncMarker().incrementProcessingDelay();
-                Runnable verifyTask = new VerifyResponseTask(plugin, packetEvent, sender, session, sharedSecret, keyPair);
+
+                Runnable verifyTask = new VerifyResponseTask(
+                    plugin, packetEvent, sender, session, sharedSecret, keyPair
+                );
                 plugin.getScheduler().runAsync(verifyTask);
             } else {
                 sender.kickPlayer(plugin.getCore().getMessage("invalid-verify-token"));
@@ -192,8 +195,8 @@ public class ProtocolLibListener extends PacketAdapter {
                 byte[] nonce = packet.getByteArrays().read(1);
                 return EncryptionUtil.verifyNonce(expectedToken, keyPair.getPrivate(), nonce);
             }
-        } catch (NoSuchAlgorithmException | InvalidKeyException | SignatureException | NoSuchPaddingException |
-                 IllegalBlockSizeException | BadPaddingException signatureEx) {
+        } catch (NoSuchAlgorithmException | InvalidKeyException | SignatureException | NoSuchPaddingException
+                 | IllegalBlockSizeException | BadPaddingException signatureEx) {
             plugin.getLog().error("Invalid signature from player {}", sender, signatureEx);
             return false;
         }
@@ -227,7 +230,9 @@ public class ProtocolLibListener extends PacketAdapter {
         plugin.getLog().trace("GameProfile {} with {} connecting", sessionKey, username);
 
         packetEvent.getAsyncMarker().incrementProcessingDelay();
-        Runnable nameCheckTask = new NameCheckTask(plugin, random, player, packetEvent, username, clientKey.orElse(null), keyPair.getPublic());
+        Runnable nameCheckTask = new NameCheckTask(
+            plugin, random, player, packetEvent, username, clientKey.orElse(null), keyPair.getPublic()
+        );
         plugin.getScheduler().runAsync(nameCheckTask);
     }
 

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/ProtocolLibLoginSource.java

@@ -55,7 +55,7 @@ class ProtocolLibLoginSource implements LoginSource {
     private final String serverId = "";
     private byte[] verifyToken;
 
-    public ProtocolLibLoginSource(Player player, Random random, PublicKey serverPublicKey, ClientPublicKey clientKey) {
+    ProtocolLibLoginSource(Player player, Random random, PublicKey serverPublicKey, ClientPublicKey clientKey) {
         this.player = player;
         this.random = random;
         this.publicKey = serverPublicKey;
@@ -126,11 +126,11 @@ class ProtocolLibLoginSource implements LoginSource {
 
     @Override
     public String toString() {
-        return this.getClass().getSimpleName() + '{' +
-                "player=" + player +
-                ", random=" + random +
-                ", serverId='" + serverId + '\'' +
-                ", verifyToken=" + Arrays.toString(verifyToken) +
-                '}';
+        return this.getClass().getSimpleName() + '{'
+            + "player=" + player
+            + ", random=" + random
+            + ", serverId='" + serverId + '\''
+            + ", verifyToken=" + Arrays.toString(verifyToken)
+            + '}';
     }
 }

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocollib/VerifyResponseTask.java

@@ -71,7 +71,9 @@ public class VerifyResponseTask implements Runnable {
     private static final Class<?> ENCRYPTION_CLASS;
 
     static {
-        ENCRYPTION_CLASS = MinecraftReflection.getMinecraftClass("util." + ENCRYPTION_CLASS_NAME, ENCRYPTION_CLASS_NAME);
+        ENCRYPTION_CLASS = MinecraftReflection.getMinecraftClass(
+            "util." + ENCRYPTION_CLASS_NAME, ENCRYPTION_CLASS_NAME
+        );
     }
 
     private final FastLoginBukkit plugin;
@@ -144,7 +146,11 @@ public class VerifyResponseTask implements Runnable {
                 encryptConnection(session, requestedUsername, response.get());
             } else {
                 //user tried to fake an authentication
-                disconnect("invalid-session", "GameProfile {} ({}) tried to log in with an invalid session. ServerId: {}", session.getRequestUsername(), socketAddress, serverId);
+                disconnect(
+                    "invalid-session",
+                    "GameProfile {} ({}) tried to log in with an invalid session. ServerId: {}",
+                    session.getRequestUsername(), socketAddress, serverId
+                );
             }
         } catch (IOException ioEx) {
             disconnect("error-kick", "Failed to connect to session server", ioEx);

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocolsupport/ProtocolLoginSource.java

@@ -60,8 +60,8 @@ public class ProtocolLoginSource implements LoginSource {
 
     @Override
     public String toString() {
-        return this.getClass().getSimpleName() + '{' +
-                "loginStartEvent=" + loginStartEvent +
-                '}';
+        return this.getClass().getSimpleName() + '{'
+            + "loginStartEvent=" + loginStartEvent
+            + '}';
     }
 }

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/listener/protocolsupport/ProtocolSupportListener.java

@@ -112,15 +112,16 @@ public class ProtocolSupportListener extends JoinManagement<Player, CommandSende
     }
 
     @Override
-    public FastLoginPreLoginEvent callFastLoginPreLoginEvent(String username, ProtocolLoginSource source, StoredProfile profile) {
+    public FastLoginPreLoginEvent callFastLoginPreLoginEvent(String username, ProtocolLoginSource source,
+                                                             StoredProfile profile) {
         BukkitFastLoginPreLoginEvent event = new BukkitFastLoginPreLoginEvent(username, source, profile);
         plugin.getServer().getPluginManager().callEvent(event);
         return event;
     }
 
     @Override
-    public void requestPremiumLogin(ProtocolLoginSource source, StoredProfile profile, String username
-            , boolean registered) {
+    public void requestPremiumLogin(ProtocolLoginSource source, StoredProfile profile, String username,
+                                    boolean registered) {
         source.enableOnlinemode();
 
         String ip = source.getAddress().getAddress().getHostAddress();

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/task/DelayedAuthHook.java

@@ -31,7 +31,7 @@ import com.github.games647.fastlogin.bukkit.hook.CrazyLoginHook;
 import com.github.games647.fastlogin.bukkit.hook.LogItHook;
 import com.github.games647.fastlogin.bukkit.hook.LoginSecurityHook;
 import com.github.games647.fastlogin.bukkit.hook.UltraAuthHook;
-import com.github.games647.fastlogin.bukkit.hook.xAuthHook;
+import com.github.games647.fastlogin.bukkit.hook.XAuthHook;
 import com.github.games647.fastlogin.core.hooks.AuthPlugin;
 
 import java.lang.reflect.Constructor;
@@ -95,7 +95,7 @@ public class DelayedAuthHook implements Runnable {
         try {
             List<Class<? extends AuthPlugin<Player>>> hooks = Arrays.asList(AuthMeHook.class,
                 CrazyLoginHook.class, LogItHook.class, LoginSecurityHook.class, UltraAuthHook.class,
-                xAuthHook.class);
+                XAuthHook.class);
 
             for (Class<? extends AuthPlugin<Player>> clazz : hooks) {
                 String pluginName = clazz.getSimpleName();

bukkit/src/main/java/com/github/games647/fastlogin/bukkit/task/FloodgateAuthTask.java

@@ -40,7 +40,8 @@ import org.geysermc.floodgate.api.player.FloodgatePlayer;
 
 public class FloodgateAuthTask extends FloodgateManagement<Player, CommandSender, BukkitLoginSession, FastLoginBukkit> {
 
-    public FloodgateAuthTask(FastLoginCore<Player, CommandSender, FastLoginBukkit> core, Player player, FloodgatePlayer floodgatePlayer) {
+    public FloodgateAuthTask(FastLoginCore<Player, CommandSender, FastLoginBukkit> core, Player player,
+                             FloodgatePlayer floodgatePlayer) {
         super(core, player, floodgatePlayer);
     }