fix: all pipeline failures (#1221)
* fix: update conditional static assertion There is a static assertion that spuriously fails on MSVC that was version checked. Unfortunately it fires every time there is a new compiler update, so for now we will remove the version check and add it back once the compiler bug is fixed. * fix: ios pipeline failure Looks like somewhere along the line, the iOS simulator changed the range of support iOS versions. This changes bumps the version from 9 to 12.0. Also noticed that the GSL OSX bundle version was quite out of date. I bumped this from 3.1.0 to 4.2.0 and created an upgrade checklist file in docs/ so we don't forget these types of tasks in the future. * bump xcode version from 15.4 to 16.4 * fix compiler warning when building gtest for ios * allow for missing include dirs on command line * replace windows-2019 with windows-2025 * update visual studio versions after runner bump * PR feedback: make sure markdown links are syntactically correct
This commit is contained in:
1 parent
7e0943d20d
commit
494e6e988c
4 files changed
+31
-17
No files matched your search
@@ -0,0 +1,19 @@
|
||||
> When bumping the version, you need to update the following files:
|
||||
|
||||
1. [ ] [CMakeLists.txt](../CMakeLists.txt) Bump `GSL_VERSION`
|
||||
1. [ ] [README.md](../README.md) Bump `GIT_TAG`
|
||||
1. [ ] [ios.yml](../.github/workflows/ios.yml) Bump `MACOSX_BUNDLE_BUNDLE_VERSION` and
|
||||
`MACOSX_BUNDLE_SHORT_VERSION_STRING`
|
||||
|
||||
> After updating, you need to create a new GitHub release:
|
||||
|
||||
1. [ ] [Microsoft/GSL - Create Release](https://github.com/microsoft/GSL/releases/new)
|
||||
|
||||
Be sure to update the release notes accordingly and properly mention open-source
|
||||
contributors.
|
||||
|
||||
> After a new release exists, update the `ms-gsl` vcpkg port:
|
||||
|
||||
1. [ ] [Microsoft/vcpkg - ms-gsl port](https://github.com/microsoft/vcpkg/tree/master/ports/ms-gsl)
|
||||
|
||||
Be sure to monitor the PR that updates the port for any feedback from vcpkg maintainers.
|
||||
Reference in new issue
Block a user