feedc0de/GSL
1
0
Fork 0
forked from microsoft/GSL
Code Pull Requests Activity

In narrow refactor !is_same_signedness to is_different_signedness

Browse Source
This commit is contained in:
Robert Andrzejuk
2020-04-29 20:39:44 +02:00
committed by GitHub
parent 1e5f44d3ea
commit 84847041ee
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/gsl/gsl_util
View File

@@ -109,12 +109,12 @@ constexpr
#endif #endif
T narrow(U u) noexcept(false) T narrow(U u) noexcept(false)
{ {
constexpr const bool is_same_signedness = std::is_signed<T>::value == std::is_signed<U>::value; constexpr const bool is_different_signedness = (std::is_signed<T>::value != std::is_signed<U>::value);
const T t = narrow_cast<T>(u); const T t = narrow_cast<T>(u);
if (static_cast<U>(t) != u if (static_cast<U>(t) != u
|| (!is_same_signedness || (is_different_signedness
&& ((t < T{}) != (u < U{})))) && ((t < T{}) != (u < U{}))))
{ {
throw narrowing_error{}; throw narrowing_error{};